summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-03-23Revert "tdf#116241 Customizing value highlighting colors"Szymon Kłos
This reverts commit fb29b8262488d045a926504725669a362bacb5bb. Change-Id: I338af7c108bb6386193550ef0603b406c4f7bd99 Reaseon: I will move this to more suitable place "application colors" and extend with protected cell backround. Reviewed-on: https://gerrit.libreoffice.org/51789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-23Enable binary search for numeric values againEike Rathke
... as used in LOOKUP and VLOOKUP. This was disabled as a fallout from commit bad266fa06294f1dacec11ec02dfc6ae4ec8cdc4 CommitDate: Mon Feb 22 21:30:28 2016 +0100 ScQueryEntry::GetSearchTextPtr() with SearchType, tdf#72196 that changed the !bRegExp condition (which includes numeric) to bLiteral (which covers only text string) searches. Change-Id: I265286ffe75bc7cd9e660ab82b0e647d82865eb9
2018-03-23Typo: GetSelectItemId -> GetSelectedItemIdSamuel Mehrbrodt
Change-Id: Ieebb50b73f1f341c924693f3966f8cd2b09a136b Reviewed-on: https://gerrit.libreoffice.org/51750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectLanguage -> GetSelectedLanguageSamuel Mehrbrodt
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2 Reviewed-on: https://gerrit.libreoffice.org/51747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23loplugin:useuniqueptr in ScPoolHelperNoel Grandin
Change-Id: I12bb470b3c0af78aa713e7b28d59235b55507d24 Reviewed-on: https://gerrit.libreoffice.org/51737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23Correct class nameJens Carl
Change-Id: Ie7e7ce72c264d9244bd0cb2e8e1f51fb6f4434d8 Reviewed-on: https://gerrit.libreoffice.org/51756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-22tdf#116448 - Function "Skip empty cells" unclearheiko tietze
Tooltip added Change-Id: I098f0680e3240535fae0797e421b5de479adff02 Reviewed-on: https://gerrit.libreoffice.org/51741 Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-22tdf#45904 Move _SpreadsheetDocumentSettings Java test to C++Jens Carl
Change-Id: Ic6bde95d0d4255e082a60e41a117365422b22aa8 Reviewed-on: https://gerrit.libreoffice.org/51724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-22tdf#116510 Copy cell anchored images too when copying cellsSamuel Mehrbrodt
Change-Id: Ia64100a00e65b7871c44a9b4700ca86782897a8e Reviewed-on: https://gerrit.libreoffice.org/51725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-22loplugin:useuniqueptr in ScDocumentNoel Grandin
and fix bug where we were deleting a pointer to an object we did not own via pFormatExchangeList Change-Id: I488c679734c48bd21bc6be04837e037e97550647 Reviewed-on: https://gerrit.libreoffice.org/51668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22tdf#45904 Rename test object for GlobalSheetSettingsJens Carl
Rename test object ScSpreadsheetSettingsObj to ScSpreadsheetSettings. Change-Id: Ia70cc82e0ee20571ad029590db735f932e5c7958 Reviewed-on: https://gerrit.libreoffice.org/51723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-22loplugin:useuniqueptr in ScColumnNoel Grandin
Change-Id: If2f8e1f730fabaf124e515dbe58ec5d755d1e57b Reviewed-on: https://gerrit.libreoffice.org/51667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in ScDPResultMemberNoel Grandin
Change-Id: Icf8a52bcf233994bc49a5d9094196154f20602ea Reviewed-on: https://gerrit.libreoffice.org/51663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-21tdf#116241 Customizing value highlighting colorsSzymon Kłos
Change-Id: I5d77e6207d1e29326282d7184c9348e59292977a Reviewed-on: https://gerrit.libreoffice.org/51653 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-21tdf#68290 cursor moves with Enter in protected sheettagezi
Change-Id: I2ac848f1799d94f521628480664cdb579417772a Reviewed-on: https://gerrit.libreoffice.org/49085 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-21ofz#7012 Integer-overflowCaolán McNamara
and fix negative rounding code, which results in changing tet of from -996 to -1002 which is closer to the original -1000 Change-Id: Ie992e61bf4d14d0cd4194e773479feba96b6d68e Reviewed-on: https://gerrit.libreoffice.org/51576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20tdf#116470:Convert between ProgName/DisplayName for pivot table stylehimajin100000
to avoid styles in different languages to be unnecessarily registered Change-Id: I450909d798749f751b1c59cda28865f6c3ea76c3 Reviewed-on: https://gerrit.libreoffice.org/51511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-20Resolves: tdf#116385 warning dialog should be yes/no not okCaolán McNamara
Change-Id: Ied6010e83b9709e5d5c8006912bff0fdce4077a3 Reviewed-on: https://gerrit.libreoffice.org/51638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20drop unnecessary includesCaolán McNamara
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430097 Dereference null return valueCaolán McNamara
Change-Id: I1cba6a67c2b94b5906c017960e5636d5e7b87dd2 Reviewed-on: https://gerrit.libreoffice.org/51565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430077 add assert for 'Division or modulo by zero'Caolán McNamara
and coverity#1430076 Division or modulo by zero coverity#1430078 Division or modulo by float zero coverity#1430082 Division or modulo by float zero coverity#1430083 Division or modulo by zero coverity#1430085 Division or modulo by zero coverity#1430102 Division or modulo by zero coverity#1430103 Division or modulo by zero Change-Id: I9d7190f95d19a755c681f1f897a8921105ef7c46 Reviewed-on: https://gerrit.libreoffice.org/51568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430075 Dereference after null checkCaolán McNamara
Change-Id: Id4c9cc1463ba8b38a7b115d574fec8c9b1d55384 Reviewed-on: https://gerrit.libreoffice.org/51556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19tdf#116421 autosum is not workingNoel Grandin
regression from commit 6529cd54c29c5800340530a1b8182c341fbeeafb don't use heap for elements in ScRangeList The change in lcl_MoveRanges is not part of the fix, just something else I noticed when reviewing the problematic commit Change-Id: I958937f92a84f6e8e7bec607705c3a958d70ad3c Reviewed-on: https://gerrit.libreoffice.org/51547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-18tdf#45904 Move _Spreadsheet Java tests to C++Jens Carl
Change-Id: Ic540d06899def77313d6dc7e0a5241e1f9eeea54 Reviewed-on: https://gerrit.libreoffice.org/51491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-18cppcheck: arrayIndexThenCheckJulien Nabet
Change-Id: If30664066e3f3f99c02244e248e72406380069aa Reviewed-on: https://gerrit.libreoffice.org/51513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-18uitest for bug tdf#86253Zdeněk Crhonek
Change-Id: If5488988ba581108d96797e58d001152cff1ad38 Reviewed-on: https://gerrit.libreoffice.org/51088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-03-18unify the message dialogs with extra widgets casesCaolán McNamara
Change-Id: I9ad3573b15d24c3d1737b9f450792952ae20a31b Reviewed-on: https://gerrit.libreoffice.org/51476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-18uitest for tdf#62267Zdeněk Crhonek
Change-Id: I49cad5ebfb459f881aa1520e18f32c1e3ac42327 Reviewed-on: https://gerrit.libreoffice.org/51235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-03-18uitest - Calc Paste OnlyZdeněk Crhonek
Change-Id: I4d858b34609058fb86fe70244236f6cca32a4c31 Reviewed-on: https://gerrit.libreoffice.org/51071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-03-18uitest - Calc Document PropertiesZdeněk Crhonek
Change-Id: Ice5a2fcb3cac3bfcc21f0c060b1a38fb686a728d Reviewed-on: https://gerrit.libreoffice.org/51074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-03-18uitest for bug#69450Zdeněk Crhonek
Change-Id: I467bbfd0c9effe81b6f67d903766a9daedd60329 Reviewed-on: https://gerrit.libreoffice.org/51090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-03-18uitest for bug tdf#65856Zdeněk Crhonek
Change-Id: I494be1801bcecff42a00208880b533f0bc4ee874 Reviewed-on: https://gerrit.libreoffice.org/51178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-03-17OperationSmiley: Adapted TestDocumentArmin Le Grand
The OperationSmiley fix is about removing the old hack that for CustomShapes in top-left and bottom-right points were added. In the ScTiledRenderingTest::testGraphicInvalidate UnitTest using this document exactly that top-left wrong polygon was hit which is now no longer there. The used shape was an ellipse, so this makes a difference - there *is* no geometry in the top-left corner of this shape. To fix that, I exchanged the ellipe CustomShape with a rectangle CustomShape. That way, the old hit behaviour will be replicated. Change-Id: I4b96ad79ba91166f097207226577d34087625589
2018-03-17sc: prefix members of ScRefHandlerHenry Castro
Change-Id: I7ba7f17256c244604549321fc4812ce845c28877 Reviewed-on: https://gerrit.libreoffice.org/51451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-03-17scalc: Add missing labellingSamuel Thibault
The "first page number" spin button was missing accessibility labelling. Change-Id: I750cebf33f20056819abc00bb6875e2d89100fdd Reviewed-on: https://gerrit.libreoffice.org/51291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-17sc: prefix members of ScFormulaReferenceHelperHenry Castro
Change-Id: I412c7336802032da93c3cc4df1d7f6d8baf36a7b Reviewed-on: https://gerrit.libreoffice.org/51442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-03-16lokdialog: do not lock events when opened ScFilter DialogHenry Castro
When exists 2 or more views and one of the views open the ScFilter dialog, the other views are locked and no event process. In tiled rendering case, collaborative editing is not functional with 2 or more views are locked, so the patch prevents locking the other views Change-Id: I0133d38ac5ecef4d3ebc22f3e922602704dcd0b3 Reviewed-on: https://gerrit.libreoffice.org/51370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-03-16weld SvxObjectTitleDescDialogCaolán McNamara
Change-Id: Id08c201ee4377fe84618906725e7699d29dc1160 Reviewed-on: https://gerrit.libreoffice.org/51395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16loplugin:useuniqueptr in ScDPSaveDimensionNoel Grandin
Change-Id: I169a8eff540c866958da37c25a03550542433f16 Reviewed-on: https://gerrit.libreoffice.org/51372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16Resolves: tdf#115923 try a different approach to solving tdf#46637Caolán McNamara
Try scrolling to the cell the mouse is over if its not fully visible already and this is not autofill selection. To avoid the mouse over the autofill handle which overflows into neighbours scrolling the neighbour cell into view before its truly desired to be selected when the mouse passes the center point in other words, for autofill go back to how it always was Change-Id: I6f67ad0f49c2d4087949f71f38322f06ced13c79 Reviewed-on: https://gerrit.libreoffice.org/51361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16weld SvxObjectNameDialogCaolán McNamara
Change-Id: I588bdc61cce9a7b4e709fcac612b229c02e734c0 Reviewed-on: https://gerrit.libreoffice.org/51375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15loplugin:unused-returns in scNoel Grandin
Change-Id: Ic1d6cbf883fcfeb013c3a82d31c177a1a14bb7c8 Reviewed-on: https://gerrit.libreoffice.org/48193 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15Check return of ScFlatBoolRowSegments::ForwardIterator::getValue()Eike Rathke
And if it is only an assert() where code (probably rightly) assumed there is a value.. if there wasn't then we'll have to handle it. Change-Id: Icbdb4a7727ca4cf8a6372c03e02d3bffa6156b6c Reviewed-on: https://gerrit.libreoffice.org/51374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15Use return value of ScTable::GetDataEntries()Eike Rathke
It's unnecessary to insert an empty set and sort it.. Change-Id: I01b7ce926747083dc9b5a82304c8ab182cd5a1bd
2018-03-15tdf#97977 related : make MODE.SNGL comply with Excel.Winfried Donkers
MODE.SNGL is to return the first occurrence of the number that has the most occurences in the array of numbers in case of multiple numbers having the same amount of (maximum) occurrences. Change-Id: If76115ddc6b84367cbcb75de611f29076a538476 Reviewed-on: https://gerrit.libreoffice.org/50593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-15tdf#50916 Refactor of the table7.cxx to allow dynamic column sizeBartosz Kosiorek
Change-Id: I60ea249ca621e25b3585e1d2f75bdf15d96f6dcc Reviewed-on: https://gerrit.libreoffice.org/48205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-15loplugin:useuniqueptr in ScBroadcastAreaSlotMachineNoel Grandin
Change-Id: Ib1f54ad7eeae5ea66ad7f8f789e86cd89c4b32d4 Reviewed-on: https://gerrit.libreoffice.org/51316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15don't use heap for elements in ScRangePairListNoel Grandin
no need to store small objects like this out of line. And use std::array for ScRangePair, so we get range checking in debug mode. Change-Id: Ie4690edbb4c3fdc4e08206cb016b8167a399d95a Reviewed-on: https://gerrit.libreoffice.org/51268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-08 06:54:40 +0000