summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-04-15Related: tdf#50916 create valid empty ScHorizontalCellIterator when...Mike Kaganski
completely outside allocated area. Prevents crash in spell checker when scrolling into unallocated area, where first visible column number is greater than maximal allocated column number. The crash happened when std::vector::reserve threw std::length_error, and Scheduler::ProcessTaskScheduling abort()ed catching that in std::exception handler. Change-Id: Id74706f4a5fedfcc5e4e316c7aea7f5a4fe110be Reviewed-on: https://gerrit.libreoffice.org/70756 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-15Remove unnecessary calls to Reference::is() after an UNO_QUERY_THROWJens Carl
Change-Id: I43f7e328b45d0058f867f3296c5a34740d51b4da Reviewed-on: https://gerrit.libreoffice.org/70752 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-15tdf#45904 Remove obsolete ScPageObj testsJens Carl
As mentioned i#84653 ScPageObj and ScDrawPageObj are supporting the same service and the later one was convert to C++ with commits ed6a71eafa61bade50219d2ff6233a42ab6d1c17, f897e80d063436be07356049f595efe5afb04859, eb0653ee80ad7249fde9ff752b56316fb98c4592, ee503c36199d225f4c906fe43c927f911c2097c7 and b99ea0ff33b78ba76d1ae436895efac490252e0f. Change-Id: Icb05b2a03893f47e5f3816366cb9f3c94fd6faeb Reviewed-on: https://gerrit.libreoffice.org/70751 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-14weld ScConsolidateDlgCaolán McNamara
Change-Id: I7d52aea1917503a37cdc7d1ae16d7d2377397f30 Reviewed-on: https://gerrit.libreoffice.org/70714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-14tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I18562d60e33c7ecff14807976dde4cbcae3f665b Reviewed-on: https://gerrit.libreoffice.org/70731 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-13Resolves: tdf#124693 Crash modifying chart data range with mouse selectionCaolán McNamara
Change-Id: I95c621615c197687552147b8328c769fdd47befa Reviewed-on: https://gerrit.libreoffice.org/70711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-13weld ScTabOpDlgCaolán McNamara
Change-Id: I515c756451539527faff59b67e0a8d1ee64c1347 Reviewed-on: https://gerrit.libreoffice.org/70686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-13use more std::make_uniqueNoel Grandin
Change-Id: I7d85cbc9105c5e0c4a8d9a69c4ac9d6dfc07eabd Reviewed-on: https://gerrit.libreoffice.org/70663 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-13Fix typoAndrea Gelmini
Change-Id: I2a73e84c9292dabeb5129b4261bb08c959b6b3e4 Reviewed-on: https://gerrit.libreoffice.org/70691 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-12loplugin:unusedfieldsNoel Grandin
Change-Id: I321c8eefdc43979ef5fd3774c7094ac0dbcac417 Reviewed-on: https://gerrit.libreoffice.org/70657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12tdf#113908: Implement exporting pivot tables' groups fields to XSLXMike Kaganski
Two tests in sc/qa/unit/pivottable_filters_test.cxx were extended to also test round-trip of group fields in XLSX. Change-Id: I70b7c15b09040c64fa1da2f88001af7ba16f2c6f Reviewed-on: https://gerrit.libreoffice.org/69653 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-12rename ScRangeManagerTable back to RangeManagerTableCaolán McNamara
Change-Id: Ie9dec478c38c484d47720e488427d797269f228f Reviewed-on: https://gerrit.libreoffice.org/70664 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12Resolves: tdf#124613 stray .05 at end of GtkAdjustment lower valueCaolán McNamara
Change-Id: If42b676c3321d73455771b6ea62aefb806caccd2 Reviewed-on: https://gerrit.libreoffice.org/70661 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12weld ScSolverDlgCaolán McNamara
Change-Id: I35fa2f63eb47f18289892ffcf042d041752bfbd7 Reviewed-on: https://gerrit.libreoffice.org/70653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12weld ScColRowNameRangesDlgCaolán McNamara
Change-Id: I976fb892f8ac1dedb0c2c3110dce17c1211de238 Reviewed-on: https://gerrit.libreoffice.org/70652 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12loplugin:unusedmethodsNoel Grandin
Change-Id: Ie90e53583484ee4f378ec92634adf3be7cd9ecbb Reviewed-on: https://gerrit.libreoffice.org/70650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12crashtesting: failure on import of tdf90694-1.otsCaolán McNamara
since... commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: I7a624f391c85f9c7af07f951c9da3914460b7526 Reviewed-on: https://gerrit.libreoffice.org/70602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12weld ScPrintAreasDlgCaolán McNamara
Change-Id: I1e1d31551b623453a1bade9c932ef1c9e1060f35 Reviewed-on: https://gerrit.libreoffice.org/70600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12crashtesting: failure on import of gnome545630-1.xlsxCaolán McNamara
since... commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: Ib42b770282753350b9c4016fe7c9f57f68e6c209 Reviewed-on: https://gerrit.libreoffice.org/70603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12tdf#117276 sc: autofilter was unexpected reset with OK pressedSerge Krot
Change-Id: I53331434bb4d5e2f13e9f2ab5b768e9880aecca8 Reviewed-on: https://gerrit.libreoffice.org/68765 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-12crashtesting: failed on reexport of fdo64646-4.xlsCaolán McNamara
since... commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: Id013d1005605f7c7b58b4065ead1e6053cedd45d Reviewed-on: https://gerrit.libreoffice.org/70601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12Fix typoAndrea Gelmini
Change-Id: Ic215895f9e67e16d5c5a6d4e70af47544d49813e Reviewed-on: https://gerrit.libreoffice.org/70631 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12tdf#45904 Move TextContent Java tests to C++Jens Carl
Move TextContent Java tests to C++ for ScEditFieldObj_Cell and ScEditFieldObj_Header (formerly ScCellFieldObj). Change-Id: Ieed5cdbc128490e66d1797c817d998a932317dd4 Reviewed-on: https://gerrit.libreoffice.org/70615 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-12dpcache : use case-insensitive normalization of...Dennis Francis
field labels, else on export to xlsx, Excel will fail to load the pivot table due to case-insensitive duplicate field labels in the pivotCacheDefinition1.xml. This could be done just for xlsx export filter, but we do normalization in dpcache.cxx anyway and it would not hurt if we do a case-insensitive normalization here. The private member ScDPCache::AddLabel had code duplication and more importantly it is called in loop for every label in the database so results in O(n^2) time complexity where n is the number of labels, so removed it to reuse normalizeLabels() at the only call-site. Also added a unit test that checks case-insensitive normalization. Change-Id: Id563dee232a98a2aea9f4fc29254f6942e1c5ba7 Reviewed-on: https://gerrit.libreoffice.org/70498 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-04-11weld ScDbNameDlgCaolán McNamara
Change-Id: I676909cbb4067ce69d5327403dd25cc80c4cbc4b Reviewed-on: https://gerrit.libreoffice.org/70593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScRandomNumberGeneratorDialogCaolán McNamara
Change-Id: I9ef8dd4ba84f37bb3bec040781766ef779d02ea1 Reviewed-on: https://gerrit.libreoffice.org/70590 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScNameDefDlgCaolán McNamara
Change-Id: Ic5e46a0a9f03733c8e151e6dff55b7b4a3fcda34 Reviewed-on: https://gerrit.libreoffice.org/70588 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScSimpleRefDlgCaolán McNamara
Change-Id: I36fe5a0790b2f7a43b9e4d8def9ef3a224d4d546 Reviewed-on: https://gerrit.libreoffice.org/70549 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11tdf#122767 sc opengl: fix rendering artifacts after hiding a cell commentMiklos Vajna
Actually this is not specific to opengl, affects e.g. the Linux gen backend as well, it just doesn't happen with the Windows gdi backend. The rendering of the caption itself was OK. Focusing on the arrow polygon at the end of the comment's "tail" (connector polyline): - What gets painted is determined by SdrCaptionObj -> ViewContactOfSdrCaptionObj::createViewIndependentPrimitive2DSequence(), which produces a PolyPolygonColorPrimitive2D, which is then processed by VclPixelProcessor2D::tryDrawPolyPolygonColorPrimitive2DDirect(). - The polygon passed to VCL there is within the bounds of the invalidation rectangle set in ScNoteMarker::TimeHdl(). So it seems the only reason sometimes these 1px rendering artifacts are left around is anti-aliasing. Fix those by simply extending the invalidation rectangle in each direction. Change-Id: I37b8e666999d3ff5ee1328fca7ac017ee8c7e9e0 Reviewed-on: https://gerrit.libreoffice.org/70584 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-11weld ScNameDlgCaolán McNamara
Change-Id: I7a00dd386a1cb52e046d0f57c77fe3fdf8252bb7 Reviewed-on: https://gerrit.libreoffice.org/70548 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11rename ScStatisticsInputOutputDialogController back...Caolán McNamara
to... ScStatisticsInputOutputDialog Change-Id: I641798943c0b469572ebd971eb39250c41c5db20 Reviewed-on: https://gerrit.libreoffice.org/70547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11drop unused ScStatisticsInputOutputDialogCaolán McNamara
Change-Id: Ide92f9b422db2ef2ee21f02b5c7dcef974f70685 Reviewed-on: https://gerrit.libreoffice.org/70546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11rename ScMatrixComparisonGeneratorController back...Caolán McNamara
to... ScMatrixComparisonGenerator Change-Id: Ib81e922455cebe7c57422aab10bc1b1d6cb325ef Reviewed-on: https://gerrit.libreoffice.org/70545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11drop unused ScMatrixComparisonGeneratorCaolán McNamara
Change-Id: I8b0da3dab82bc6a112ac6380b2359861f23905ce Reviewed-on: https://gerrit.libreoffice.org/70544 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScFourierAnalysisDialogCaolán McNamara
Change-Id: I87e28f62cf03f4a612def322fda5e03d702bec4c Reviewed-on: https://gerrit.libreoffice.org/70543 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScChiSquareTestDialogCaolán McNamara
Change-Id: I652bf123bc9cba5edbb052bddd9be02640b3884c Reviewed-on: https://gerrit.libreoffice.org/70542 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11rename ScStatisticsTwoVariableDialogController back...Caolán McNamara
to ScStatisticsTwoVariableDialog Change-Id: Id4a2ac62f212fb9356f052461485e6e517a1ed3f Reviewed-on: https://gerrit.libreoffice.org/70541 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11ScStatisticsTwoVariableDialog no longer usedCaolán McNamara
Change-Id: Id0aff27f71263769c74ce0a4fc8240ce4fe2110e Reviewed-on: https://gerrit.libreoffice.org/70540 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScZTestDialogCaolán McNamara
Change-Id: I9cd624d0dd80d56e772c0241e20ec93e253d8d2b Reviewed-on: https://gerrit.libreoffice.org/70539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScFTestDialog and ScTTestDialogCaolán McNamara
Change-Id: Id65a4a78f89ed45a21cd89b6e41e7dd5b4a79529 Reviewed-on: https://gerrit.libreoffice.org/70518 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScRegressionDialogCaolán McNamara
Change-Id: I26cbf2b5ed7482daa8d02adb206b6a783524985a Reviewed-on: https://gerrit.libreoffice.org/70517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScMovingAverageDialogCaolán McNamara
Change-Id: I5dee3cc19118356d325bc3db9a5ef563945c82ec Reviewed-on: https://gerrit.libreoffice.org/70511 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScExponentialSmoothingDialogCaolán McNamara
Change-Id: Ib648cc1c877eeddcf76c4c5add9058116816d707 Reviewed-on: https://gerrit.libreoffice.org/70510 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScCovarianceDialogCaolán McNamara
Change-Id: I7546aa234ee986701b9908f33a6c96e6779d654d Reviewed-on: https://gerrit.libreoffice.org/70509 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScAnalysisOfVarianceDialogCaolán McNamara
Change-Id: I94b736bbc5268f36a56a4a40ec39c6adaf67afbf Reviewed-on: https://gerrit.libreoffice.org/70506 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScDescriptiveStatisticsDialogCaolán McNamara
Change-Id: Idedc0c47bed3ce57e9e681146222dc7f7573819e Reviewed-on: https://gerrit.libreoffice.org/70505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScSamplingDialogCaolán McNamara
Change-Id: Ifbae09b2d2b6ebf0c56332ef4f87f3045f97f1ad Reviewed-on: https://gerrit.libreoffice.org/70503 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11tdf#124651: always write "name" attribute to dataField elementMike Kaganski
Despite being optional as per ECMA-376-1:2016, Excel 2016 seems to require the presence of "name" attribute in dataField element of pivot table definition, so make sure to write at least empty string there. Change-Id: Iaab5674f86b7dd0b267776678e11af47086635d7 Reviewed-on: https://gerrit.libreoffice.org/70522 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-11XmlTestTools::getXPath now asserts that non-empty attribute existsMike Kaganski
It turns out that this change revealed unit tests written incorrectly (and untested), or maybe which became broken (not testing) because of some previous assertXPath change? They incorrectly used 3-arg form of it to check node content equality to passed string, while in fact, an attribute was looked for with that name, and its empty return tested to match default empty 4th argument. Change-Id: If24e18518543102d115a22a6282e4cca9cf694e2 Reviewed-on: https://gerrit.libreoffice.org/70581 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-01 01:27:24 +0000