summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-06-24Resolves: tdf#143008 Evaluate AM/PM for type date+time text-to-column and CSVEike Rathke
Change-Id: Ib760b9a103ab4b8ce7f5a158b09fbe11c6617f2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117747 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d81775f5b12080676ebaf659c5a4c10d64a9074b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117720 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-22tdf#142932: fix crash when pasting cells with comments+"skip empty cells"Julien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173011 4 0x00007fc4b0cdbb3d in ScColContainer::operator[](unsigned long) (this=0x872e1e0, nIndex=64) at sc/inc/colcontainer.hxx:43 5 0x00007fc4b120d82b in ScTable::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScTable const&, sc::ColumnSpanSet&) (this=0x872e1e0, rCxt=..., rClipTab=..., rBroadcastSpans=...) at sc/source/core/data/table7.cxx:118 6 0x00007fc4b0e42939 in ScDocument::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScMarkData const&, sc::ColumnSpanSet&) (this=0x3bffa60, rCxt=..., rMark=..., rBroadcastSpans=...) at sc/source/core/data/document10.cxx:75 7 0x00007fc4b0e0b67b in ScDocument::CopyFromClip(ScRange const&, ScMarkData const&, InsertDeleteFlags, ScDocument*, ScDocument*, bool, bool, bool, bool, ScRangeList const*) (this=0x3bffa60, rDestRange=..., rMark=..., nInsFlag=7, pRefUndoDoc=0x0, pClipDoc=0x7d3bb40, bResetCut=true, bAsLink=false, bIncludeFiltered=false, bSkipAttrForEmpty=true, pDestRanges=0x7fff4a3da4b0) at sc/source/core/data/document.cxx:2916 8 0x00007fc4b2412dc3 in ScViewFunc::PasteFromClip(InsertDeleteFlags, ScDocument*, ScPasteFunc, bool, bool, bool, InsCellCmd, InsertDeleteFlags, bool) (this= 0x41a29e0, nFlags=7, pClipDoc=0x7d3bb40, nFunction=ScPasteFunc::NONE, bSkipEmpty=true, bTranspose=false, bAsLink=false, eMoveMode=INS_NONE, nUndoExtraFlags=InsertDeleteFlags::NONE, bAllowDialogs=true) at sc/source/ui/view/viewfun3.cxx:1312 Change-Id: Ic119cb5d414a35a9ba18b0564d7adf83154eb9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a6d269ed9478b20f611912bf9711c2683e7bc924) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117632 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit bb59b4165456d13eda800098be8b875d93b093d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117637
2021-06-21tdf#142873: Fix print preview zoom-out zoom-in buttonsJulien Nabet
.uno:ZoomOut has been renamed .uno:ZoomMinus .uno:ZoomIn has been renamed .uno:ZoomPlus Change-Id: I06e7e66550399e53032a0df39a98846982acba48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117279 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c21398066b6bf630070ed291456f2663e06d94b9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117427 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-06-14Resolves: tdf#127013 differentiate non-/array separators and restrictEike Rathke
This is a combination of 2 commits. Resolves: tdf#127013 differentiate non-/array separators and restrict Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117068 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit bb54d6d8241a06a6772052b77b67d6a4f686426c) Related: tdf#127013 Check loaded separators for validity ... not only if something is present at all. That way future restrictions can reset separators. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117072 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 381bc9d9acd461415cf81eef71ec3dd935a07b62) I738bcb9e052e8dbecb0a6cd07bbae8f4a8ea1c35 Change-Id: I9ff6b816b0c7af9081954fa407a4d516a576a338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117075 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-10tdf#136766 Zoom slider in calc print preview has white backgroundNoel Grandin
I cannot figure out any way to make transparent stuff on the toolbar behave under all rendering backends, so just revert this this reverts commit 00cffc20e40b2412c7e9867eed24c9834504e24f Date: Mon Sep 7 13:28:33 2020 +0200 tdf#135181 Calc print preview zoom slider print preview not transparent (gen) commit 444c7c736be7545344298a9cbb3a69886edc5ecb Date: Mon May 18 18:23:13 2020 +0200 tdf#125538 fix background of zoom control Change-Id: I7c351796b2c0778c1520fc8177d05567b2ae8a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116982 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d693223b84b518701d308678801ccc50877490dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116904 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-10tdf#141769 ScTextWnd has to be available before the editview is createdCaolán McNamara
Change-Id: Iec3b4180c4dc83723224b7122a1513cb8fe3ea0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116921 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-05-26Related: tdf#81757 Do not even try to re-enter ScDocShell::Do*Recalc()Eike Rathke
That happened when loading bug doc https://bugs.documentfoundation.org/attachment.cgi?id=103462 where form selection events fire asynchronous recalcul() and BASIC Main also calls recalcul. Change-Id: Ic27fb340c7b5019453723c7cabe2122905d400f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116133 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 807f3508c9319d7f94820ea1282e306594418fce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116152 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-24Resolves: tdf#134675 Allow unrestricted pastes of same size in one dimensionEike Rathke
So copy-paste of for example one entire column onto more than 23 columns is possible as that does not create multiple repetitions. Change-Id: I2b035afa1c04522db55569396a36b1bac57c590c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116031 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116039
2021-05-22tdf#142395: properly handle "no string delimiter" caseMike Kaganski
In this case, the delimiter character value would be '\0'. Change-Id: Idb0f01756991b3ea35a92f11b78fddd56c25265a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115839 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 6155689bb6f1d72f29b43ac5ae94b32522ef9b42) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115851 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-18tdf#138209 ODF export: work around forms problem in LO < 7.0Michael Stahl
LO without commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6 makes a mess when storing form documents it has loaded from ODF 1.3 documents: the XML parts are stored as ODF 1.2, but the storage (and therefore manifest entry) keeps version 1.3. To avoid this, store form documents as ODF 1.2 extended by default. Unfortunately a bunch of ODF export code accesses the global SvtSaveOptions variable; with this version override, only SvXMLExport::getSaneDefaultVersion() must be used. Change-Id: I5fa8e286f5103c578ed0d93da07a8a6cbe2f0ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115357 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 16de54a5c47fbc4691ee099c1f7bb559a8fe11ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115390 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-05-12tdf#139241: partially revert 059f07f9f33460c809a93e0fda1165f5c6f6d805Mike Kaganski
And instead normalize the start and end values before creating rectangle. Change-Id: Ib9921f1a537ca88a70cedf989d2f696180ad68e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115284 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 05f8f239d49bd66145e736b4e2e28ad073ef6f2f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115285 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-05-10tdf#43175 - Adjust chart references on every copied sheetAndreas Heinisch
Change-Id: I92fcfeecb9aa10bf8974de953399d780ffe02176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115058 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d55bf8aab008d84fac673f3cd907f5199347ce77) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115210 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-03tdf#90278 - Set the vba border to the default borderAndreas Heinisch
The default border width in calc is 0.75[pt] * 1/72[inch] * 2.54[cm/inch] = 0.0264[cm] set in 2f527738ea4f8e93acafdd7f0ae06de1678cfdd8 which contradicts the border setting of OOLineThin used in order to parse vba borders. The latter was set to 1.00[pt] * 1/72[inch] * 2.54[cm/inch] = 0.0352[cm]. This mismatch leads to an exception when the corresponding weight of a cell is parsed. Change-Id: I945d8aecdf31e5ad76d0d04e76eaaf4668e3d8ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114980 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115035
2021-04-30tdf#137945: sc: Add UItestXisco Fauli
Change-Id: I6fa935d0c77556113ae087a67c2932ddcee12a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114871 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-29tdf#141970 Revert "tdf#129606: Round the mean of the two subtractions"Mike Kaganski
This reverts commit d5ebe7c3089ab9f4d3fe0707169fc1ce024cdb70, and brings number of inexact values in testing back to lower numbers (see test document in the bug). Change-Id: I5cfb34b7260fc6e4866585af6a2a50e79696eea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114861 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit aa096331ba468f19951e43e2550105d4dcf50053) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114865 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-29Related: tdf#130326 skip calling Refresh if its already just calledCaolán McNamara
Change-Id: I80d3ae7f10b56dfe53a4ab5101ae771b47848092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114877 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-04-29Related: tdf#130326 drop ScContentTree::ObjectFreshCaolán McNamara
this was introduced as part of the large IA2 integration commit b41332475783c31136673fb44cf4c411bb0148f8 Author: Steve Yin <steve_y@apache.org> Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 Both calc and writer gained the feature that "space" in the navigator for drawing objects selects the highlighted object, extending the selection of another one is already selected. (notably impress was left unchanged) In calc, but not writer, an ObjectFresh was added which fires on every SfxHintId::ScKillEditView which is broadcast on every exit of the cursor from a cell. Its purpose seems to be primarily to re-highlight the last selected-by-keyboard entry on a content refresh. As far as I can tell this doesn't seem necessary and we already refresh content on SfxHintId::ScDrawChanged events so we shouldn't need to additionally refresh on ScKillEditView and refreshing on every ScKillEditView is very slow on navigating through a calc document with a lot of drawing objects. Change-Id: I64b2840f8510d474314d108e657fc3367f8ab6c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114876 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-04-27tdf#99991 - Don't resize toplevel widget containing the options expanderAndreas Heinisch
Change-Id: I930445e9047478b26142d049598fbe656d25d666 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114628 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit dc83f99c466296caaa6b236e32b39e04ae9e6d8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114598
2021-04-26tdf#95554 fix ScDocument::GetClipArea() for rows: use > instead of <scito
I did not write any tests, as the multi range copying to system clipboard has another issue, see tdf#141847 Change-Id: I3af58d68370038274a07d753809fb4ceca9016f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114534 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit 7c1e22152ed1a1837782a55fc9997f8e7801681b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114510 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-25Related: tdf#130326: GetDrawNames doesn't do anything when !bisInNavigatoeDlgCaolán McNamara
so return early instead of looping to do nothing Change-Id: Ibb8fe1409a8e66d37d51d9a1b99ce135f36b9522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22tdf#94962 - Limit calculation of pearson coefficientAndreas Heinisch
The RSQ/PEARSON functions return values greater than one, if the divisors are below the numerical limits. Change-Id: Ice224315072afafc6206c367f219771adebe23ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114301 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit fc9919bcfcf32f2ecefa4fce18a49545b93d3499) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114426 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-04-22tdf#141537: UNO Object Inspector: Crash while inspecting fileJulien Nabet
See bt: 6 0x00007f276e146773 in ScChartsObj::getByName(rtl::OUString const&) (this=0x7738e00, aName="Object 1") at sc/source/ui/unoobj/chartuno.cxx:345 7 0x00007f276e146865 in non-virtual thunk to ScChartsObj::getByName(rtl::OUString const&) () at sc/source/ui/unoobj/chartuno.cxx:348 8 0x00007f27a1d87b7f in (anonymous namespace)::NameAccessTreeEntry::fill(std::unique_ptr<weld::TreeView, std::default_delete<weld::TreeView> >&, weld::TreeIter const&) (this=0x6d463e0, pDocumentModelTree=std::unique_ptr<class weld::TreeView> = {...}, rParent=...) at sfx2/source/devtools/DocumentModelTreeHandler.cxx:139 9 0x00007f27a1d87905 in (anonymous namespace)::ChartsEntry::fill(std::unique_ptr<weld::TreeView, std::default_delete<weld::TreeView> >&, weld::TreeIter const&) (this=0x6d463e0, pDocumentModelTree=std::unique_ptr<class weld::TreeView> = {...}, rParent=...) at sfx2/source/devtools/DocumentModelTreeHandler.cxx:596 10 0x00007f27a1d842e5 in DocumentModelTreeHandler::ExpandingHandler(weld::TreeIter const&) (this=0x76e3850, rParent=...) at sfx2/source/devtools/DocumentModelTreeHandl chart isn't retrieved from there: 0 sc::tools::findChartsByName(ScDocShell*, short, std::basic_string_view<char16_t, std::char_traits<char16_t> >, sc::tools::ChartSourceType) (pDocShell=0x351baa0, nTab=0, rName=u"Object 1", eChartSourceType=sc::tools::ChartSourceType::CELL_RANGE) at sc/source/ui/unoobj/ChartTools.cxx:106 1 0x00007f6297305323 in ScChartsObj::GetObjectByName_Impl(rtl::OUString const&) const (this=0x77ce370, aName="Object 1") at sc/source/ui/unoobj/chartuno.cxx:126 2 0x00007f62973076b4 in ScChartsObj::getByName(rtl::OUString const&) (this=0x77ce370, aName="Object 1") at sc/source/ui/unoobj/chartuno.cxx:343 Indeed, if graph hasn't type ChartSourceType::CELL_RANGE, it could be ChartSourceType::PIVOT_TABLE Change-Id: Id5a248535b214ad5f114671c52e4592d87c9f54a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113777 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 42e0ea0a6e4f48967d58fa95081c8ba5a6b08bc6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114361 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-20tdf#93664 sc: fix filtering clicking on cells merged horizontallyTünde Tóth
Click on the filter button of cells merged horizontally showed the "Empty" entry instead of the filter list. Pressing Alt-Down (.uno:DataSelect) worked correctly here, so only mouse handling was broken. This was a regression from commit aaab3a79dfd762a64fa4c1d19dd29ae46c0b9dd0 "Resolves: #i120017, filter button is not shown in merged cell" (which fixed filtering clicking on cells merged vertically). Partial revert of that commit sets the correct first column in the merged range again instead of the last one. Change-Id: I83724f18580134868867bc829cad0739f0932733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114050 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit b7d8ee083230964de2e1580c4639ee4cd307207f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114353 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15Work around assert() in circular reference within group calc, tdf#141146Eike Rathke
Triggered by crash test loading document of wget 'https://bz.apache.org/ooo/attachment.cgi?id=71756' -O ooo114587-1.ods after commit 042dbf83122b14fd1dd32705c8f8b7d65c22f21b CommitDate: Thu Mar 25 16:31:29 2021 +0100 Resolves: tdf#141146 Fix LOOKUP in array with result scalar / single reference Though could happen any time whenever a shared formula group calc attempts to obtain a result from an already running cell. Change-Id: Id668b31a8d81389c593c6fd2191fd444efcdb70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113494 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 465b8b0e9ad4b0c9c7701dee2820a99c5d00b5bf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113633 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-12tdf#138646 - consider the document's address conventionAndreas Heinisch
When accessing a named range using getCellRangeByName, consider the document's address convention. Otherwise, an exception is raised, when the formula syntax is EXCEL R1C1 or EXCEL A1. Change-Id: I5df2546f1c3fd00ff30cb057dcf47f6bb01d501d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112602 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113984
2021-04-10tdf#141416: partial revert of the fix for tdf#81396Xisco Fauli
d4743045a0b320449d07a957463a76bb8b13f939 < the cells need to be imported before we handle charts, tdf#81396 > Import time of sample file in tdf#141416 goes from more than an hour to 1 minute while keeping tdf#81396 fixed Unittest for tdf#81396 added in 9a59068fc31d7150e255ada91c59b8299636f185 Change-Id: Ic15d57945069397076c483b6ef8f3070057db317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113818 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 30f222c91fa816a7863bf4bfc4a36e503e0bf2d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113768 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-08tdf#141547: maQueryItems can be 0Mike Kaganski
E.g., fillQueryParam (sc/source/ui/unoobj/datauno.cxx) may clear it and leave empty if relevant input item is empty. Note how commit e4b924df8f9ad02c66549751cb8e123e420e8508 had changed the same checks in ScQueryEntry::IsQueryBy[Non]Empty. Change-Id: I552462c72e69ddce43711bcff645dc6c7b133db7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113783 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a0d2fb3217094aa7158310f0bcf16093bcc4984f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113757 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07Resolves: tdf#128334 Reset mnCurrentSheetEndPos, mnCurrentSheetTab in all casesEike Rathke
Encountered for a single decimal separator not being a value either, but could be for any condition within IsReference() returning false up to the IsSingleReference() call. Change-Id: I6222adf2a2d06904001175da8798b2ba9fdef99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113697 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 4d4fd4cc57a37a5f24178cf8bac63d979f4323da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113647 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06tdf#99913 XLSX import: set filtered flag for rowsTünde Tóth
hidden by AutoFilter to support copying the result of filtering. Unlike ODS and XLS, XLSX doesn't differentiates filtered and manually hidden rows, and without this fix, copy of the unupdated data of the loaded filtering contained the hidden rows, too. Change-Id: I390d1a84b9bf275f3d3782756553b2f236487758 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113040 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113382 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-06ofz: Segv on unknown addressCaolán McNamara
Change-Id: I6c69375a89781fc0b87230203335c861efb562f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113481 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-06tdf#139786 partial revert tdf#106181 XLSX export: output form controlsJustin Luth
Not every export is going to be to OOXML format, so don't just set ooxmlexport to true and remove the "if" clause (especially when leaving the comment that this is for DOCX only). This is a partial revert to 7.1 (and backported to 6.4.5) commit 577dd32b1c4eb0a4cff574fbabca987cb52b831b. Change-Id: If7ea32a236715ec779cac302773c4c9da19865a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113399 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit a3c5c0f7ce73001adab7475fde1f8ffec4eef48b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113484 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-04tdf#58745 - Detect end of month when extending a date listAndreas Heinisch
Change-Id: Icaa64a493598dc4bb8f2d6d076ad4300e2e4dde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112976 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113156 Reviewed-by: Eike Rathke <erack@redhat.com>
2021-03-30tdf#118482 set a scroll step of the height of a collapsed entryCaolán McNamara
Change-Id: I09ea056f6c2284afda5b387b6fdff3160bb7adc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112625 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-26Resolves: tdf#141146 Fix LOOKUP in array with result scalar / single referenceEike Rathke
The returns are identical to the cell range search. Also, the single reference case is just a special case of range reference and acts as row vector (as number of rows is not greater than number of columns), equally extending the passed "range" if found position is greater than 1. Extending a result range such leads to the result cell not being listened to and not acting on its changes, this was always the case for results of an extended range, and Excel seems to have the same problem. This is logical because the range cell is unknown in advance, and certainly we don't want to make LOOKUP() a volatile function being executed on each change everywhere. Solutions to this could be: - create a single cell broadcaster/listener on the fly while pushing the out-of-band cell result - this is nasty and modifying the model while interpreting is ugly and error prone and it's unclear who should destroy such broadcaster if the query or data range/array changed - so this is a no-go - create a range broadcaster/listener for the entire row right of the cell - would mean to inspect during listener setup to which parameter of which OpCode a reference belongs - really? ...no - which also doesn't help if a given range is too short and is extended - would mean to always extend the listener either as row or column * doubtable if it is really worth it for this one time off fouled up Excel behaviour * or should we rather return an error for out-of-band results? - but then again for ranges it always worked this like + do not advertise, or strongly deprecate such use + a result range should have the same length as the search range/array Change-Id: Ie903f4491844306d3768ee40bd16786ebe648461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113085 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 042dbf83122b14fd1dd32705c8f8b7d65c22f21b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113113 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-24tdf#133159 store current config before changing sheetCaolán McNamara
Change-Id: I0c50c2fd145e80996d8aeddeabdb3ae5c4d83bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112805 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-17tdf#140986 hang in validity messageNoel Grandin
this doesn't fix the root of the problem (something generating an insanely long validation message). It just prevents that problem from locking up the UI. Change-Id: I334729a30eca4a11d0150e3c89ff11c92a862061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 924733c65902d0b17764aded56c88c99d4b9a568) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112529
2021-03-16tdf#139804 Focus form controls inside document with Alt-<Mnemonic>Samuel Mehrbrodt
Change-Id: I710a23a53ca0eb256a477a78ce1b7ae01129f717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111865 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 67ad205404211a2ae17c430a17ede6e9d04d0b7e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112431 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-12tdf#89754 - don't increment non different consecutive date cellsAndreas Heinisch
Change-Id: I6fedc0fe286ebe8b0110360391e8d3325fc2ca25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112054 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3ba901f050d262cdeccefa5b21b0d32aa7332dc7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112295 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09fix ScFlatBoolSegmentsImpl delayed setup with threads (tdf#140754)Luboš Luňák
Change-Id: I258263f6a15e7098a2292ba7f3336fcaaf5224ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112184 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 2fb274950e5207ca55f4f52325fb522bd44024e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112212 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-08tdf#140833 show ScHeaderControl help tip after double click time has expiredCaolán McNamara
so under gtk the popover isn't active when the double click is processed by gtk because under load on wayland the double click is getting handled by something else and getting sent to the the window underneath our window Change-Id: Ie3afcf45c69b7b947b1aeb787478f947deca9307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112135 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-08tdf#140700 nullptr dereferenceMike Kaganski
Change-Id: I6a2ffddfd67784ddc2194dafba7d3eaeb6e4e12e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110854 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 20305894243e24eb383ab9feefebf4a0e9f2644f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112083 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-07tdf#139928 XLSX import: fix conditional formatting in same cell rangeTibor Nagy
Multiple conditional formatting rules of the same cell range were imported incorrectly because of missing handling of their (different) priorities and operators. Note: older unit tests were modified according to the fixed priorities. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I4b542b310642e1a85ef6281d0025b3ef2b2ba8c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110544 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit a5513cb45d90e0a1bfa0dfe39c0f090f1cda45de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111923 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-03tdf#139763 set anchor type in meEditAs in all casesRegina Henschel
OOXML specifies a shape anchor type with xdr:absoluteAnchor and xdr:oneCellAnchor, or with xdr:twoCellAnchor and the attribute editAs with values 'absolute' and 'oneCell'. For our UI the member meEditAs is used. But only in case twoCellAnchor it was set. The patch adds the missing assignments. Change-Id: Iceffd4c5c7640e4d9a614cd52cb491774989595f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111436 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit b2848591ca529004fcfef9bd0f3650750b3735d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111425 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-24delete from mdds in reverse order (tdf#139820)Luboš Luňák
This is a more elegant solution from Noel, compared to my previous commit. Deleting in reverse order means the underlying std::vector used by mdds does not have possible to-be-deleted items to move around that forward order would have. Change-Id: I31f0774e302308bcb70595cb899c977ee5966c7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111395 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111438
2021-02-24Revert ""delete" also empty Calc cells if it helps mdds (tdf#139820)"Luboš Luňák
It's much simpler to just delete in reverse order. This reverts commit 2ac0ab976f814e97a38a9685bc23b7255cfef2f2. Change-Id: I310ebb7d517cbfbb7a22206d3c04660097d4ae1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111394 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111437
2021-02-23"delete" also empty Calc cells if it helps mdds (tdf#139820)Luboš Luňák
With mixed non-empty and empty cells, deleting a range would normally mean deleting just the non-empty cell ranges, which would make mdds repeatedly move parts of the underlying vector. Including empty cells in the range to delete may result in just one pass. Change-Id: Ia2ebcaba054c6e46f3cf6c964ba883bb600d6ee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111125 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit b9921adae997579915b4600c688719620f9adaf6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111191
2021-02-17tdf#140387 grab focus to first panel widget on panel gaining focusCaolán McNamara
otherwise focus is getting lost in these currently mixed vcl+gtk widget panels. Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110956 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-16tdf#105301 - increase the size of the sorting keysAndreas Heinisch
During the import of a document, increase the number of shown sorting keys to match the actual size accordingly. Change-Id: I24ab596f47fadf33d0358f162d26b12c24615fa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108987 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 788c777c6cdf2254e8bba05321f4a9de309b15b5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110916
2021-02-15tdf#123202 calc: fix sorting of autofiltered rowsTünde Tóth
by keeping the query, when the data range contains hidden rows. Change-Id: Ib3de0c36d53b6fd4541a9cb5e53e018c29bd38c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110715 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110940 Tested-by: Jenkins
2021-02-11tdf#140006 don't limit dropdown width to 300pixelsCaolán McNamara
let it use the full width of the cell. Keep that 300 pixel limit if we are expanding the widget width beyond its size request. Change-Id: Ifeaa9ee60e0d5649de71c960ae83270fb1afb2e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110682 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2024-07-13 13:27:07 +0000