Age | Commit message (Collapse) | Author |
|
(cherry picked from commit ac8532ce26e79453b3a969b956ebb7823c455131)
Conflicts:
sc/source/core/tool/address.cxx
Change-Id: Iac80d74a9ec6382a232fdc2f4b798e57dc643ad3
(cherry picked from commit e5931aa5aa2180e0587b93cb94ba1405cfe96f83)
|
|
Change-Id: Ifd6acd85a9bf33742cb62327a3b8a4320f35d0f3
(cherry picked from commit 054213e86b8f3b1084474b0447cc7ffaf82178c5)
Reviewed-on: https://gerrit.libreoffice.org/9512
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 20857b5d7536b3fcafa16ca6527ba459032933d7)
Reviewed-on: https://gerrit.libreoffice.org/9528
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This happened when the HTML export via clipboard tried to resolve
conditional formats, where we have a temporary instance of a document
containing only the sheet to be exported.
Change-Id: Ic7498a1cab3eabede74773868287a2cc3edef052
(cherry picked from commit 17979abf4fde202cae231be19a218be3fe27d04c)
Reviewed-on: https://gerrit.libreoffice.org/9510
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I96a26bd495d6a78fffd0854b5084f69b5db84ee6
(cherry picked from commit 1b35c7ea4f7fe1473dbe08ab93b7259403b290ff)
Reviewed-on: https://gerrit.libreoffice.org/9588
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 282227a81df90dfe11f0b57a4d7558d7faa56836)
Reviewed-on: https://gerrit.libreoffice.org/9623
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I06749af90bed6a43f3fb6b3b5ceb61d5fbbc7c02
(cherry picked from commit a35d92197d850527bd294eb6197b5bf83109d5be)
Reviewed-on: https://gerrit.libreoffice.org/9547
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
|
|
Be aware of the variable address convention.
Change-Id: I37ca38758f055e7799cadefafda61174ea3cbf9c
(cherry picked from commit 653e4adddfc80aeb91c1d21c18e95b3986c85c54)
Reviewed-on: https://gerrit.libreoffice.org/9454
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
It's unfortunate that adding a modeless dialog is such a pain. But we
still need to implemenet this properly else we'll leak at best, or end
up with tons of weird bugs at worst.
(cherry picked from commit 81c492ef18b04cc283561018d69818cbca7f83ef)
Conflicts:
sc/inc/sc.hrc
sc/sdi/cellsh.sdi
sc/sdi/scalc.sdi
sc/source/ui/view/cellsh1.cxx
sc/source/ui/view/tabvwsh.cxx
Change-Id: Ie03260f288fad76f994d0ca6a8b1feeade299ffd
Reviewed-on: https://gerrit.libreoffice.org/9451
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
We need to wait until all the affected cells get marked dirty at the
end of the deletion process.
Change-Id: I49618fcc386ec2209f5f0267d50257ecb8dd21d1
(cherry picked from commit cb167ac784f9b16944da4494b65e56b2a5b66bb7)
Reviewed-on: https://gerrit.libreoffice.org/9443
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Unconditionally set miAutoPosColumn at the end of all operations so it
is also valid in case of pColumnData->clear() and no entries inserted
after pDoc->GetDataEntries().
Change-Id: I689632f696091fd9ce8e93c06d7918e5eaf05ab4
(cherry picked from commit 23e9f36a21f7daa6175f53fd244677b9c2e2a660)
Reviewed-on: https://gerrit.libreoffice.org/9412
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Inserting data in pColumnData invalidated miAutoPosColumn
See https://bugs.freedesktop.org/show_bug.cgi?id=78838#c6
Cherry-picked from 1df54514d7a1ebb1b4fa16cca386a34e7c41c490
Change-Id: Iece423cd8d14f5ae7bf382583c0369895a00f168
Reviewed-on: https://gerrit.libreoffice.org/9409
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Data member entries are inserted when they are added in addDateMember().
(cherry picked from commit 836328d6473ae1a0c472c7dbf8262641c74843cb)
Conflicts:
sc/source/ui/cctrl/checklistmenu.cxx
Change-Id: I6cb2e3629053fe2bb49517c4ef8d5c1fee576446
Reviewed-on: https://gerrit.libreoffice.org/9398
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
This prevents creation of a temporary EditView instance which would mess up
the cursor state while the mouse pointer is hovering.
(cherry picked from commit df51f7d486cafb2795a38ae9fedd8fde8827d8a4)
(cherry picked from commit 8c8de51cc954aaae07f76732e6202398e33afeb7)
Conflicts:
sc/source/ui/view/gridwin.cxx
Change-Id: I7759667b105b4389dd4de2673cd2fbe32082c95d
Reviewed-on: https://gerrit.libreoffice.org/9386
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
That means there is nothing to delete, and proceeding would cause Calc
to freeze.
Change-Id: I2a8fb5736870ba459082873c8f864283d8b9c664
(cherry picked from commit bc7e0967be52f5eb7948fbb1c30edc7dd5acc18d)
Reviewed-on: https://gerrit.libreoffice.org/9388
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Also fix the export of underline types as well. It was always saved
as a single line.
(cherry picked from commit fcf5b5c081ded93b12dd888236d0a860b7693ed1)
Change-Id: I88cb0f3702a6afc14544ecbce8f200b5422fd78f
Signed-off-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
Change-Id: Ia9c29d37eaf962e0245920e50f534dd779af72dc
(cherry picked from commit 48eccfb812284f43ba24c3be3903537ce954944d)
Reviewed-on: https://gerrit.libreoffice.org/9366
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
When inserting or deleting sheets.
Change-Id: Ibf898350e22f092ec38b75ad98957832a5580e6a
(cherry picked from commit 146f6e7e68ea56f79b72047b97bd9fba66db499d)
Reviewed-on: https://gerrit.libreoffice.org/9350
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
Or, even simpler, don't bother with the needless namespacing.
Change-Id: I4bbb115c1c2c89881a0bf88ccd54b0f5cb8b3518
(cherry picked from commit da9bd301c6f62e829daadb2af6a6b9633d4f1cb9)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: I7fd62153c7267a3d606b86d74bebecf6b8d75250
(cherry picked from commit a93bb27aa46c84410c8848a6118d5d63d47be92c)
Reviewed-on: https://gerrit.libreoffice.org/9345
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
Shared formula import code depends on this.
Change-Id: Iecb009252c56673df33e0d681de825911154903a
(cherry picked from commit 286760359bae7e21a772dd104ab17a1df69a57b0)
Reviewed-on: https://gerrit.libreoffice.org/9347
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
Else it would get processed further to a surprising result.
Change-Id: I3d6f0d680e0c4c3ffe1d28dcbaf51a156f569359
(cherry picked from commit 162029e55af8f681966497ab7f20277888eac478)
Reviewed-on: https://gerrit.libreoffice.org/9335
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
Or they would get drawn for real.
Change-Id: Iec24e70a80ff8aa1ef7512e71249a99243297c4e
(cherry picked from commit 224b235971a01971de626d38ccc8506d0a55771b)
Reviewed-on: https://gerrit.libreoffice.org/9323
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ibe64cf7177a5298c1878e0014c049dc9c82b1344
(cherry picked from commit 83a88b942134314e86ac612d0ef70a8e4919e4af)
Reviewed-on: https://gerrit.libreoffice.org/9298
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Returning prematurely would end up skipping pasting of notes.
Change-Id: I79e0968023342a68fe729f31eb6cfc3cfacd5850
(cherry picked from commit f4673ccd5e26d38a28f297d64ed70ba719d21ef2)
Reviewed-on: https://gerrit.libreoffice.org/9295
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I0878f734599f566cde83183947cd7613c0f8d5c6
(cherry picked from commit a45973a90625f4b9e0f603154194f357ff2418d4)
Reviewed-on: https://gerrit.libreoffice.org/9292
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Regression introduced with c81dec478ab0618f2acd2580654a93d3a7185444
memcpy some sizeof(OUString) is doomed to fail.
Change-Id: I81dc9cc7eaf02607ed05b4d284a7e5e462eeeb0a
(cherry picked from commit e891afeccba8f20f8bdaeacb20f2215cfcb1abfd)
Reviewed-on: https://gerrit.libreoffice.org/9282
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
|
|
We don't want to broadcast over the whole selected range, which may be
the whole sheet which is well over 1 billion cells !
(cherry picked from commit af7df25bcc8bc95462e2b3bf8c003d035111a479)
Conflicts:
sc/source/ui/inc/undobase.hxx
sc/source/ui/undo/undobase.cxx
Change-Id: I7c139ce5efe09312cf824e35f0efe551184032eb
Reviewed-on: https://gerrit.libreoffice.org/9240
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
This causes crash with dbgutil build, and I'm sure would cause issues with the
release build as well.
We now use broadcasting to handle reference update during undo of block move,
so this old way of handling undo for block move is redundant and obviously
causes issues.
(cherry picked from commit 6cc92a2fead337eef3d9cc3e5818cfcc505e4651)
Conflicts:
sc/source/ui/docshell/docfunc.cxx
Change-Id: I9dcbb9d9e3808da3f8510eab16ad21b626f881d9
Reviewed-on: https://gerrit.libreoffice.org/9265
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I269497cac645e486ac08bb2b011df1b5b23dc021
(cherry picked from commit 1899bd0c3b8a16ede2de0125e762b23ba013d81f)
Reviewed-on: https://gerrit.libreoffice.org/9264
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I7c78f54c9386eced16113e69e625d23ed4acedd7
(cherry picked from commit 7aa32a759fb7b440f870739f7bb680f405f338ce)
Reviewed-on: https://gerrit.libreoffice.org/9261
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ib9d6a73d485878bfe6c2a1875936025eb4d0a30a
(cherry picked from commit 67563fd55b230eb68fef705ff645af7dab73af73)
Reviewed-on: https://gerrit.libreoffice.org/9260
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Don't be fooled even when the document doesn't have a drawing layer
initialized. Sometimes a note creates caption on demand later, but if
the drawing layer isn't there the caption will not get created, which
ultimately causes this crash.
(cherry picked from commit fe451fb94a33c914c0a7c1265c013d9704af850a)
Conflicts:
sc/inc/document.hxx
Change-Id: I37f4902fa84de91c9f793dc352127d9345a725e3
Reviewed-on: https://gerrit.libreoffice.org/9254
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I9dfe76d422ad732a081442b95a995d8d395a098e
(cherry picked from commit 571cefca474e6b77d68f9fa31f805dcf692927fd)
Reviewed-on: https://gerrit.libreoffice.org/9253
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
|
|
Change-Id: I9ebdb2315b51c2b53d8cfa0486b3ec22a8e0d88d
Reviewed-on: https://gerrit.libreoffice.org/9232
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
|
|
Also fixed reference update problem.
(cherry picked from commit 3c4fb52d8fc89fe43983991ed2339295b2e0ef8c)
Conflicts:
sc/inc/column.hxx
Change-Id: I06e6115ef969a011fdd5c92d5eb1927fb7ae789b
Reviewed-on: https://gerrit.libreoffice.org/9220
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Else an invalid iterator may result, which would eventually leads to a
crash.
Change-Id: Ie909de61244d661c72a3450cc69b29fbb218a248
(cherry picked from commit 7fbe0f56192f7e106c560646d37fbb93b69b0446)
Reviewed-on: https://gerrit.libreoffice.org/9225
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
... because SvTreeListBox can hold more than 64k elements.
Change-Id: I138876d84cd9eb42d32ef7f52099e792b55b6384
|
|
Change-Id: I8685c2e3a6993f3924fe8e7caf75318c8ebc566d
|
|
(cherry picked from commit 878a5dabff4669fb606a461e11eaf286d0c8b07f)
(cherry picked from commit 0b03f7ed575838f90e6b1ebec3538a3a214f81fb)
Conflicts:
sc/source/ui/cctrl/checklistmenu.cxx
sc/source/ui/inc/checklistmenu.hxx
Change-Id: I1b3ae601726401a0e70fb1a05b9a90c43773794c
Reviewed-on: https://gerrit.libreoffice.org/9211
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
below the top of the reference range.
Change-Id: Ibb3dadb50dd076ae05033b046c9506c60605f713
(cherry picked from commit c3e40f47abe3da7e24059281a9047b1292241398)
Reviewed-on: https://gerrit.libreoffice.org/9190
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: Idfc3b3dd1d9f4de428e43c515b13a8d7e40e347c
(cherry picked from commit f1d5c27892b0b6a5dc81c94dbf61f9285a52aa5a)
Signed-off-by: Kohei Yoshida <kohei.yoshida@collabora.com>
|
|
Change-Id: I225d50445d7f84a17c0b9492c17247e4c1c9ef44
(cherry picked from commit 453ea919e70fa9832f11e3ef042bb80cd86892cc)
Reviewed-on: https://gerrit.libreoffice.org/9189
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
This is the behavior as of 3.6. It had changed in 4.0 and onward by
accident, and caused the bug as reported in fdo#75397.
Change-Id: Id96fea354604b3c13cbbf2d9a73223b7725c7d66
(cherry picked from commit 5fab47ddbe332a150fb2005e941a2c19bd38ce7f)
Reviewed-on: https://gerrit.libreoffice.org/9187
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ic007b07a82eb83978527254518d85c5a2903a48d
Reviewed-on: https://gerrit.libreoffice.org/9175
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
When importing shared formula tokens.
Change-Id: I7e1a05a78c3a93330476516e0459cffb668e3f66
(cherry picked from commit c6c286f14468d341f5fd88edc39a37175a1b6caa)
Reviewed-on: https://gerrit.libreoffice.org/9167
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Icd9f8c60d9e105478abb5b5ad64e969623830a4c
(cherry picked from commit dafce0665c852297d39cddf76f46c77c14a8f12a)
Reviewed-on: https://gerrit.libreoffice.org/9157
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I7a4160db0dd2b9ac2c98402bb6110c548e879b3d
(cherry picked from commit 36e0d770928f71c932db5dea9f04645f65222ea6)
Reviewed-on: https://gerrit.libreoffice.org/9156
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
And in case of an empty string, call svl::SharedString::getEmptyString()
to get an empty shared string instance.
(cherry picked from commit 50708577850544920c746ebc382d47275452a761)
Conflicts:
sc/source/core/tool/queryparam.cxx
Change-Id: I0923e59f03468790270de8ef22323c0cedad002f
Reviewed-on: https://gerrit.libreoffice.org/9155
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I00683ce64fea58a80cd7137384e8f30464c44e9f
(cherry picked from commit 4158d8843d50d50e9830c8dc24af8722de77f4af)
Reviewed-on: https://gerrit.libreoffice.org/9153
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
This change requires mdds 0.10.3 as the baseline.
Conflicts:
configure.ac
sc/inc/fstalgorithm.hxx
sc/source/core/data/column.cxx
sc/source/core/data/table3.cxx
sc/source/ui/docshell/dbdocfun.cxx
Change-Id: Ia6d2bf1ee17e96c30b6d5310f5c49e5a4404e094
Reviewed-on: https://gerrit.libreoffice.org/9144
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Also improves the situation for fdo#55697.
It is just the fist step to a better algorithm.
Change-Id: I15de1ca6604e585fcf5690f0d903c757d641e765
Reviewed-on: https://gerrit.libreoffice.org/9078
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|