summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-08-17tdf#133853 Large spreadsheets have 16385 columns instead of 16384Aron Budea
MAXROW_JUMBO/MAXCOL_JUMBO should be max - 1, similarly to MAXROW/MAXCOL. Since f6064b13586aa8681907b69e4f43643251f9b803. Change-Id: I3d300e916b9584a2231f39bec5a044bd82c81752 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100777 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 8f53858381e0cd6a3391c4ce8a097cdafa9c8df0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100790 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-11tdf#131047: expand search results frameXisco Fauli
Change-Id: I883c86658f3aa4ee18d03d8c3aa277000f278abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100362 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-08-04tdf#134817 XLSX export: fix partially lost header/footerAttila Szűcs
When header/footer text contain text portions with different font setting, only the last text portion was exported. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Id4cba2b9188459cdaa0ade30c2217d8f59fe6316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98938 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99788 Tested-by: Jenkins Reviewed-by: Attila Szűcs <szucs.attila3@nisz.hu>
2020-07-30tdf#130559: don't fail creation of preview when BackingComp can't add...Mike Kaganski
an event listener. This crashes when loading a document with print preview set as active view. Regression after commit 128ecffe53394c1f045521c2efb42ea03a319f4b. Change-Id: I5dc421f7c08dd70d51772fac5432f33cd9a1491a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99442 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit e3b695f6a1525ac6b32abd27a6368a7e8b7d09fa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99740 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-30rhbz#1861794 csv fixed width import missing split handleCaolán McNamara
regression from... commit 1e97ca02773e2ba968606eed61d25d88f0d7e417 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Oct 14 11:05:07 2019 +0100 EndMouseTracking was left uncalled Change-Id: Ia952addac585737c3d3aa4fd68d772c3acbae848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99732 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-07-27tdf#134769 XLSX export fix: unable to open with MS ExcelSerge Krot
Change-Id: I8fff01118e25768ca54c816fcb0eb522da6f38bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99149 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 641dbafcb4c7b00bc9e56b58d12c95a6f05ee88d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99394
2020-07-21tdf#31231: don't set charts modified state when !IsEnableSetModifiedMike Kaganski
Modified state of the chart is part of modified state of owner document: see SfxObjectShell::IsModified. So when the document is loading, any updates to its charts don't make the document modified. Change-Id: Ie7643ff55bd44f1afe3f796f72c2508ea57f65d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99102 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 3e6519714abebf00637c953dbba055d620cfe6f7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99064 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-16tdf#134332, tdf#134796: sc_subsequent_export_test: Add unittestXisco Fauli
Change-Id: I4b67937dbec76c32c61a85ed24ca67bfcf3f83a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98743 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit c60ce3d48dbccd616cfa989ca3d8f1ded4ccd411) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98844 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-09tdf#107885 - VBA AutoFilter can't compare stringsAndreas Heinisch
This is a combination of 2 commits. tdf#107885 - VBA AutoFilter can't compare strings During the creation of table fields from an auto filter search criteria, check if the search text is numeric in order to search either for strings or numeric values. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91834 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 59374ea361815b022b1f2a415f995852f23f222e) Use OUString::toChar(), tdf#107885 follow-up (cherry picked from commit 978862b99ca7af6a17012084923494b6c85754d5) Change-Id: I6f334e7fd06c03850a535a0d54438577d15ccac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98453 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-07-09tdf#134688 run error dialog async and keep the events in the one event loopCaolán McNamara
instead of a sub loop which helps to not lose the mouse release where the dialog was shown on the mouse press Change-Id: If0baf15e85aff7a28ca058e2626b58802d0dad08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98451 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09Resolves: tdf#124454 exec the matrix operator on values converted from stringsEike Rathke
Effectively a fallout from the matrix operations rework started for tdf#89387 that did not convert strings at all and subsequent work converted the string according to settings but did not apply the current operator on the result. Change-Id: I90c8963021396fd9a46b063f6aee96283f89271a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98385 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7ead920f7015bb8e7a4343b863333bb26187d9a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98338
2020-07-04Revert "tdf#126733: inverted emoticons sets for the conditional formatting"Heiko Tietze
This reverts commit a330d8eef09a3135bf6ae94b31b7ea944f256bdc. Reason for revert: Regression for existing documents Change-Id: I7bf70ddfa54c40732ca902f258530f34cac6cd98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97910 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a54dd72bce539faa0de7f18affd4fe6e426fd2d4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97917 Tested-by: Eike Rathke <erack@redhat.com>
2020-07-03Resolves: tdf#134455 Let TIMEVALUE() use lax time recognitionEike Rathke
... to accept minutes or seconds >59 Prepare SvNumInputOptions as enum class in case further options would be needed for anything else. Change-Id: Ie9ae62adf68f9948e23f55ac32c09a6b992a36e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97784 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 75230de70fece41986b5ad96bc959e6b1640003c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97792 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-02tdf#126733: inverted emoticons sets for the conditional formattingJulien Nabet
Change-Id: I5bd631b17c1008355c299ffceb622e6ea8c39d45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97636 (cherry picked from commit a76cb42a75b1694f20a1c95c99e3137369527dd3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97677 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-07-02don't add a cell to a non-existent column (tdf#104865)Luboš Luňák
This change also needs invalidating column position hints if the columns get changed by the copying of the cells. Change-Id: I4793e25f253c0197d88b313bc9336435cef649f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97603 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit ee2d2184133b3bf47d38a03b14abab2caa15dad1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97673 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01Resolves: tdf#85551 OFFSET() NewWidth and NewHeight must be >0 if givenEike Rathke
This also makes it necessary to adjust a test that reused the bug document for a different scenario but checked the result. Change-Id: I80136747445d5029aa5c894270448f002c567e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97553 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit f31d8d61859bb375c99419ff176adca27a9197b6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97509
2020-07-01Resolves: tdf#131424 separator in TableRef column specifier is validEike Rathke
Even only a separator or any operator single character. Change-Id: I102dd7fd49c1a6a7f1d8c39f4a6139a51dbebe51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97535 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit f02207acc00787f29bc9e8992b1e2f3a182de43c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97506
2020-06-27cid#1464973 & cid#1464975 Resource leakCaolán McNamara
Change-Id: I4df8fefa7f875e0a25585c4fef22f077dcd0b83d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97300 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464973: RESOURCE_LEAK (sc/excel)Julien Nabet
Change-Id: I923788f57e022c99a89a6406cf3ed02066efd022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97279 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8407daed1ddab1cc754f72d9f7d140a649abf1f5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97299
2020-06-26Related: tdf#134280 set max limits for solver options that show max valuesCaolán McNamara
just simply clip to the claimed max Change-Id: Ie64da80204c9c817c85724abd1fee8c6594967b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25Revert "tdf#133858 opening spreadsheet with large array formula takes 10 ↵Noel Grandin
mins" (tdf#134234) This reverts commit 9a5f2961b085ce2f23ecdf0a03d1114bacac8e2c. Reason for revert: causes regression, see tdf#134234 Change-Id: I1cc3e6daa0e65231e8a4d7c1ae4a60cfdf106457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 6f151be2994b0e78a890c13ccdd9249f1800c6de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97057 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-24tdf#134280 set legal range for Epsilon levelCaolán McNamara
Change-Id: If544da13913ab6ce84e934e351e4e2d78b6e1466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97051 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-24tdf#133629 calc, crash on format borders on multiple sheetsNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: Ie862ec4a29d495c71aa3a21a1941f801fa3a789e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96957 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8cad16207cb6d6df098d2a2f307df4fbc7519035) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96993 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-24tdf#133326 Crash after redoNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: I6a3d6b35dbd442014c84785d97cbd7eae19244cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96958 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 240758a972eb99dd4d26fa6040ff0b6614036621) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96992
2020-06-24tdf#133699 Slow sorting of a columnNoel Grandin
reserve inside a loop is a pessimization, since it breaks the logarithmic resizing of the std::vector data area. Also use the std::vector::insert method, instead of std::copy, since the insert method will perform less resizing operations. On my machine, this takes the sort operation from 25s to less than 1s. Change-Id: I30b99d42c56abc5a4ad5c133c7579fac3952173c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 97965876459d8cfda0b653551708eb14de36e632) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96885
2020-06-22failed cell dependency check should not set invalid values (tdf#132451)Luboš Luňák
Calc's dependency check done before parallel formula cell group calculation tries to ensure valid cell values for all the dependencies of the group's cell, and if it detects a problem such as a cycle it bails out. But since ScFormulaCell::Interpret() simply bailed out without doing anything, other cells could use that cell's possibly incorrect value for their calculation and get their dirty flag reset. This fix adds a flag to mark that bailing out is in progress, which ensures the bail-out is short-circuited and no cell values are set. Change-Id: Ia93c70d456682e19ce533abd2cf65ce35ffed9ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96838 Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Tested-by: Jenkins (cherry picked from commit 82803ef4736fbed89dd8ae0723f2c4f30e37ba8e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96801
2020-06-22tdf#97177 speedup loading of large ODS fileNoel Grandin
drop ScSimpleRangeList and just use ScRangeList, which saves us a conversion step. Then teach ScRangeList to do a simple merge, since we are loading in row order, and can just check the last few entries. Then fix a case of optimisation doing the wrong thing in ScAttrArray::SetPatternAreaImpl where std::vector::reserve repeatedly resizes the data array and breaks the normal doubling-resizing inside vector. On my machine the time goes from 5.4s to 4.8s Change-Id: I68a2204e0c02b673bbfe8aa0fdbe126e53ddbb41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96516 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit aabcf90da9a90240bddc140485f210dcab66724c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96800 Tested-by: Jenkins
2020-06-19delay and batch calls to StartListeningFormulaCells() (tdf#132165)Luboš Luňák
This is pretty much the same as tdf#133302. Change-Id: I5325b90601f503e572faefc455a38e0f5b055bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96560 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 7c99e23fddf089f2d52028944db8e435fc05088f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96580
2020-06-17tdf#133807 re-present search dialog after a short timeoutCaolán McNamara
Change-Id: Icc6016b3a9e3f25fd4c9e065e9f2d9570ad040c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17tdf#133692: Spacing within Calc formulabar reworkedThorsten Wagner
Change-Id: I4f590589fdc390bfa11f7db86e65ccab3dd084fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96403 Tested-by: Jenkins Tested-by: Andreas Kainz <kainz.a@gmail.com> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 45261267964d6fa1e820b0e4a7745e2e10fcb5f7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96503 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-16tdf#133268: Update non cmd icons, update Glue point iconsRizal Muttaqin
- Update some menubar visibility Change-Id: I7a464691b8608d01f0a8b3924c37e0fd510df45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96468 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 9a75493c69cdd79bfc1cb3d9faf003948e084ae3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96427
2020-06-16tdf#103414 Add/Delete decimal for 100th secondLaurent BP
Use Add/Delete decimal to change precision of time and duration Apply only to 100th second Change-Id: I2ff1b01db7ee67645511fcf7ea6bf65055e92a8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94765 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1861363d623963461905f42aa0b9dc2301f2eaaa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96349 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-15rhbz#1847031 null-derefCaolán McNamara
Change-Id: Ic9327788ebf49ac1ab0d3463f2f1e4d87ef14cb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-15tdf#132137 Rename Default Style in Calc.Srijan Bhatia
Change-Id: I0f7c5ffc64b2387fbb63bb5724594480d3135f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96215 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-15tdf#133971 hold self-ref until we returnCaolán McNamara
Change-Id: Iac1b79152c07915675a7dc562aaad9b4c465faa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96280 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-14Resolves: tdf#133985 make ok the defaultCaolán McNamara
Change-Id: I5fa0db660c03fb85a6a661b70fa9c14014c92579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96278 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-13tdf#133855 return early if disposed by FilterSelectCaolán McNamara
Change-Id: I532cf28039f2a63cbfd68aff44810cf6a5d40afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-13tdf#133953 use a popover to show interactive row/column resize intoCaolán McNamara
because a simple tooltip won't fire under gtk for that interaction Change-Id: I487b5c05805e3d0233da9a3b3c5ff1912d98baf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12fix ASAN in SharedStringPoolNoel Grandin
regression from commit 3581f1d71ae0d431ba28c0f3b7b263ff6212ce7b optimize SharedStringPool::purge() and fix tests which results in us potentially de-referencing an already de-allocated OUString object in the first loop in purge(). So switch to a different strategy, which only needs one data structure, instead of two. Change-Id: Iaac6beda48459643afdb7b14ce7d39d68a93339c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95226 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 5af636c5021ecf7fba8f5f34cc6af929f1e04b4c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96180
2020-06-12tdf#130227 Tabbed UI remove second extension manager buttonandreas kainz
Change-Id: I07a57afeb1c3a7814fe2f3fd63eb214d96d4af9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95773 Tested-by: Jenkins Reviewed-by: Andreas Kainz 🦅 <kainz.a@gmail.com> (cherry picked from commit 4fcf45bd1fb014a07fb062fb3ad1bd92427be9d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95876 Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-06-11tdf#133858 opening spreadsheet with large array formula takes 10 minsNoel Grandin
the spreadsheet has lots of SUM(IF over a whole column. Which results in us allocating a matrix with 1 million rows, which is rather slow to process. So reduce the matrix to the data that is actually there. We can only do this for some opcodes, because other opcodes act differently when referencing empty space, so for now I only perform this optimisation for the opcode in use in this spreadsheet. This takes the load time from 5m to 3s on my machine. Change-Id: I41fe9afcb0fbdf2a928a19c44a0f291a1247a41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9a5f2961b085ce2f23ecdf0a03d1114bacac8e2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96042
2020-06-10detect inconsistent SUMIFS() ranges when range reducing (tdf#132431)Luboš Luňák
03b352b9599514e4e244e1907510713cf1331284 introduced reducing of the SUMIFS range to the cells that actually contain data, but tdf#132431 introduces incorrect ranges that lead to negative indexes, and correctness checking of ranges comes only after the use of these indexes. Change-Id: Ia13db83d222310d470a0a8ecef51dbdd7992d479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95898 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 707cd62e00a75f5a07ef3a4acf5df9d49e8e07c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96030 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-10delay and batch calls to StartListeningFormulaCells() (tdf#133302)Luboš Luňák
In the testcase ScColumn::StartListeningUnshared() gets called repeatedly with almost the same cells range (just extending), so this gets quadratic. Delaying and doing it once on the whole range at the end avoids this. Change-Id: I3e92817d434cf7e4be0ea658f9adc0a24ceda260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95531 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 3677b86af004f331762d460f1a84c950ee8d0480) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95874
2020-06-09Resolves: tdf#133780 allow sorting search result treeview columnsCaolán McNamara
Change-Id: I7d5b1ffdaf99fd2e28dfd124db0fbbd4036e2dd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95877 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-09tdf#133807 represent a visible search dialog when search results is closedCaolán McNamara
Change-Id: If38b2770cfdd7d88bb75cbd47f44cc8515c4e041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-08tdf#133785 autofilter with dates crashes when search entry is used and clearedCaolán McNamara
restore original logic, and just keep the clear-all optimization for the non-hierarchical case Change-Id: Iafcd934c7e6e48e7e11f7fca9e51478e7e678b44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-08tdf#133595 FILESAVE XLSX: invalid content when opening file with shapeSerge Krot
Change-Id: I67fe29bbc9b982328a3efe63874922e7ed1a5854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95490 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 2081ab036bfd203d4d3be07064ef783baae97c3b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95671 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-06tdf#133486 Revert "fix TODO"Noel Grandin
This reverts commit 457d2a0c9373937332ad2ec7b16edc4b2c971a97. Reason for revert: <INSERT REASONING HERE> Change-Id: I4493fd0f1a309bd49ebe4ea3c14f7f558db9b90d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit bfb807bf6cf07243a88dc1e66883dfcea872ceab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95670
2020-06-03tdf#88109 improve autofill perf (2)Noel Grandin
make SvxWeightItem sortable, which shaves off 1% and turn the tree search off while performing this operation, which shaves off about 25% of the time on my machine. Change-Id: I94358ed565a0d9f1cc0ddb36b8349e83c9deb959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9073a47b99e22585c6d1603dd747cb14f081fca1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95414
2020-06-03purge shared string pool if ScDocument is closed (tdf#125428)Luboš Luňák
Especially with the testcases given in the bugreport the undo history would keep many unused shared strings. Change-Id: I57fcad73532fdcbad0a1298fbd06cb35c058bf96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95045 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 861fbd998f2b526c2aea073c9471613bf728fa75) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95323 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-30 00:01:31 +0000