summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-05-12remove unused uno::Reference varsNoel Grandin
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12convert SdrLayerId to strong_intNoel Grandin
Also - rename SetOfByte to SdrLayerIDSet - add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't allocate overlapping SdrLayerID values - add a new constant SDRLAYERPOS_NOTFOUND to be returned from SdrLayerAdmin::GetLayerPos Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8 Reviewed-on: https://gerrit.libreoffice.org/37467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12tdf#93171 Subtotal function with function indexes don't updateArul Michael
Calling InerpretTail during Hide rows by SfxHintId::ScDataChanged broadcast Change-Id: Ie78170bb6d49933a49d828a18637cb410796dc06 Reviewed-on: https://gerrit.libreoffice.org/37509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-11lok: sc: notify cell cursor position to address control in clientMarco Cecchetti
A new callback has been introduced for notifying the client: LOK_CALLBACK_CELL_ADDRESS Change-Id: I40b38a3cb8fb658c3f00332d56cfcbaf98e13771 Reviewed-on: https://gerrit.libreoffice.org/37357 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-05-11tdf#107258 Create show/hide all comments toggle button.Gulsah Kose
Created new show/hide all comments button for calc by ShowAnnotations command. Unifyied writer, calc and impress's ShowAnnotations slot. Change-Id: I27149d09ee1763b84258c5e0c890a9628c8874c0 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/36697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-11Get string also for external reference to double for operands of '&'Katarina Behrens
In a formula like ='ExtRef1' & 'ExtRef2', or ='LocalValue' & 'ExtRef1' empty string became an operand in concat operation if the referenced external cell was a non-string one. Change-Id: I7b0ac5de68349eae85afe48f377e30cab76e3fbf Reviewed-on: https://gerrit.libreoffice.org/37469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10tdf#107572: retrieve Default autoformatJulien Nabet
by fixing DefaultFirstEntry comparison operator. From http://www.cplusplus.com/reference/map/map/key_comp/: "... Two keys are considered equivalent if key_comp returns false reflexively (i.e., no matter the order in which the keys are passed as arguments). ..." Certainly regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=652158c3f2c9cd0d6f71ecd14bf5d5cc02a71b50 author Julien Nabet <serval2412@yahoo.fr> 2015-09-15 19:41:48 (GMT) committer Julien Nabet <serval2412@yahoo.fr> 2015-09-30 12:11:35 (GMT) commit 652158c3f2c9cd0d6f71ecd14bf5d5cc02a71b50 (patch) tree 13ad29a110565f24e7010a68d902cadf1c441b62 parent 8727afe771a3e4d585e98ca9cceff2504e500bb0 (diff) tdf#94173: Calc doesn't save your own created autoformat presets This new patch has also been tested for tdf#94173 Change-Id: I60de5fffe39be9b3615c32a317611812b42bafc7 Reviewed-on: https://gerrit.libreoffice.org/37362 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-10Add unit test for non-propagation of array context, tdf#107724Eike Rathke
Change-Id: I59abfaba2866c25dac7db2b8bc5ce8c563a88240
2017-05-10ParamClass::Reference return for range creating OpCodes, tdf#107724 relatedEike Rathke
Change-Id: Icb9dd2da1900fa4e9d57326681642cfc2b06095b
2017-05-10partial revert of "loplugin:checkunusedparams in sc(part4)"Noel Grandin
<erAck> noelgrandin: actually that "also fix bug in ScDocShell::DBAreaDeleted" with 4d047221945b34a9023d852bbd19a2a24a7f54c3 wasn't a bug because the aDocument.RemoveFlagsTab() call with ScMF::Auto removes the AutoFilter which is in the first row of the DB-Area <erAck> noelgrandin: now it unnecessarily processes the entire range <noelgrandin> erAck, does that also apply to the PostPaint call? <erAck> noelgrandin: should so, as only the row with the AF-buttons needs to be repainted <noelgrandin> erAck, will revert that part Change-Id: I29b9ee4e1b6517a01bf67f8efc09217d9df453a5
2017-05-10fix buildNoel Grandin
after commit 4d047221945b34a9023d852bbd19a2a24a7f54c3 "loplugin:checkunusedparams in sc(part4)" Change-Id: I3d088bb73baa8c3d6e6186697c215350056c56a4
2017-05-10Resolves: tdf#107724 INDIRECT and OFFSET return ParamClass::ReferenceEike Rathke
In which case ParamClass::ReferenceOrForceArray is not propagated to a nested function. Change-Id: Ibf054d7a2b7350b90ab71766fd1d501c5ae5d5e9
2017-05-10GetParameterType: SAL_MAX_UINT16 for return ParamClass, tdf#107724 prepEike Rathke
Change-Id: Idff1d247907494ffd50a0fcf0fc73344e381cc3c
2017-05-10Add ParamClass ScParameterClassification::CommonData::eReturn, tdf#107724 prepEike Rathke
Init with Value, could be Unknown or any other value except Reference as well at the moment, actually DontCare. Change-Id: I689eb2ed297bec3a5ad333f8bb247ec2184faf5a
2017-05-10loplugin:checkunusedparams in sc(part4)Noel Grandin
also fix bug in ScDocShell::DBAreaDeleted which has been there ever since it's initial commit in commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: Ifc8d6dec4843c668404fdf1ca1a9e521f73132d5 Reviewed-on: https://gerrit.libreoffice.org/37459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10loplugin:checkunusedparams in sc(part3)Noel Grandin
Change-Id: I61fc2ba762983d7bafb6ed8baafba458590af59a Reviewed-on: https://gerrit.libreoffice.org/37458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10loplugin:checkunusedparams in sc(part2)Noel Grandin
Change-Id: I1d54d16dbe5648a21baa9bf96444e60fcd034c81 Reviewed-on: https://gerrit.libreoffice.org/37457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10loplugin:checkunusedparams in sc(part1)Noel Grandin
Change-Id: I8c4fca704fe8ed6f861728cc3f3782c676aba67c Reviewed-on: https://gerrit.libreoffice.org/37435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10Hold ParamClass at FormulaByteToken instead of bool, tdf#107724 prepEike Rathke
* change IsInForceArray() to GetInForceArray() * add IsInForceArray() to keep previous functionality Change-Id: I64c891486e548a66539646846a4691a213c783ac
2017-05-10Disambiguate Reference -> uno::Reference (tdf#107724 prep rel)Eike Rathke
Change-Id: Ie2858e2e3c81da2041b53389bd06c87211fa8833
2017-05-10Change IsForceArrayParameter() to GetForceArrayParameter(), tdf#107724 prepEike Rathke
Change-Id: Icd3400e4ee1c69860908a2ad0ca6e52879f2f725
2017-05-10Disambiguate Reference -> uno::Reference (tdf#107724 prep rel)Eike Rathke
Change-Id: Ie456b0cff5f317a10b9dbfce58626d1b8a74fb49 Reviewed-on: https://gerrit.libreoffice.org/37440 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-09Move ScParameterClassification::Type to formula::ParamClass, tdf#107724 prepEike Rathke
To be able to later differentiate specific types in the compiler. Change-Id: If97485c0cb8e8e2e129c61cd3f01d9d420c92c8d Reviewed-on: https://gerrit.libreoffice.org/37439 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09Fix typosAndrea Gelmini
Change-Id: Ie0f67456e5c7d9b7b26b27b4d633881236ceeadb Reviewed-on: https://gerrit.libreoffice.org/37361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-09Guard against a failure when compiled with optimization using g++ 4.8.2Eike Rathke
i.e. Linux-rpm_deb-x86_71-TDF Change-Id: I4866eda4f87af3fd9b15ab24f549d1a1c6ae4ee7
2017-05-09make loplugin constantparam smarter about string paramsNoel Grandin
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09Avoid adding unnecessary overhead to formula calculation.Kohei Yoshida
Instead, hide the overhead within the logger code which is disabled in the release build. Change-Id: Ie80c2a1725476d96d3e5551cf0303ecb5d73b47e Reviewed-on: https://gerrit.libreoffice.org/37409 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-08Removed duplicated includeAndrea Gelmini
Change-Id: If24026da701ea041fa3138a8ab0905a175da4ea6 Reviewed-on: https://gerrit.libreoffice.org/37360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-08cleanup tools/debug.hxx includesJochen Nitschke
with command > git grep -l tools/debug.hxx | xargs grep -L DBG_ | xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d' don't change files in includes/ and */pch Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08 Reviewed-on: https://gerrit.libreoffice.org/37349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08loplugin:checkunusedparams in xmloffNoel Grandin
Change-Id: I59d2cb1f69882b62e6fe732e9d9214feec8a79a2 Reviewed-on: https://gerrit.libreoffice.org/37283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07break circular includeJochen Nitschke
of include/vcl/window.hxx and include/vcl/vclevent.hxx Change-Id: Iacb3cc942693a732de5899af26e08e0977a83102 Reviewed-on: https://gerrit.libreoffice.org/37338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-05-07revert OSL_ASSERT changesChris Sherlock
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert sc module away from OSL_ASSERT to assertChris Sherlock
Change-Id: Iead653868ea7e0d1ed4ba83ef1a46e1ae5874d13
2017-05-06coverity#1403661 try to silence 'Mixing enum types'Caolán McNamara
and coverity#1403660 Mixing enum types Change-Id: I5b47384747e24139ac0531e5e373c4f88f30ea81
2017-05-06tdf#86001: Pass on the language info from the cell to the engine.Kohei Yoshida
So that it can be used to set the correct language to use to check spelling (or disable it altogether). Change-Id: I4fddd9a7e08ab55476566db98476794b2fc1eb13 Reviewed-on: https://gerrit.libreoffice.org/37307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-05Fix typosAndrea Gelmini
To complete commit 0ef94e2b559547bc4e906e7f24e57ff5d642e108 and f12096272e684ddcd8ffa4e34dcb0a680cc594c2 Change-Id: Ie86bbfbd58dd728a013bef221e4d5c8fbcaf8e03 Reviewed-on: https://gerrit.libreoffice.org/37199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-05Use Date(css::util::Date) ctorEike Rathke
Change-Id: I99fa34fe3177bced41b16660ef1c3548b55ec60d
2017-05-05ScDatabaseDocUtil::PutData: do not create an empty date if row wasNullEike Rathke
Didn't harm because bEmptyFlag is evaluated later, but now Date asserts on various occasions. Also, the calculations are completely unnecessary in this case and were wrong anyway. Change-Id: I03ad7204668fbd6bcfa243e6a7c778be66f92c43
2017-05-05Use the non-template variants.Kohei Yoshida
Eventually the template variants of these helper functions should be removed. Change-Id: I63edf2776efafd08908947217ce53dfc6d5e35fc Reviewed-on: https://gerrit.libreoffice.org/37269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-05Will this fix the android build?Maxim Monastirsky
Change-Id: I2ab31fa445d9b8a6aeaa721848d3afb72fd865b7
2017-05-05loplugin:checkunusedparams in toolkit..vbahelperNoel Grandin
the extra argument on the runtimeexception method was only ever passed an "OUString()" Change-Id: I0ea19ae9328760918f1267f27ba103432fff0b47 Reviewed-on: https://gerrit.libreoffice.org/37274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05sc: Remove some dead slotsMaxim Monastirsky
Change-Id: I92cfd5043c084d64fdfba3a1df817ee035388797
2017-05-05Defining SID_UNICODE_NOTATION_TOGGLE once is enoughMaxim Monastirsky
Change-Id: I6d63ee582ad5530ecb713dd65350912ee27dc15d
2017-05-05loplugin:checkunusedparams in svtoolsNoel Grandin
Change-Id: Iea68d7c0683740acaf4f85c14efe2a33e0cf13e7 Reviewed-on: https://gerrit.libreoffice.org/37201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05loplugin:checkunusedparams in svx(part4)Noel Grandin
Change-Id: I032b49f4e1228ef275d7ff8d87ba969dcef687ab Reviewed-on: https://gerrit.libreoffice.org/37248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05loplugin:checkunusedparams in svx(part3)Noel Grandin
Change-Id: I4b9b749565750acc7f674957fd619870b0e29237 Reviewed-on: https://gerrit.libreoffice.org/37240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-01 23:50:35 +0000