summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2015-06-17Resolves: tdf#86305 clone upper left of matrix result if double tokenEike Rathke
Change-Id: I541577e0b99b0144a755e5755adc890c0ca8d204
2015-06-16unit test for tdf#91411Eike Rathke
Change-Id: I963674ad6c6a4ca95f1a65041f7ced64d7d86a43
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16fix 176 unbalanced XML_f xlsx export failuiresCaolán McNamara
regression from commit beb8e2830dc9e1c771e196fcaf08cdfd6bf3dde3 Author: yogesh.bharate001 <yogesh.bharate@synerzip.com> Date: Tue Jun 2 16:39:09 2015 +0530 tdf#61908:XLSX formula cell range is not exported for MMULT. Change-Id: Ia54ce5ce437e592378fe930b779c518de9670995
2015-06-15Resolves: tdf#91411 end listening only on selected sheetsEike Rathke
... not in cell areas of all sheets. Change-Id: I8d19c15c6d8d89652ac5695214bc4dd930783087
2015-06-15use ReplaceToken() in ReadjustAbsolute3DReferences()Eike Rathke
Actually the RPN token needs to be replaced as well if it was referenced. Change-Id: Ie548568dceadaf315ae5596c480916730bed2dca
2015-06-15prepare ReplaceToken() to replace also in RPNEike Rathke
Change-Id: I98fbcb9849f2c2b1f26109a54ecbf5347cdd8b4e
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15tdf#55065 try to re-enable the testDavid Tardon
It works for me at least. Change-Id: Ib4128ace7b218d55a72dddd50666fe75faee7d34
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15cppcheck:redundantConditionNoel Grandin
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-15more adjustment of references in RPNEike Rathke
Similar to 47f002cbbf9593ab0097e178732e51b365b42732 the RPN tokens have to be adjusted to catch also references generated from named expressions and the like. Quite likely this may fix some non-obvious cases of reference update bugs and listener problems. If some cases worked so far it means we're recompiling too much.. Change-Id: I29e8427f72afdd29aa45047cb52ba59161c18892
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-13do not access token data after token has been destroyedEike Rathke
Change-Id: I624e64745fd3874be3e1bd3df6bac18dfb17aebb
2015-06-12do not adjust RPN named expressions relative references, tdf#91842 follow-upEike Rathke
Change-Id: I5a991d3b86fec0a3800d8243f73eb764789c8c69
2015-06-12spellingAntoine Cœur
Change-Id: I5ccbb5a2b31192cea96fbb0f4ab926af86e94c9d Reviewed-on: https://gerrit.libreoffice.org/16223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Philippe Jung <phil.jung@free.fr>
2015-06-12tdf#61908:XLSX formula cell range is not exported for MMULT.yogesh.bharate001
Problem Description: - Matrix multiplication cell formula range is not exported after roundtrip. XML Difference: Original : <f t="array" ref="G5:G6">MMULT(A1:C2,E1:E3)</f> Roundtrip : <f aca="false">MMULT(A1:C2,E1:E3)</f> Solution : Added formula cell range support for matrix multiplication. Change-Id: Ic871f064a98a324bc16a4253b633c97417c3f900 Reviewed-on: https://gerrit.libreoffice.org/16033 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-06-12copypasta error, tdf#69552 follow-upEike Rathke
Change-Id: I3388a75bb8aa23d8a8998671f25b5297352efca8
2015-06-12tdf#62095 fix O(n^2) algorithm in opening pathological fileNoel Grandin
with tons of missing styles Change-Id: I93c41f1e461a6e148e9f4c1dd84a598ca0090b54
2015-06-12FLOOR.MATH has 3 parameters, show them in UIEike Rathke
Change-Id: I04a3990b90bd84c680df56ab6a5dc9eca575e696
2015-06-11tdf#91820 Minor fixes and fix icon linksYousuf Philips
Change-Id: I8b151c09bd8630abfc5b7ec3b56870e0075c8d36 Reviewed-on: https://gerrit.libreoffice.org/16231 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-11recompile TableRef formulas only after position was updated, tdf#91842Eike Rathke
Change-Id: Ibdcfdd6175e6ccb8aded02d59b1b21e92a0fc120
2015-06-11adjust also RPN reference tokens, tdf#91842 and probably othersEike Rathke
Similar to beb5879f8fea231a037acf010812df2dffbe302d it is not sufficient to adjust only the parsed tokens, generated RPN tokens need to be adjusted as well. Quite likely also other Adjust...() functions have to handle this, need to investigate. Change-Id: I5de4e2238703b3ce134f7d46a87bd7a4fb940cff
2015-06-11Resolves: tdf#89643 report builder function wizard segfaultsCaolán McNamara
regression from commit 3d6521280929ecacc53b7c358d29d0b5d31b3462 CommitDate: Thu Jul 31 22:14:25 2014 +0200 fix memory leak around function descriptions Found by Lsan. There are two implementations of getCategory, one (sc) returns a new one each time (hence the leak fix) and the other (reportdesign) returns a pointer to one that belongs to the manger (hence the crash). The code in formula really looks to me to expect that the getCategory return a pointer that "someone else" needs to look after, i.e. the reportdesign variant is the more correct so revert 3d6521280929ecacc53b7c358d29d0b5d31b3462 and to fix the leak make the sc own the ScFunctionCategories and just cache them like the reportdesign one does Change-Id: Ifd986301a54b4d20449e864697655cd973e0c4df
2015-06-11java:remove more unnecessary catch/re-throwNoel Grandin
Change-Id: Id9a13c7f4ae0fd53c95c551544e60af44bb3fb95 Reviewed-on: https://gerrit.libreoffice.org/16203 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11tdf#69552 [part 2] support all ODFF1.2 and Excel2013 variationsWinfried Donkers
of CEILING and FLOOR Change-Id: I9537d9bd8dbca2eac769e74e9d3d5b298b76f594 Reviewed-on: https://gerrit.libreoffice.org/16016 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11convert 'it.begin() == it.end()' to 'it.empty()'Noel Grandin
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145 Reviewed-on: https://gerrit.libreoffice.org/16212 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11speed up Java unit tests by removing sleepsNoel Grandin
and replacing them with a call to XToolkitExperimental:: processEventsToIdle Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932 Reviewed-on: https://gerrit.libreoffice.org/16201 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11loplugin:staticmethodsStephan Bergmann
Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10tdf#89972: also copy external reference statusMike Kaganski
fixes regression from commit 4467c67dc8bf17c67c70985c0d0ea64636884f9f, where the new optimized code path failed to properly register ScFormulaCell with ScExternalRefManager. Introduces a new public method in ScExternalRefManager: insertRefCellAsTmpl that registers a formula cell to listen to the same external references as template cell Introduces new property to ScFormulaCell: mbIsExtRef that indicates that some external references are referenced by this cell Also introduces new method ScExternalRefManager::hasCellExternalReference (for use in unit test, will be posted immediately) Change-Id: Iee07d7b51949fd31953b5fa662a213052eb85181 Reviewed-on: https://gerrit.libreoffice.org/16066 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-10tdf#89972: unit test: check proper external ref manager registrationMike Kaganski
depends on gerrit#16066 Change-Id: I3dde8acfbf0170d0c2cd3ef0b626f3b286922b65 Reviewed-on: https://gerrit.libreoffice.org/16210 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-10sc tiled editing: Mapping has to be turned off after drawing the buttons.Jan Holesovsky
Otherwise the redlines are on wrong positions in the tiled rendering case. Also - we are actually never call with something else than MAP_PIXEL, so let's kill the resetting of the mapmode; let's see if some obscure corner case bites us here. Change-Id: I8da07dd5448b8863df3148882ec50e6746760cca
2015-06-10Enablaed -> Enabled.Jan Holesovsky
Change-Id: Ia73ae54068d208d6b2db3439f38402664bfa8d29
2015-06-10sc tiled editing: Corrected dropdown button offsetHenry Castro
Change-Id: Ieff88d5de119db30c3fbd2f58ba52696eeb3d327
2015-06-09more tests for the implemented cases, tdf#90001Eike Rathke
Change-Id: Iec22ad67c9deaada827ba8eac47581e08f934353
2015-06-09correct 3D reference update on sheet deletion, tdf#90001 follow-upEike Rathke
be1b3daeeb64a44e577510561d02147b87db72c2 missed a few cases * a deleted reference start was shifted by two sheets instead of one if the formula was on a sheet before the deleted one * a deleted reference end was not correct if the formula was on a sheet behind the deleted one and used relative sheet reference * #REF! wasn't set when the entire referenced range was deleted Change-Id: Ib9c7492a651a8429fa1c411c8e447593e366e09d
2015-06-09More CppunitTest_sw_uiwriter fixesMiklos Vajna
1) Guard against nDPI == 0 in ImplLogicToPixel(), it's the caller's responsibility to ensure that the DPI value is in the expected range. 2) pOut in sdr::overlay::impCheckPossibleOverlayType() is seen as 0. Change-Id: Iab5ff10aa7953993161dcad2d49d99d80c588e01
2015-06-09calc mapmode: Convert ScOutputData::DrawGrid to draw in logic units.Jan Holesovsky
Change-Id: Ie641c31e9023accf9d6bc510f8ca0b25ced3031b
2015-06-08destroy and reconstruct listeners only if content is affectedEike Rathke
Pasting formula content that created a formula group always constructed group listeners, then destroyed those listeners again and reconstructed the same listeners, because ScDocument::DeleteArea() is called with IDF_OBJECTS again if nothing is excluded from paste. Do the listener stuff only if one or more of the IDF_CONTENTS bits are set. Change-Id: I8c6b7f7bb3402590f2b1f3259ee730f26a906cdf
2015-06-08Windows MSVC: cannot specify explicit initializer for arraysEike Rathke
Change-Id: Ic42897ba6bb520c931f63e56d0f453ed14cfaa3d
2015-06-08Revert "Revert "check bounds in RPN tokens, tdf#90694 related and others""Eike Rathke
This reverts commit 3caa8c633168d3fa9540192d85869492df602d54. Rather let's solve that instead of reverting..
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I700b727c048aff5c19411fb9d5bd9601b296cb06
generated by cgit (git 2.34.1) at 2024-08-16 16:42:58 +0000