summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-03-27tdf#98893 Remove expensive calls to GetCellType + GetValue/... in calcAleksas Pantechovskis
Conflicts: sc/source/core/tool/cellform.cxx Change-Id: Id949800f6e13e268df798d2f1868f26deff66191 Reviewed-on: https://gerrit.libreoffice.org/23543 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-03-27extract function from ScDocument::FillInfoMarkus Mohrhard
A first step in breaking the function into smaller pieces. Change-Id: I94aeb11fd9c44a7eaa198cb39f208b574ef2758d Reviewed-on: https://gerrit.libreoffice.org/23548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-27mark the reference as constMarkus Mohrhard
Change-Id: I66ee342205acb9875899af9a65da9eb9cd5ecc74
2016-03-27don't inherit from std::mapMarkus Mohrhard
Change-Id: I50e9b27c45f6f7bd52af9e0c8a188124d6413cbc
2016-03-26sc: replace local macrosJochen Nitschke
inline one time use macros convert other macros to local helpers HMM2XL(x) probably means hundredth millimetres to excel or xls. Excels seems to use pixel and the ratio of 1/100th mm per pixel happens to be 26.483 hmm/px @ 96dpi Change-Id: I84de6106b24daa7bd1fb355fc9bc4c355bc285c7 Reviewed-on: https://gerrit.libreoffice.org/23478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-26remove debug functionsMarkus Mohrhard
Change-Id: I7a3aaa223c08d9fc79baeed59546d7268bd8e57b
2016-03-26no need to iterate through all cellsMarkus Mohrhard
Change-Id: I4621e58032a79b8438b4094b8c66d5d7a104e8af
2016-03-26also test that we are not still listening to the old areaMarkus Mohrhard
Change-Id: I7ad84ec75f435e3171b064eaaf60a819b09aeb02
2016-03-26add a few unit tests for conditional format reference listeningMarkus Mohrhard
Change-Id: I0609bf9033a7a2dd40afaae9effbfa06de5e4c83
2016-03-26fix indentationMarkus Mohrhard
Change-Id: Ibd65797b70cac33eb3302ad2020ffe38a01a2d85
2016-03-26add a few unit tests for ScFormulaListenerMarkus Mohrhard
Change-Id: Ie6c26967167a2dffa0e2047a78eb2b44b6c502f3
2016-03-26switch to a listener based cond format update, tdf#95437Markus Mohrhard
Change-Id: Iaee665a37a9637c40cd02a89a19240ade6e5af37
2016-03-25unit test for copying sheet-local names before original positionEike Rathke
Change-Id: I3a70539480b5b1d85b717fd6638359aa9ce5075a
2016-03-25sheet-local names' references of original sheet are updated laterEike Rathke
... in contrast to global names that are already updated before content is copied. So don't modify the token's original sheet number before adjusting the copied sheet-local names' references. Change-Id: I3edfb53370a5e8811d7301af95238a865ff38f0c
2016-03-25use the ScRefCellValue already available, tdf#97989Markus Mohrhard
Change-Id: Iccfff23f72d33ee012f91a230f2598b8fe3131cf Reviewed-on: https://gerrit.libreoffice.org/23514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-25use the ScRefCellValue that is already available, tdf#93405Markus Mohrhard
Change-Id: I68a2ddbe5049d10b5c11c2d77b26dce8dc55ab28
2016-03-25we already pass the ScRefCellValue as parameter, tdf#93405Markus Mohrhard
Change-Id: I27f7e8ffe93545fe872a0c5b64f26dc90cb70e6f
2016-03-25these two methods are identical copies, related tdf#93405Markus Mohrhard
This already gives a 15% improvement as we now only query the cell twice instead of three times. Change-Id: I2e0533f05ace6773ad0710b2c586ca325aeae91b
2016-03-24MM: remove lock from saved documentsJan-Marek Glogowski
Actually we have to call DoSaveCompleted to get rid of the locking. Instead this adds a parameter to skip the recent file registration used in non bCreateSingleFile modes. Change-Id: I57151f08ad8d737007da84c4566685cc37612dfb
2016-03-24const as const canEike Rathke
Change-Id: I6826c2f12d601a91462af454b90272ea7a7e932f
2016-03-24unit test for copying global names to sheet-local names, tdf#75372Eike Rathke
Change-Id: Ice179cfcbb81b6455648d67e6f8aec516f7c8576
2016-03-24tdf#75372 rework sheet-copy names for converting global names to sheet-localEike Rathke
This during copying a sheet copies global names that from a copied formula cell reference the copied sheet and converts the copied global names to sheet-local names. References to the original sheet are updated to point to the new sheet. It works for names used in formula cells copied but needs enhancement to pick up nested names, i.e. names used in names that do not reference the sheet but the nested name does. Change-Id: I1aa16cb28c9f7b3581bec289435492c21e6fcd73
2016-03-24tdf#98657: Fix a corner case when NaN's were added to ScFullMatrix.Jan Holesovsky
Change-Id: Id3befb82c39f9caacc908d664d42365ce6996054
2016-03-24don't sanitize value to an insane value, tdf#97863Markus Mohrhard
Change-Id: I0e4de6b676fb61536dadefc96a719cf50be128ed
2016-03-24use FindRangeNameByIndexAndSheet()Eike Rathke
Change-Id: I94c0ba0d613e235c538cd7bdd3c36c98618fec42
2016-03-24loplugin:constantparam in scNoel Grandin
Change-Id: I8608a6cb47972e9b838cc5ea431863348758ded0
2016-03-24werror: loplugin:staticcallMarkus Mohrhard
Change-Id: Ifce20e96dc088b982307fc60ba185f5dddfc28cc Reviewed-on: https://gerrit.libreoffice.org/23481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-24don't allocate and destroy a LocaleDataItem for each cell, tdf#97989Markus Mohrhard
Change-Id: I8bcdc7a42c87d17fde1dc9c79bc361bb625f992b Reviewed-on: https://gerrit.libreoffice.org/23480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-23sc - added fixed and variable array formula range perf testsMarco Cecchetti
Change-Id: If1efa2340e4ed8acca6fde08dcd422f4bd5fd531 Reviewed-on: https://gerrit.libreoffice.org/22721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-23add test for new ScMatConcat codeMarkus Mohrhard
Change-Id: I084e08575e8efd27bebdd9ae9880322913789ba4 Reviewed-on: https://gerrit.libreoffice.org/23440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-23better use mdds in matrix concat, tdf#88849Markus Mohrhard
Change-Id: I6155b86d0afbefafdf982962ffd0216334834379 Reviewed-on: https://gerrit.libreoffice.org/23425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-23sc: sc_mark_test can just link to scqahelperMichael Stahl
Change-Id: I90a5ca71ab8e2306eae337493a30ff0a56d5394f
2016-03-23add a recursion guard to lcl_FindRangeNamesInUse()Eike Rathke
Change-Id: Ia4a8f0273bb30b696b3499e75fa70e5c1a0981f1
2016-03-23loplugin:constantparam in scNoel Grandin
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01
2016-03-22Resolves: tdf#98642 comparing RPN insufficient in shared formula detectionEike Rathke
Change-Id: I78812c2d6fdb3464ccc2ebeee901a76f675effa4
2016-03-22enquote sheet name of other-sheet-local named expressions, tdf#96915 follow-upEike Rathke
Change-Id: I8fde73dc86c29054ec05bbc60e212ae660c78376
2016-03-22use an empty block as empty cell flag, related tdf#88849Markus Mohrhard
This should reduce the memory consumption for matrix objects quite a bit. Change-Id: I7a768f0c45777678000f4f8c25868107b22d62a7 Reviewed-on: https://gerrit.libreoffice.org/23383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-22tdf#84938 replace #define with scoped typed_flagsJochen Nitschke
'RangeType' becomes 'Type', goes into ScRangeData and is strongly typed now. This revealed a misuse of RangeType in vbanames.cxx where the uno equivalent was expected, but it had no impact because both values were 0. Change-Id: I0b4764d1411c709a1faa243ec70afeb160410990 Reviewed-on: https://gerrit.libreoffice.org/23415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-21unit test for copying cells within named range, tdf#93127Eike Rathke
Change-Id: I7bf6cd1c328e1d6eda5b67f05ec4870efe001b68
2016-03-21drop unused headerDouglas Mencken
Change-Id: Idca6bfe816f9e5fbade92a57b99eba59a17c1394 Reviewed-on: https://gerrit.libreoffice.org/23372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-21Resolves: tdf#93127 copying cells does not modify named expressionsEike Rathke
Change-Id: Ic3d0b0a709ecfeade4b3a9c4be9e0c9cfd766103
2016-03-21UBSan: SfxInt16Item/SfxInt32Item mismatchStephan Bergmann
...presumably a typo in 0bd43b8c782135e5eb3018ee345a3bd409419a1b "sc lok: Extend uno commands: .uno:SelectRow/Column" Change-Id: I725876ab17ffeb5814919f7b418fedb4506ecf91
2016-03-21sc tiled rendering: Fix a corner case with shift modifierPranav Kant
With shift modifier, all rows/cols should get deselected upto the current cursor position from the last cursor position *if* the last cursor position *with* KEY_MOD1 resulted in a deselection of row or column. Added a unit test to support this. Change-Id: I7b338ca52505d59480209802ee65a6d64b0ac67d Reviewed-on: https://gerrit.libreoffice.org/23364 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-03-20no need to declare the variable outside of the for loopMarkus Mohrhard
Change-Id: I1289d7e9b5f3459882582b494006a69075a0b860 Reviewed-on: https://gerrit.libreoffice.org/23382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-20loplugin:stringconstantTor Lillqvist
Change-Id: I94db03d7aa812df584cc13e75c132c09ce4b33aa
2016-03-20-Werror,-Winconsistent-missing-overrideTor Lillqvist
Change-Id: Ic197ab65be361ae3e642da2e20da4aba5cb93a74
2016-03-20tdf#45904 move java based api tests to c++kadertarlan
Change-Id: Ibd9411e844c8e42fe625ffd979e936f827099ee9 Reviewed-on: https://gerrit.libreoffice.org/22604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-19simplify new testMarkus Mohrhard
Change-Id: Icb43a88c03c364d7bdcbc99ff64804df7174fec1
2016-03-19fix previous commitMarkus Mohrhard
Change-Id: I5f7ec7f48bbcb995609c3d3ef4f64b9e6230b395
2016-03-19tdf#70448, Test for SetFormula functionJaskaran
Change-Id: Ie6899b90f02f8344710515af847170783a5e0d0f