summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2013-08-17No need for pointers here, use referencesMatteo Casalin
Change-Id: If00f4f6248f40e3a8feb0c11b3d46b85748a97bc Reviewed-on: https://gerrit.libreoffice.org/5459 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-08-17sal_Bool to boolTakeshi Abe
Change-Id: I85995bc3e1fc3c1f01b4d9bded3707ea0b296fa9
2013-08-17Mark as constTakeshi Abe
Change-Id: I95844f01d3f7ed6e22b8d78b7a2366b131bd325b
2013-08-17WaE: C4305: 'argument' : truncation from 'int' to 'const bool'Tor Lillqvist
Change-Id: I92729c7272e87c2aede6cd5134c84d17b466e57f
2013-08-16import .xlsx files saved by Calc before fdo#59727 was patchedWinfried Donkers
Change-Id: Id1eedc86056f7de24913f8156a819f8a0695fd59
2013-08-16fdo#37230 Add legacy cell selection behavior and config. optionTomaž Vajngerl
When selecting cells with ctrl+shift, the legacy behaviour was to take in account to which cell the cursor moved. This allowed the user to make some convenient selections. This behaviour can now be turned on with a switch in the configuration (Tools > Options > Calc > General > Input Settings > "Use legacy cursor movement behavior when selecting"). Change-Id: I00ae7b4ee001b416cc680c7a650631daec71e51b
2013-08-16pass gb_DEBUG_CFLAGS for the remaining NOOPT filesMichael Stahl
Change-Id: I5d5f65766d4ad3b319b2cbe4f6491d0aab7f02df
2013-08-16cppcheck: memory leak + test rResult before freeing itJulien Nabet
Change-Id: Ia2cd69eb0a180cdfb747a82edefbe1527138b26d Reviewed-on: https://gerrit.libreoffice.org/5444 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-16fix for bnc#834705 missing drop downs for autofilterNoel Power
After commit fc861c7088e9b639a1c2c80f8ba4535c798aeb34 there is now an order dependency, between any ScPatternAttr flags indirectly set and SheetDataBuffer::finalizeImport which sets the attributes directly for a column So the ATTR_MERGE_FLAG that has ScMergeFlagAttr ( and associated SC_MF_AUTO flag ) is scrubbed when by the direct writting of the attribute from SheetDataBuffer::finalizeImport -> Document::SetAttrEntries I've reordered that Table import here and split the finalize ( which happens before heetDataBuffer::finalizeImport ) so that the databaseranges which were created before sheet import still happens, the autofilter part of the import is now deferred ( until after SheetDataBuffer::finalizeImport ) Change-Id: I11bb45ee7b330760fd93ecca30b23399414ac3a7
2013-08-15Make this a separate function.Kohei Yoshida
This code block happens to be a performance hot spot right now. Change-Id: I4fa2c4ea27cb6ae4c4331d0bb474eddc167b69fa
2013-08-15corrected description strings of 'criteria'Eike Rathke
Criteria in SUMIF, AVERAGEIF, COUNTIF, SUMIFS, AVERAGEIFS, COUNTIFS are not cell ranges. Change-Id: Iace25057ab3c9af1e2ec3c45c6803d42272f962b
2013-08-15get rid of tabs from mergeEike Rathke
Change-Id: I39e41abc17979f6b84b787d1078de05475ea8a62
2013-08-15Mark as constTakeshi Abe
Change-Id: Ic7ee570935b5d827dc01a483877ea5021da5abea
2013-08-15convert GetName/Title/Description methods to OUStringIvan Timofeev
Change-Id: Id16a2b29b1d6cf02b94cc6c423e2475a9cbeb8a3
2013-08-15convert include/svtools/imap*.hxx from String to OUStringNoel Grandin
Change-Id: Iacfb93a4cf9a7b7ac0ae27b9fa6f765e74604dc2
2013-08-15convert include/svtools/insdlg.hxx from String to OUStringNoel Grandin
Change-Id: I72c5e3e47040e78976f46f585b50ab6c12f84986
2013-08-15convert include/svtools/parhtml.hxx from String to OUStringNoel Grandin
Change-Id: I20adfc9148b8afa7a59245349f233604bd9a1d2e
2013-08-15convert include/svtools/transfer.hxx from String to OUStringNoel Grandin
Change-Id: Ie80c29a73db295ccc8fe975f8fe7027b9a1eb79a
2013-08-14Avoid wholesale rebuilding of formula groups at re-calc time.Kohei Yoshida
And do it once when importing xls, xlsx, and ods documents. Although xls(x) file formats support shared formula natively, it's still beneficial to re-group it as some old xls documents limit the length of shared formula span to only 64, or some don't use shared formulas at all even though they could. And re-grouping just once is not terribly expensive. Change-Id: Iff9c605d19baa187553ddab6af8b9fbd4c366d7d
2013-08-15resolved fdo#67571 write flags and formula token array againEike Rathke
Regression introduced with 337066eb1fa395990b78d1032c399a4688d2a6f9, flags and formula token array weren't written if the formula result was an error value. Change-Id: I8ccd55a7b43d5ceb79002e01f0b3d33d36d85538
2013-08-14import/export WEBSERVICE and FILTERXML from/to .xls BIFFEike Rathke
Change-Id: I8bf6cf93a2f9b5daee77f3dd75b0366caa9ec25d
2013-08-14import/export WEBSERVICE and FILTERXML from/to .xlsxEike Rathke
Change-Id: I2ea9797156df306b25b25ef42ed865483e08b6af
2013-08-14Do the same when inserting columns.Kohei Yoshida
Change-Id: I387ef3c2c8345bb5be75909596f59af80b966443
2013-08-14Revert "Revert "Always disable anti-aliasing for drawing cell borders." ↵Kohei Yoshida
fdo#60805" This reverts commit 46d122d4cc405c4070eb4945abd20cdf3a5fac33. Unfortunately this re-introduces the previous problem of the cell borders drawn too thick when anti-aliasing is enabled. Also, even with this reverted the problem will still persist if the user manually disables anti-aliasing in the Options dialog. So, we *do* need to find a way to draw the double-borders etc correctly without anti-aliasing.
2013-08-14convert Read/WriteUserData methods to OUString and boolIvan Timofeev
Change-Id: I06a8158b7f503976b19383014a7c8a867c0184ea
2013-08-14Revert "Always disable anti-aliasing for drawing cell borders." fdo#60805Noel Power
Unfortunately this patch creates a very weird ( and took me forever to find ) bug ( fdo#60805 ). Basically certain double line borders seems to dissappear at certain zoom levels. I guess maybe its possible to tweak the create2DDecomposition to process the line as hairline at those problematic zoom levels ( but I suspect that actually would look worse ) Best maybe would be to tweak the rendering/painting ( but isn't that processor specific maybe ? ) as is maybe this problem. I admit this is outside my comfort zone :/ This reverts commit a551cad4e35b6b664167d65dfc25e5a0f6990687. Change-Id: Idb25493ffb038cb1f8ae9b364a29052abafd940d
2013-08-14fdo#59727 fix #NAME?-error with add-in functions on (re)open of xlsxWinfried
Change-Id: Ia3c452f21328e2d5773f245e729905a70d14c29e Reviewed-on: https://gerrit.libreoffice.org/5312 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-14Resolves: #i122149# Corrected stuff around polygon-based clip regionsArmin Le Grand
do not use them where not needed (cherry picked from commit 4ccb1eb7d58005ab3b501b7c6ff128fadbcd5066) Conflicts: basegfx/inc/basegfx/matrix/b2dhommatrixtools.hxx basegfx/inc/basegfx/polygon/b2dpolygontools.hxx basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx basegfx/inc/basegfx/tuple/b2dtuple.hxx basegfx/inc/basegfx/tuple/b3dtuple.hxx sc/source/ui/inc/output.hxx sc/source/ui/view/gridwin.cxx sc/source/ui/view/output.cxx vcl/win/source/gdi/salgdi.cxx Change-Id: Ie265814a51180bffe3c821a3f2148cb3bb54ecad
2013-08-14convert GetSelectionText... methods to OUString and boolIvan Timofeev
Change-Id: I77726f009338ae49877c5f58fe6c14d386089bbe
2013-08-14XubString->OUStringCaolán McNamara
Change-Id: I178f9eb702afb6143c583d5fd54003a427d895fa
2013-08-13Do the same when deleting rows.Kohei Yoshida
Change-Id: Ib1deab33a8771e196d0520bae872eb0d492c913e
2013-08-13Regroup formula cells later in columns where references are updated.Kohei Yoshida
Change-Id: I4dd6ade18e72d8f57583180463f9dda3603be4c2
2013-08-13Try to re-group without ungrouping all cells.Kohei Yoshida
Change-Id: I8e5c4e240e64a1d70e599c4a8791133dddc0b75b
2013-08-13Add test for reference update on shared formulas.Kohei Yoshida
This currently (rightfully) fails. Change-Id: I254dc7042e93b257765c8ed8cdb9904966afd77e
2013-08-13Ensure iterators are value-initializedStephan Bergmann
...instead of merely default-initialized, to avoid undefined behavior in enclosing classes' copy ctors/assignment ops. (Cf. resolution of <http://www.open-std.org/JTC1/SC22/WG21/docs/lwg-closed.html#408> DR 408 "Is vector<reverse_iterator<char*> > forbidden?") In return, remove the enclosing classes' user defined assignment ops that do explicitly exactly what the default ones would do anyway. Change-Id: If1bb1aea56dd48da873a92a8fa30dedea844740c
2013-08-13Unused memeberStephan Bergmann
Change-Id: Iaa3ab3d73270f0a1441eb64854f47088967ca0d5
2013-08-12Compile token array only once per formula group.Kohei Yoshida
Change-Id: I70694ee8834b1b2f2ebdfaa90582ccfb19db0210
2013-08-12Return something.Kohei Yoshida
Change-Id: I46ff752f62d2f3fc988bbacc58097ee36e87182f
2013-08-12This is clearly a bug. Let's fix it.Kohei Yoshida
Change-Id: I83aa2c108e7d8561d28d76b69a8763a15a20a2bd
2013-08-12Ungroup a cell when the group length becomes 1.Kohei Yoshida
Change-Id: Ic656d4837ab1fc5feb4b19765ae427371dfdfe10
2013-08-12Fix indentation.Kohei Yoshida
Change-Id: I2caebb42d92bf81e3ba8809a47f833a9379e769d
2013-08-12We still need to update cell positions for non-top cells.Kohei Yoshida
Change-Id: If967247ed5d916535e7b52af14b00090b7c9d0d2
2013-08-12Do the splitting of formula groups.Kohei Yoshida
Change-Id: I5a8661895b558b67abc19cdc39de9eb027bc1c34
2013-08-12Collect all boundaries at which to split the formula group.Kohei Yoshida
Change-Id: Ic78d7a06991b983e625b161f11fbbabce02334f3
2013-08-12If the formula cell is grouped, update reference only on the top cell.Kohei Yoshida
Change-Id: I5e2e9db621a61deba39a46962e0ca877235d7c90
2013-08-12Export shared formulas to xls, from the new shared formula in the core.Kohei Yoshida
Turns out we don't export shared formulas to xlsx, so no work is needed there. Change-Id: I85604f3b80c95c5b6179bbdac41e758c5de7854a
2013-08-12Fix the (Windows) build. No idea how this was buildable on Linux.Kohei Yoshida
Change-Id: I9c0701b1b8f30c36f45bbee0d95e92a59f9891fe
2013-08-12Detect self-referencing groups, and disable group-calculation.Kohei Yoshida
And re-enable group-calculation on named ranges. Change-Id: I4957ff05bac23bd266bbc96fe5619ad5f0a65688
2013-08-12Fix import of negative relative row reference from xls.Kohei Yoshida
Change-Id: Ibaa325396a8a06c45cf59af9809ed5cbff6d10d0
2013-08-12Disable vectorization on named ranges for now.Kohei Yoshida
Change-Id: Ibc10d5eb9afff6062106c952aa2e7d3f9cb58100