summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-11-08Ensure that the string array is null when no strings present.Kohei Yoshida
It was intended this way from day one, but the implementation didn't live up to that promise... Change-Id: I231ddc8923fdd8a205127c6a3214dd93f13378b9 Reviewed-on: https://gerrit.libreoffice.org/30678 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-08try and auto-silence coverity#1394273 Use after freeCaolán McNamara
and coverity#1394272 Use after free Change-Id: Id2340bccc6fbaeb917cb397890875bd0849ffe85
2016-11-08loplugin:unnecessaryvirtual in sc..scaddinsNoel Grandin
Change-Id: I4a2d333984827f363ea76580993438d704f9738f Reviewed-on: https://gerrit.libreoffice.org/30660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08Resolves: tdf#103701 bulk-broadcast the correct hint ID for formula groupsEike Rathke
BulkBroadcastGroupAreas() and BulkDataHint and thus FormulaGroupAreaListener::Notify() omitted to transport the actual hint and assumed SC_HINT_DATACHANGED, but SC_HINT_TABLEOPDIRTY needs to be handled as well. Change-Id: I765f7c95f7aeab295f35dcf6949a3b1926cbe248
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07officecfg: add .uno:SignPDF labelMiklos Vajna
And replace the existing .uno:Signature in the File menus with a submenu that contains .uno:Signature and the new .uno:SignPDF. Change-Id: I801b9332c697985446c64dd208c25dea2494350e
2016-11-07Fix typos (also in the code)Andrea Gelmini
Change-Id: I45d45513b102f4fdcb55e8de20b95b37f66ea463 Reviewed-on: https://gerrit.libreoffice.org/30658 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-11-07tdf#92160 - sc: limit search results to 1000 entries.Michael Meeks
Very large replace results give huge space consumption in the display widget, and are of dubious usefulness. Change-Id: Ib8ad01a673ea52976befaf958f8f695aca2190ae Reviewed-on: https://gerrit.libreoffice.org/30574 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-07wrap some more dialog pointers in VclPtrNoel Grandin
and fix a couple of memory leaks in the process, some of them were not being deleted at all Change-Id: Icb5c948662ad3ba878eadfbc807f93cc35cfb228 Reviewed-on: https://gerrit.libreoffice.org/30651 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07inherit from ScXMLImportContextNoel Grandin
and drop a bunch of redundant code Change-Id: I187273ad9eebeaf2446e09b2e3442e963d8ae4f4 Reviewed-on: https://gerrit.libreoffice.org/30568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:expandablemethods in scNoel Grandin
Change-Id: Ib417c5e978fca563f8c0ef0dbe6b9d50fead9828 Reviewed-on: https://gerrit.libreoffice.org/30566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Avoid crash when calling a Worksheet's ShowDataForm()Takeshi Abe
in VBA, e.g.: Option VBASupport 1 Sub Main Worksheets(1).ShowDataForm() End Sub Change-Id: Ice6cfccc4fc15a4d0044d6464c7d6c04243e86ae Reviewed-on: https://gerrit.libreoffice.org/30619 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-05add LENB test caseZdeněk Crhonek
Change-Id: I337345dc18cffb1be663cbeab27c2d78a7c47e6c Reviewed-on: https://gerrit.libreoffice.org/30468 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-05add MID and MIDB test caseZdeněk Crhonek
Change-Id: Idcfe8de78d939703bd8c20cc5a80a0cb4e8baa90 Reviewed-on: https://gerrit.libreoffice.org/30471 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-05add LOWER test caseZdeněk Crhonek
Change-Id: I2d220c6754059fb22a7bcdf2a34020b50984abec Reviewed-on: https://gerrit.libreoffice.org/30469 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-05add NUMBERVALUE test caseZdeněk Crhonek
Change-Id: Ib947cd86794584e04cff043f38a184490bb01683 Reviewed-on: https://gerrit.libreoffice.org/30540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-05add PROPER test caseZdeněk Crhonek
Change-Id: If05a1bee832f0c65156a27c7596bb1160073a3de Reviewed-on: https://gerrit.libreoffice.org/30542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-05Pass the current cell position to conditionally display sheet name.Kohei Yoshida
Change-Id: I28dba90500af7c11db569fded28ce571a1ec9089
2016-11-05Log cell range references.Kohei Yoshida
Change-Id: Id6402a35ced37aff7215a46d23b4103a64bf669b
2016-11-05Log single cell references.Kohei Yoshida
Change-Id: If711c44a3be7ae02d1354bb36ed7db6b5a86ef6b
2016-11-05Dump the single cell vector reference info to the log.Kohei Yoshida
Change-Id: If0ee6dca6642063501c728bec3b4e5d7b6401442
2016-11-05Output the header information to the formula log.Kohei Yoshida
The header information for now contains relevant formula calculation configuration settings. Change-Id: Ia6f8b84a3a6fa448708b9a78957002481c3a1c67
2016-11-05[loplugin:simplifybool]Julien Nabet
Change-Id: I20177b47fd756558430420710c0f497be49c8948 Reviewed-on: https://gerrit.libreoffice.org/30584 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-04unify color selectorsCaolán McNamara
Note: this removes the use of auto-color from writer's asian text grid, because its always invisible as far as I can see in practice. Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-04bail out early in ScColumn::UpdateSelectionFunction() if nothing is markedEike Rathke
... which happens if there are multi-marks in non-adjacent columns. Change-Id: Ic8cf0fb0071f793fa91c506a56b01f2833fe5cec
2016-11-04add test case for rhbz#1390776David Tardon
Disabled, because the file fails to load for some reason... Change-Id: Ida79b9de4ff53d76fed86e0495f9479addc228f8
2016-11-04unit test for tdf#103684, calculate status bar function across sheetsEike Rathke
Change-Id: I8205cf56628b6b4d4b5d655386df994a9c02a1ad
2016-11-04use ScMarkData::GetMarkedRangesForTab(nTab) in SingleColumnSpanSet::scan()Eike Rathke
That always worked only by chance only on the first selected sheet, luckily with ScMarkData it seems to be used only in ScColumn::GetOptimalColWidth() which usually operates on the visible sheet. So now setting optimal column width actually works on all selected sheets for the selected columns. Change-Id: I5944b943824a67d77b549b6cdfc0b2550b8d77b8
2016-11-04tdf#91260 - ReplaceAll should use a columnar direction.Michael Meeks
MDDS is columnular, so this shrinks the working set very significantly, and should improve performance. Change-Id: I2aff92b31bfc459e85291059d977541aa65155cf Reviewed-on: https://gerrit.libreoffice.org/30562 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-04sc-perf: eliminate unnecessary loops in ScTable::UpdateSelectionFunction()Eike Rathke
That looped unconditionally over all columns of a sheet just to let ScColumn::UpdateSelectionFunction() costly (by creating empty spans) decide that it doesn't have to do anything. This for *every* cell cursor movement or switching sheets et al. Instead, use the ScMarkData area to narrow down the range beforehand, which when travelling with the cell cursor is just one column. Change-Id: Ic60928d07bc6cec4f6d8491ab30b99d7b20b8490
2016-11-04loplugin:defaultparamsJulien Nabet
Change-Id: I3436df5ebfe0ef4bca6d44ba426f26911482bbcb Reviewed-on: https://gerrit.libreoffice.org/30557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-04tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I619cb50c3475519921ffd318b32875ae4ff2c0b8 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03Resolves: tdf#103684 calculate status bar functions across sheetsEike Rathke
Also trigger recalculation when additional sheets are selected or deselected. Change-Id: I259396a3e30c5653ac252b7bb2eb6a0a9405d6cc
2016-11-03tdf#88821: Implement support for <meta charset="..."> for HTML import.Jan Holesovsky
The editengine HTML import was not handling it at all, and consequently not setting the right encoding when importing HTML in Calc. Change-Id: I3ca3dd20f36cfb579fb7ae4cd3da63a69d97601e
2016-11-03tdf#88821: Set the encoding correctly for HTML files with a BOM.Jan Holesovsky
BOM (Byte Order Mark) in the HTML file changed the underlying eSrcEnc encoding, but did not actually update the rtl_TextToUnicodeConverter hConv. Subsequent changes of eSrcEnc in SetSrcEncoding() (triggered by 'content="application/xhtml+xml; charset=UTF-8"' in the HTML file) were then ignored (eSrcEnc was already set to UTF-8), and the parser was happily using the old (Windows-1250) hConv. Change-Id: If432d59891d51c6abe3517e325ed73057d0f8610
2016-11-03loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I572b83949c7e643536b7d62567760546509e4d9f Reviewed-on: https://gerrit.libreoffice.org/30514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#103633 avoid segfault in a11yDavid Tardon
This partially reverts commit 8e8a88ec1ad02c153ae3c7653edc81716dc91b7a "loplugin:unusedfields". Change-Id: Id95a46374ed2b35e05dc32a8759e5db01829f050
2016-11-03remove unused BiffInputStreamNoel Grandin
Change-Id: If34bc1d5ea0e0153991d4891b88550e471b4ec07 Reviewed-on: https://gerrit.libreoffice.org/30489 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03merge ScBiffReader and ScQProReaderNoel Grandin
Change-Id: I7267ffb4ad5c874d6c836a8d6ab823d63f8e2610 Reviewed-on: https://gerrit.libreoffice.org/30488 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02unit test for tdf#99291, empty array elements match 0.0, not emptyEike Rathke
Change-Id: I65cac442583ecd90831ebea01d2be6c0b1e60b9a
2016-11-02loplugin:singlevalfieldsNoel Grandin
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76 Reviewed-on: https://gerrit.libreoffice.org/30476 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01loplugin:oncevar in sal..scriptingNoel Grandin
Change-Id: Id9ab12f3a61eb83a2288b2fd4d99ab77f5833e1b Reviewed-on: https://gerrit.libreoffice.org/30461 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01cppcheck unreadVariable: nModifiedJochen Nitschke
unused since initial commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24 Change-Id: I2828af1fbfda993dff32abf0f9a9f73e9fb61028 Reviewed-on: https://gerrit.libreoffice.org/30455 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01Omit the default comparator for std::sort()Takeshi Abe
Change-Id: Ib865bdf911b53d809fc2979f524da3735bb39ce5 Reviewed-on: https://gerrit.libreoffice.org/30432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-31Resolves: tdf#99291 empty array element should not match empty cellEike Rathke
As weird as it is, but an empty cell is only to be matched by an empty string, not another empty cell. Affects spreadsheet functions SUMIF, AVERAGEIF, COUNTIF, SUMIFS, AVERAGEIFS and COUNTIFS. Change-Id: Ib33402e8c93f26cd8e2648426a5bde6b267c55ab
2016-10-31Resolves: tdf#64001 exclude "boolean" value cells from increment during FillEike Rathke
Change-Id: Id79438cc37a63c0619c6b96ecf57b10d781afea3
2016-10-31don't loop uint16 against sizeEike Rathke
Theoretically selecting over 64k rows with a series sequence and calling Fill could had looped endless. Change-Id: I1740b674638eb90d51808e619c562cf8064f4888
2016-10-31Nonsensical OUString null checkStephan Bergmann
...ever since 523e10ac08b35b6b63e9ac0ffefac7c013e4ee89 "INTEGRATION: CWS scriptingf4: #i28384# - implement Macro Selector specification". (That happened to redundantly check for non-empty aScriptURL, too.) Change-Id: I3fae859af4b0cc5d2b5f8a609c74b00b120694f3
generated by cgit (git 2.34.1) at 2025-01-29 16:45:59 +0000