summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2022-02-28uitest: remove duplicated testsXisco Fauli
They are pretty much the same as the other one in the same file Besides, the 'with self.assertRaises(IndexOutOfBoundsException)' nonsense Change-Id: I0ad9aaf80721eb49080d94a34deb43b0bc39724c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130718 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-28tdf#122471 xlsx import: pivottable error OUString, not uInt8Justin Luth
This fixes a LO 6.0 regression from commit 9fa34e9f2cebe2cfc551668f2a67ddcb799d3fb8 which only half-way changed to OUString from uInt8. An exception was raised because in XLSX, an INT was written while the corresponding read function was expecting an OUString. However, doing this runs into problems with binary files (xlsb), which were still setting the value to an int. Unit test shows the need to use OUString for xlsb too, which now matches what I see in Excel 2003. make CppunitTest_sc_pivottable_filters_test \ CPPUNIT_TEST_NAME=testPivotTableErrorItem2FilterXLSX Change-Id: I399c9e34984bb1ff71695a87aa56f53063d37b3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130714 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-28tdf#147667 - Remove hard-coded underscore from UIHeiko Tietze
Duplicate underscores make the hotkey unusable. While the path removes it from the UI it's neccessary to also clean-up the translations. Change-Id: Id8a216c7c928eccebabbac79744cb802c07ae3f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130688 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-28ensure null terminatorCaolán McNamara
LIBREOFFICE-WB8DT2Q9 Change-Id: I98529325bbd3ff475ba84b4991eb17240440df4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28tdf#45904 Move XElementAccess Java test to C++Jens Carl
Move XElementAccess Java test to C++ for ScHeaderFieldsObj. Change-Id: I1bc29be9f17d117edecfd889b4f9784ffbd74d71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130660 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2022-02-27use more SfxItemSet::CloneAsValueNoel Grandin
to reduce heap allocations Change-Id: Ia755c3e7f9610a5441a447cc74ea38ebcef068bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130066 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-27Revert "Related: tdf#147448 Scope owning mutex before it gets destroyed"Eike Rathke
This reverts commit dcd042c6f28276d707af409a87a1a4380398e9b0. Reason for revert: Revisiting, it was wrong to put that protector in its own scope because the actual mutex lock is only held in its ctor and it does SetAllowRefresh(true) in dtor, so while it exists it prevents other refresh timers to execute. Change-Id: I058c1359c19971dba59a9273a7a8cddd77ece37f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130556 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7aae1d338aaf454b99c7354aca78951e26043b2b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130566 Reviewed-by: Eike Rathke <erack@redhat.com>
2022-02-27fix inverted conditionLuboš Luňák
Logic says that 'contains' should be '!empty()'. And checking history shows that 94d76cef1f71056fab106caf4cc8e65504475615 inverted the condition presumably by mistake. Change-Id: I6c0ddc6486a5fb89eb39b93e32ee52d478c05927 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130543 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-27prefix CellInfo and BasicCellInfo with ScLuboš Luňák
CellInfo is a pretty generic term to be used in the global namespace. Change-Id: I9a2ce6b7b2157f75d7213321c615fc9636817252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130608 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-27do not allocate so many CellInfo objects in FillInfo()Luboš Luňák
FillInfo() is used for drawing to screen, so it's given a range of rows and columns, but drawing also depends on all cells to the left (e.g. their width, for position), so it allocated CellInfo for all columns starting from 0. But with many columns this can easily mean allocating and initializing a large amount of memory, easily 90MiB with a maximized window and going to XFD1, and handling all that can be slow enough to be seen when moving around. Since only few of the CellInfo fields are actually needed for all columns, split them into a separate smaller BasicCellInfo, and allocate CellInfo only for columns that need it. And exception is the nRotMaxCol code (for rotated cells?), which accesses more of the fields, so for that case allocate the same way as before. Change-Id: I2f0f2a9c27b1a8b74b70fc2d208d0689e16ee1a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130607 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-26do not repeatedly call ColHidden()Luboš Luňák
The function returns the last column that has the same return value, so reuse the return value until that column. Change-Id: I5d19478ee37068049d4ff035efcacdb5eb724e15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130606 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-26cid#1500566 Uninitialized scalar fieldCaolán McNamara
Change-Id: Idd0e3d461f84a5ec476d77fde9c8ab03b4dbbbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-26cid#1500706 Uninitialized scalar fieldCaolán McNamara
Change-Id: I2546ea6880ad1cdb4312ca1c1251dbf6758ff5ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-26cid#1500582 Uninitialized scalar variableCaolán McNamara
Change-Id: Idec4ce43f99be60658a6e60cff73dd6702bb3d91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-26optimize ScColumns::HasCellNotes()Luboš Luňák
This probably doesn't matter much for optimized code, but in dbgutil builds this avoids all the libstdc++ iterators mutex locking (WTH does libstdc++ debug mode need to lock anything?). It's functionally equivalent (similarly to ScColumn::IsEmptyData(), and the container can contain only notes or empty elements), and cuts run time of e.g. sc_uicalc test to about a half. Change-Id: Ibb2bd8be522de889a8a06cbb7a4f880c9b065c71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130604 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-26ScCompressedArray doesn't need to be polymorphicLuboš Luňák
It's value-based, and only inherited by ScBitMaskCompressedArray, which is also value-based and doesn't need a virtual destructor. Change-Id: I0814702107d50208aaff19690c989a501d2c4e3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130605 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-26do not fail import if there are only warningsLuboš Luňák
When opening CVE-2012-4233-4.xls or ofz5527-1.xls in LO UI, they show a warning about too many columns (presumably because Excel as of now supports 16k and LO only 1k columns by default), but besides stripping the extra columns they otherwise actually load normally. But ScFiltersTest::testCVEs() fails loading them just because of the warning. And if 16k columns are forced for the tests, the files unexpectedly load fine, making the test fail. ScDocShell::ConvertFrom() is rather inconsistent on whether only a warning results in a failed load or not, but most seem not to return failure on only warnings, and I think that makes sense, so make code paths for all formats consistently handle it that way. Change-Id: I202f29f5a5a44aecd34b84cf2f8180222e8d870a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130500 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-26make VBAMacroTest::testVba() pass with huge sheetsLuboš Luňák
One test checked for the last cell being $IV$8 or $AMJ$8. Simply add $XFD$8 to the list of possible values. Change-Id: I96685c4404b3281d64622380e7d42614adb1c041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130570 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-26lock paint when VBA sets value for a number of Calc cellsLuboš Luňák
VBAMacroTest::testVba() spends the majority of time repeatedly repainting. Change-Id: Iea69221834b80b0fbe484ee3ec5f64ba9e28e37d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130569 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-26Related: tdf#147448 Scope owning mutex before it gets destroyedEike Rathke
Change-Id: I9bacffe1d075431427fb3bf01e4bf30ba6fbc201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130574 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-02-26Resolves: tdf#147448 ScRefreshTimerControl mutex must be std::recursive_mutexEike Rathke
ScRefreshTimer::Invoke() locks the mutex and subsequent nested locks are attempted in ScDocShell::ConvertFrom() and ScDocShellModificator ctor by ScRefreshTimerProtector. A std::mutex must not be owned by the calling thread when a lock is attempted, otherwise even deadlocks may occur, as was the case here. This is exactly the difference of std::recursive_mutex. Likely a regression from commit 287680683ca266f1fb4f447ac9bdaf76669d559d CommitDate: Mon Aug 2 12:17:07 2021 +0200 osl::Mutex->std::mutex in ScRefreshTimer Change-Id: Iaa0f1da2b4b9616e9627d8d0001775f554756048 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130573 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-02-26tdf#147298: Add a simple test case for formula cell tracking by column.Kohei Yoshida
Change-Id: Ibdd72c08f8660ade511fdce8b3fb7cd3ed97f4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130511 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2022-02-25convert more MAXCOLCOUNT/MAXROWCOUNTLuboš Luňák
And add GetMax{Col|Row}Count() directly to ScDocument, and also add MAX{COL|ROW}COUNT_JUMBO. Change-Id: Ib92cfbf65dd7cbe87230b02b8916e7cc50fcdbc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130529 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-25tdf#147404 sc AutoFillPreview: consider hidden cellsJustin Luth
Back in the days before LO 3.6, only filtered cells were skipped by autoFill. But when hidden cells were also skipped, the preview function wasn't updated to look for hidden cells instead of filtered cells. (I said "instead" because filtered cells are also considered to be hidden, so it encompasses both cases.) Change-Id: I38b230361f0f0f1722873bbdd2c870d55b77bd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129912 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-25tdf#147298: When swapping the cell stores, swap back the event handlers.Kohei Yoshida
Swapping the cell stores also swap the event handlers stored therein. But we do want the event handlers to stay with the original column instances as they store pointers to their host column instances. Change-Id: Id35b89db641e94dbaa341b33d0b64dce19a99465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130510 Reviewed-by: Kohei Yoshida <kohei@libreoffice.org> Tested-by: Kohei Yoshida <kohei@libreoffice.org>
2022-02-25uitest: introduce wait_until_file_is_availableXisco Fauli
For export - import tests See https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91 Change-Id: I3c2537a43cc69067355f18162d6463e268420090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130530 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-25tdf#81894 sc spelling: re-close EditView if not spelling errorJustin Luth
In order to check if there is a spelling error, the code had to open an EditView. If there was no spelling error at the mouse pointer, then stop edit mode again before showing the context menu so the full popup is shown, not just the edit one. 1.) Open LOv4304.ods from bug 81894 comment 6. 2.) right click on "The" in B3 Since we haven't been in edit mode, it should show the full format popup. Before this patch series, that is what happened, so this follow-up patch is critical to preventing a regression. This patch makes use of a variable created in earlier patches to fix other issues related to right-click spelling. Change-Id: Ia9713e9654c1f74bc926d51fe8bc5180a8265c79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130300 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-02-25tdf#81894 sc spelling: close EditView when moving outside cellJustin Luth
In a previous patch, we noted that instead of a spelling suggestion, a popup was displayed. This patch handles that unfinished business. 1.) Open LOv4304.ods from bug 81894 comment 6. 2.) double-click on cell B4 (to enter edit mode) 3.) right click on "spellng" which appears to be in D4 Before any of the patches, this did nothing. After the first base patch, it was showing the format popup. Now it offers a spelling suggestion. [By running EnterHandler, we are accepting any changes made so far in editing mode. That is consistent with what happens if a left-click selects a different cell.] Change-Id: I23876a26861b695dc46efa42f6c3fed6fdb8da6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130299 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-02-25tdf#81894 sc spelling: choose correct cell when in edit modeJustin Luth
In edit mode, text that is too large to fit inside the cell will expand to cover other columns (or rows if cell wraps). GetPosFromPixel doesn't account for this, so it needs to be done separately. (SHOULD the function itself take this into account? Probably, but it is used a LOT, so I'm afraid to mess with it.) This patch fixes two situations in bug 81894 comment 25's example. 1.) Open Francewhoa---2017-May-29---speadsheet.ods 2.) Double click on A1 to enter edit mode. Notice that the cell expands to cover A1:A3. 3.) Right click on "productivityy". Before the patch, the spell check was inspecting empty cell A2, and thus showed the edit popup. With the patch, the spell check is using cell A1, and thus provides spelling suggestions, as expected. [This patch depends on this bug report's prior comit.] 4.) Look at B3 and notice misspelled words spilling over from A3. Double click on B3 to enter edit mode. 5.) Right click on the position where the misspelled word had been. Before the patch, a spelling suggestion was provided, even though we right-clicked on an empty place in a different col. After the patch, we get the normal edit popup. Change-Id: I58fbf60711a5c010263b525a96383a805be1b3ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130298 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-02-25tdf#81894 sc spelling: eliminate separate(inaccurate) checkJustin Luth
ExecuteSpellPopup is quite accurate at identifying whether the spelling at PosPixel is a spelling error or not. If it is not a misspelled word, then it just silently returns. If we make this a bDone flag, then it will just move on to the normal right-click dialog. There are a few additional scenarios that need to be handled (mainly in terms of showing the edit-mode menu instead of the full format menu, and also not always returning the correct row/col when in edit mode). I will do them in separate patches so that each edge case can be clearly seen and handled. They all rely on this patch being applied first. This is the base patch. Too many things simply don't work with the interim check, so I removed it. (Part of the problem is that EditView kicks on and off, and then a new CompleteOnlineSpelling needs to be run before IsWrongSpelledWordAtPos can return a meaningful answer.) This patch specifically fixes the problem of not opening SpellPopup on a misspelled word in a wrapped-cell. Steps to reproduce: 1.) Open LOv4304.ods from bug 81894 comment 6. 2.) Right-click on "spellng" in cell B12. Before the patch, a full format popup was displayed (not in edit mode) because IsSpellErrorAtPos returned false, when it should have been true. With this patch, spelling suggestions are provided. As an example of an edge case, also notice: 3.) double-click on cell B4 (to enter edit mode) 4.) right click on "spellng" which appears to be in D4 Before the patch, nothing happened at all, but with the patch at least the fall-back menu is displayed. (EditView never switches out of cell B, so SpellPopup is looking at wrong information.) Change-Id: I91d413debc58de832dc7413034618e9e2bae3dd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130297 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-02-25don't try to delete unallocated columnsLuboš Luňák
Change-Id: I1508f9eb624a78946f5216078953ce8f95e566b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130522 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-25uitest: remove debug optionXisco Fauli
it does nothing Change-Id: I6fa67aa42b1de6199cbb49100624826f5b3b77d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130524 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-25fix copy&paste mistakeLuboš Luňák
Introduced in bc734289e5542a0ffa04c0ac3cd1aa7cb1810be0. Change-Id: I5b844e579d6ebfb7be5edaa15944a6df1af66394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130517 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-24uitest: check the value and not the textXisco Fauli
This fails for me with AssertionError: '90%' != '90\xa0%' - 90% + 90 % Change-Id: Ieec52a4aff721705451a0545eb606c97235b1248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130507 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-24use more TypedWhichIdNoel Grandin
Change-Id: I6ab3ca829bc08e672736dd8dd41ba714d7172090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-24followup tdf#122098 xlsx export: avoid dataloss if not bool valueJustin Luth
Change-Id: I54b2f44a1ab0b7681667e811be72d1504928fab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130469 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-23tdf#147611: fix indicesMike Kaganski
The maKeyState vector in ScSortParam is initialized with three elements, and they are never removed. The code in ScVbaRange::Sort incorrectly used 1-based indices into that vector. This was broken since commit a02b445c39d969fedc554fc2c500b88a27a13906 Author: Albert Thuswaldner <albert.thuswaldner@gmail.com> Date: Tue Mar 20 19:38:29 2012 +0100 fdo#45747 remove the limitation to 3 sort entries in calc part1 It was fixed in commit 568d3912bf8ced76ecb9506bccc3bd361daba082 Author: Kohei Yoshida <kohei.yoshida@gmail.com> Date: Wed Apr 04 15:30:35 2012 -0400 Cleanup. ScPivot(Collection) is no more. but was restored by commit 3e887edcaacc5b0f5e35d682a259124648e84229 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Thu Apr 5 05:05:40 2012 +0200 Revert "Cleanup. ScPivot(Collection) is no more." Change-Id: I009252e794c9365f0aef8a61daf9cbd40eca8b75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130441 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-23tdf#147458: sc_jumbosheets: Add unittestXisco Fauli
For some reason, the test fails on windows with Test name: ScJumboSheetsTest::testTdf134553 equality assertion failed - Expected: 1058 - Actual : -7421 However, the issue is not reproducible manually. If the test is executed with aDefaultsOption.SetInitJumboSheets(true); then it doesn't fail Change-Id: I5314c326d3937eaf5e96e4d25d71a7f1347c11af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130365 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-23tdf#122098 xlsx im/export: let formulas guess their number formatJustin Luth
This fixes the import side of a LO 4.2 regression from commit 07b66cd3ac1a9f6c7b61a1d7da6e9d266e6de92d and the export side of a LO 4.3 regression from commit 69ecdad805281b2cb6ec2437da18daa19576deae make CppunitTest_sc_pivottable_filters_test \ CPPUNIT_TEST_NAME=testPivotTableBoolFieldFilterXLSX Change-Id: I4c680dbff844cf1eca52de641856daafa032eeb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130406 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-23handle hardcoded MAXCOL/MAXROW in ScInterpreterLuboš Luňák
The change from <= to < is intentional to compensate for the change from MAXCOLCOUNT to MAXCOL (there's no MAXCOLCOUNT_JUMBO and I don't want to add it). Change-Id: I223b2fd3b1a9e22e82f6a31d16d44c98ae43876d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130436 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-23remove MAXCOL/MAXROW from ScViewDataLuboš Luňák
Change-Id: I12461bac8dd127075ee9071e1015561f7a029624 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130435 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-23SdrLayerID must be based on sal_Int16Mike Kaganski
... which is the type corresponding to the related published property "LayerID" of com.sun.star.drawing.Shape service. Without this, the code asserts on values passed to the published API from external sources to be in the 8-bit limits, which is incorrect. Change-Id: I0449a7dd313f7e6c4adbc1c1f7b8c50b6a51434e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121760 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-23sc: qa: no need to have an empty file, just create itXisco Fauli
Change-Id: I7586f1a196f057681e53173bd7d7dd3d57883abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130425 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-23sc: qa: factor out common codeXisco Fauli
Change-Id: I3a71cdb4b64397403b1a17b9c63c736169581376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130424 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-23CppunitTest_sc_pdf_export: don't load an empty doc in setUpXisco Fauli
Change-Id: Iebd4ebf3e0ca7c9e3fa00d0addc0ec21ee4deb57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130412 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-23check valid col in ScTable::GetDataEntries()Luboš Luňák
Presumably uncovered by 823eb92025853d120c17790d1c8efde59f033c69 no longer allocating a column on GetPattern(). Change-Id: I2f23414a912ec1a0f22b4b88ea367423fb6fb7e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130388 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-23fix more MAXCOL/MAXROW in testsLuboš Luňák
Change-Id: I7e3444f0b2ee5a4297705a24fbab3bfb96904b8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130387 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-22sc: qa: factor out common codeXisco Fauli
Change-Id: I363f4adba8d1d3e98cff8422d0a574e73a6c442f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130366 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-22sc: qahelper: combine saveAs and exportToXisco Fauli
Change-Id: I75667249cce2a03e23bb2e0af080c935d5f15eb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130362 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-22Fix typosAndrea Gelmini
Change-Id: I705530b841a5e1a4c45f78408948d4cdba630d96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130291 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-12-26 11:15:54 +0000