summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-01-19ofz#29713 Direct-leakCaolán McNamara
Change-Id: I6acec28ac5ebfe5e266b8dc6ff355eb4dbd6fc6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19loplugin:unusedmethodsNoel
GtkPrintWrapper stuff is dead since commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 drop never completed GtkSalPrinter Change-Id: Ia42e9bca020a9683ba247d466f743a0018e920f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-18tdf#133887 Set flag of variable when formal parameter is not expecting variant.tushar
If there is no param info for formal paramter then type of formal parameter and actual parameter will be same and there is no need to set the flag in that case. Change-Id: I12af64f82fc5b2d6d7fb920bde1cb96f8c7bd51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109070 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-18Bring uno:RefreshView to CalcSamuel Mehrbrodt
Allow refreshing the document layout via UNO slot Change-Id: I956bb884b1fb4231b1f617c4aa5a80ff9a45ec92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109230 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-01-17Fix typosAndrea Gelmini
Change-Id: Ibf250ad583c0c58c1c7866bf1c37129f0e4b8fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109468 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-17Removed executable permission on ods fileAndrea Gelmini
Change-Id: Idabe9a8070c4a248b34e38ad58fcdd7a9e9afd72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109467 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-01-16snap near 0.5 align values to 0.5Caolán McNamara
Change-Id: Idcedba97e1738f097a36845614a17f143c20c7c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16replace near-zero xalign values that should be zeroCaolán McNamara
Change-Id: I10c7d542064cffd44b1cd50972775db51f0f7e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109388 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16tdf#139583 fix case rot 180deg for cell anchored shapesRegina Henschel
Method adjustAnchoredPosition() in ScDrawView::Notify() needs to distinguish whether an object really has a changed geometry or only becomes visible. The previous solution used the snap rectangle for this. But in the case of a 180deg rotation only the logic rectangle changes, not the snap rectangle. The patch extends the test to consider logic rectangle as well. SetCellAnchoredFromPosition is adjusted to create maShapeRect, which is compared to the logic rectangle. Change-Id: Iba8a173938da05178f1058ef98e9ef526cca490e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109386 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-01-16lok: sort: invalidate the row-height cache tooDennis Francis
Change-Id: I13e59dc045b23a6ea60cd4cf34dda3166dbf5aad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109208 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 7ef5fcc08f6678ad6a61c46b187e1920fca74d23) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109275 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-01-16tdf#97087 Give unique, comphrehensible names to idleshomeboy445
Change-Id: I6823486a45311f81f0ed789dedff6c02b8fb3893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109056 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-01-16make the Color constructors explicitly specify transparencyNoel
to reduce the churn, we leave the existing constructor in place, and add a clang plugin to detect when the value passed to the existing constructor may contain transparency/alpha data. i.e. we leave expressions like Color(0xffffff) alone, but warn about any non-constant expression, and any expression like Color(0xff000000) Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-15fix location of change tracking boxes in OnlineNoel Grandin
Change-Id: I65fcb52e224dce7df2a5a7baed2b8f23d0d49397 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108849 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-01-15replace stock button imagesCaolán McNamara
Change-Id: I9be83856c0dd15552a042f009464c279bf239848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15cid#1472119 silence Uninitialized scalar fieldCaolán McNamara
Change-Id: I0a8a12e8bb823fc650212f5cf946ad9139395030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15tdf#136155 let the other elements in the dialog determine the final widthCaolán McNamara
Change-Id: Ib47db4f47a331b1f3754ca4974a9f3e5b14efc95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109292 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-15tdf#138832 XLSX export: fix lost file names in modified linksAttila Szűcs
Also for single-reference links, use the temporary indexes calculated in commit f85d860ccbebd99bc128218148e2992c9415f221 (tdf#87973 XLSX export: fix lost file names in modified links), Note: only a new test case has been added to the modified unit test document. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I4337a4e68008956ea42b626d210f07b1cbfe59ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109088 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-15tdf#139258 XLSX export: fix position of rotated imagesSzabolcs Toth
Follow-up of commit a4eec60c388cc65ae0b4c8ea0fd7235f520a749d (tdf#123613 XLSX export: fix position of rotated shapes) and commit 368c56144aab5794c39d5bc2082d9b3d6d7cebdb (refactor for xlsx shape export). Change-Id: If5a79685efa1a80ea82eac19aed12bb426d10987 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108533 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-15replace stock button labelsCaolán McNamara
Change-Id: I726ba7846322863d9f38314b6c6ccc7f71124a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14lok: send sheetGeometry invalidation after sortDennis Francis
...just for the rows to let the client know the row sizes/spans have changed. Change-Id: I26f985ab0ba4eb5b21db5783a8ac3957c64c2f22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109207 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit cca01519c7e778d3cf9208e642073d939d9fdac0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109272 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-01-14tdf#133858 reduce the double-ref range to data contentDennis Francis
in certain matrix formulas like SUM(IF(A1=G:G, H:H)*B1/B2) where whole columns are used for comparison in the condition of IF ultimately followed by a reducer like SUM. In such cases we can safely reduce the double-refs involved in the comparison to the sheet area where there is data before converting the data to ScMatrix. This is a more restricted version of Noel's fix in 37ffe509ef011357123642577c04ff296d59ce68 Change-Id: I1c2e8985adedb3f4c4648f541fb0e8e7d0fae033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109050 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 65167a9265acfea04733b5ff6ee3220a9da624f4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109118 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-01-14Rename m_xBtnCancel->m_xBtnClose (sc/optsolver)Julien Nabet
Since it corresponds to id="close" gtk-close, response close in sc/uiconfig/scalc/ui/solverdlg.ui Change-Id: I909f8f7a5d08784bda786eb86d92f88831749f23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14fix .ui indents and trailing whitespace on recent commitsCaolán McNamara
Change-Id: I45b706c99efef2e74b7c34a9d09459f2d20f6edf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14uitest: sc: factor out common code ( part 2 )Xisco Fauli
Change-Id: Ia2a707f1df513e067c8e34b263ad336fed6d14dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109235 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-13tdf#139435. Add Help button to Databar "More Options" dialog. Add extended ↵Balaharipreetha Muthu
tip for widgets. Change-Id: I9b98092b5c1229db72fb58dcb5f9636d8b6b9855 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109011 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-13Revert "pivot table: make options cancel button working" + fix crash againJulien Nabet
In the dialog, you have 3 buttons "Help", "Cancel" and "OK" Using "Cancel" will call "close" which doesn't revert back changes. To test this: - Launch Calc - Create an array with 2 cols (qtX and qtY) and put 2 rows of values - Create a pivot dialog - Put qtX in "Filters" part - Double click on qtX (=> "Data Field" dialog appears) - Click "Options..." (=> "Data Field Options" dialog appears) - Enable any checkbox (eg: Empty line after each time) + click "OK" (=> dialog "Data Field Options" closes) - Click "Options..." again (the checkbox is still enabled as expected) - Disable the checkbox + click "Cancel" (=> dialog "Data Field Options" closes) - Click "Options..." again (the checkbox is still enabled as NOT expected) So revert the below quoted commit and fix this by using "cancel" in: - action-widget response - id for the GtkButton - the use of the id to initialize m_xBtnCancel with m_xBuilder->weld_button This reverts commit c2a349bc1482482d3e5ec06232c166d77fe9b602. Change-Id: I555a90706de635e90b0ee397dfd958df55b5c40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109193 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-13Resolves: tdf#138972 dnd is moving instead of copying the dataCaolán McNamara
Change-Id: Icb2a3882704bf38c14b7a46154d51c3171268ca6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-13tdf#139182 "Symbol" shows up twice in "Visible Buttons"Vishwas
Change-Id: I5d0256c23c8e06bf3af1fb33edbe5c940b28ed56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108937 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-13move CppunitTest_sc_jumbosheets_test from subsequentcheck to slowcheckXisco Fauli
and sort the list this way, Jenkins executes this module on Windows and Mac as well. Before I submitted this test, I ran 'make clean && make CppunitTest_sc_uicalc' on a Win machine Change-Id: I906255bcf82e19917036aa3e99344f9ecf2a26fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109190 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-13lok: don't turn off online spelling by view change.Tamás Zolnai
Since we don't exit editing for LOK inside this NotifyChange() method, we should keep also spelling functionality alive. See also the comment we have here: "As long as the content is not edited, turn off online spelling." So it seems a good idea to make this spelling modification dependent of bStopEditing flag. This causes issues, during view switches. Change-Id: Ic684073d129c1cac4b6f4d11f34cd64cb5db3295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109206 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109209 Tested-by: Jenkins
2021-01-13devtools: move DevelopmentToolChildWindow to its own fileTomaž Vajngerl
Change-Id: I12326479afb5756729b62ff3676f995d16f64aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109045 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-13devtools: Enable DevTools in Calc, Impress and DrawTomaž Vajngerl
This adds the DevTools to menu in Calc, Impress and Draw, so it is possible to turn on the DevTools docking window in these most relevant modules. Change-Id: I446d2f0c9b6e5a1169d4eef556ac6989fa080634 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108977 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-13tdf#113013 XLSX import: fix "Formula is" type conditional formattingTibor Nagy
rule when the formula contains a reference to another worksheet. Change-Id: I873fad97a88df64e885fef20d4259ef6bfeaa06b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108850 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-13ofz#29528 uncaught exceptionCaolán McNamara
Change-Id: Ie2d52ba50d911ab6245d1dcf9b5e0f13ad53c300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109188 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12uitest: sc: factor out common code ( part 1 )Xisco Fauli
Change-Id: Ib0b84349c138d361001af4547d91a81d8b5d8e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109166 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-12cid#1471553 establish that pViewData will never be nullCaolán McNamara
seeing as these are created from CreateScSubTotalDlg and that is always called with a aArgSet containing a ScSubTotalItem with a non-null ScViewData set Change-Id: I1e3d243e4b00d54f9f5015a543556c39d6053f07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12transparency->alpha in tools::ColorNoel
this just changes the Get/Set methods, the constructor and internal representation of Color is not changed. Change-Id: Idb6e07cc08bbaa5bd55b6bd4b585e648aef507b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-12move CppunitTest_sc_uicalc from subsequentcheck to slowcheckXisco Fauli
this way, Jenkins executes this module on Windows and Mac as well. Before I submitted this test, I ran 'make clean && make CppunitTest_sc_uicalc' on a Win machine Change-Id: I5bb708e3b61f16c3bd53da2222f19f2b73742819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109106 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-12pivot table: make options cancel button workingSzymon Kłos
Change-Id: Ife5b5b09d7fb0879f5c29a5aefeec4746bc0ae56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107816 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109099 Tested-by: Jenkins
2021-01-12jsdialog: make Data field dialog workingSzymon Kłos
Change-Id: Iae4ec2b585272fb09253b6e05ac2a59da2219fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107777 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109098 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-11CreateScSubTotalDlg always called with a non-null pArgSetCaolán McNamara
Change-Id: I8a13a66ab7ce55a48896a921dc3b91594abefbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11MakeNumberInfoItem always passed a non-null ScViewData*Caolán McNamara
Change-Id: Ibf6c837f841749b7fb25fd448c954105ef78beeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109067 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11CreateScAutoFormatDlg always passed a non-null ScViewData*Caolán McNamara
Change-Id: I0b9568df6fdc571b5fa6cbf75a7473ac588442da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11SetTabNoAndCursor never passed a null ScViewData*Caolán McNamara
Change-Id: I972a7825306f6251f9b864ae451fdb491fcd837a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109065 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11PasteFromClipboard never passed a null ScViewData*Caolán McNamara
Change-Id: I472e280ed110bb54fc204426c50ec98acbd3a556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109063 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11ScFormatShell::pViewData is never nullCaolán McNamara
Change-Id: I29831bae8656aea014dd278c5ee87eb5f9af8db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109062 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-10merge ScSubTotalItem ctorsCaolán McNamara
Change-Id: Id71c56eb96abc80a1038a9d6cf12bc5124aa8529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109060 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-10fix coverity parse errorsCaolán McNamara
Change-Id: I4884bfb67a061b865e8cf38b2fea6de0cb1bc3d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-10remove non-standard commentCaolán McNamara
so all the .ui files follow the same pattern Change-Id: I28791fd0f7c61ca54819f810d1ac7933191d901e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-08 02:06:34 +0000