summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-01-02tdf#129712: check if outliner view pointer is valid to avoid crashMike Kaganski
Regression after commit 64233bbaa0e91ddf14d59ae7547df6bbfa60adcc. editenglo.dll!std::unique_ptr<EditView,std::default_delete<EditView>>::operator*() at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\include\memory(1886) editenglo.dll!OutlinerView::GetEditView() at C:\lo\src\core\include\editeng\outliner.hxx(208) sdlo.dll!sd::DrawViewShell::GetAttrState(SfxItemSet & rSet) at C:\lo\src\core\sd\source\ui\view\drviewsf.cxx(514) sdlo.dll!SfxStubGraphicViewShellGetAttrState(SfxShell * pShell, SfxItemSet & rSet) at C:\lo\src\core\workdir\SdiTarget\sd\sdi\sdgslots.hxx(1524) sfxlo.dll!SfxShell::CallState(void(*)(SfxShell *, SfxItemSet &) pFunc, SfxItemSet & rSet) at C:\lo\src\core\include\sfx2\shell.hxx(199) sfxlo.dll!SfxDispatcher::FillState_(const SfxSlotServer & rSvr, SfxItemSet & rState, const SfxSlot * pRealSlot) at C:\lo\src\core\sfx2\source\control\dispatch.cxx(1672) sfxlo.dll!SfxBindings::Update_Impl(SfxStateCache & rCache) at C:\lo\src\core\sfx2\source\control\bindings.cxx(270) sfxlo.dll!SfxBindings::NextJob_Impl(const Timer * pTimer) at C:\lo\src\core\sfx2\source\control\bindings.cxx(1285) sfxlo.dll!SfxBindings::NextJob(Timer * pTimer) at C:\lo\src\core\sfx2\source\control\bindings.cxx(1230) sfxlo.dll!SfxBindings::LinkStubNextJob(void * instance, Timer * data) at C:\lo\src\core\sfx2\source\control\bindings.cxx(1227) vcllo.dll!Link<Timer *,void>::Call(Timer * data) at C:\lo\src\core\include\tools\link.hxx(111) vcllo.dll!Timer::Invoke() at C:\lo\src\core\vcl\source\app\timer.cxx(76) vcllo.dll!Scheduler::ProcessTaskScheduling() at C:\lo\src\core\vcl\source\app\scheduler.cxx(478) vcllo.dll!Scheduler::CallbackTaskScheduling() at C:\lo\src\core\vcl\source\app\scheduler.cxx(288) vcllo.dll!SalTimer::CallCallback() at C:\lo\src\core\vcl\inc\saltimer.hxx(55) vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() at C:\lo\src\core\vcl\win\app\saltimer.cxx(164) vclplug_winlo.dll!WinSalTimer::ImplHandleTimerEvent(unsigned __int64 aWPARAM) at C:\lo\src\core\vcl\win\app\saltimer.cxx(174) vclplug_winlo.dll!SalComWndProc(HWND__ * __formal, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) at C:\lo\src\core\vcl\win\app\salinst.cxx(626) vclplug_winlo.dll!SalComWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) at C:\lo\src\core\vcl\win\app\salinst.cxx(658) user32.dll!UserCallWinProcCheckWow() user32.dll!DispatchMessageWorker() vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) at C:\lo\src\core\vcl\win\app\salinst.cxx(420) vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) at C:\lo\src\core\vcl\win\app\salinst.cxx(493) vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) at C:\lo\src\core\vcl\win\app\salinst.cxx(522) vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) at C:\lo\src\core\vcl\source\app\svapp.cxx(446) vcllo.dll!Application::Yield() at C:\lo\src\core\vcl\source\app\svapp.cxx(511) vcllo.dll!Application::Execute() at C:\lo\src\core\vcl\source\app\svapp.cxx(427) sofficeapp.dll!desktop::Desktop::Main() at C:\lo\src\core\desktop\source\app\app.cxx(1609) vcllo.dll!ImplSVMain() at C:\lo\src\core\vcl\source\app\svmain.cxx(191) vcllo.dll!SVMain() at C:\lo\src\core\vcl\source\app\svmain.cxx(226) sofficeapp.dll!soffice_main() at C:\lo\src\core\desktop\source\app\sofficemain.cxx(171) soffice.bin!sal_main() at C:\lo\src\core\desktop\source\app\main.c(48) soffice.bin!main(int argc, char * * argv) at C:\lo\src\core\desktop\source\app\main.c(47) soffice.bin!invoke_main() at d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(79) soffice.bin!__scrt_common_main_seh() at d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(288) soffice.bin!__scrt_common_main() at d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(331) soffice.bin!mainCRTStartup() at d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp(17) kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() Change-Id: Ia9ba183bc1be2f22082ac3833e57435dd8462adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86097 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-01tdf#57113: store UTF-16 stringpool data after legacy 1-byte dataMike Kaganski
This allows to correctly store and read Unicode strings used in password-protected libraries. The additional data stored after all legacy data of the stringpool record (after a magic number to mark its presence), and so is invisible for older versions of program: this allows to keep the version of data and backward compatibility. Of course, older versions will only see legacy data, with broken Unicode strings; and password-protected libraries edited and saved in older versions will not contain Unicode data. read_uInt16s_ToOUString and write_uInt16s_FromOUString are used for correct handling of UTF-16 strings on LE/BE systems. Change-Id: I990bc27b5cc7d499e71c43d45b7f263af41911e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86065 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-01weld NumberFormatPropertyPanelCaolán McNamara
including GtkMenuToolButton hackery to support a toggled state Change-Id: Ia1cf5fd7d56c2e475194cd2d0431611f278f5a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85873 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-01explicit uitest for uno:DataFormCaolán McNamara
Change-Id: I795ec97e663708fa36feae8f537e2138dfd77547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-01Fix typoAndrea Gelmini
Change-Id: I9b7183be9bc5cbfef9ab1538fd20554217fa4b70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86062 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-01tdf#129228 speedup opening of xlsx file with lots of commentsNoel Grandin
de-UNOise the Comment::finalizeImport method, so we can build a better custom import code path, that does not touch all the stuff that updating a running UI needs. The primary improvements comes from using setPropertyValues to set a bunch of props together. This takes the opening time from 61s to 53s for me. Change-Id: I5506a5a37a9b4b84b6930f0563a775a8aa0a9e2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85947 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-31tdf#120502: Excel doesn't increment max column for OOXMLMike Kaganski
This is obviously a result of copy-paste from XclExpColinfo::WriteBody (where that increment existed at least since commit 92d8c6d6c4dc2a2824a0e24e22485361c3b65b54 from 2004). Implementing OOXML export, authors of commit 64274b38f6cc50a8bb49f114f1ac9e7c1c3b3c4f likely forgot to remove this after copying the code to XclExpColinfo::SaveXml. This change removes the copy-pasted code incrementing column number for the last possible column. Change-Id: Ie2f043c4910568731cac90d89ec791ecbc8565b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86046 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-30Document what is discovered about XclTools::GetXclDefColWidthCorrectionMike Kaganski
This is based only on "reverse-engineering" of the formula, and is not necessarily correct. Change-Id: I2fa09e07e38de6c706cc6bf4ede7da4f04cb7c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85994 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-30Use range-based for loopMike Kaganski
Change-Id: Ia7572b2f8a5bc901434a9564b69408643a3e9fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85990 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-30weld AlignmentPropertyPanelCaolán McNamara
Change-Id: I3070f5e7b2d5f104f4eea9d3e2f700ce2d1e7375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85721 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30tdf#96505 - Get rid of cargo cult long integer literalsKemal Ayhan
Change-Id: Iaf0cfc96771e33493becfad77af9b7f3b7c817d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85950 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-12-30Decrease SplitVertical value to pass on small screen sizeMike Kaganski
Testing on Windows with UI scaling set to 150%, having screen size 1920x1080, ScMacrosTest::testVba failed in window2.xls (SplitColumn) because it tried to split at pixel position 486, while maximum split position was 460. This changes tested SplitColumn value in the test from 243 to 193. Change-Id: Iec9b25dc7b2a700adf23d7ec8983f393ba603191 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85983 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-29tdf#129228 speedup opening of xlsx file with lots of commentsNoel Grandin
by avoid some of the EqualPatternSets memcmp cost by using a hashcode, memcmp with lots of large and similar arrays ends up blowing the L1/L2 cache Takes the time from 64s to 59s for me. Change-Id: I6961aa34f4e7457a70cb75a37dfae50d5f328589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85918 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-27tdf#129533 Calc crashes on Navigator click or moveNoel Grandin
regression from commit 5bcdbf03012e9d2754c3eb166bd5a01201406d9b Date: Fri Dec 13 20:45:33 2019 +0200 sc: rowcol: tdf#50916 convert Valid* methods Change-Id: I0357b125653821ae552cb270f0d64598feedffa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-26tdf#129597: Add missing group propertyXisco Fauli
Change-Id: Icb172fc1e41510f3a2f5caf9a9270bf0dbb9bb4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85783 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-23use ScIndentItem instead of SfxBoolItem(SID_ATTR_ALIGN_INDENT)Caolán McNamara
Change-Id: I711ffb37cb4cd604d9f89c68387409ab83967a32 Reviewed-on: https://gerrit.libreoffice.org/85719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-23use ScLineBreakCell instead of SfxBoolItem(SID_ATTR_ALIGN_LINEBREAK)Caolán McNamara
Change-Id: I01bde41e4cba189c6e669e68396a9f9874f52cfb Reviewed-on: https://gerrit.libreoffice.org/85718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-23use ScVerticalStackCell instead of SfxBoolItem(SID_ATTR_ALIGN_STACKED)Caolán McNamara
Change-Id: I4571d8e399e38a91a029419f9c4b13c237af1c01 Reviewed-on: https://gerrit.libreoffice.org/85717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-23XStyleLoader::loadStylesFromURL Allow loading from streamSamuel Mehrbrodt
Change-Id: Iab0c301096118203466dd91c724c25f1283a0488 Reviewed-on: https://gerrit.libreoffice.org/85392 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-23sc: clear the spell checking markers after applying correctionsAshod Nakashian
Change-Id: Ia3fc3b5a21d21b9b945ce72f397350a57859f107 (cherry picked from commit afa5f2b0edb43b36b1b4f0ab8f70ecbe638435e5) Reviewed-on: https://gerrit.libreoffice.org/85006 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e1ca2b989bf4d124588c35f7f4a0bc3da3c1f58e) Reviewed-on: https://gerrit.libreoffice.org/85682 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-23sc: correctly update spelling markers on undo/redoAshod Nakashian
(cherry picked from commit 62eb6210895b24855b077fb0d89f182beac4a43c) Reviewed-on: https://gerrit.libreoffice.org/85005 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit a05fd0eb30767471c6d20c93e0fb8b3ff7c7eaee) Change-Id: I946cede7967f454813f717273c4114d31167c8c6 Reviewed-on: https://gerrit.libreoffice.org/85681 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-23LOK: spelldialog: don't create the dialog when loading new viewsAshod Nakashian
By default dialogs/decks are re-created when a new view is created/attached, if they are visible. For the spell checker this is unexpected, as the user doesn't expect to be doing spell checking upon loading a document, just because another user was at the time spell checking. Currently the suppression is for LOK only. This also adds support to suppress the recreation of any dialog by flagging it with the SfxChildWindowFlags::NEVERCLONE flag upon invoking RegisterChildWindow. (cherry picked from commit e3fb48fe4f84b5609730c64fdb49b1bd7ddd1f96) Reviewed-on: https://gerrit.libreoffice.org/85004 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e573919cd8561a81d967c1a4566c5733dd44b7b1) Change-Id: I7d71c664f1b2804910c96eeb0431164d48b5679b Reviewed-on: https://gerrit.libreoffice.org/85680 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-22sc: LOK: commit cell edits before saveasAshod Nakashian
Users typically don't recognize that changes done to a cell need to be committed (typically by hitting RETURN) before they are saved to file. This is especially true on the web. This patch commits any in-flight changes before SaveAs. This is currently done only for LOK and unconditionally at that. This can be controlled via a flag, if there is such a use-case. Reviewed-on: https://gerrit.libreoffice.org/78012 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit cc7eb4d345e3fede698a3f255c1938d275305c14) Reviewed-on: https://gerrit.libreoffice.org/78455 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit e867404fbe7e0ff0d6f2573292c19b3a178a412d) Change-Id: I2a88b2f1df47be764058f4505561b22830d9d67a Reviewed-on: https://gerrit.libreoffice.org/82102 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-22sc: spelldialog: lock before resetting the editviewAshod Nakashian
Painting also resets the view and that can happen asynchronously. When the spelldialog gets focus it resets the editview if it detects it has changed, which happens when, for example, another view is created. (cherry picked from commit d91d940ad0319e0cc6e0080a903ac0a7e9f6ba88) Reviewed-on: https://gerrit.libreoffice.org/85003 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 550c0a666e119c911b311c96f9185c11d8465dcb) Change-Id: Ib23e332e4ba069e05787d1cc03ae23fe657b12c8 Reviewed-on: https://gerrit.libreoffice.org/85679 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-22sal_Char->char in scNoel Grandin
Change-Id: I7e212a36898e71b03db88053647bfeee12a49cb5 Reviewed-on: https://gerrit.libreoffice.org/85690 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-21fix some runtime warningsCaolán McNamara
Change-Id: Ifffd65c6301fc7599927c095de07a34c0a5246c8 Reviewed-on: https://gerrit.libreoffice.org/85615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-21remove unnecessary CreateChildContext methodsNoel Grandin
that do the same as the base class method Change-Id: I5048edf9d5fa40bb4ebdd96d9b13c303fb061945 Reviewed-on: https://gerrit.libreoffice.org/85646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20the data provider feature is not ready for productionMarkus Mohrhard
Change-Id: Idca4b9dbde4fed2524c186851cb44d95953181ec Reviewed-on: https://gerrit.libreoffice.org/85541 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-12-20loplugin:duplicate-definesNoel Grandin
these are duplicated in sfx2/sfxsids.hrc, with no easy way to de-duplicate them without making stuff much harder to understand, so wrap them in conditional defines Change-Id: I83f53a224e83ba808acc03e116dd416a4291d77b Reviewed-on: https://gerrit.libreoffice.org/85557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20weld ScFunctionWinCaolán McNamara
Change-Id: I9cb15dcb188354ebf6ba382a2f8109a3ae27be0d Reviewed-on: https://gerrit.libreoffice.org/85606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-20Resolves: tdf#129501 cannot change formula separators in optionsCaolán McNamara
Change-Id: I5cf5736f8ad3d5e28f2c31ffa88dafac59df8a8e Reviewed-on: https://gerrit.libreoffice.org/85587 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-20loplugin:duplicate-definesNoel Grandin
move these into their own file, the way we do elsewhere Change-Id: Ib97e09c80537e31d795a8c66a6dfb06b350ff0e2 Reviewed-on: https://gerrit.libreoffice.org/85560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20loplugin:duplicate-definesNoel Grandin
just include the header file which has a shared definition Change-Id: I7412cc2c87ab1c757a82ac3f307a3a07c3289980 Reviewed-on: https://gerrit.libreoffice.org/85561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20loplugin:duplicate-definesNoel Grandin
duplicates in same file Change-Id: I3f700bf3d7641f544f007a2a662a414a579156e4 Reviewed-on: https://gerrit.libreoffice.org/85559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20tdf#129228 speedup load xls file with lots of commentsNoel Grandin
by locking the underlying SdrModel while the comments are added, so we avoid the reformatting that happends when the model is unlocked Takes the time from 3m30 to 1m for me. Change-Id: Ibc3d2b1ded548d5eee7715d9a655a0af61b0eb2b Reviewed-on: https://gerrit.libreoffice.org/85523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-19Remove commaAndrea Gelmini
Change-Id: Ie8b573d2b319c046013e7189fa3cc19c9409f499 Reviewed-on: https://gerrit.libreoffice.org/85517 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-19lok: send "EMPTY" if the rect is empty for cell selection or fillTomaž Vajngerl
It can happen that the selection or auto-fill rectangles are empty and if that's the case then we need to send "EMPTY" string and not the content of an empty rectangle (0, 0, -32768, -32768). This can happen for CELL_SELECTION_AREA or CELL_AUTO_FILL_AREA in calc. Change-Id: I9a60e3907a2ab8b0e0fd1a2ff81137fba6c8e9a3 Reviewed-on: https://gerrit.libreoffice.org/85441 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-18Unit test insert with shared formula group shift, tdf#129396Eike Rathke
Change-Id: I99ab71f6fba4eb9f83fe8c262a6549a236ccf1ec Reviewed-on: https://gerrit.libreoffice.org/85422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-12-18Resolves: tdf#129396 Refresh shared formula group area listeners upon shiftingEike Rathke
Regression from commit 47230a036fe35b9a7a7c0609232849fcbb51efcc CommitDate: Thu Feb 5 11:52:51 2015 +0100 Resolves: tdf#88792 do not hold a ScFormulaCell** in group area listener where previously the listener position's column was taken from the group's remembered top formula cell (then updated) position, which holding the cell was wrong in other cases. Change-Id: Ida1503daa7cbda2b41459ff5d63652a6febd91e0 Reviewed-on: https://gerrit.libreoffice.org/85347 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-12-17Fix typo in codeAndrea Gelmini
Change-Id: I32f99d6dbdaa52f53bd630b611d13decf110fd75 Reviewed-on: https://gerrit.libreoffice.org/85318 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-12-17Removed duplicated includeAndrea Gelmini
Change-Id: Iaa0b6006b53b2f20f9eb6e86f081211bf60d19bf Reviewed-on: https://gerrit.libreoffice.org/85311 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17tdf#129435: Fix menu referenceXisco Fauli
Regression from 81f01259dfe29b7ee73c42d3b44934d6fc973cd8 Change-Id: Ibeb094d7dfd998322acf88bdc38fe1f15d524e78 Reviewed-on: https://gerrit.libreoffice.org/85306 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-17ScSheetLimits must be a complete type here (Windows --disable-pch)Stephan Bergmann
...after 113444f59dc7690850919155b9b164b1a686bbe7 "sc: rowcol: tdf#50916 create ScSheetLimits to hold by rtl::Reference", due to the MSVC rules of emitting definitions of implicit member functions of dllexport classes: > In file included from sc/source/ui/condformat/condformathelper.cxx:14: > In file included from sc/inc\conditio.hxx:30: > In file included from sc/inc/tokenarray.hxx:24: > include\rtl/ref.hxx(74,20): error: member access into incomplete type 'ScSheetLimits' > m_pBody->acquire(); > ^ > sc/inc/tokenarray.hxx(69,5): note: in instantiation of member function 'rtl::Reference<ScSheetLimits>::Reference' requested here > ScTokenArray( const ScTokenArray& ) = default; > ^ > sc/inc/tokenarray.hxx(47,8): note: forward declaration of 'ScSheetLimits' > struct ScSheetLimits; > ^ Change-Id: I4e79340f52e92b88c43fa5b78aa69ed49b367705 Reviewed-on: https://gerrit.libreoffice.org/85260 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17Add missing DoClose of test documentsStephan Bergmann
I had added these while tracking down some issue which ultimately turned out to be unrelated to this. But looks like it can't hurt to explicitly close these documents, as is already done in all the other tests in this file. Change-Id: I32f8b3cb38264aac4b7c5982430006b374142be0 Reviewed-on: https://gerrit.libreoffice.org/85264 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17Resolves tdf#129127: do a safe swap of patternsDennis Francis
Following swap of patterns is not safe : """ const ScPatternAttr* pPat1 = GetPattern(nRow); const ScPatternAttr* pPat2 = rOther.GetPattern(nRow); SetPattern(nRow, *pPat2); rOther.SetPattern(nRow, *pPat1); """ as the first SetPattern can cause deallocation of the pattern object pointed to by pPat1 if it had a reference count of 1 to begin with. In such cases, increase the reference count of first pattern by putting it into document pool, thereby evading deallocation. The stacktrace of the crash without the fix looks like : Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault. 602 SfxPoolItem *pPoolItem = rItem.Clone(pImpl->mpMaster); 0 0x00007ffff4ad2905 in SfxItemPool::PutImpl(SfxPoolItem const&, unsigned short, bool) (this=0x16c6830, rItem=..., nWhich=39321, bPassingOwnership=false) at /ssd1/work/dennis/core/svl/source/items/itempool.cxx:602 1 0x00007fffd179e5a5 in ScDocumentPool::PutImpl(SfxPoolItem const&, unsigned short, bool) (this=0x16c6830, rItem=..., nWhich=0, bPassingOwnership=false) at /ssd1/work/dennis/core/sc/source/core/data/docpool.cxx:333 2 0x00007fffd14e88fb in SfxItemPool::Put<ScPatternAttr>(ScPatternAttr const&, unsigned short) (this=0x16c6830, rItem=..., nWhich=0) at /ssd1/work/dennis/core/include/svl/itempool.hxx:154 3 0x00007fffd14dd228 in ScAttrArray::SetPatternAreaImpl(int, int, ScPatternAttr const*, bool, ScEditDataArray*, bool) (this=0x2cbc020, nStartRow=9, nEndRow=9, pPattern=0x2da5d80, bPutToPool=true, pDataArray=0x0, bPassingOwnership=false) at /ssd1/work/dennis/core/sc/source/core/data/attarray.cxx:464 4 0x00007fffd1653fcd in ScAttrArray::SetPattern(int, ScPatternAttr const*, bool) (this=0x2cbc020, nRow=9, pPattern=0x2da5d80, bPutToPool=true) at /ssd1/work/dennis/core/sc/inc/attarray.hxx:142 5 0x00007fffd163cd41 in ScColumn::SetPattern(int, ScPatternAttr const&) (this=0x2cb4610, nRow=9, rPatAttr=...) at /ssd1/work/dennis/core/sc/source/core/data/column.cxx:694 6 0x00007fffd170e65b in ScColumn::Swap(ScColumn&, int, int, bool) (this=0x2339270, rOther=..., nRow1=0, nRow2=9, bPattern=true) at /ssd1/work/dennis/core/sc/source/core/data/column4.cxx:1112 7 0x00007fffd1ada654 in ScTable::SortReorderByColumn(ScSortInfoArray const*, int, int, bool, ScProgress*) (this=0x2cb9ea0, pArray=0x5ef71a0, nRow1=0, nRow2=9, bPattern=true, pProgress=0x7fffffff09a0) at /ssd1/work/dennis/core/sc/source/core/data/table3.cxx:922 8 0x00007fffd1adf991 in ScTable::Sort(ScSortParam const&, bool, bool, ScProgress*, sc::ReorderParam*) (this=0x2cb9ea0, rSortParam=..., bKeepQuery=false, bUpdateRefs=false, pProgress=0x7fffffff09a0, pUndo=0x7fffffff0950) at /ssd1/work/dennis/core/sc/source/core/data/table3.cxx:1750 9 0x00007fffd17cc70a in ScDocument::Sort(short, ScSortParam const&, bool, bool, ScProgress*, sc::ReorderParam*) ( this=0x2cc4db0, nTab=0, rSortParam=..., bKeepQuery=false, bUpdateRefs=false, pProgress=0x7fffffff09a0, pUndo=0x7fffffff0950) at /ssd1/work/dennis/core/sc/source/core/data/documen3.cxx:1411 10 0x00007fffd22a2f76 in ScDBDocFunc::Sort(short, ScSortParam const&, bool, bool, bool) (this=0x7fffffff0b50, nTab=0, rSortParam=..., bRecord=true, bPaint=true, bApi=false) at /ssd1/work/dennis/core/sc/source/ui/docshell/dbdocfun.cxx:578 11 0x00007fffd2744e29 in ScDBFunc::Sort(ScSortParam const&, bool, bool) (this=0x2e3b560, rSortParam=..., bRecord=true, bPaint=true) at /ssd1/work/dennis/core/sc/source/ui/view/dbfunc.cxx:217 12 0x00007fffd2744d7b in ScDBFunc::UISort(ScSortParam const&) (this=0x2e3b560, rSortParam=...) at /ssd1/work/dennis/core/sc/source/ui/view/dbfunc.cxx:208 13 0x00007fffd2735e3d in ScCellShell::ExecuteDB(SfxRequest&) (this=0x1e42330, rReq=...) at /ssd1/work/dennis/core/sc/source/ui/view/cellsh2.cxx:528 Change-Id: I70f8b95a6ff59f372b909fd173117a114906deff Reviewed-on: https://gerrit.libreoffice.org/85072 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-12-16LOK: emit modified status on entering cell dataAshod Nakashian
Entering data into a cell without committing will normally not set the modified flag. However clients might want to know whether there is in-flight changes when they need to save the document. A possible scenario is that the user enters some cell data and then closes the window. Both WSD and the client app would here rely on the modified notification to decide whether to save the document or not. We do not change the document modified state, since that may be incorrect (in case the user actually cancel the cell entry), so we preserve that so future updates to the modified status would reflect the correct state of the file. Instead, we emit a client notification that the document has been modified, to signal them that saving is sensible. Note that ideally we would undo this when the user cancels the cell edit, but that would be complicated due to multi-editor scenarios. For example, another user might actually edit the document while we cancel our cell edit, and in this case we should not reset the modify flag. Since this is unreliable, we leave the flag set, unless the Core emits an update, which will surely be accurate. Reviewed-on: https://gerrit.libreoffice.org/75513 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 38b899312245758381fa72ad17c2d4c281edb1ba) Reviewed-on: https://gerrit.libreoffice.org/78451 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Change-Id: Id26aa6f8ce2c0a08f8bee6812fcf99275dc24551 Reviewed-on: https://gerrit.libreoffice.org/82093 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-16lok: calc - update our version of the other view's selections on zoom.Michael Meeks
Change-Id: I4d23bb77045b41d04109e7dd70a1f47bca8aaa56 Reviewed-on: https://gerrit.libreoffice.org/84767 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84768 Tested-by: Jenkins
2019-12-16crashtesting: null deref on load of tdf113898-2.odsCaolán McNamara
Change-Id: Ie6e00af220d1ee65c363224abcf63ece2e7bff6f Reviewed-on: https://gerrit.libreoffice.org/85206 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-16crashtesting: null deref on export to odsCaolán McNamara
of EDRM_Data-Set_File-Formats_1-0/data-set/dbs/PICTURES.DBF Change-Id: Id501c1fe24aa42d25974cee7d35693f8d221d067 Reviewed-on: https://gerrit.libreoffice.org/85208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-16lok: calc - send other views our selection in their co-ordinates.Michael Meeks
Change-Id: If48b5adb9b8b03310d2d2c4e4fefab84ad8bb149 Reviewed-on: https://gerrit.libreoffice.org/84370 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/85085 Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-10 17:22:28 +0000