summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28tdf#48140 Replace CellRangeAddress with ScRangeBartosz Kosiorek
Change-Id: I5aa1dabf938e1567d386fceb153e2986862f70a6 Reviewed-on: https://gerrit.libreoffice.org/34707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27move assign() into operator=() and add the relevant bits to copy-ctorEike Rathke
Change-Id: Iac606a8e5e4fc9beb019d95d2a05f0ab9d9dad34
2017-02-27rework ScCaptionPtr to have a distinct head elementEike Rathke
Not only saves a pointer per list element, but future versions could hold a document pointer and/or drawing layer's draw page as well. Change-Id: I85e05981239223bec88c47f2ebe4c22e50cd9a0d
2017-02-27sc: make tabview3 more readableTomaž Vajngerl
- add some curly-braces - join consecutive if statements - declare variables inside for statement Change-Id: I369452cdd684f71a7bd30b5dc072831b982ee1b3 Reviewed-on: https://gerrit.libreoffice.org/34686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-27uitest: move all the conditional format tests into an own testMarkus Mohrhard
Change-Id: I5673341b05c8352bc1d46f1483c265ccdc6a1cc5 Reviewed-on: https://gerrit.libreoffice.org/34667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-25add TINV test caseZdeněk Crhonek
Change-Id: Ic9b8398d935e32e529252f55fb09fac5e800e578 Reviewed-on: https://gerrit.libreoffice.org/34647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-25add CHISQ.DIST.RT T.DIST.RT testcaseZdeněk Crhonek
Change-Id: I146e08bbe6984db0fba9e5da93db8ce8d0ef5826 Reviewed-on: https://gerrit.libreoffice.org/34630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-25add CHISQ.TEST,CHISQDIST,CHISQINV,CHITEST,SEARCH test caseZdeněk Crhonek
Change-Id: Ib0fcb9756049bc741b21fb608e1985c1f7c6e7d6 Reviewed-on: https://gerrit.libreoffice.org/34631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-25xPoolHelper is empty in a clipboard docMarkus Mohrhard
Found by the crashreporter: http://crashreport.libreoffice.org/stats/signature/ScDocument::IsClipboardSource() Change-Id: I3fb030921b653396deb46a9e98d30d5df9c9ce15
2017-02-24tdf#50916 Allow dynamically increase number of columns according to needsBartosz Kosiorek
Change-Id: I08b1d70b6aafb01738bb5dec3f4eafd7b21e6bb5 Reviewed-on: https://gerrit.libreoffice.org/33724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-02-24adapt comment to realityEike Rathke
The code now does what the original questioning comment suggested. Change-Id: I359c99a30d2e6822fe9164bb9f903876095c9f6f
2017-02-24grml.. and do that rightEike Rathke
Change-Id: I71bc423bde1f7df576175120741c8a08100b08dd
2017-02-24replace a leftover OSL_DEBUG_LEVEL >1Eike Rathke
Change-Id: Ic5e5e72a2c79e68752c3108de9f3722fbcb8e7b3
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-24correct descriptionEike Rathke
Change-Id: I830e81985243e7a552716ede163466bf7adfcd9a
2017-02-24a first stab against the note caption ownership messEike Rathke
This should not change any existing behavior, but may help tracking down what happens where and when. The final goal is to let ScCaptionPtr also handle deletion of caption objects once they're unreferenced and guard against dangling pointers and double delete, and/or to manage transfer of ownership to the drawing layer. Further improvement to the structure could involve a head data element so that the duplicated (and unused except in head) mnRefs field could be eliminated and the walk simplified when removing an element from the list. Change-Id: Ifbb2fb1d9dc4d2594a1eae2a8489270dd1fe0d0c Reviewed-on: https://gerrit.libreoffice.org/34616 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24maybe try ROUNDSIG(...,9) ...?Eike Rathke
Change-Id: Ib72c2776c54f905f369be756a4a14a25c3149616 Reviewed-on: https://gerrit.libreoffice.org/34615 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24Remove SC_DPOUT_MAXLEVELS limit in PivotJulien Nabet
by using vectors instead of fixed arrays Change-Id: I4bd070e05ccc464c80722ffd05e70b7acac17d5f Reviewed-on: https://gerrit.libreoffice.org/34408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-02-23let's try if using the new ROUNDSIG(...,12) helpsEike Rathke
... against sporadic tinderbox failures. Change-Id: I54dab5665575802b5fe9051d215399c3554e8fd8 Reviewed-on: https://gerrit.libreoffice.org/34578 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-23All ScAxisPosition values that meAxisPosition can take on are coveredStephan Bergmann
...so all of pInfo's members are initialized, so no need to first zero- initialize it Change-Id: I9cc7a0cc038aec59dca4121d16164843483737fc
2017-02-22less ugly ClosingClipboardSource()Eike Rathke
Change-Id: Ie53837e4dd5f779255eac25e090b23e49c3786ce
2017-02-22lok: these are not always plain asciiPranav Kant
Change-Id: I9783b6b2839805189015dbad8a97128c89e0a4a9
2017-02-22use std::unique_ptrCaolán McNamara
Change-Id: I11a58aa38f931c7912e2e5ac6df46f98e6bb681e Reviewed-on: https://gerrit.libreoffice.org/34539 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-22Revert "Fix typos"jan iversen
This reverts commit ffd7f8fcfc2b551509e9cb31c0920e0f64292ea7. Caused some problems, need to be broken down. Change-Id: Iee816a266c32e7cebe623d36300c13d079e77c52 Reviewed-on: https://gerrit.libreoffice.org/34534 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-02-22Fix typosAndrea Gelmini
Change-Id: I61764094dd6f8e13f29ca554373d30d1d5def447 Reviewed-on: https://gerrit.libreoffice.org/34476 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-02-21do not test for different caption pointers ...Eike Rathke
... if it's not guaranteed they may not be identical. Change-Id: Ieb4b0eb07a1b1832df65dde3c2e5a92b5121a162
2017-02-21this should be GetOrCreateCaption()Eike Rathke
... as the caption object has to be created after the note was pasted from a clipboard where the caption was forgotten.. Change-Id: I9b04f0146a7609ac44973dc181fa2ab6b11295b9
2017-02-21tdf#105772 apply all ODFF constraints with function SEARCH.Winfried Donkers
Now the function both complies with ODFF1.2 and behaves the same as Excel does. Change-Id: Ic49af48cacedbac54688266a916c5fa6e28bb5c4 Reviewed-on: https://gerrit.libreoffice.org/34037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-21tdf#105885 fix incorrect result with CHISQ.DIST.RT.Winfried Donkers
With X-argument < 0 Excel returns an error; Calc now does too. Change-Id: I58a84436b2418bef824b6494c2cc5737932cc936 Reviewed-on: https://gerrit.libreoffice.org/34098 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-02-21tdf#105937 fix incorrect constraint for Calc function T.DIST.RT.Winfried Donkers
As code is shared for various t-distribution functions, the applied constraints did not all apply for T.DIST.RT. Change-Id: Ia68330e6fad7990e964fa5fd86fc062c156d1a4e Reviewed-on: https://gerrit.libreoffice.org/34149 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-02-21convert writer changes menu to .uiCaolán McNamara
Change-Id: I30a957f91c3faca5e16a70efce08579ac3368bdf
2017-02-21unit test for copying note from clipboard after closing orig doc, tdf#104967Eike Rathke
Change-Id: I165363eecbb37561d8265638415e0f5f069878d7
2017-02-21this should had been GetNote() and GetCaption()Eike Rathke
Not creating if there wasn't. Change-Id: I3e7a0d167e604b13674d24de18bd2bc7d3b36aa0
2017-02-21stray fprintfCaolán McNamara
Change-Id: Ieebdd7166e4a1b002cc5085bc5c83e17924cc15e
2017-02-21convert calc changes menu to .uiCaolán McNamara
Change-Id: I65c07995ab7a63bcefeb1612e86bf3fedc33f4a5
2017-02-21stl debugging points out that a < aCaolán McNamara
when using right click menu in calc redline dialog to sort changes Change-Id: Ib79028168470b7a556bdc37cd65ce99b4dce5152
2017-02-21add ENCODEURL test caseZdeněk Crhonek
Change-Id: I0854c146a8fed793460fcbe392d43e91bcfd113e Reviewed-on: https://gerrit.libreoffice.org/34492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-21move ScDocShell de-/init related to getNewDocShell() and closeDocShell()Eike Rathke
In preparation for being able to handle two documents. Change-Id: Ie7ea65136bcd6719031af6b1034d002058bfd81a
2017-02-21unit test for cell merge with note caption undo, tdf#105667Eike Rathke
Change-Id: Ib49e0f35aa554025634c8496fbb80d87dbc86d89
2017-02-21Fix typos/translations, following 04644956e53dAndrea Gelmini
No automatic tools Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428 Reviewed-on: https://gerrit.libreoffice.org/30874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21tdf#106049 Apply proper constraints for Calc function T.INV.Winfried Donkers
Probability p must be 0 < p < 1 for inverse cumulative left-tailed t-distribution function. Change-Id: I4f79eac8c9362e31de46b3ff4ebe7283ec475fac Reviewed-on: https://gerrit.libreoffice.org/34375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-21tdf#106052 Treat SubFormat for "Precision as shown"Laurent Balland-Poirier
Get precision from the correct subformat Change-Id: I458e5b3d1fb515864f19499ac9ac529e1d68a267 Reviewed-on: https://gerrit.libreoffice.org/34505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21Improve readability.Jan Holesovsky
Change-Id: Ibbbac458e3ef8b3d02f4d73cd8bf3ac880ff0522
2017-02-21loplugin:subtlezeroinit: scStephan Bergmann
Change-Id: I98e433441e97d0f2e88f84cd9b3cf91861465bff
2017-02-20Related: tdf#106089 generate range string with current address conventionEike Rathke
... so subsequent parsing actually works. Change-Id: I47d661d24552104b56827248b4c5e6a6617c5d63
2017-02-20Resolves: tdf#106089 catch legal IllegalArgumentException on bad range stringEike Rathke
... that for example doesn't match the document's current address convention. Further work is need to make that actually fly, but at least don't terminate the application but come up with a default Chart instead where the range can be edited. Change-Id: I6cb6400c56c896dac7ab949b8a986c784690dfd3
2017-02-20use SvNumberformat::GetMaskedType()Eike Rathke
... instead of manually masking out css::util::NumberFormat::DEFINED Change-Id: I0761132800b2b1693df41085695f36cd3cc1236b
2017-02-20don't obtain the underlying SvNumberformat thrice, tdf#105657 follow-upEike Rathke
... which all GetFormatTable()->...(nFormat) do. Also introduce SvNumberformat::GetMaskedType() for convenience. Change-Id: I9495d71b99116e74e8b877ffc9cd21bd36cc7b7f