summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2015-08-24tdf#93437: release reference held by ScFormulaReferenceHelperKatarina Behrens
This does two things: reverts a revert of 087f7fe50b03307e2d9202365886e8c37bd7e6e3 -- turns out it was innocent. Plus, it actually releases the reference that prevents destructor from being called. It was actually ScFormulaDlg's own m_aHelper member variable holding reference to 'this' (extra-wicked, through SetWindow(this)), never releasing it. Change-Id: I258a280e09674d1a2f1ddebea19ea1b42dcdc777 Reviewed-on: https://gerrit.libreoffice.org/17949 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-23tdf#39440 sc: reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: Ia7f58c24429310b66f4464d8ba8b4f2e5c6fef38 Reviewed-on: https://gerrit.libreoffice.org/17922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-23tdf#39440 reduce variable scope, adapt indentationMichael Weghorn
This addresses a cppcheck "variableScope" warning and adapts the indentation of some code lines according to the surrounding code. Change-Id: I76eca59a808740ab0366dd41c889a6ef19a2436d Reviewed-on: https://gerrit.libreoffice.org/17923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-22tdf#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: Ie492fb9c106b37c3fe7b0105236ad6315f4f159e Reviewed-on: https://gerrit.libreoffice.org/17921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-21tdf#93437: Calc RefDialogs were never actually destructedKatarina Behrens
as ScTabViewShell::CreateRefDialog was still holding VclPtr reference to them and never released it -- regression from commit 087f7fe50b03307e2d9202365886e8c37bd7e6e3 which is hereby reverted. Now it is *DlgWrapper holding the reference (via SfxChildWindow::pWindow) and dialogs get properly destructed when SfxChildWindow dies in SfxViewFrame::SetChildWindow(0, false) Re tdf#91125, it turns out that the follow-up commit 06ecf7d2aebe64226142ee27c2512351960f8bb1 is actually enough to prevent the crash. Change-Id: I895825da59aabc7c0de530ecb528b9bf5acde562 Reviewed-on: https://gerrit.libreoffice.org/17899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-21loplugin:defaultparamsNoel Grandin
Change-Id: Iaf6415d3b33a4ce195a00913a0df69f1fb794217
2015-08-21remove last WeakImplHelper8 usesCaolán McNamara
Change-Id: I7ecadedb77832fb3073870880dbfba121fdae826
2015-08-20Revert "tdf#93437: Re-enable input after closing formula wizard"Eike Rathke
This reverts commit 808063ebe7d410eb7e370be1f5d8047377137dfb. As seen, the real cause is that ScFormulaReferenceHelper is never destructed because ScFormulaDlg isn't either. Change-Id: I45290ecd7932f4a6e607fc541837a253b8f86acc Reviewed-on: https://gerrit.libreoffice.org/17876 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-20tdf#93437: Re-enable input after closing formula wizardKatarina Behrens
Input was disabled on opening the wizard (in ScFormulaDlg ctor), but never enabled again. Row and column headers seem to be more sensitive about it than e.g. grid window and they then just discard mouse events ... Change-Id: Id27757fb1b3a8b96ad1588354f016ac55d71cca2 Reviewed-on: https://gerrit.libreoffice.org/17872 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-19sc: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl
Change-Id: I966069726fd7dbc57e03e93514bec62d8bbb2ba0 Reviewed-on: https://gerrit.libreoffice.org/17862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-19sc: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I2a56ebf8edb30b5f16e09237f9480484a699170e Reviewed-on: https://gerrit.libreoffice.org/17861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-19sc: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl
Change-Id: I93bdb33a442a358b0067d57499b11d73bfbaa2d9 Reviewed-on: https://gerrit.libreoffice.org/17860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-19sc: these are ptr_map not ptr_setMichael Stahl
Change-Id: I55848b3fedae79d714c8341fd84d505cb83a7c2c
2015-08-19loplugin:literaltoboolconversionStephan Bergmann
Change-Id: Iad48cf4949cb4a398a8abee32febaf8e152dade5
2015-08-19Bugfix test for tdf#77431Katarina Behrens
Change-Id: I2120ed72c281d2078e387f7f3ae91004ad95822c Reviewed-on: https://gerrit.libreoffice.org/17855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-08-19tdf#77431: Move setting sheet visibility to finalize phaseKatarina Behrens
and thus fix xlsx-specific issue that 1st sheet can't be hidden. Also kill some UNO in the process. I'm not sure if guarding against all sheets being hidden (by having at least active sheet visible) is absolutely necessary, but better be safe than sorry. Change-Id: I4ad21d223b2effe427ab1d5411c035886f6cc71c
2015-08-19Clean up remaining utl::LocalFileHelper::Convert...Stephan Bergmann
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040 "ConvertURLToSystemPath->getSystemPathFromFileURL" and 28f3464a571a23a2c16bd0980e9021b95d011511 "ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those Convert... functionality with direct calls to the corresponding osl::FileBase functions. Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-18introduce temporary hard-recalc state, tdf#92749 follow-upEike Rathke
This allows listeners to be setup and initial lookup caches to be kept, which were thrown away after the initial calculation as an interim fix for tdf#92749. Change-Id: I34068b3f6b833a46f3c526579efbdc342a2e71df
2015-08-18tdf#75973 : User Defined Types in password encrypted macrosLaurent Godard
save/load basic script so that when executing password protected the user defined types can be rebuilt supports array and nested types a unit test in sc macros-test.cxx Change-Id: Ie127ea7ad9aea3353741048c00f1b3910c5517a4 Reviewed-on: https://gerrit.libreoffice.org/17815 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-18Resolves: tdf#92749 invalidate lookup caches after initial hard recalcEike Rathke
... because the caches are not setup as listeners during when the document's hard recalc state is active. Change-Id: Ie7ec84ee64d046e3e55ce26b92824e94a2f660e9
2015-08-18add a simple formula cell calculation chain dumperEike Rathke
Change-Id: Ie6409724dcf0baa2f1d7dd62ed8d995f0374dbf1
2015-08-17Move export tests where they really belongKatarina Behrens
Change-Id: Ia231bd3e355c398d4ea3ef3d8adcd64b7074847c
2015-08-17make Control::ImplCallEventListenersAndHandler take a lambdaNoel Grandin
so that we make the Link<> calls type-safe, without having to make this a template method Change-Id: I2e36bd6aa7c63440f72d266b593e101965b5ebce
2015-08-17tdf#93392 leak when linking to external html data file with auto updateDennis P. Francis
Change-Id: I32d96b945ad0c2a0505418a0841156600570b301 Reviewed-on: https://gerrit.libreoffice.org/17757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-17convert Link<> to typedNoel Grandin
Change-Id: Ib0bf56a0e642720ff5daafdfc2dc12809be87e43
2015-08-17make Link<> typedNoel Grandin
Change-Id: If16adfa3310df94c79d1a4fe9a9bb4f4f56365f0
2015-08-17Put Polygon from tools under tools:: namespaceNorbert Thiebaud
Polygon is one of these names that Clash with some system objects A similar work has been done earlier with PolyPolygon. Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5 Reviewed-on: https://gerrit.libreoffice.org/17789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-15Resolves: tdf#93358 resync attribute pattern that may have changedEike Rathke
Change-Id: If3ce8feec940c7212fe467f39db868630522b17e
2015-08-14Some more tdf#92256 related testsKatarina Behrens
Change-Id: I052cceb229f8ab72277c51600994269e4ea52135 Reviewed-on: https://gerrit.libreoffice.org/17704 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-14tdf#92256: Don't force CalcA1 syntax on all !Microsoft xlsx docsKatarina Behrens
in other words, don't override user's configuration of string ref syntax Change-Id: I70281f6869663ccdaabacf506f6effcaf4b5a3fa Reviewed-on: https://gerrit.libreoffice.org/17702 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-14tdf#92256: Save ref syntax when different from native oneKatarina Behrens
that is, CalcA1 for ODF and ExcelA1 for OOXML Change-Id: Ie4df23c5787531677c4533776d489991d413a8d6 Reviewed-on: https://gerrit.libreoffice.org/17701 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: If342e813063eb0a17f7a8f8e872290f056964e05
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: Idd291659ca786b7bd2755c8faf98edc51314687b
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: I4f635044b93f74fb397a4e47535e91160fce456c
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: Ibf8328d5000d82d09d5621d3701039bcbdb49407
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: Id5cdb8516db9e9017de06c3ab6e25f272c945677
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: I0d4b901b6678f3344ed62018d871e1630195aef0
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: I807ce811f5988d6134b4c6f73408cd034f25a7f7
2015-08-14remove default value from SfxPoolItem::PutValueNoel Grandin
more useful to make it explicit. Specifically, otherwise my defaultvalue clang plugin would want to remove lots of places that contains #define constants which, while technically the same as the default value, convey semantic information which is quite useful. Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-08-14remove default value from DffPropSet::GetPropertyValueNoel Grandin
more useful to make it explicit Change-Id: Ic76fcc5ffa245b3eb3c99f3a5e4d0656b56c511e
2015-08-14Move dropdown menu from 'Save As' to 'Save' buttonSzymon Kłos
Change-Id: I24e9b16ea38811791804e6c85205b304bd781617
2015-08-14reorder of File menuSzymon Kłos
Change-Id: I8265b291554765775871905b0349564131dfa8c7
2015-08-14forget about the C++ Standard, use our own known goodsEike Rathke
Android-ARM doesn't have std::copysign(), who knows what else will be non-functioning on whatever platform.. Change-Id: I40e80c26f2892007caa3729bd0dda2733e875613
2015-08-13second attempt to blind fix MSVC werror C4701,C4703Eike Rathke
Change-Id: Ic9d8ee4a88e9bfb6586417c66fb197becd5cfa46
2015-08-13do not use INFINITY (or NAN while at it..) macroEike Rathke
With MSVC werror bails out, that generates warning C4756: overflow in constant arithmetic because aparently there is #define _HUGE_ENUF 1e+300 /* _HUGE_ENUF*_HUGE_ENUF must overflow */ #define INFINITY ((float)(_HUGE_ENUF * _HUGE_ENUF)) /* causes warning C4756: overflow in constant arithmetic (by design) */ Great stuff.. Change-Id: Id85e3cac6ea24858654ced617c7e06c62f78374d
2015-08-13blind fix MSVC werror C4701,C4703 potentially uninitialized local variableEike Rathke
... ´pModelObj´ used. Which is bullshit, but.. Change-Id: Ic731fc92264560c34bd512dc232a9ba901e218a5
2015-08-13use sc::divide() for -fsanitize=float-divide-by-zero triggered by unit testEike Rathke
Change-Id: I370f2f5e3e0ceb40051cbf2f806072f4fd213811
2015-08-13add sc::divide() for defined -fsanitize=float-divide-by-zero behaviorEike Rathke
Change-Id: I3af85344119ca0056a127a5278e8993f9d79e2f9
2015-08-13sc: fix LOKit invalidate setPartHenry Castro
The bindings invalidate correct tiles. Change-Id: Id28a7a78157030243ef1ad798daba9583746f0d3
2015-08-13sc: LOK_CALLBACK_DOCUMENT_SIZE_CHANGED callbackHenry Castro
Handle the LOK_CALLBACK_DOCUMENT_SIZE_CHANGED callback. Change-Id: I855b1e23cfc6ec66e2a0eec603e38e9dd1e28cc5
generated by cgit (git 2.34.1) at 2025-03-16 10:04:30 +0000