summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2013-06-27coverity#1038296 Missing break in switchNorbert Thiebaud
Change-Id: I3c0282d731082c32558a527110762dffad01b44b Reviewed-on: https://gerrit.libreoffice.org/4558 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-06-26fdo#65856 allow shift cells in paste special for copy-modeWinfried Donkers
Change-Id: I7a7e13104e7256da9a82e16e14ddfa04e35e7f8a Reviewed-on: https://gerrit.libreoffice.org/4525 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2013-06-26convert calculation settings dialog to .ui formatCaolán McNamara
Change-Id: I0031094be63f2d8efeac42d5ca560f57af5326b6
2013-06-26fix OptionString to set a correct item sizeCaolán McNamara
Change-Id: I3406b5481991e459ac051868e441c0c04a2f7d5a
2013-06-26coverity#1038508 Use after free (USE_AFTER_FREE)Caolán McNamara
** CID 1038508: Use after free (USE_AFTER_FREE) ** CID 1038509: Use after free (USE_AFTER_FREE) ** CID 1038510: Use after free (USE_AFTER_FREE) Change-Id: I3a1422e252af415536d9303e58ff85763c231921
2013-06-25Avoid ID number clash.Kohei Yoshida
Change-Id: I7fbaad5ffc89e4df0d9ce79595e9e0426802e3cf
2013-06-25Resolves: #i119637# "Case sensitive" in "Special Filter" dialog can not work.Wang Lei
Patch by: Clarence GUO Review by: Wang Lei (cherry picked from commit 0f04f29fbc7c1f3700343304c01e8934b6dad45b) Conflicts: sc/source/core/data/table3.cxx Change-Id: I7ffa7b82dc88b78982af2d5291f6c15b88a81c4c
2013-06-25cleanup options dialog, and add an option for formula grouping.Michael Meeks
Change-Id: I3cb19fb24028bc07d24b56786b6573dc79911bda
2013-06-25The horizontal cell iterator was *still* broken. Let's fix it again.Kohei Yoshida
And add a test for it. Change-Id: If76a67e02ac6ad5199d664850bd8591bd3032f32
2013-06-25unit test for commit:1680a8cd4f4393ec15c4f85cb63b6654117d56d1 (fdo#56960)Noel Power
expand the existing borders import check to cater for xlsx ( and testing for fine/hair border styles ) Change-Id: Ic5c3cd46e0049dbce9997f0881c4d98e0d64e00c
2013-06-25WaE: private field 'mnIndex' is not usedTor Lillqvist
Change-Id: If8c9b4bf1041881bb8fb92c51e2bce22909147c5
2013-06-25WaE: private field 'mrCells' is not usedTor Lillqvist
Change-Id: I0ab3fabb82c839f5194b0e20eb834dd86635a609
2013-06-25WaE: private field 'mbDateTime' is not usedTor Lillqvist
Change-Id: I29967aa15b879cc96cccb686814e594526b200d5
2013-06-25WaE: implicit conversion of NULL constant to 'bool'Tor Lillqvist
Change-Id: I1cbfa318e75ac5c86c0c7d2dbc033601fec3d46c
2013-06-25WaE: private field 'mrAttrs' is not usedTor Lillqvist
Change-Id: I3b87820eee8182e6c4b36d62acfe90cabd830c86
2013-06-25WaE: unused variable 'itEnd'Tor Lillqvist
Change-Id: Idec79adce1f4bbb4003b3e8fb76a1f4a40fcc13f
2013-06-24Replace more characters functions with rtl/character.hxxArnaud Versini
Change-Id: I70f3c31e4b2f44d2b30020a588aaa53d3b63d452 Reviewed-on: https://gerrit.libreoffice.org/4447 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2013-06-24Temporarily disable failing tests. Will look into it later.Kohei Yoshida
Change-Id: Ib7585036116e8d370d6a689e4d9adae209024e6b
2013-06-24Fix incorrect merge.Kohei Yoshida
Change-Id: I1337413e1ee49b7d90671ac517dbb2bd918dbebf
2013-06-24Turn off column storage debugging.Kohei Yoshida
Change-Id: I5d88c94a9cf0bbd194c8c505de7cc34bb9e20500
2013-06-24Use position objects for more efficient element value lookups.Kohei Yoshida
The underlying multi_type_vector didn't have the concept of position objects back when the matrix was reworked. It is now available, and there is no reason why we shouldn't use it to speed things up. Change-Id: Iac75a5584779c16e6eff7fcd577fc3d717c3c2e7
2013-06-24Prevent crash during on-line spell checking.Kohei Yoshida
The new ScHorizontalCellIterator internally uses iterators for each column to track positions. This means that, if a cell value in the iteration range chnages while the iteration is on-going, those internal iterators get invalidated. Allow the client code to rehash the iterators when modifying a cell content during iteration. Having said that, it's best not to modify cells during iteration. Change-Id: Ida453d4f883e1fbcbab4eb0401e37fea8c0b901d
2013-06-24Fix my wrong logic in row info iteration.Kohei Yoshida
Align the array position of RowInfo by comparing its nRowNo value with the current row number. Change-Id: Idd26636cac0ba4ade1b538dd68580b469611da04
2013-06-24Make them officially non-copyable.Kohei Yoshida
Change-Id: Ie8f8c2227b35ffb81f902458ce1b0a732b430b53
2013-06-24A little more cleanup.Kohei Yoshida
Remove CELLINFO macro, and rename nArrX and nArrY to nArrCol and nArrRow. Change-Id: Id105cfefc44e454be2df96a4084dee9185435fab
2013-06-24Rename parameter names for consistency.Kohei Yoshida
nCol and nRow are better than nX and nY etc. Change-Id: Ie92d4e2727a1100736610a3876721d61e8279b15
2013-06-24Incorrect way to initialize a multi_type_vector.Kohei Yoshida
Change-Id: I5db7923be8444db8a0cb1a6766f967d731776535
2013-06-24Don't allow outside code to set text attributes.Kohei Yoshida
Also, use position() to update the value, to avoid performing position lookups twice (once for getting the current value, and once for setting the updated one). Change-Id: Iaa1575a4938b996266c01c8b3170e6a65b871961
2013-06-24Avoid having formula cell directly update text attributes.Kohei Yoshida
This would cause column cell and text attribute arrays to go out of sync, because the formula cells may be stored and interpreted in places such as change track and conditional formatting. We still need to find a good way to mark text attributes "obsolete" when formula cells are re-calculated. Change-Id: Ida612806d3afec23c5ae501f2fc8cc7d52e019a8
2013-06-24Add more calls to CellStorageModified() when it's called for.Kohei Yoshida
Change-Id: Ib7a7abd82060b19f7911f1fef5ccccff5d850055
2013-06-24Remove unused method.Kohei Yoshida
Change-Id: Id49307f8b7050e1f95cd589421f01a85b4e992b2
2013-06-24Fix a bug in "find all" search, and a test to catch it in the future.Kohei Yoshida
Change-Id: I296d2dff65da55cc86e10a78eb9c768a924fcddd
2013-06-24Turns out ScHorizontalIterator was still broken. Fix it for real.Kohei Yoshida
And a unit test to accompany the fix. Change-Id: I41e9451049d3c6ab7b3fd7904bcef3675979884c
2013-06-24Make sure to set the cloned formula cells dirty during undo / redo.Kohei Yoshida
This fixes the last failed unit test from ucalc. Change-Id: I37a79e444084397629cac77e2137377cd555a89c
2013-06-24Fix ScCellIterator, which also fixes matrix handling in the formula engine.Kohei Yoshida
This one alone fixes 2 unit test failures. Change-Id: I3392f4567888447d867ed29f7ecda2474fae1547
2013-06-24Add Dump() method to ScMatrix, which is useful when debugging.Kohei Yoshida
Change-Id: I45e6c28b58a03782814ef1089b49a52b873573a6
2013-06-24Update references on all cells.Kohei Yoshida
Passed row range is the range of moved cells, not the range of cells to update. This alone fixes 3 unit tests. Change-Id: I4cb154879c6c33bc277bc2ab136f7580c35e479e
2013-06-24Fix the horizontal cell iterator.Kohei Yoshida
I got its logic totally wrong. Now it works. Change-Id: I79e556da19c7c0b0d8cecbb4875d6d21d5ec4208
2013-06-24Same fix for fill series & some cleanup.Kohei Yoshida
Change-Id: I2f741305ac64c221c5af8ab99f3ddff0ce56f458
2013-06-24We need to clone the source cell value to prevent crash.Kohei Yoshida
If we don't clone this, the original string value would become invalid after the first insertion, which may cause a reallocation of the array that stores the cell. Change-Id: I5b1bb5f378ed5503169fce75fcbc7aeb85c5ed6e
2013-06-24Don't forget to return true if we are successful.Kohei Yoshida
Else we'd never get out of this inifite loop.... Change-Id: I96e072eb79cce77302b27cad42da31f9a66c3401
2013-06-24Have the clone handler handle the text attr array as well.Kohei Yoshida
In order to handle the special case of cell removal. Change-Id: I7782232ce0fe6c0248c40482ec62d909d2dfe621
2013-06-24Use template functions to remove these duplicate code blocks.Kohei Yoshida
Change-Id: Ica293362fefbe1d8492bdda88dd1a09e4f16c1e6
2013-06-24When deleting cells, be sure to delete the corresponding cell attrs as well.Kohei Yoshida
The cell and cell attr arrays must - be - in - sync - at - all - times. Change-Id: I2854c977eada389e5b9d908b97dd3fa78fc62097
2013-06-24Don't bail out on good condition.Kohei Yoshida
It's a good thing to have found a table to work on. Change-Id: I9b42ebb20041756b6086490dac4264d17369f83f
2013-06-24Leave the RowInfo's for empty cells unfilled.Kohei Yoshida
Else empty cell regions would get skipped and the non-empty cells would get displayed at incorrect row positions. Change-Id: Ica8d1c654458e0ea508e8f00846180d89bfe8804
2013-06-24Fix a bug in the find area position code for the upward direction.Kohei Yoshida
And a test to catch it. Change-Id: I7582b5bca5309f247b44e8cbaa29feda838e6d99
2013-06-24Compiler warnings.Kohei Yoshida
Change-Id: I79b8370429bccaf8467a5c87ee5b68b643fb2f75
2013-06-24Remove these file entries.Kohei Yoshida
Change-Id: I00c6e996d2a533c2434df152752a09edee9a3fa5
2013-06-24Put ScBaseCell, ScValueCell, ScStringCell, ScEditCell to eternal rest.Kohei Yoshida
You had your day. Now it's time for us to part ways. Change-Id: I4bd5797adf2091387cacaf6474069c3f9f20c134
generated by cgit (git 2.34.1) at 2024-12-27 20:41:25 +0000