summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-12-11Fix typosAndrea Gelmini
Change-Id: I667aaaab0bc57bd6a0a3ea9cb2b837e124031627 Reviewed-on: https://gerrit.libreoffice.org/46221 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11tdf#114342 move recursion guard to encompass threaded path tooCaolán McNamara
Change-Id: If815d3faeb72fd8a176225fb80f87ee584ece3ba Reviewed-on: https://gerrit.libreoffice.org/46195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-11Improve set up of test objectsJens Carl
Improve the set up of the test objects by either adding an assert that a valid uno::Reference<sheet::XSpreadsheetDocument> exists or adding a message to existing asserts. Change-Id: I21af3a168eeae232edc8ef6787c439279e52d266 Reviewed-on: https://gerrit.libreoffice.org/46176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-10lok: calc: fix: the last col/row headers were not collectedMarco Cecchetti
Change-Id: I14b168dea9c1f1565dc973bf8ac07f3222b3eb9d Reviewed-on: https://gerrit.libreoffice.org/45791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-10lok: calc: fix: CTRL+RIGHT => crashMarco Cecchetti
Change-Id: I5c127aa4cbdca5e13d2329c1fb68f466464fe432 Reviewed-on: https://gerrit.libreoffice.org/45790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-10Fix inconsistent naming of a variable.Kohei Yoshida
Change-Id: I769d95a9800919b2241d48de246bee7fdbaa7996 Reviewed-on: https://gerrit.libreoffice.org/46170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-09Remove __ORCUS_STATIC_LIB defines.Kohei Yoshida
Since orcus is now integrated as dynamic shared libraries, we don't need these defines (in theory). Change-Id: I33ea2e862ecc23becf5d01173d3fb31c03797159 Reviewed-on: https://gerrit.libreoffice.org/46166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-09tdf#113715 Fix .uno: names appearing in the customization dialogMaxim Monastirsky
Change-Id: Ia4a4231acf2f15ebf58f2acd02b7fc0ab5a88072 Reviewed-on: https://gerrit.libreoffice.org/46062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-09Name it what it is, the format category for the sidebarEike Rathke
Change-Id: Ice6bbfc5f9412ba2d7bce7fb63782a12b48304a1
2017-12-09Rip out already masked out css::util::NumberFormat::DEFINED in casesEike Rathke
Change-Id: Ic769a755fba5cf89596509098ec6dff4fc011598
2017-12-08GetCurrentNumberFormatType() mask out the user defined bitEike Rathke
SvNumberformat::GetType() includes css::util::NumberFormat::DEFINED whereas SvNumberFormatter::GetType() does not. For the type determination we don't need the user defined bit, or even don't want it to be a different type. Change-Id: I713eeb25af01110a0f27bc0c082a7483efdf55db
2017-12-08We already have the type, use itEike Rathke
Change-Id: I77e968e91d6ba44df8a70453f90d11249845a7b3
2017-12-08A "standard" format does not necessarily mean the General formatEike Rathke
Actually there can be up to three and most times are at least two (short,medium[,long]) of which usually the medium default is General. Change-Id: Iab853fbaa2db3dca488ee40f63271ccd55b6b517
2017-12-08Avoid iterating over selected cells' attribute rangesEike Rathke
Change-Id: Ieb233f6e952dfea0461976c3a7ea9df862f72969
2017-12-08Call GetItemState() only once per WhichID loopEike Rathke
Change-Id: Ic14015692bc934f06fb8371216ae5e3e1afe5afd
2017-12-08Slightly change state method logic, tdf#86085 follow-upEike Rathke
It is unnecessary to obtain the SvNumberformat, we already have the type information of the selection, so use that if the item state is not DONTCARE. Also, SfxRequest::Done() needs to be called in the excute method to flag the slot execution as not cancelled. Change-Id: I2fbb8df9b8233fc45552540b996bc6b45a16cbc2
2017-12-08tdf#45904 Move _XDatabaseRanges Java tests to C++Jens Carl
Change-Id: Iee6753fd60fefc1ecd17ba8fe0acef58f17d64e6 Reviewed-on: https://gerrit.libreoffice.org/46076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08tdf#86085 add slot for toggling thousands separatorJim Raykowski
In preparation of adding a button to the toolbar. Change-Id: Icd97f828def1aacbb92297e8e74bdd2310c4d0f8 Reviewed-on: https://gerrit.libreoffice.org/45731 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-08GetMarkableObjCount() is only compared against 1Matteo Casalin
Change-Id: I390b260fe481c7db73a065dd271c78a5df188ccc
2017-12-08Adapt description to realityEike Rathke
Change-Id: I24133fb6c52bd7500037364120cb11d1b1f099c2
2017-12-08Fix segfault when ScDBDocFunc::AddDBRange is called ...Jens Carl
multiple time with same name. ScDBCollection::NamedDBs::insert() use an unique_ptr to hold ScDBData* and if the insert isn't a success we don't have clean up with delete. Change-Id: I9b24834ea2e2dfd67b07438e6c4789ad0c01b888 Reviewed-on: https://gerrit.libreoffice.org/46075 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-08sc lok: 1 view has 1 clipboard to transfer dataHenry Castro
In tiled rendering case, each view copy and paste the contents of the clipboard associated with the view Change-Id: Ic7b0d38ce4741af8c2053926ffd5172ab81aaaf5 Reviewed-on: https://gerrit.libreoffice.org/41113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-08rtlRandomPool: remove pointless seeding with system timeThorsten Behrens
Change-Id: I88647a66a72d092303560a4348ce3dc55ee6c321 Reviewed-on: https://gerrit.libreoffice.org/46055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-08loplugin:salcall vcl builder methodsNoel Grandin
these don't need to be SAL_CALL, and the function pointer definition was not annotated SAL_CALL either Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e Reviewed-on: https://gerrit.libreoffice.org/46067 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08clang-tidy modernize-use-equals-default in sc/source/uiJochen Nitschke
Change-Id: I827e05835838508eb83053a3de80dfa5f53cb685 Reviewed-on: https://gerrit.libreoffice.org/46046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08simplify construction of a const vectorJochen Nitschke
Change-Id: I9860e6dc113df6d2d95f75df647a54bd8c9a5c1d Reviewed-on: https://gerrit.libreoffice.org/46054 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08tdf#45904 Move _XDataPilotField Java test to C++Jens Carl
Change-Id: I5ba1733a8e675048366651aa5f3affc9c249622c Reviewed-on: https://gerrit.libreoffice.org/46066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08tdf#45904 Move _XDataPilotTables Java tests to C++Jens Carl
Change-Id: I5a452f10799f78a6f83136bec4e1346c4ec8edf8 Reviewed-on: https://gerrit.libreoffice.org/46063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08Revert "tdf#113861: Unittest for chart datatable labels expansion"Eike Rathke
This reverts commit 51cdf6248dbdf7a5dcddd2128bbb8f889cec25d6. It breaks all Linux debug builds. To be investigated. Change-Id: Ic0cd080e249aff80b73f2338ab5aae4b32f97793 Reviewed-on: https://gerrit.libreoffice.org/46058 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-08Key must be sal_uInt32 instead of sal_Int16 SCCOL, tdf#113861 follow-upEike Rathke
FormulaTokenMapMap key is bit masked left shifted tab value plus column value. And as FormulaTokenMap key was changed from sal_uInt32 to SCROW (which is correct), use that type when assigning. Change-Id: I4c76330378e64cb7dc06a956cbf2c23f4428b658
2017-12-07coverity#1425723 silence 'Wrapper object use after free'Caolán McNamara
Change-Id: Ibcc0e5f28910bdd15c94579d754de3698ac8beb1 Reviewed-on: https://gerrit.libreoffice.org/46035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-07lokit: add .uno:DocumentRepair commandHenry Castro
Change-Id: I5b13ea6f4785bc91c29111fa63c4a1b0ea9b2660 Reviewed-on: https://gerrit.libreoffice.org/38908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-07tdf#113861: Unittest for chart datatable labels expansionVasily Melenchuk
Change-Id: Icfa10b1e75c801a9a025c0173bd8a34e362f049e Reviewed-on: https://gerrit.libreoffice.org/45670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-07Translate german variable nameUlrich Gemkow
Change-Id: Ic43d47cfeac01c263422fcf8d596d62826f6981b Reviewed-on: https://gerrit.libreoffice.org/45915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-07Assert pDrawView even to spot bad usageEike Rathke
Change-Id: Id33df9548085f8ab5cea6866664b4bed7c779c63 Reviewed-on: https://gerrit.libreoffice.org/46023 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-07Check pDrawViewEike Rathke
Change-Id: I88351676e7a11800b84b64afc57f91dddaed8eb6
2017-12-07aDrawView -> pDrawViewEike Rathke
Change-Id: I2e0a3157ae00a248c3a92d6bb8ab1ed61b72b1a9
2017-12-07Remember ScViewData* and further check ScDrawView*Eike Rathke
Follow-up on commit 3809655e6d554dbc6c74b11597c540c4a62d4c09 Date: Thu Dec 7 00:06:36 2017 +0100 sc: don't crash on loading comments Seems filters call ShowNote before a view is set or something. Fixup for 25555c50ad2a57c1b2313f39b8132ac5e80a45fd. This "best current view" looks a bit fragile anyway.. Change-Id: I7012e4d0e10128b21ece304507b204976a9e03db
2017-12-07loplugin:constparamsNoel Grandin
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07tdf#45904 Move _XDataPilotTablesSupplier Java test to C++Jens Carl
Change-Id: Iaea5b7abc0a289035c7a230c0034d2422cc4ae5f Reviewed-on: https://gerrit.libreoffice.org/46001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-07sc: don't crash on loading commentsThorsten Behrens
Seems filters call ShowNote before a view is set or something. Fixup for 25555c50ad2a57c1b2313f39b8132ac5e80a45fd. Change-Id: I9a69bf28b17cb16df7f1b1d06d9d3168da4a34b5 Reviewed-on: https://gerrit.libreoffice.org/46000 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06Prevent out-of-bounds access, tdf#114228 relatedEike Rathke
Such document access should be validated, specifically if it's called from accessibility. Change-Id: I67fa14c7fb1bf3885fc009428b981149f3f448fb Reviewed-on: https://gerrit.libreoffice.org/45978 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-06tdf#114228: fix crash when deleting sheet in specific caseJulien Nabet
1. Create a brand new ods file 2. Select L12 (so cursor is obviously on sheet1 L12) 3. Create a brand new sheet (and cursor is on sheet2 A1) 4. Delete sheet2 It crashes with gtk3, see https://bugs.documentfoundation.org/attachment.cgi?id=138199 As indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=114228#c5 the tab number is wrong Reporting cursor management later in ScTabView::SetTabNo prevents from the crash Change-Id: Iea307267d2cdcf1c01f7e72f45b6a68aeef26fa1 Reviewed-on: https://gerrit.libreoffice.org/45911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-06assert on export of fdo69698-1.ods to pdfCaolán McNamara
since... commit 3af8a4faf5e20ccae2386052697713da160afb16 Date: Wed Nov 15 13:10:40 2017 +0300 tdf#113861: Less aggressive expansion of chart headers. In this example nAllColCount is 3, nAllRowCount is 5, the columns available are 0, 1, 4 and the rows are 20, 21, 22, 25, 26. So I assume, comparing to the original version, that its not the actual row and column we want, but the index of the row/column into the range provided Change-Id: I568c561a8c5f0b2ee84590293bed8e302d5dda75 Reviewed-on: https://gerrit.libreoffice.org/45811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06coverity#1421089 seems to be really reporting missing move ctors/assignmentsCaolán McNamara
Change-Id: I434eebac395bbb53a0c586a43568f64ec3fb8448
2017-12-06loplugin:salcall handle virtual methodsNoel Grandin
Change-Id: Iab95db31188ea2914a46d63a7ebef3d825e6ec42 Reviewed-on: https://gerrit.libreoffice.org/45851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05ofz#4530 Null-dereference READCaolán McNamara
Change-Id: Ibc5fbb021589b22bbcac0062366e2267839b09e7 Reviewed-on: https://gerrit.libreoffice.org/45873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05tdf#45904 Move _XFunctionDescriptions Java test to C++Jens Carl
Change-Id: Ie2c8e55cabd6adcd523baf2f75c5f2decaf8fe87 Reviewed-on: https://gerrit.libreoffice.org/45772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
generated by cgit (git 2.34.1) at 2024-12-29 17:30:33 +0000