summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-03-09fetch/set/clear primary selection without intermediate vcl::WindowCaolán McNamara
the intermediate layer doesn't do anything useful Change-Id: I00564f43db8914445ea4013c6f387c7d7c783427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09Drop "32" from names of SbxArray methods taking 32-bit indicesMike Kaganski
... a leftover from times when there were methods for 16-bit as well as for 32-bit indices. 16-bit indices were removed in commit 62f3f3d92aa204eaaa063b30d7ade44df501b997. Change-Id: Idf8b1160e68e8b303cf75ea79dd7dbb3bd00275d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112187 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09let ScLinkedAreaDlg have a Widget parent instead of a WindowCaolán McNamara
Change-Id: Ida871186e5d15290ed2520b18651bad211799c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09fix ScFlatBoolSegmentsImpl delayed setup with threads (tdf#140754)Luboš Luňák
Change-Id: I258263f6a15e7098a2292ba7f3336fcaaf5224ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112184 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-09defer getting toplevel for color picker until we need itCaolán McNamara
Change-Id: I60f4ded47f7d80b397647ea3344e83a5dfd1b11e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09decompose ScNavigatorDlgUIObject and use sub components directlyCaolán McNamara
Change-Id: I817d0e201804dce3e83d204702ff236f5689ebb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112148 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09fontwork: insert in the center of LOK viewSzymon Kłos
Change-Id: Iabde4ee927546b0e396c4fbd6d0099fa82240166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109968 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112163 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-09Make sal/config.h the first in pchMike Kaganski
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-08autofilter: handle click for scaled dropdown buttonSzymon Kłos
Missing thing for commit: 68892230ddcde135e9951047a3621438eb7987d0 autofilter: scale dropdown button according to zoom level rendering was scaled but click position was handled using non scaled button size Change-Id: I599b7e6aef39e8b5225b53423125f2b271597a46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110646 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112160 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-08pivot table: make subdialogs of pivot table dialog asyncSzymon Kłos
Change-Id: I2c1b26ebe661a2f66bc7bf94e4f3ede2fc5e18b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107775 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112095 Tested-by: Jenkins
2021-03-08default to 'contents' hidden until toggled to floating modeCaolán McNamara
Change-Id: Iff671e9f8d0a41d4ed83f8fe05b70998558590b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-08tdf#133260: move unittest to function testXisco Fauli
Change-Id: I602f83e1a5afd0ab05c35b848a32475cac3b21ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111982 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-08tdf#140796: Wrong English string for U+2060 characterJulien Nabet
Rename "No-width No ~Break" to "Word ~Joiner" + replace pattern "ZWNBSP" variable names by "WJ" Change-Id: I95a874a9d2d20a30d2c4c3add6041adbe72d872c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112055 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-08clean up some more dynamic/static castingNoel
using a hacked version of the staticdynamic plugin and some judgement Change-Id: I5e6668b19320025e419f84bebceade4239577729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-08loplugin:refcounting check for one more caseNoel
where we might be holding something newly created by pointer instead of by *::Reference Change-Id: Ife6f7acae4252bf56dcdeb95d72e43c523444f97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07tdf#107459: move unittest to function testXisco Fauli
Change-Id: Ic509ba1451e5f59e2f61a37816132ef5bb9ac440 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111981 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-07tdf#140833 show ScHeaderControl help tip after double click time has expiredCaolán McNamara
so under gtk the popover isn't active when the double click is processed by gtk because under load on wayland the double click is getting handled by something else and getting sent to the the window underneath our window Change-Id: Ie3afcf45c69b7b947b1aeb787478f947deca9307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-07ref-count SdrPageNoel
which simplifies ownership handling, particularly with regard to undo/redo Change-Id: Ie8f300ebfdae6db3c06f78a87e35a07497d6b825 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07loplugin:staticdynamic now with extra saltNoel
because it wasn't quite there yet - now checks for casts with and without const, because const doesn't really matter here. Change-Id: I319025b2095a803fcaad2a7a696d2730b7fd2f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06update pchesJulien Nabet
I just used ./bin/update_pch.sh Change-Id: I06a7f36eb4c511b8d6c6477fd87e57f0d9702457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-06replace GetOptimalSize with Container::get_preferred_sizeCaolán McNamara
Change-Id: Ie014a3e48c1d05a91afd0db969e0af21fa84eb71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112027 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05don't use the vcl::Window parent to derive a treeview sizeCaolán McNamara
Change-Id: Idee74fbdf45574fbb7997498062aaac0fb11eb74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111996 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05tdf#115879: sc_logical_functions: Add function testXisco Fauli
Change-Id: Ia6b230564911f05b1d19669f4137fc3892619a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111983 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-04SidebarPanelBase is always created with a PanelLayoutCaolán McNamara
Change-Id: I825452fbd56435edcc0a2ffb7abe0f834bf10fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04autofilter: scale dropdown button according to zoom levelSzymon Kłos
Change-Id: I4f8a16e196bc33ea5b29fda0edc1f773a24e28db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110259 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111896 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-04tdf#116215 sc: move UItest to CppunitTestViKrAm-Bais
Change-Id: Iae6076bd34331e7ddf441a7d6de22ad9b784b0a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111867 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-04tdf#93415: sc_ucalc: Add unittestXisco Fauli
Change-Id: Id06ceb081459831637ee78e0a049cf7099772372 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111942 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-03tdf#42481: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: Ie8bccee362dc14ce3b5d635151f46564026ccd48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111938 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-03autofilter: show menu only if has itemsSzymon Kłos
Change-Id: Ie6b7158e74a8bdccdbafaa9b6d9b09b3796088ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108846 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111895 Tested-by: Jenkins
2021-03-03tdf#72470: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: Ia43626e11c37f06eb3534182187d4255a9336fd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111850 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-03loplugin:refcounting in scNoel
Change-Id: I0b808785e54bf1dfc9387a649aacf731b2f34d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111801 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-02Revert "tdf#43175: Adapt ranges when copying or moving several sheets"Noel
because it causes failure in the tdf101894 part of UITest_chart This reverts commit 3078044653f1e1b0a055c47eeb8d27834c07268a. Change-Id: If187b7a1125eb6f85bb7329bd9029dc8236a85f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111822 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-02lok: sc - suppress LOK editengine events for the calc input bar.Michael Meeks
The calc input uses an EditEngine - but it emits events as if it is part of the document - as well as emitting events as if it is a dialog window. This causes horrible jumping artifacts to the top of the document with word auto-completion and typing in cells a few page down. Also remove obsolete tweak to turn off autocorrect for LOK, since it was contradicted by: 1f0943e5e9432f96daff9f3b006388d5bc7415b2 Change-Id: I7352cd3b5ca6d18645cfd9e18959b0e44ec969d7 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110422 Tested-by: Jenkins
2021-03-02Implemented MoveShapeHandle uno command for scmert
Change-Id: I5f81348cd778d7fbcb3b4e721fbf0412c4f5753d Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111195 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111514 Tested-by: Jenkins
2021-03-02tdf#43175: Adapt ranges when copying or moving several sheetsOuyang Leyan
When copying several sheets at once using the "Move or copy sheets..." feature, the ranges were not updated, in charts for example. Same when moving a sheet and choosing a new name at the same time. Change-Id: I0d05f2d123dfe1174ba126d7f73845988ec1e983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-01tdf#118086: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: I90d8a58ef4d7304a0c1788bf3f074bc9589965e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111759 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-01tdf#116421: sc: move UItest to CppunitTestXisco Fauli
Change-Id: I9a7913f631fbf970faa2e3f50710b7e67a19c558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111751 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-01uitest: sc: re-enable test to see if it still failsXisco Fauli
it doesn't fail for me, let's see for others. Change-Id: I7650cfe8378ed6876472e108b6a658f2955f1cb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111744 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-01tdf#140462 sc ODF import: fix empty autofilter columnsBalazs Varga
(followed a date type autofilter column) by setting QueryType to ByDate at ODF import. Change-Id: Ie78cb15885dfb1e40c9e8ac993ff79b19fe17993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111070 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-01drop intermediate vcl container for ScFilterListBox floating toplevelCaolán McNamara
Change-Id: Ib76fe7658f5f6817f048b1490be59bf24fc26e11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-01FloatingWindow::StateChanged will set the same ILibreOfficeKitNotifierCaolán McNamara
as set here so it doesn't seem necessary to explicitly set it. The very similar ScenarioMenu doesn't do this. Change-Id: I6454cbdcb464b401df6cb1d6171fc2212f3be3ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-28remove unnecessary MouseButtonDown forwardCaolán McNamara
I don't see how this scenario can happen, and if it does, why we would want to send a MouseDown to the filter list. This hunk appears in the "initial import". There is a "On OS/2 when clicking next to the Popup menu..." comment on a different popup in this file so maybe there was some workaround for some condition that no longer happens. Change-Id: I15b4d57259047a20822685a00e1bf5b00aa21a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111715 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-28lok: mark calc document as modified when adjusting split-panes (2)Andras Timar
Change-Id: I91231770ebf02218ae0380ddf76a8664dc6e5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111589 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-02-28tdf#124701 sc status bar: hide bad filtered row countBalazs Varga
After loading the document, positioning the cell cursor on filtered data, the status bar showed always the maximum amount of the filtered data, e.g. "9 of 9 records found", regardless of the real result, e.g. "6 of 9 records found", because the ScTable::Query() function will not run until we refresh the filters. As a workaround, we hide the (often false) data in the meantime. Change-Id: I904ca0c55e3afb276b11491c05430f985557f914 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110032 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-28tdf#124176 Use pragma once in sc/source/core/openclSuhaas Joshi
Change-Id: I90253fdf9528116379cf06cb00a3342944e3351a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108918 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-26Update Calc home tabandreas kainz
Change-Id: Iecdfe016878673d22d5afca3b9ef70fcbe2b35ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111257 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-02-26tdf#64401: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: I624d4f94899634fa7b65768b7d5bbf82d786cc57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111623 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-26lok: mark calc document as modified when adjusting split-panes.Michael Meeks
Change-Id: I592ee4dc4317f27fae24141b2052475ef26e9fc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111582 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-02-26loplugin:refcounting in svlNoel
Change-Id: I0009464121faf6dd36793b031d892f492b56187c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-26tdf#131000: sc: Add UItestXisco Fauli
Change-Id: Icb2737de1e9e14c55cf4a2f999d1d0585c98b895 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111570 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>