summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2014-11-07Make SdrGrafObj swapping methods private.Zolnai Tamás
Plus remove some useless call of them. Change the tests accordingly. Change-Id: I47a50b5734d799ac02ee7221c95f82415afb9497
2014-11-07Test for swapped out image loss during Calc exportZolnai Tamás
Related to the bug fdo#52226. The problem was that the images were somehow swapped out but were not swapped in during export. Test the main Calc formats: ODS, XLS, XLSX, HTML. Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: I4835ff2960fbd11cc9750ed3da20df26cd6cbaba
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06Don't be too modern for MSVC2012Tor Lillqvist
Change-Id: Ibdee512a330d4520a32a56d2f1703dc2eab4981f
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06Bin unused include files, thanks to Andrea GelminiTor Lillqvist
Change-Id: I848505b1d4ff03779b89a08d4aeefd6ea0ff205b
2014-11-06Don't be too modern for MSVC2012Tor Lillqvist
Change-Id: I6f9049f6b5261f6099e97c7f10d6ab6ea7eaab9b
2014-11-06Try to get the SC_DLLPUBLIC placement rightTor Lillqvist
Change-Id: Iddf7cad771d271e848ba3abc1c144b9c313cdb99
2014-11-06Fix error: call of overloaded 'append(int)' is ambiguousTor Lillqvist
It is sal_Int32 that we want. Change-Id: Idbe34ff9c0f39ad73ed7df9185512921294b3b4e
2014-11-06Bin unused "description" labelsTor Lillqvist
Change-Id: I8710b698904d5c89644633bb53b78a95dcef7d7b
2014-11-06Fix non-dbgutil build where OpCode is sal_uInt16 and not OpCodeEnumTor Lillqvist
Change-Id: Ie88b0b23b7b6f688f920f5aadcf711ba15602686
2014-11-06Bin unnecessary variablesTor Lillqvist
Doing .ui "manually" is not *that* verbose;) Change-Id: Ide50258174e86cc94975a33c5c0e5c663ae8d77c
2014-11-06Intermediate commit: start on whitelist/blacklist of OpenCL implementationsTor Lillqvist
Change-Id: I5a6ef8f5e428ec4e62b3fdac8fe3e63f0ae58f1b
2014-11-06More work on the new OpenCL optionsTor Lillqvist
Now the new options show up in the "Detailed Calculation Settings" dialog and are saved and restored from the per-user configuration. The code that manipulates the "Detailed Calculation Settings" dialog is quite ugly with all its manual hiding and showing of widgets depending on which detail it is that is being edited. This also means that the dialog cannot be designed using Glade. But no time now to re-work this. Change-Id: I03a3a51d902084e73aab5a787b588d22ea7578f2
2014-11-06Check also unary and binary operation opcodes for presence in subsetTor Lillqvist
Change-Id: I316ebdb017d512e72d0ad15a847802bca0e15814
2014-11-06Add also parameters for the opcode subset to enableOpenCL()Tor Lillqvist
In CppunitTest_sc_opencl_test we want to explicitly disable subsetting and use OpenCL maximally, to match how it used to work. Change-Id: Ie900adb5fa58b7cd1111169e44efd70d8cac5256
2014-11-06Indent the generated OpenCL a bit sanerTor Lillqvist
Change-Id: Ie180d47558bdb9496ef55e39652f33ef52d1addb
2014-11-06Don't use OpenCL unless the function is in the subset we supportTor Lillqvist
Change-Id: I6c6fcc492f338cd8994bbc781bbf71abb6bf5057
2014-11-06Don't use OpenCL unless the group is long enoughTor Lillqvist
Change-Id: I37d54e39186fca2653717bb364072a2b283bcfb9
2014-11-06Add a setting for what subset of functions we use OpenCL forTor Lillqvist
Change-Id: I9ecea99a921a9230fa80f813627db6cdf7ed5875
2014-11-06Avoid crashTor Lillqvist
Sure, this is probably "defensive coding" and the root cause is my other changes... Change-Id: Ia888921fddc48dc022a3205c7e0abc7e2160cf5c
2014-11-06Add more detailled configuration for OpenCL use, and make OpenCL default to onTor Lillqvist
Add a boolean whether to use OpenCL for just a subset of functions, and a numberical minimum length of a cell group for OpenCL to be used. No functionality or GUI for this yet implemented, just the setting fields. Make whether to use OpenCL default to "on". Sure, this breaks stuff right and left for now. Fixes and workarounds later. Change-Id: I09b7aff9c7d1845df2bf01f09616e646373f030c
2014-11-06fdo#75673 - Removed duplicate insert entriesJoel
Inserting audio and video was duplicated in media and object menus. Removed from object to match every other component. Change-Id: I221e73184b835554c8c6a9293a8042a24d429030 Reviewed-on: https://gerrit.libreoffice.org/12276 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-06sc: remove some unused codeNoel Grandin
Change-Id: If64738067e3b35523272285ae2606c6c06d4c121
2014-11-05coverity#1242614 Untrusted loop boundCaolán McNamara
Change-Id: I913e14d30d54b4b370c14017b0702005c23c4fc4
2014-11-05markup with event type not checker typeCaolán McNamara
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#85809 - MENU: Rearranging the Insert > Media submenuYousuf Philips
Change-Id: I34f753904a232a7b338736eee60f9bc225cd8f7f Reviewed-on: https://gerrit.libreoffice.org/12226 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-05Register ParaLineSpacingPopup in sc and sdMaxim Monastirsky
The Sidebar Paragraph panel is used there for text boxes. Change-Id: Icff81d50c0341f02d29e36d0c3b99478a872a48f
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04Resolves: fdo#69049 Format in 'Outline Numbering' not saved anymoreCaolán McNamara
Change-Id: Ibd129d989a32eec2f63413d1ed09962ad3b38c68
2014-11-04 calc ScTable::ReplaceAll : avoid calling GetLastDataPos uselesslyLaurent Godard
Change-Id: Ibb6fb9ea3e524a889de96f560e308a4aa54fa2af Reviewed-on: https://gerrit.libreoffice.org/12248 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-11-04calc ScTable::SearchAll : avoid calling GetLastDataPos uselesslyLaurent Godard
in the loop we are in the same table refactor ScTable::Search too perfchek result for testSheetFindAll-Search value before : 804252982 after : 229861999 Change-Id: I907f1260472bcc5d93b2c6425c342187a5f4c787 Reviewed-on: https://gerrit.libreoffice.org/12225 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-11-04fdo#39468 Translate German Comments - sc/source/core/data/documen{4,5}.cxxChristian M. Heller
Change-Id: I19a2242909dd8519a4819045e039def6e48f2c39 Reviewed-on: https://gerrit.libreoffice.org/12237 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-04remove some unused code in scNoel Grandin
Change-Id: I6cd2acaf361ae1947787b5aacc86b75a6e21c379
2014-11-04Bin presumably obsolete SUNWS crackTor Lillqvist
Change-Id: I83038a7160251e59a2178e54859c2ab8e4bffe2e
2014-11-03fix the PCH after 8e399602ea7aa11a81d704ff6ce8e660df4205b9Michael Stahl
Change-Id: Ia5e05901a066619e0e819b3b06c0a7da3b2de536
2014-11-03sc: clean up Library_scfilt.mk duplication wrt. ORCUSMichael Stahl
Change-Id: Ide3c9987fb15112d5a4c8c2b5e15277b2579ee51
2014-11-03coverity#707956 Uninitialized scalar fieldCaolán McNamara
Change-Id: I690de0eb0db28a25dc6c2e83a6dcba620d7c5922
2014-11-03fdo#84844 Use SvxColorToolBoxControl for border colorMaxim Monastirsky
Change-Id: Id177964ec35d6b5a08c46b8ba96615c2a4729136
2014-11-03coverity#1209103 copy-paste errorDavid Tardon
Change-Id: I9ed3ef809401ecf23e9c1f9bd020cf96049b56f0
2014-11-03fdo#85620 - Changing the label 'Gallery' and having it in the insert menuYousuf Philips
Change-Id: I4deaef9a942b82566bc7dcdc65f2a84441045f91 Reviewed-on: https://gerrit.libreoffice.org/12167 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-03callcatcher: update unused codeCaolán McNamara
Change-Id: Ida4221bfbfe30f7e1abd5c367d8cb8b9edd310bb
2014-11-03fdo#85403 broadcast changes after TextToColumnEike Rathke
Regression introduced with 3d869cda8db03820dea8c4ba463eb155d05e933b for fdo#74014 Change-Id: Ie8ca1e7c15609aaf80b4ecbb6ccffc30a3f79f0a
2014-11-03fdo#39468 Translate German Comments - final bits of sc/source/filter/Christian M. Heller
Change-Id: Ie01e9488c6b8e36c40e6176bc1cac38a93a8087f Reviewed-on: https://gerrit.libreoffice.org/12194 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-03fdo#39468 Translate German Comments - sc/source/core/data/documen2.cxxChristian M. Heller
Change-Id: I9a426f40f8cdce1f1ebe207dd9ada8154d8fde46 Reviewed-on: https://gerrit.libreoffice.org/12195 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-01fdo#60349 - FORMATTING: Icon in Calc toolbar for wrap textYousuf Philips
Change-Id: I04390075006bd0492e0c39c5e1bf4a4eb107ed2c Reviewed-on: https://gerrit.libreoffice.org/12163 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-31i#90076: avoid double-free race condition for ScCellRangesBaseMichael Stahl
This is similar to fdo#72695, just with SfxBroadcaster in Calc. Solve it in a similar way, by putting a WeakReference to "this" into the UNO object so its Notify() can return if another thread is already in the dtor waiting for the SolarMutex. ==11581==ERROR: AddressSanitizer: heap-use-after-free on address 0x6170006fdb08 at pc 0x2b2c4f5b8e3e bp 0x2b2c0b2ad9f0 sp 0x2b2c0b2ad9e8 READ of size 8 at 0x6170006fdb08 thread T262 (cppu_threadpool) #0 0x2b2c4f5b8e3d in ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1448 #1 0x2b2c4f643914 in ScCellRangeObj::~ScCellRangeObj() /sc/source/ui/unoobj/cellsuno.cxx:4751 #2 0x2b2c4f697624 in ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6053 #3 0x2b2c4f69648d in ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6052 #4 0x2b2c4f69661f in non-virtual thunk to ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6053 #5 0x2b2b2c58b6af in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:204 #6 0x2b2c4f5c50ff in ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1752 #7 0x2b2c4f64de58 in ScCellRangeObj::release() /sc/source/ui/unoobj/cellsuno.cxx:4800 #8 0x2b2c4f6a2c08 in ScCellObj::release() /sc/source/ui/unoobj/cellsuno.cxx:6093 #9 0x2b2c4f6a5f0f in non-virtual thunk to ScCellObj::release() /sc/source/ui/unoobj/cellsuno.cxx:6094 #10 0x2b2c053b96fb in bridges::cpp_uno::shared::freeUnoInterfaceProxy(_uno_ExtEnvironment*, void*) /bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:43 #11 0x2b2b2bae80fb in (anonymous namespace)::s_stub_defenv_revokeInterface(__va_list_tag (*) [1]) /cppu/source/uno/lbenv.cxx:383 0x6170006fdb08 is located 264 bytes inside of 728-byte region [0x6170006fda00,0x6170006fdcd8) freed by thread T264 (cppu_threadpool) here: #3 0x2b2c49c980f5 in cppu::OWeakObject::operator delete(void*) /include/cppuhelper/weak.hxx:87 #4 0x2b2c4f5b840a in ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1442 #5 0x2b2c4f5b858f in non-virtual thunk to ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1458 #6 0x2b2b2c58b6af in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:204 #7 0x2b2c4f5c50ff in ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1752 #8 0x2b2c4f5c65ff in non-virtual thunk to ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1753 #9 0x2b2c4af84583 in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() /include/com/sun/star/uno/Reference.hxx:104 #10 0x2b2c4f5bc66f in ScCellRangesBase::Notify(SfxBroadcaster&, SfxHint const&) /sc/source/ui/unoobj/cellsuno.cxx:1570 #11 0x2b2c4f5bdf0d in non-virtual thunk to ScCellRangesBase::Notify(SfxBroadcaster&, SfxHint const&) /sc/source/ui/unoobj/cellsuno.cxx:1645 #12 0x2b2b31dda705 in SfxBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/SfxBroadcaster.cxx:41 #13 0x2b2c4b03f2e4 in ScDocument::InsertTab(short, rtl::OUString const&, bool, bool) /sc/source/core/data/document.cxx:510 #14 0x2b2c4e7ed861 in ScDocFunc::InsertTable(short, rtl::OUString const&, bool, bool) /sc/source/ui/docshell/docfunc.cxx:3007 #15 0x2b2c50b1f415 in ScViewFunc::InsertTable(rtl::OUString const&, short, bool) /sc/source/ui/view/viewfun2.cxx:1855 #16 0x2b2c502e075f in ScDBFunc::ShowDataPilotSourceData(ScDPObject&, com::sun::star::uno::Sequence<com::sun::star::sheet::DataPilotFieldFilter> const&) /sc/source/ui/view/dbfunc3.cxx:2056 #17 0x2b2c4fa8924d in ScDataPilotTableObj::insertDrillDownSheet(com::sun::star::table::CellAddress const&) /sc/source/ui/unoobj/dapiuno.cxx:1286 Change-Id: I4cd0fca46b9b81311bddfab2229ab9abf4c06c4e
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31eliminate duplicated initializationEike Rathke
RowInfo.pCellInfo is already initialized by ctor. Found while investigating coverity#707985 Uninitialized scalar field Change-Id: Ibb41032674ce5f07ed855a62d76648526d09a1ad
generated by cgit (git 2.34.1) at 2025-01-31 22:04:35 +0000