summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2024-06-27Related: tdf#127293 Ignore 'search-criteria-must-apply-to-whole-cell'Balazs Varga
dependency for XLOOKUP and XMATCH because of better compatibility. The idea is to specify, that the global setting 'search-criteria-must-apply-to-whole-cell' is ignored and XMATCH and XLOOKUP always behaves as if 'search-criteria-must-apply-to-whole-cell'=true. That would affect exact search in Match_mode value 0. Users would need to use wildcard or regex to get a match to part of the content. But removing dependency to the global setting increases interoperability with MS Excel. Also the ODF TC will follow that in the final specification of these functions: https://issues.oasis-open.org/browse/OFFICE-4154 Follow-up commit: 17d578ba91f9c78a0e41d19b58183d2214c0b7a4 (Related: tdf#127293 Add new Match_mode option for XLOOKUP and XMATCH functions.) Change-Id: I1317865631d2925eaff72e9c1425d93386c3d016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169582 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Jenkins
2024-06-27xlsx: Don't export notes author when in privacy modeSamuel Mehrbrodt
Change-Id: Id0b3f0aca7bd4e21f41c2a8307964423debcf5bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169616 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-27xlsx: Don't export changes author/date when in privacy modeSamuel Mehrbrodt
Change-Id: I1b1ef4dd75f02cc545721d5458617cfa92b26615 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169453 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2024-06-27Resave with newer Glade versionBogdan Buzea
Change-Id: Id30a7872e3f0d2689f77ece82d138696e3249882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169560 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-27Resave with newer Glade versionBogdan Buzea
Change-Id: Ia53a3474107874d5b97156e8bc9a971db7a1e21a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169545 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-25Fix typoAndrea Gelmini
Change-Id: I6d1130f6d59439420dccbdf94a4df43504e7cd36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169514 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-25tdf#161210 speed xls loadNoel Grandin
instead of applying row styles to all 16384 columns, only apply them to columns that have data. That takes the load time for this file from 19s to 1s for me. Change-Id: Ifec56995e0053938dc5a7ed0d15ae3a173614dd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-25tdf#161210 speed up XLS loadNoel Grandin
flatten XclImpXFRangeColumn a litte, no need to allocate this separately Change-Id: Ic33131626b41ca19b964387b3d7f6e74cefdd91c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169505 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-25Resolves tdf#161641 - Select data area before select allHeiko Tietze
Advanced option SelectRangeBeforeAll to restore original behavior Change-Id: Iab4b4e61dffc1ecf2ffed01a994c9894c84ab74d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169276 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-06-24tdf#161743 Calc Sidebar Functions deck: move focus to document uponIlmari Lauhakangas
Esc while in empty search field Change-Id: I7bb6aaeb69712b293c74bfcf34ab65c4869c860c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169352 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-06-24Resave with newer Glade versionBogdan Buzea
Change-Id: Ia266b96c1cc558ca4eb17194a58a1623c3f3ed54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169392 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-24NFC cleanup duplicate entry in sc/IwyuFilter_sc.yaml #2Justin Luth
found by sed -i -f ref.sed */*.yaml --------------------ref.sed -------------------- { N; s#\([^\n]*\n\)\1#\1#g; P; D; } ------------------------------------------------ meaning: by default it reads in one line from the file then the N; command says "add a \n and read in the next line which leaves a one-line pattern containing 2 lines separated by \n then search for line1\n repeated \1 and replace with \1. likely nothing has happened, so P; print up to the first \n (aka line1) so that we don't lose that line D; delete up to the first \n so that it isn't in the pattern buffer any more, and next search starts line2 and then repeat. Change-Id: Ib5d38af77568f59f36083f5348762d852acaa3e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169047 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-06-24ods: Don't export changes author/date when in privacy modeSamuel Mehrbrodt
Change-Id: I8c542f398bb70da96a64b61a9931398b6a78ea72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169258 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-24editeng: add convenience creators to ESelection All, NotFoundTomaž Vajngerl
ESelection::All() select all text ESelection::NotFound() sets seletion to not found state ESelection::NoSelection() sets selection to no / invalid selection Introduce max paragraph and position constants in ESelection, use for EE_PARA_APPEND, EE_PARA_ALL, EE_PARA_MAX_COUNT, EE_TEXTPOS_ALL, EE_TEXTPOS_MAX_COUNT. Also simplify some ESelection constructs. Change-Id: Ib110c5a730a1deabe4f988baa5a600249b3a31e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169356 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-06-22tdf#161658 Limit new selection overlay to Calc onlyRafael Lima
Previous patches [1] and [2] introduced a contrast white line to the selection overlay that was supposed to affect only Calc, but it ended up affecting other areas of LO, such as the star math editor as well as Writer. This patch makes sure the changes only affect cell selection in Calc. [1] dc243f0122ba656d2630e93bebfb84a2bfe4042a [2] 3c0db898092c2cf6148c01f6c561acc199d484f5 Change-Id: Ie910120e4b71c55ad8c00a905e1204e291a711f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169292 Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2024-06-22fix O(n^2) behaviour when fetching field info from EditEngineNoel Grandin
Change-Id: I324a1814fc1b3321eed5b29922790600e7092c17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169344 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-21tdf#161648 sc a11y: Set a11y names for items in border style controlMichael Weghorn
Set accessible names for the items in the "Borders" control in the Calc Sidebar, "Properties" deck, section "Cell Appearance". Use the same text as is used for the tooltip. With this in place, Orca now announces what each item is about when using the gtk3 VCL plugin, instead of just saying "Button". Move the gla11y suppressions to the .false file, as they have been dealt with now, see doc at [1]. [1] https://wiki.documentfoundation.org/Development/Accessibility Change-Id: Id1856e4b116acad9bf6d14132bc6d9c91a01ae06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169321 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-21Related: tdf#127293 Add new Match_mode option for XLOOKUP andBalazs Varga
XMATCH functions. Introduce a value "3" for parameter Match_mode for Regular Expression mode in XMATCH and XLOOKUP, to seperate the original Match_mode value "2", which was used for both, Wildcard and Regular Expression mode as well. Note: "The ODF TC will follow that in the specification of these functions and at the same time specify, that the host dependent properties HOST-USE-REGULAR-EXPRESSIONS and HOST-USE-WILDCARDS (file format table:use-regular-expressions and table:use-wildcards) will be ignored by these functions." https://issues.oasis-open.org/browse/OFFICE-4154 Also Microsoft Office will introduce this new value for Match_mode in XLOOKUP and XMATCH: https://insider.microsoft365.com/en-us/blog/new-regular-expression-regex-functions-in-excel Follow-up commit: 0ca20dca3349daa303b89251443f550491968a39 (Related: tdf#127293 Add unit test for xlookup regex search mode) Change-Id: Ibcbfa4cf227ab9a9d317d94c1bab8254b1f91822 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169275 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-06-21tdf#146468: Fix typo and move commentsKira Tubo
Fix typo on variable RID_SVXSTR_TABLE_PRESET_OUTER and move comments about consolidating border tooltip strings to solenv/sanitizers/ui/modules/scalc.suppr See comments on Gerrit for more information: https://gerrit.libreoffice.org/c/core/+/169052 Change-Id: Ic5283e568e13023242858850dbce8922e2c80d8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169308 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-06-20Resolves tdf#64028 - Command to retain source cell on cutHeiko Tietze
.uno:CopyDelete copies the cell and deletes the content, assigned to shift+ctrl+X Misses to block the command while in edit mode, see tdf#161712 Change-Id: I479008b0484ef8ced86b709a0dc2bdbfa6c44cb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169266 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-06-20loplugin:unusedfieldsNoel Grandin
Change-Id: I4bc67811e228b4806db9f9b9bf9fb0de0eb36de2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ia216da9bd7764f2d21aaee761a02eafda88d892e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169257 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-20tdf#146468: Match border tooltips in toolbar/sidebarKira Tubo
Update the border tooltips within Calc's toolbar and sidebar so that they have matching descriptions. Also update tooltips in Writer toolbar so that descriptions match across both apps. Change-Id: Ib7c682ed5035fe61d991209c4f2cf7f0a1a08a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169052 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
2024-06-20tdf#161648 sc a11y: Set a11y name for border style button in sidebarMichael Weghorn
Set accessible name for the button to open the popup to select a border style. This is announced by Orca with the gtk3 VCL plugin when the button gets focused as expected. Setting accessible names for the items in the popup still remains to be done, s.a. discussion in pending Gerrit change [1] that's related. (If that gets merged, setting a11y names should probably be done in C++ code, not the corresponding .ui file.) [1] https://gerrit.libreoffice.org/c/core/+/169052 Change-Id: I200e160e64735e8701866428bf51e8b955dcc930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169188 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-19Fix typoAndrea Gelmini
Change-Id: I9bac90a35b82367ba5e6a543e3567b5304cc276b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169212 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-06-19Fix typoAndrea Gelmini
Change-Id: I04f646e812b9c8dcf1a0e207529ece61a74de00d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169239 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-19Fix typoAndrea Gelmini
Change-Id: I77229760404a8739755508a5991d00ce0ceed8d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169158 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-19Fix typoAndrea Gelmini
Change-Id: I782d794bd4acc760ec53e226796a4ac0424fd0d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169168 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-19Fix typoAndrea Gelmini
Change-Id: I7ee174497b9f6ca7256ef71297c20c04b52ecae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169179 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-18Add warning and progress to AutoFormatOliver Specht
Applying AutoFormat to large selections may take really long. A warning has been added to warn users. Additionally a progress is shown while AutoFormat is working. Change-Id: I74909a6243748ebfe0089406ebe947bb48eb93d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167950 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-06-18tdf#131562: move test to svl and extend itXisco Fauli
based on the commit message from 7186541219599e1b51ad35601c2cd015a329f360 "Resolves: tdf#131562 decimal separator may not be surrounded by blanks" Change-Id: I19c2a687663304003566e9d93504f0baf33f1d83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169111 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-18tdf#118226, tdf#161462: sc: Add UItestXisco Fauli
Change-Id: Ifd7b8a92dff30fee25b1431dde0f3426b2f8bab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169083 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-18tdf#37341, tdf#43693: move UItest to CppUnittestXisco Fauli
and remove duplicated test, tdf43693.py, which is basically the same as tdf37341.py Change-Id: Ib29638ecbc2f89e717712ad03afccc70c5aa47ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169079 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-18loplugin:ostr in variousNoel Grandin
Change-Id: I7aa8ed716998a185996482dc561219b398a1c919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-18Remove duplicated includeBogdan Buzea
Was added in https://gerrit.libreoffice.org/c/core/+/165672 Change-Id: I0943e08bdfa200d849ccaa366937eb90d4e76e2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169095 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-18Add SfxItemType to SfxPoolItemOliver Specht
The SfxPoolItem has a new member SfxItemType m_eItemType to compare types based on enums instead of typeinfo() which consumes a lot of time e.g. while AutoFormat is running Change-Id: I033ce67bc9a28ee4790f162380314de85fb4154e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166452 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-06-17tdf#161616: do not set error when XGoalSeek failsXisco Fauli
Change-Id: I2fcec37cd9d22862dd136c97e5b4097e69fd41cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169035 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-17NFC cleanup duplicate entry in IwyuFilter_sc.yamlJustin Luth
from 2018 commit 7dc9fb33db45c269fece6cfec993b124491c68f6 tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[a-e]* Change-Id: Ia6ada37ff06355198d00fbf0f7fdfa0e0aede71c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168896 Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-06-16Fix typoAndrea Gelmini
Change-Id: I3be6bd8effb33183f67d63d910663d2741b24de5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168965 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-16Fix typoAndrea Gelmini
Change-Id: I3d26c49a46f7382b34bd1619cfe7ff09db5e200c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168964 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-16Fix typoAndrea Gelmini
Change-Id: I767eb6e62285434ff70e65f631e8bc77caf02995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168966 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-06-16cid#1603803 Unchecked return valueCaolán McNamara
Change-Id: Id7f4d7a27720856c5e53dab4333a8ecf370004dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-16cid#1603805 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Ieb2c72dbdfec8431bd23da8a5e4844f3c1a5b74e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168958 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-15tdf#158914 add back reusing weakly cached ScAccessibleCellsPatrick Luby
While commit 8e886993f32b7db11a99bdecf06451e6de6c3842 fixed tdf#157568, moving the selected cell rapidly creates a large number of stale ScAccessibleCell instances that aren't deleted until the Calc document is closed. So reduce memory usage by adding back the ScAccessibleCell cache that was in commit f22cb3dfab413a2917cd810b8e1b8f644a016327 now that a new fix for tdf#157568 has been implemented. The new fix for tdf#157568 is to do the following: - Check if the edit engine text has changed. If the input string is different than the edit engine's existing text, force update of the edit engine's text. Otherwise, the edit engine will still to be set to its existing text. - Before a cell loses focus, check if any accessible text changes have occurred and fire text and value changed notifications if needed. Change-Id: I106ad0138d5d834367be59ca625d41a692696d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167961 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-14tdf#68034: sc_goal_seek: Add unittestXisco Fauli
Change-Id: I675d59cd7e22c09ea1c673e016d71f8d3ed404a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168890 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-14tdf#161511: sc_goal_seek: Add unittestXisco Fauli
Change-Id: Icc05195a4870d5bb4f8c5ffc9b3bcae89367a89d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168866 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-14tdf#68034: set the variable cell to value temporarily if neededMike Kaganski
Change-Id: I35fed710862ed87c477686e26bc8c82379c5e5a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168854 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-14CppunitTest_sc_copypaste: inherit from ScModelTestBaseXisco Fauli
Change-Id: I0847ba4455cec24332030e87244c0d9c9ad2ad2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168859 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-14CppunitTest_sc_jumbosheets_test: inherit from ScModelTestBaseXisco Fauli
Change-Id: Ifc35741c0d46dfbf3366696ea70284c382617a8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168861 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-14Flatten a bitMike Kaganski
Change-Id: If021f2edf8e4029d22118a2ed369b21a3a7215da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168836 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-05 04:16:50 +0000