summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2023-06-29loplugin:unusedmethodsNoel Grandin
Change-Id: I95ab7581dec35b113cb657ce8e5ee27c89c73593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29Fix buildMike Kaganski
Failing like ThemeImportExportTest.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class Color const & __cdecl SvxBrushItem::GetColor(void)const " (__imp_?GetColor@SvxBrushItem@@QEBAAEBVColor@@XZ) referenced in function "public: void __cdecl testCellBackgroundThemeColor::TestBody(void)" (?TestBody@testCellBackgroundThemeColor@@QEAAXXZ) ThemeImportExportTest.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class model::ComplexColor const & __cdecl SvxBrushItem::getComplexColor(void)const " (__imp_?getComplexColor@SvxBrushItem@@QEBAAEBVComplexColor@model@@XZ) referenced in function "public: void __cdecl testCellBackgroundThemeColor::TestBody(void)" (?TestBody@testCellBackgroundThemeColor@@QEAAXXZ) C:\lo\src\build\workdir\LinkTarget\CppunitTest\test_sc_theme_import_export_test.dll : fatal error LNK1120: 2 unresolved externals Change-Id: I7a64405e3e8bf774163d8f101681c2c0de892767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153736 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29tdf#73537 - sc: show author and creation date in calc commentsBalazs Varga
in temporory mode. Show the author and creation/modification date of the the comment only in temporory mode. In edit mode, or visible mode, shows only the original text. Change-Id: I2c5856e4c6a813dbef4ad55de319f922daa57f67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153358 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-06-29sc: Add import tests for text, background, border theme colorsTomaž Vajngerl
Change-Id: I03f0ddb42e6491618e56ba98f5bd8befc9ba47a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153506 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-29sc: use ComplexColor for font color (+others) in OOXML exportTomaž Vajngerl
Change-Id: I2544c7ece152323d84faafe1a544e4f89ca466d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152014 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-28sc: prefix m_* ScViewFunctionSet class membersHenry Castro
.. Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153405 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 8276b9593a2a9e3a0d5aaeaadd64369667120303) Change-Id: Ic16ae0fc6580e350444576a087c333d52296ec5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153663 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-06-28Header columns can disappear with filtered data in pivot tablesluigiiucci
When we set on a pivot table a filter that filters all the rows, the pivot table showed only the first header columns and computed column, but all the columns headers should still be shown so we can adjust the filter for the column. This fixes this issue. Also add more debug output and prevent a crash when running pivot table tests. Change-Id: I30b4ee72cf8436c4522ab4ba0781462b214816dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151871 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27Import CSV: remove erroneous warningLaurent Balland
If Fixed width is selected, clicking on any option in Other section generates a warning about option not allowed, which is wrong. Only checkboxes in Seprator section are not allowed Change-Id: I3fc6fd6ac870e8c681aae8fd1d033b550d9bc20d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152573 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-06-27tdf#54768 sc: fix resizing of cropped images to original sizeTibor Nagy
This is a follow up to commit a4e12cbfc69cfe668fa30756a3c5843e911e22b1 (tdf#155863 sd: fix resizing of cropped images to original size) Change-Id: I923ed8b1df6c6559d527d43e4abe842497c4c28f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153449 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-27tdf#156028 sc: use color of the highest value if only one valueTibor Nagy
(in a single cell or the same value repeating in all cells of the data set) on percentile color scale, like other spreadsheets do. This is a follow up to commit 6a059f8d1b0a7a5b64bd272e1e7b8291979bcd56 (tdf#155321 sc: fix color of the highest value on percentile color scale if the highest value occurs multiple times in the data set.) Change-Id: I630df332e403705e8338e3441af093c2de95c280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153577 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-06-27loplugin:stringstatic look for more stringsNoel Grandin
that can be initialised at compile-time instead of runtime Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-27sc: import and prop. theme color support for cell bordersTomaž Vajngerl
Adds import for theme colors for cell borders and UNO properties for the cell border theme (complex) colors. Change-Id: I9d8dd7e71f74a623f916e19d59964058f43440bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153502 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27tdf#123026 sc xlsx: provide per-sheet optimal row height settingJustin Luth
This patch is a pre-requisite for a follow-up patch which will run SetOptimalRowHeight on all un-sized rows on FILEOPEN. XLSX sheets can provide a default height for all rows on that sheet. That imported/round-tripped well. However, if Calc optimizes these rows, the undefined rows likely will change height - since the default XLSX row height tends to be 300 twips, while Calc uses 256 (in ScGlobal::nStdRowHeight). This patch allows a sheet to define its optimal row height, so that running .uno:SetOptimalRowHeight doesn't change any row heights, and doesn't cause all kinds of new row definitions. make CppunitTest_sc_subsequent_filters_test2 \ CPPUNIT_TEST_NAME=testTdf123026_optimalRowHeight Change-Id: I35008107d71f66375c7e9469e559f3836cf14df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152909 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2023-06-26sc: filter: oox: fix crash delete ScDatabarFormatDataHenry Castro
Unfortunately, the instance of "ScDatabarFormatData" is deleted before finalizeImport is called. The "maEntries" is not usable, the global format buffer is required to hold the reference. #1 0x7f2ef19081c0 in oox::xls::CondFormatBuffer::finalizeImport() co-23.05-asan/sc/source/filter/oox/condformatbuffer.cxx:1322:23 #2 0x7f2ef1b9999a in oox::xls::WorksheetGlobals::finalizeWorksheetImport() co-23.05-asan/sc/source/filter/oox/worksheethelper.cxx:942:22 #3 0x7f2ef58d030e in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) co-23.05-asan/sax/source/fastparser/fastparser.cxx:910:36 #4 0x7f2ef23f0e46 in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) co-23.05-asan/oox/source/core/fastparser.cxx:121:15 #5 0x7f2ef23f1544 in Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ieb3840cc10372867d5462a19d9efa9771f633437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-26problem pasting to calc an image copied from firefox (windows)Luigi Iucci
Calc tries to paste the image as html. In case both HTML_SIMPLE and BITMAP flavors are present in the clipboard, we paste as BITMAP Change-Id: I2527bedf11eb6986b58329acaf360a397af03101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153614 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-06-26new loplugin:constexprliteralNoel Grandin
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-26convert ScAutoFontColorMode to scoped enumNoel Grandin
Change-Id: Id34bac78719943bd4c4cbfa60e0cb86b4ca570f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153562 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-25sc: simplify and fix prop. mapping for cell BG and char theme colorTomaž Vajngerl
Change-Id: I461106200d37f0c605c07095c6b5871ea89e0e20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153501 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-25sc: ThemeColorChanger - change theme color for bordersTomaž Vajngerl
Change-Id: Id6b08ad48b496d2f1138aeea8d024a5f61bee633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153500 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-25crashtesting: crash seen on exporting fdo66241-1.ods to xlsxCaolán McNamara
Change-Id: I730bd782ddf67555c40651aed1442465574a1c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-24Rename "aStrTextColor" to "aStrFontColor"Taichi Haradaguchi
This patch improves consistently with item labels in AutoFilter/Standard Filter menu. Change-Id: Ibee26623f5561d228930b887778d5c61b32a1456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147747 Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-06-23related tdf#68695 tdf#141136 sc: comment can't resize; avoid context changeJustin Luth
In order to avoid having the notebookbar constantly flipping back to the home tab, try to avoid useless context switches. That should also be a nice performance win. In this case, the context change occurred because handles were enabled, but that broke in LO 4.1, so just revert that broken OOo fix. Back in OOo, https://bz.apache.org/ooo/show_bug.cgi?id=33764 added resize handles to a newly inserted comment, and was added to LO as part of a huge batch. commit 07b0c01857137de7e4bd02375e7c892d622d270e Author: Oliver Bolte on Mon Mar 2 14:19:13 2009 +0000 CWS-TOOLING: integrate CWS dr66 But that didn't allow select and copy, so in LO 4.1 commit 54a1feb9b9bd654774b9aa60cda7ef9a1cd11064 Author: Armin Le Grand on Fri May 10 12:08:40 2013 +0100 Resolves: #i122142# use simple text hilight frames Bug 68695 exists to complain about the inability to resize. Change-Id: If04d718b7de9cff1038bbe9f6372d4859643d3f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153508 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-23Speed up scrolling through large document with lots of patternsNoel Grandin
Cache visibility for use in ScPatternAttr::IsVisible Change-Id: Ia248a06b876b53115bbc3017d97538bbbc03830d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153482 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-23Improve ScImportExport::CountVisualWidth()Khaled Hosny
- Use East_Asian_Width Unicode property to check for double width chars instead of hard-coding CJK characters. - Use Default_Ignorable_Code_Point Unicode property to check for characters that shouldn’t be counted, instead of checking only of IVS characters. Change-Id: I4349ea0ee6a32736865f37cd0a6e1a8e7e9a6e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153451 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-23sc: qa: filter: add import excel unit testHenry Castro
single line. Change-Id: I2d76f54e0ccf943794bd817b2e80583b8dd69558 Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148005 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153473 Tested-by: Jenkins
2023-06-22sc: filter: excel: import cell multi-line textHenry Castro
The excel document, if the cell has multi-line text and the property wrap text is off, the paragraphs are rendered all in a single line. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I3b5c82dde2616887e51ad6e3dfe91d100482f747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148004 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153470 Tested-by: Jenkins
2023-06-22sc: filter: excel: add getter function LineBreakHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I17646ed53f663fd72a10437d7a3a4407df0c176e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148003 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153468 Tested-by: Jenkins
2023-06-22sc: filter: oox: fix preserve space, single line caseHenry Castro
The unit test testPreserveTextWhitespace2XLSX fails when a single line is enabled Test name: ScExportTest::testPreserveTextWhitespace2XLSX equality assertion failed - Expected: 1 - Actual : 0 - In <>, XPath '/x:sst/x:si[2]/x:r[1]/x:t' number of nodes is incorrect In order to fix, the single line cell should not be enabled and import the attribute: <t xml:space="preserve">abc</t> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I380ba8726c03abc40bdc745ea74eceb80fec6e54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151599 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2dd86aa3f365057494bf41f4da7f2f410ea3bf2e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151615 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153459 Tested-by: Jenkins
2023-06-22tdf#147056 sc: convert xml menu to popupmenu .uno:PrintRangesMenuJustin Luth
The labelling in the notebookbar left much to be desired when adding the print ranges separately in the "context menus". Making this into a proper submenu fixes the problem. Thanks to Maxim for reviewing and for the commit template: commit 0e7cd653ea90da388820220bf6a3eb140b57bbd6 Author: Maxim Monastirsky on Mon Jan 25 01:09:03 2016 +0200 tdf#86567 Dropdown for conditional formatting Change-Id: If92836ee29d322f5a2fca1e27d2e034e5cc995e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153402 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-22Speed up scrolling through large document with lots of patternsNoel Grandin
Optimise comparison in ScPatternAttr::IsVisibleEqual Change-Id: I8e569c888c695a3ce89c2b9993ed729754d402e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153454 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-22Missing test dependenciesStephan Bergmann
Change-Id: I2441d2d4df0e7f72a80828a131d82d8bb22e4181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153432 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-06-22sc: theme color export for cell fill color + testTomaž Vajngerl
Change-Id: Ibaad410f094f86d9f7197090db702ae45340c239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151859 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-22sc: factor out color from setting vcl::Font from a ItemSetTomaž Vajngerl
vcl::Font color parameter is deprecated so we need to handle the color separately from font data. This refactors GetFont into 2 separate functions - fillFontOnly and fillColor, where fillFont now does the same as previously GetFont function did. All GetFont calls have been changed depending on if we need only the font data or also color - where the color is now treated in a different call. There are a couple of calls where fillFont was used, because to change that needs a more complex refactoring. Change-Id: I0a2ce50a0cb28d196fcff87e1e80099a2bb60a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151858 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-21Require icu-i18n >= 66Khaled Hosny
We were requiring ICU 4.6 which was released in 2011, and ifdef'ing our way through newer ICU versions. ICU is a core dependency and it makes no sense to build LibreOffice with such ancient versions of it. This change requires ICU 66 (released in 2020), and removes all the ifdefs for older versions. There are more cleanups to do, but these will be done separately. Change-Id: I2e4f7608a08f4d531b0a4c74bbfdf91a451f833f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153387 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-21sc: OOXML import of theme colors for char and background colorsTomaž Vajngerl
Change-Id: I8209238927bb425e8e306352f1fa78d63378f005 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151707 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-21sc: change text and background theme colors for direct attributesTomaž Vajngerl
Change-Id: Ia1ef2d151476bb627a0cb999135f6add827fb341 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151675 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-21sc: Use DateTime::Sub() instead of operator-()Eike Rathke
Change-Id: Ib73eec1c11ced76890b8eacb0079ae336072a4c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153379 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-21sc: add CharComplexColor and CellBackgroundComplexColor propertiesTomaž Vajngerl
Change-Id: I30153796a39b2aa3648cb107905974ed6f0f3851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151668 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-20lok: sc: reset RTL if it is changedHenry Castro
Reset the LOKSpecialFlags, otherwise the selection engine select wrong lines. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I94e33cc3e293330d9a3480bd3838a20c1d94d15f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151841 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153365 Tested-by: Jenkins
2023-06-20lok: sc: fix layout RTL mouse selectionHenry Castro
If the Calc is in layout RTL, the edit view mouse selection does not change. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I0bd2640dac3cdc96fa247c305c379b2d1a8564ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151974 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153357 Tested-by: Jenkins
2023-06-20lok: sc: fix layout RTLHenry Castro
The function "IsRightToLeft" fails in Hebrew language when Calc has a layout RTL, add additional condition to check the layout. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If3972b80770a7aa6073881487e411a34cc6871d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150758 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153350 Tested-by: Jenkins
2023-06-20lok: sc: restore edit output areaHenry Castro
The edit view output area is modified after the draw, restore it so the mouse can handle selection at layout RTL. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I94dd9db385a3a9c60f015027894338504b4ce533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151972 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153325 Tested-by: Jenkins
2023-06-20tdf#122676 sc: fix format with * (filling) and NBSP thousand separatorCzeber László Ádám
Numbers containing no-break space (NBSP) thousand separator enabled the EditEngine layout, losing filling e.g. for stretching spaces. Enable EditEngine for NBSP characters only if there is no filling in the number format code, fixing MSO interoperability, too. In number format codes, asterisk (*) followed by a character is used to fill the available space in the column with that character, e.g. format code [>0]" "* # ##0" € ";[<0]-* # ##0" € ";" "* -#" € ";" "@" " put the minus sign at the left side of the column, while the number at the right side of the column. Because of the NBSP thousand separator, bigger numbers got different layout previously, i.e. minus signs right next to the numbers. Note: there is a better solution for the layout problem: using narrow no-break space (U-202F), which is the proposed thousand separator in typography, and it's back-compatible, because it doesn't enable the different layout. Change-Id: Ia35f01733687ee6005f06ff3ab999b7a4b712ad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152901 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-06-19sc: filter: oox: fix setting value to color scaleHenry Castro
The COLORSCALE_VALUE setValue method reset the mpCell that contains formula. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Idbbfcdc5bce78542ce671753d9a70dcd375e7966 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153281 Tested-by: Jenkins
2023-06-19fix crash on LOKIT spelling dialogJaume Pujantell Traserra
Update active view before trying to access it's selection. Change-Id: Ic83d335216304f7122005e447f5bd1c1484d0eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153136 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-06-19Use tools::Duration in ScInterpreter::CalculateAddSub()Eike Rathke
... for all (date+)time inflicted operands. Change-Id: I93043d912867e2ef7d4af271b5c4566a3ffb4ef9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153291 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-18Use getXWeak in scMike Kaganski
Change-Id: I6a120265be4e4f2ec859a17459d9d92ea23f00d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150863 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-18sc drawstyles: Restore text selection after applying a styleMaxim Monastirsky
Change-Id: I0a9bb39d8a7a9e770b3593eaa0a97867cbe86913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153171 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-17Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)timeEike Rathke
Change-Id: I18567fdac512ee786ce4b0785b01b2ae6da7450e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153203 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-06-17tdf#155402 - sc improving CELL() function return value in case of OOXMLBalazs Varga
In case of Excel/OOXML formula syntax: Before the patch =CELL("FILENAME";D2) returns 'file:///X:/dr/own.ods'#$Sheet1 After the patch =CELL("FILENAME";D2) returns file:///X:/dr/[own.ods]Sheet1 Change-Id: I34c805aef813632c45ac3fe930d690ae3c1d5d96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153098 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
generated by cgit (git 2.34.1) at 2025-02-16 05:43:07 +0000