summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-07-27Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I035eb9803631e7e8fffb49723c96100b1efda7af Reviewed-on: https://gerrit.libreoffice.org/58154 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-27uitest for bug tdf#100793Zdeněk Crhonek
Change-Id: I43c7f2d350e54ae00b03e4498f05f59bcfd16337 Reviewed-on: https://gerrit.libreoffice.org/57952 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-27Use IsInArrayContext() instead of (bMatrixFormula || pCur->IsInForceArray())Eike Rathke
Change-Id: I50debd5be2e0d4db0b5c57676d03ec33a2c38737 Reviewed-on: https://gerrit.libreoffice.org/58128 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-27Introduce and use ScInterpreter::IsInArrayContext(), tdf#91502 follow-upEike Rathke
Change-Id: I4c6299e9b6890eb22f50586ceb5788057527e88c Reviewed-on: https://gerrit.libreoffice.org/58124 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-27Related: tdf#91502 handle FORMULA() pCur->IsInForceArray() as wellEike Rathke
... so using it in SUMPRODUCT() and other ForceArray context works as expected. Change-Id: I60197301edcd2c24f8cb0c5fcf4dc4699d9a6165 Reviewed-on: https://gerrit.libreoffice.org/58118 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-27Resolves: tdf#91502 handle ISFORMULA() in array contextEike Rathke
Obtaining the usual matrix for iterated scalar values doesn't work here because we don't want the formulas' results but whether there are formulas at the referenced positions. Change-Id: I7912f9019d21b803ca327cb022df2014d3cc5c5a Reviewed-on: https://gerrit.libreoffice.org/58115 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-27add simple calc tests for ocAdd and ocSubLuboš Luňák
Triggered by 710aeefd2 ("make opencl also use approximate add and sub"), OpenCL doesn't actually get used to check these because it's not used for single formulas, but it looks like handling of imprecise doubles is not checked anywhere, so add a test. Change-Id: I7a73af508d6ea5f141397ebf11f246cf0a622fed Reviewed-on: https://gerrit.libreoffice.org/58068 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-07-27make opencl also use approximate add and subLuboš Luňák
Code basically taken from rtl::math::approxAdd() and friends. Without this OpenCL will sometimes not get results as 0 because of rounding errors (sc/qa/.../linest.fods with minimum formula size disabled). Change-Id: Ib66f5eb1c6aeb9c95047406de1442b388ccc7f5f Reviewed-on: https://gerrit.libreoffice.org/57911 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-27do not keep incorrect calc values in the cacheLuboš Luňák
All these calls first entered the whole array into the cache and only then filled it up with values. If that failed, the values stayed in the cache and could be reused by something else. Testcase is sc/qa/.../linest.fods, where the error in X19 prevents caching of that column for the formula in AA24:AA28. Since currently ScFormulaCell::InterpretFormulaGroup() calls InterpretFormulaGroupOpenCL() twice, the first ScGroupTokenConverter::convert() call cached the incomplete column and then failed, and the second call simply reused the value. But this could presumably happen for multiple formulas using data in the same column as well, even without the double call. Change-Id: Iaa55671936fe61f72dfa35940db8deaf27d1c22d Reviewed-on: https://gerrit.libreoffice.org/57912 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-07-27Related: rhbz#1602589 silence coverity copy_paste_errorCaolán McNamara
Change-Id: Idca4bfaaa9f127eae87ae879e2131aed747ce4b3 Reviewed-on: https://gerrit.libreoffice.org/58089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27ScDPObject is only needed in endFastElementCaolán McNamara
Change-Id: I8e1a7897777111c225e42ebcf81e67face6b29b9 Reviewed-on: https://gerrit.libreoffice.org/58114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27pDPObject can never be nullCaolán McNamara
Change-Id: Ie98da9b53e952c2fb1f8f91e4b9489060114c366 Reviewed-on: https://gerrit.libreoffice.org/58113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27InsertNewTable always returns trueCaolán McNamara
Change-Id: I28b2cd46bf40011f5f813784bd5c182f18ee103f Reviewed-on: https://gerrit.libreoffice.org/58112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27add test for tdf#109132Markus Mohrhard
Change-Id: I115590658708bafc7c7778612251ad7eb716b30b Reviewed-on: https://gerrit.libreoffice.org/58150 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-27sc: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc.; and by removing explicitly user- provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non- deleted in the future. (Even if such a user-provided function was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already include, so why bother with non-inline functions.) Change-Id: I4efe3eb088e5f9096be87dd8240504768755112b Reviewed-on: https://gerrit.libreoffice.org/58096 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27related tdf#109132, ugly hack to ensure the VBA mode is setup during importMarkus Mohrhard
Change-Id: Ia48e4b19eb690ba7ab24a37538f6de11a74ad4d3 Reviewed-on: https://gerrit.libreoffice.org/58148 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-26Related: rhbz#1602589 silence coverity use_after_freeCaolán McNamara
Change-Id: If5345b6515c45bee2742d1293cd181ab46e8e61b Reviewed-on: https://gerrit.libreoffice.org/58088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26uitest for bug tdf#81696Zdeněk Crhonek
Change-Id: I1fba51bc60912d4c0c107a88c34c2df91cd8913d Reviewed-on: https://gerrit.libreoffice.org/58033 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-26Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I3166be8669d5bb46ac31ecdd10327572c678ef47 Reviewed-on: https://gerrit.libreoffice.org/58032 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-26tdf#117647 - Conditional formatting of "Top 10..." misleadingheiko tietze
"Top 10..." misses the option to enter different values; changed top "Top N..." Change-Id: I919fe48cce08ddd52a5f7246b77853c1b8c14253 Reviewed-on: https://gerrit.libreoffice.org/58052 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-26add simple add/sub to the opencl test documentLuboš Luňák
See gerrit#57911. Change-Id: I122cf6069cdac05ef6781bfb0a4840614514d435 Reviewed-on: https://gerrit.libreoffice.org/58067 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-26Refresh AutoFilter buttons unconditionally, tdf#118867 related follow-upEike Rathke
Not just in the merged-does-not-need-refresh case, in the needs refresh case ScMF::Auto is not handled. Change-Id: I6d1b98a4afb51893d052498c87a0477982106a36
2018-07-26crashtesting: crash on loading ooo126177-3.odsCaolán McNamara
since... commit 5be0637827cd987b7b7dda7ca2c54a3548d9ef51 Date: Mon Jun 25 16:46:32 2018 +0200 loplugin:useuniqueptr in ScSheetEvents Change-Id: Ia20f6c8dfc1fcde49e35c07415f336f49ef79a28 Reviewed-on: https://gerrit.libreoffice.org/58037 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26uitest for bug tdf#118206Zdeněk Crhonek
Change-Id: Ia78195d49dfa72bc8ee06b81a1b18d38b17a72a3 Reviewed-on: https://gerrit.libreoffice.org/58028 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-26uitest for bug tdf#105351Zdeněk Crhonek
Change-Id: Ifbeda8a97c81167d5ba6c66c9691b059794f32b1 Reviewed-on: https://gerrit.libreoffice.org/58025 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-26Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Ic870fce3b88745ca6d25bab17c8c995cbd13f967 Reviewed-on: https://gerrit.libreoffice.org/58031 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-26Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I836019b91866ecb993a3604dd646759acfd70a46 Reviewed-on: https://gerrit.libreoffice.org/58030 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-26sc: Make CONFIDENCE.T() raise #DIV/0! when size is 1Takeshi Abe
... for interoperability with Excel, as remarked in <https://support.office.com/en-us/article/CONFIDENCE-T-function-E8ECA395-6C3A-4BA9-9003-79CCC61D3C53>. Change-Id: I2d24573055455fa014c38f6e5985e3501ed6ba6e Reviewed-on: https://gerrit.libreoffice.org/57322 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-25Related: tdf#118867 refresh AutoFilter buttons when deleting cols/rows/cellsEike Rathke
Also in ScUndoDeleteCells::Undo()/Redo() Change-Id: I203e447e8d1bcbad48658c26c98a1558e0d4881a Reviewed-on: https://gerrit.libreoffice.org/57989 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-25ofz#8373 tight OUString concat loop causes libfuzzer oomCaolán McNamara
it doesn't get a chance to release memory and falls over with an oom. Or something like that anyway. Change-Id: I9d8dd704fb63d70755c6c1b211db6fe9d99cc2e5 Reviewed-on: https://gerrit.libreoffice.org/57987 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25Fix typoAndrea Gelmini
Change-Id: I24e325e2d283c58ea58e8d227a909417e3535484 Reviewed-on: https://gerrit.libreoffice.org/57995 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-25tdf#118777: Disable signature line slot if non-text objectKatarina Behrens
both in sw and sc Change-Id: I54f7ec336026013d09ac6262779e7fcbd17c2084 Reviewed-on: https://gerrit.libreoffice.org/57949 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-25uitest for bug tdf#96698 , Validity-> CustomZdeněk Crhonek
Change-Id: Ia35d95c4ac6cddfb7db7a6e770b6c193baeab9fa Reviewed-on: https://gerrit.libreoffice.org/57896 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-24ofz#9431 don't check attribs of Invalid columnCaolán McNamara
Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0 Reviewed-on: https://gerrit.libreoffice.org/57915 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24sw,sc: Signature Line: fix VclPtr assertionMichael Stahl
Insert a Signature Line, right click, Sign..., Cancel include/vcl/vclptr.hxx:116: VclPtr<T>::~VclPtr() [with reference_type = AbstractSignSignatureLineDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed. Change-Id: I09a1b37b917b267a84ee95fb375658974ee1b320 Reviewed-on: https://gerrit.libreoffice.org/57913 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-24valgrind: use of unit value exporting tdf107162-1.ots to xlsCaolán McNamara
Conditional jump or move depends on uninitialised value(s) at 0x4554B657: SetApiUnderline (xlstyle.cxx:487) by 0x4554B657: (anonymous namespace)::lclSetApiFontSettings(XclFontData&, rtl::OUString const&, float, float, com::sun::star::awt::FontSlant, short, short) (xlstyle.cxx:583) by 0x4554C096: XclFontPropSetHelper::ReadFontProperties(XclFontData&, ScfPropertySet const&, XclFontPropSetType, short) (xlstyle.cxx:679) by 0x4546D8BE: XclExpTbxControlObj::XclExpTbxControlObj(XclExpObjectManager&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xeescher.cxx:753) by 0x45593D99: XclEscherEx::CreateTBXCtrlObj(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xcl97esc.cxx:441) by 0x45594E85: XclEscherEx::StartShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xcl97esc.cxx:254) by 0x44E4FFBC: ImplEESdrWriter::ImplWriteShape(ImplEESdrObject&, EscherSolverContainer&, bool) (eschesdo.cxx:164) by 0x44E510C3: ImplEESdrWriter::ImplWriteShape(ImplEESdrObject&, EscherSolverContainer&, bool) (eschesdo.cxx:215) by 0x44E5452B: ImplEESdrWriter::ImplWritePage(EscherSolverContainer&) (eschesdo.cxx:848) by 0x44E54D27: ImplWriteCurrentPage (eschesdo.cxx:932) by 0x44E54D27: EscherEx::AddSdrPage(SdrPage const&) (eschesdo.cxx:945) by 0x454696BC: XclExpObjectManager::ProcessDrawing(SdrPage const*) (xeescher.cxx:1523) by 0x45407A35: ExcTable::FillAsTableBinary(short) (excdoc.cxx:518) by 0x454088B8: ExcDocument::ReadDoc() (excdoc.cxx:767) Change-Id: Ibefe8ea808bfbd9dfc8e773b4c13936387633507 Reviewed-on: https://gerrit.libreoffice.org/57904 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24crashtesting: tdf107162-1.xlsNoel Grandin
regression from commit 8a304fe8b1282efa2d40bdf337728e64b7532a35 loplugin:useuniqueptr in XclEscherEx Change-Id: I84c2619a1ac62cf70144b530c540a4c18b474bd1 Reviewed-on: https://gerrit.libreoffice.org/57903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24uitest for bug tdf#53920Zdeněk Crhonek
Change-Id: I4e4cd572c2f2354da4f024d4bc80f56b589faab9 Reviewed-on: https://gerrit.libreoffice.org/57895 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-24loplugin:useuniqueptr in ScValidationDataListNoel Grandin
Change-Id: Icbf8eb814e7d3bd57e78d2d1a97eb44bbfd2a432 Reviewed-on: https://gerrit.libreoffice.org/57874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24Fix typosAndrea Gelmini
Change-Id: I8758872f6a5270de3f9b9dea750b9d40c7a446db Reviewed-on: https://gerrit.libreoffice.org/57800 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: If0d8f4033d9bc20f521d33d732fb349f0df5eeef Reviewed-on: https://gerrit.libreoffice.org/57822 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23uitest for bug tdf#65686Zdeněk Crhonek
Change-Id: I4c50618d0f570978873c13c9e503d5c3d32f9f9d Reviewed-on: https://gerrit.libreoffice.org/57830 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-23Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I1a926f45510e18cf399aa2eb7e1bf0ad8f4f0226 Reviewed-on: https://gerrit.libreoffice.org/57836 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-23HandleIIOpCode: testing for ForceArray is not sufficientEike Rathke
There are also other "force to array" context modes in which a range reference does not result in an implicit intersection. Change-Id: I3f4d85f73ecde5bbf9f011deeac2936d5f43949b
2018-07-23tdf#118764 Add missing tab stops in sidebar panelsJim Raykowski
Change-Id: I09d5df8d7f07eb4b6c4341d9cd281131fc2df23b Reviewed-on: https://gerrit.libreoffice.org/57535 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-23tdf#118453 Reactivate navitagor submenu drag mode and displaySalimHabchi
I add a function to get the data from the submenu Change-Id: If8aedc72abfc7ca967377f0e588167f9f62fe137 Reviewed-on: https://gerrit.libreoffice.org/57269 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-23Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: If68a45523242a30d5bc8122818b36f0babc70dcd Reviewed-on: https://gerrit.libreoffice.org/57828 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-22tdf#98074, using the same builtinId maps the styles to the same oneMarkus Mohrhard
Additionally, using customBuiltin for all styles is a bad idea as well. Change-Id: I788a3c5b9164f79aa65ded2fc3e6a556e44ee0a8 Reviewed-on: https://gerrit.libreoffice.org/57807 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-22Fix typosAndrea Gelmini
Change-Id: I326827c394347cbe9fad242e9da5702cba7a4d95 Reviewed-on: https://gerrit.libreoffice.org/57761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-21sc: Compare vectors by simpler codeTakeshi Abe
Change-Id: I5efac4a449b388c2d8a6e47beb4a6a8fbfed909a Reviewed-on: https://gerrit.libreoffice.org/57797 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-13 03:52:56 +0000