summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2023-04-08uno:TextAttributes - add to popupmenu draw.xml for textboxesJustin Luth
Text Attributes includes margins for spacing the borders (lines) away from the text. I personally would like to see the order be Area, then lines, then textAttributes, but I suppose one could look at it as area margins instead of border margins. In any case, margins are a pretty critical piece of either lines or margins, and so should be a menu choice whenever either of these is available. Change-Id: Ifec5bbcd20dba6f42aba586bd0cd791bb9f3acae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150131 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-08Fix typoAndrea Gelmini
Change-Id: I16044e195878c4d51a2e4a92986a1b0baf8bc2a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150127 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-07sc drawstyles: Keep style assignment for commentsMaxim Monastirsky
Need to handle 3 cases: - Import of hidden comments (not too much useful by itself, as we still force the default comment formatting as DF). - Copying cells with comments. - The comment popup that is shown when hovering over a comment marker. Change-Id: Ibf2e22f1432745fe46f89da624ed3586b5d9fb55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149943 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-07tdf#113027 - Allow cycling cell reference types including whitespacesAndreas Heinisch
A formula containing a remote reference to a sheet including a whitespace in its name does not correctly handle switching from relative to absolute cell references using the EXCEL R1C1 formular grammar. Change-Id: I3391f4e8f57993899b5e97f0a173b624b5ef0b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150109 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-07tdf#154679 unable to scroll with mouse wheel with frozen rowsCaolán McNamara
which is a problem since: commit f2b97ecf340e1fd714c636060ae09382518a2b46 Date: Tue Mar 21 14:30:38 2023 +0000 unmerge default and ScrollType::Drag cases for calc scrollbars which noted that in commit 8c4e8818fe9f5ac1f6cdf908299cc109d67f1e50 Date: Thu Aug 4 16:38:47 2022 +0100 nDelta overwritten on all branches except default the default case was different to the Drag case and speculated that the right approach might be to restore that distinction. but in fact ScrollBar::DoScroll(tools::Long nNewPos) had an unconditional 'meScrollType = ScrollType::Drag' which ScrollAdaptor::DoScroll doesn't so it was originally the case that scroll wheels used to be reported to calc as "ScrollType::Drag" so the default handler never arose and such scrolls were handled by the drag handler after all, despite the unlikely looking scroll type. So restore the merge of ScrollType::Drag and default as the desired outcome, dropping the comment about "only for warnings" which is out of date now. Change-Id: Ibb396f053ae518a6ad5a9b4266ee879c84883953 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-07crashtesting: crash on saving of fdo48916-1.odsMaxim Monastirsky
That document has <style:style ... style:family="graphic"> before <style:default-style style:family="graphic">. The problem was that only the default style was creating the draw layer (in ScDrawDefaultsObj::getModelPool), which means that the SdrItemPool didn't exist at the time the item set of the former style was created. The easiest solution seems to ensure the draw layer existence on each UNO style object creation, similar to the other draw layer related objects in this method. A similar fix was added recently for another scenario in commit aec0830f31c2fd258de711baaa7da24bd01488c9 ("Ensure valid SdrItemPool for drawing styles"). Change-Id: I50d89fea6d419119cd47ab163c82d1470b04b4a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150115 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-06Update ODFF linkEike Rathke
Change-Id: Ieb72077d175862bd459e85a1acc9ea3b0e49c25b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150110 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-06Resolves: tdf#154627 RANK() query value not in data must return errorEike Rathke
For all RANK(), RANK.EQ(), RANK.AVG(). Also, use #N/A NotAvailable instead of #VALUE! NoValue. This made it necessary to adapt sc/qa/unit/data/ods/functions.ods and result check that had a totally senseless query value with arbitrary results. Change-Id: If835b5ed49caf16a813b4ea897e1d7dd1aa02954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150067 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-05fix leaks when using tools::JsonWriterNoel Grandin
Specifically in sd/source/core/annotations/Annotation.cxx We seem to end up fixing leaks here often. The current tools::JsonWriter API is just very hard to use correctly. So rather return an OString, which is cheap to copy, and push that down into the LOK code. AFAIK that seems to end up requiring less code and less adhoc copying of data (specifically the queueing code in init.cxx was creating copies when converting to std::string). Ideally, we could have some special API to avoid the new strdup() calls in init.cxx, but not sure how to prevent other people from accidentally using that. Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-04tdf#153880 sc: Make Calc text hyperlinks stand out moreBalazs Varga
Add underlining for links in Calc. TODO: unit test Change-Id: Idd5a7de7464d8ce443cdec756ac803491e73b0ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149913 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-04-04tdf#151206 - Sc Auto Filter: filter items after search edit timeoutAndreas Heinisch
In addition, UI tests have been adapted to address the timeout of the search process. Change-Id: Id9d78896e45da43734346654762c3541b8c07ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149958 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-04Resolves tdf#154446 - Remove redundant option for grid line colorHeiko Tietze
Change-Id: I41d39b763e651f90660f2a451ed0a9b473ead206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149715 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-04resave with latest gladeCaolán McNamara
Change-Id: Ida60773e87cc607de6763fb6676aad83c316e8b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150000 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03Resolves: tdf#154582 Obtain English DisplayName before CompatibilityNameEike Rathke
... for Add-Ins from configuration. Change-Id: If13d692ca7550e69d2f6e3ff72747d17aee3e7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149995 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-03set a parent for embedded object warning dialogCaolán McNamara
calc does a lot of "CaptureMouse" which then leads to a lot of "ReleaseMouse", I'm somewhat unconvinced that there should be any CaptureMouse calls in there. Change-Id: I7c44d2c36c89a5c32c525d65939723da9be77a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149973 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03tdf#124525: sc_subsequent_filters_test4: Add unittestXisco Fauli
Change-Id: I16321c8e22a205d211536b189191db453ebf1ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149956 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03Ensure valid SdrItemPool for drawing stylesMaxim Monastirsky
... when pasting cells as OLE object. Problem caught by UBSAN build with UITest_conditional_format UITEST_TEST_NAME=tdf117899.Tdf117899.test_tdf117899: /sc/source/core/data/stlsheet.cxx:238:53: runtime error: reference binding to null pointer of type 'SfxItemPool' #0 0x7f9cb1ef60ce in ScStyleSheet::GetItemSet() /sc/source/core/data/stlsheet.cxx:231:28 #1 0x7f9cb1ed52e3 in ScStyleSheetPool::CopyStyleFrom(SfxStyleSheetBasePool*, rtl::OUString const&, SfxStyleFamily, bool) /sc/source/core/data/stlpool.cxx:144:40 #2 0x7f9cb1ed9285 in ScStyleSheetPool::CopyStdStylesFrom(ScStyleSheetPool*) /sc/source/core/data/stlpool.cxx:223:5 #3 0x7f9cb0e25d51 in ScDocument::CopyStdStylesFrom(ScDocument const&) /sc/source/core/data/documen8.cxx:292:35 #4 0x7f9cb4602d7c in ScTransferObj::InitDocShell(bool) /sc/source/ui/app/transobj.cxx:683:14 ScStyleSheetPool::CopyStdStylesFrom wants to create/update the default drawing style, but in case the source clipdoc didn't have shapes - without creating ScDrawLayer first, which means no SdrItemPool exists. Fix that by creating ScDrawLayer unconditionally, as we attempt to do this later on anyway. Regression of commit 685a864cfc40227559ed55f6273fd118174e8e6e ("sc drawstyles: Clipboard support"). Change-Id: I3def9860ab4f11c70c120f5324a60adf63056a7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149966 Tested-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-03tdf#89920 - Handle embedded newline in Calc's search cellAndreas Heinisch
Update short-circuited boolean expression so the least expensive subexpressions will be executed first Change-Id: I8c924e00e8de809f3e6df2828f8537185e71c18c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149891 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-03jsdialog: enable spelling options dialogSzymon Kłos
and make it async Change-Id: Idbf8661aa106d69e60ab6037052fd3d6dec28c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149205 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149824 Tested-by: Jenkins
2023-04-03tdf#89920 - Handle embedded newline in Calc's search cellAndreas Heinisch
If the replaced string contains a newline after find and replace, insert an edit cell in order to handle an embedded line correctly regardless of the content in the source cell. Change-Id: Ic8a5fc80b85546897572a228511b319cd5a8b9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148752 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-02Related: tdf#152250 Copy also style hierarchyMaxim Monastirsky
Change-Id: I134857c9a7749b0dd4a6fe6842dcc8c72d373f4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149928 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-02Explicitly check for cell stylesMaxim Monastirsky
Now that this method is used also for drawing styles. Overlooked this in 685a864cfc40227559ed55f6273fd118174e8e6e ("sc drawstyles: Clipboard support"). Change-Id: I7218b735d743841106606739fbd72e45a1d4bf1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149923 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-02Try a different approach for cid#1524623Maxim Monastirsky
I fail to see how pClipDoc could be nullptr, as all call sites of ScDrawLayer::CopyFromClip get a ScDocument-owned ScDrawLayer. But even in such case we can still get the style sheets pool from ScDrawLayer itself, which guaranteed to have one with or without ScDocument, as per ScDrawLayer's ctor. Change-Id: I6a3b7af7080b0a07ab3ec1fcfa7c6ca00e365162 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149921 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-01use more XVclWindowPeerNoel Grandin
Rather than using it's superclass XWindowPeer and implicitly relying on it being XVclWindowPeer and casting it everywhere. Change-Id: Icfb46f3b920d00f4a167a31803a71bbb0368d05c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149894 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-01cid#1524623 Dereference after null checkCaolán McNamara
Change-Id: I43de41c207d129013fa9c2003cccb12facf3f1da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-31CppunitTest_sc_macros_test: use CPPUNIT_TEST_FIXTURE()Xisco Fauli
This suite is large enough so that avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I60792ef623f6db275bf5b1346debceaa38fd6539 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149838 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-31jsdialog: enable Insert header footerSzymon Kłos
Change-Id: Ib6f1cd1ffac5479ae9cdf1e47fe0cb69abfc8c91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148889 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149365
2023-03-31jsdialog: enable sort dialogSzymon Kłos
Change-Id: I694bf3ea9982032b0202e408f8121a6407427cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148789 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149820 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-30sc drawstyles: Enable the UIMaxim Monastirsky
I believe it's in a usable state now. But keep in mind that the work isn't finished yet. For example, there is only one base default style, and the work to support styles for comments wasn't merged yet. Change-Id: I1ad3a4803ad91773906743e19a35405d5cd3255d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149754 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-03-30sc drawstyles: Clipboard supportMaxim Monastirsky
- Paste as Calc's own format (default in Calc, results with an OLE object elsewhere), should preserve style assignment. This can be in one of two ways: Either copy the shape itself, or a cell range that includes a shape. - Similarly, copying or moving a whole sheet to another document should also preserve the style. - Paste as drawing format (default in other apps, also default in Calc when copying shapes from other apps), should preserve the formatting as direct formatting. Pasting into Calc will also assign the default style to that shape. Change-Id: Icb951dad1a77ba9ced706c33c928980d1ec7f8ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149753 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-03-30sc drawstyles: Add a default style and make use of itMaxim Monastirsky
The style is empty, similar to the default cell style, thus fall backs to the pool defaults for everything. This ensures compatibility with existing documents, despite the fact that the default style is applied to all shapes upon import. In addition, people who will ignore styles and just continue to use DF, will have their spreadsheets look the same in older versions that don't support styles. For this reason I also opted to not set a dedicated style for images and OLE objects via SdrModel::SetDefaultStyleSheetForSdrGrafObjAndSdrOle2Obj, unlike Impress/Draw, and continue setting the "no fill and no line" override as DF. Change-Id: I11554044a1aaf386dc6c4acdbab798fc5a231adc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149359 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-03-30tdf#150471 Remove duplicated Freeze commands from the Tabbed UIRafael Lima
As discussed in the ticket, the commands "Freeze First Column" and "Freeze First Row" are duplicated in the Tabbed UI (under the View tab), since there's already a "Freeze Rows and Columns" command that already offers these 2 options. So this patch removes the "Freeze First Column" and "Freeze First Row" entries and keep the "Freeze Rows and Columns" comand. The label of the ".uno:FreezePanes" is also changed to "Freeze Panes" so that it doesn't occupy so much space in the tab. I set the ContextLabel to "Freeze Rows and Columns", so in the menu and context menus, the text shown remains "Freeze Rows and Columns". Change-Id: I57e6b22b103c2316ca0722878491b719e93b9bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149650 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-30tdf#108188 - Use constant string for default page styleAndreas Heinisch
Change-Id: I7c398c3dec044722e4552527de8553506cda54f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149730 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-30UITest_{calc_tests6,chart,chart2,sort}: enable oneprocess modeMiklos Vajna
Execution time changes: - from 1m27,535s to 0m55,724s - from 5m40,926s to 4m46,884s - from 1m54,886s to 1m31,400s - from 3m30,592s to 2m20,833s for me. Also add a simple script that lists what's remaining to be converted. Change-Id: I274f5a11a0f606964bdad5d5e5254b65b09fe497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149739 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-29tdf#154445 - Export all page styles even if they are not in useAndreas Heinisch
Change-Id: If0ca5ea97ad545058c6a70d223158a87bf9207ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149729 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-29UITest_calc_tests{,2,3,4}: enable oneprocess modeMiklos Vajna
Execution time changes: - from 5m6,456s to 3m26,832s - from 2m56,710s to 1m56,982s - from 1m37,645s to 1m9,388s - from 1m52,203s to 1m12,651s for me. Change-Id: Ie3860309c768dd3aaf8efe40a1e995874737b052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149728 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-29Resolves tdf#152184 - Application color should follow system colorHeiko Tietze
This patch reverts the previously added "LibreOffice Dark" application color set and adds it to the automatic colors. Switching between light and dark changes the Automatic color accordingly instead switching to another color scheme. The added System Theme option makes Light/Dark follow the actual OS appearance. Reverts 6dfc49bb6a72bf6bb79167b12f0d2d0c5a155d06 (Introduce dark color set), 546ad5d17d3e363b75337c336cfb2b2f8acc55e3 (color scheme translatable), 9f0cf00d29298ed55737928ec4dddc50ac850cd8 (Update view options string based on theme) Change-Id: Ibf491f2e510fac5f1d27a7166560c4ec281d98d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149059 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-28Removed executable bits on ods fileAndrea Gelmini
Change-Id: I9a43b02caaad389d8f67a2d2d43ad555d131edf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149645 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-28tdf#142391 - Store method using 0x13 format only when actually neededAndreas Heinisch
Change-Id: I907d234b20be5e3c7bee0d44407f1bf4c4b49f05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149175 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-27-Werror=maybe-uninitializedStephan Bergmann
Change-Id: I65f7583851dda2233a375a9f37a7e12a7fc29d07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149625 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-27Better error msg for sheet insertNewByName() and copyByName()Olivier Hallot
+ Indicate where the error occurs, + What are the possible causes, + and what are the possible fixes. Change-Id: I42d4d35ba33a1f5a20a2f0b20724754d8c63a049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149589 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-27xmloff: prefix members of NameSpaceEntry, SinglePropertySetInfoCache, ...Miklos Vajna
... SvXMLAutoStylePoolP and SvXMLNamespaceMap See tdf#94879 for motivation. Change-Id: I306ceadd6d3753b76188fed3707b4df63c10bb8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149621 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-27tdf#151309 Fix the use of t-test in the UIRafael Lima
As discussed in the ticket, we should use "t-test" instead of "T test". Change-Id: I0aeb122b0f9a9affd4c298915956396580cb4de7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149598 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-26Related: tdf#154005 sc ods fileopen: fix dropdown form control sizeBalazs Varga
Fixing the crashtesting assert/crash after the original change. Also a little clean-up. Change-Id: I35453fbc55b3d5d4064179e84755334c2d3a01ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-03-26loplugin:stringadd in scNoel Grandin
after my patch to merge the bufferadd loplugin into stringadd Change-Id: Ifa70db5be4719fe66d3043e5e49403246f6aa8bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149582 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-25tdf#38948 Save solver settings to fileRafael Lima
This patch implements the mechanism to save solver settings in LO Calc as well as export/import them from XLSX files. In MS Excel solver settings are saved as hidden named ranges, so in this patch I used the same strategy to save solver settings in Calc, i.e. by creating named ranges to store the solver settings using the same terminology used in Excel. With this we gain the ability to save solver settings by tab, as well as export/import since we already have "named ranges/expressions" import/export implemented in LO. Change-Id: Id41bca261dc3cd8e6888643f0ed6a97b26097876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148112 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-23CppunitTest_sc_uicalc: split in twoXisco Fauli
It already has 99 tests Change-Id: I672de980ce170b83ba84252170878731e1ce02f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149462 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-23sc drawstyles: ODF import and exportMaxim Monastirsky
Change-Id: Id92088a7d70c550682fe707d81e94157edc7caa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149330 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-03-23jsdialog: enable data validation dialogSzymon Kłos
Change-Id: Ide679ada03dff5e62432d77b8c804d667bf2435b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148781 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149219
generated by cgit (git 2.34.1) at 2025-01-10 01:21:05 +0000