summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-07-20cid#1448465 Uncaught exceptionCaolán McNamara
Change-Id: Ic70f0926b4e26f82045a791eadf6af1e9d7949a9 Reviewed-on: https://gerrit.libreoffice.org/76009 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20assign nLen during ctorCaolán McNamara
Change-Id: I9164bd2b653208214276c48ddf49b21436edbd63 Reviewed-on: https://gerrit.libreoffice.org/76012 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448265 Untrusted value as argumentCaolán McNamara
Change-Id: I31280f417e3542bb7596bab798e971b714b5285f Reviewed-on: https://gerrit.libreoffice.org/76002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20loplugin:referencecasting in scNoel Grandin
Change-Id: Ife30500d1ff67e06afc4d64634febfb4c161c702 Reviewed-on: https://gerrit.libreoffice.org/75976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448351 Use after freeCaolán McNamara
Change-Id: I5591303096a495565e4e3638ca8db8196fa26092 Reviewed-on: https://gerrit.libreoffice.org/75913 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448217 Use after freeCaolán McNamara
Change-Id: Icb7700c701dd8e9b23bfe29bbedf27ddd9c8f0a1 Reviewed-on: https://gerrit.libreoffice.org/75911 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448311 Dereference null return valueCaolán McNamara
Change-Id: Ie0ad350d48441dc6012dddc9fa3989acc4d4aab8 Reviewed-on: https://gerrit.libreoffice.org/75917 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448287 Unchecked return valueCaolán McNamara
Change-Id: Ifd6bd0f4218805ad52a256fad82a4d2455c6afa9 Reviewed-on: https://gerrit.libreoffice.org/75871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448339 Use after freeCaolán McNamara
Change-Id: I3259e0fe9ebaba819d529af2fdb003ce9a297961 Reviewed-on: https://gerrit.libreoffice.org/75813 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#101443 Horizontal inset margin of Calc input bar increasedThorsten Wagner
Change-Id: Ic609da4b8b5fae0f556761c4493e490c82a6386d Reviewed-on: https://gerrit.libreoffice.org/74214 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-07-18tdf#126453: hide ScInputHandler's tooltips when loosing focusMike Kaganski
Change-Id: I188db03ad9027bcb17a72f7c59d85e611b57bfd0 Reviewed-on: https://gerrit.libreoffice.org/75824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-18include supported SIMD intrinsics headers automaticallyTomaž Vajngerl
If we include simdsupport.hxx, this now includes the supported intrinsics headers automatically, so this removes the need to do it ourselves. Change-Id: Icc406316a7e27b7b5fd5905f51664f4fe47e5468 Reviewed-on: https://gerrit.libreoffice.org/75783 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-17fix "tdf#119388 calc, slow removing column, improve ScChildrenShapes"Noel Grandin
forgot to add the code to actually update the map, which would be bad for accessibility Change-Id: I5d93dd84649ce27a37c9035622f94fff3237b778 Reviewed-on: https://gerrit.libreoffice.org/75773 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-17tdf#121039 "Open hyperlink" from context menu does not workSamuel Mehrbrodt
Change-Id: I802a4a64d48befa9c41b7095416f165082a155f2 Reviewed-on: https://gerrit.libreoffice.org/75778 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-17crashtesting: assert on export of fdo63407-3.ods to xlsCaolán McNamara
since... commit 3cdc1b35b9d86bcfa1277e3e94925ae7b18b8fde Date: Tue Jul 2 10:07:24 2019 +0200 tdf#126177 XLSX export: fix hyperlinks to documents Change-Id: Id5aaaab760a53b1e996d5d47c7477d77ce1d4efc Reviewed-on: https://gerrit.libreoffice.org/75757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17tdf#126421: don't limit pasted data to allocated columns in destinationMike Kaganski
Change-Id: Ic30360795c5dac1dc232f95bd25f5a11946c7dee Reviewed-on: https://gerrit.libreoffice.org/75738 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-17tdf#126393 Select cell even when clicking on a hyperlinkSamuel Mehrbrodt
and the hyperlink isn't being opened anyway (no ctrl clicked e.g.) Change-Id: Ic0c0df9b91000a8e661075901e8bfdb7167081f9 Reviewed-on: https://gerrit.libreoffice.org/75730 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-17tdf#126315 - Tooltip for drop-down widget in Formula barHeiko Tietze
Change-Id: If2379ab939f6f9bffeddfab64ac2c6da927e841b Reviewed-on: https://gerrit.libreoffice.org/75691 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-16tdf:126142 ImageMap menubar entry moved to tools sectionandreas kainz
Change-Id: I8600e4bb88db4460a16a559a0fe1fd645bb0446a Reviewed-on: https://gerrit.libreoffice.org/75687 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-16cid#1448279 Dereference before null checkCaolán McNamara
Change-Id: I14e975f9bcb2b18a8dc12cef70478457391f72dc Reviewed-on: https://gerrit.libreoffice.org/75721 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#14484777 Dereference null return valueCaolán McNamara
Change-Id: If59f06db4a4048f068acc54f9908e45c908138e8 Reviewed-on: https://gerrit.libreoffice.org/75720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16tdf#126306: ignore Top10, Empty and NonEmpty in fix for tdf#117276Xisco Fauli
Regression from 4e7e3670c31329d60f5cc782abc4568c2aba33a7 Change-Id: I034f4f087580aa7c54b92909736af712047251a6 Reviewed-on: https://gerrit.libreoffice.org/75304 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-07-16tdf#104717 don't set the primary selection on pasteJan-Marek Glogowski
When pasting, Calc sets a selection for the pasted cells. But this also includes the primary selection, which is unexpected. And that will eventually even update the clipboard, if a clipboard manager is configured to sync primary selection and clipboard. I actually couldn't find any other application, which select on paste at all. Normally they just replace a selection. But I guess this is very known behaviour for spreadsheets. gnumeric at least changes the primary selection on paste too. Calc also removes the system selection when clearing the selection. Other applicatios keep the primary selection valid, until the application or document closes, so do the same in Calc. We still clear the selection when we close the view in ~ScTabView(). Change-Id: I816d8caec1e0364fec20266db3fb3c63cf584865 Reviewed-on: https://gerrit.libreoffice.org/73906 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-07-16cid#1448349 Uninitialized scalar fieldCaolán McNamara
Change-Id: Iba1a4bf89ab02521e0692f217571b113e12a5b79 Reviewed-on: https://gerrit.libreoffice.org/75703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448390 Uninitialized scalar fieldCaolán McNamara
Change-Id: I72cda3927a1145acfce661d7432f3f430f0e39cc Reviewed-on: https://gerrit.libreoffice.org/75698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16LOK: getPartInfo now returns list of selected partsAshod Nakashian
For spreadsheets, selected parts are still unimplemented, so returns false for all. For presentations, visible parts seem to be always return false at load time. Change-Id: I90c79617f88deec98849bb374ca0ba177cd9c9af Reviewed-on: https://gerrit.libreoffice.org/69611 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73494 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-15cid#1448276 Dereference null return valueCaolán McNamara
Change-Id: I1f11115b730cb51d0aa59b99e15b5dacff4cd68e Reviewed-on: https://gerrit.libreoffice.org/75572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15tdf#39593 Remove SvxUnoDrawMSFactory::concatServiceNamesArkadiy Illarionov
Replace with comphelper::concatSequences Change-Id: I6b16104fac6ac5fdfcb6f322da4a5b8405d5d999 Reviewed-on: https://gerrit.libreoffice.org/75315 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-15tdf#62561 Add remove/edit hyperlink to calc context menuSamuel Mehrbrodt
Change-Id: Idb1b96dc4e95be40a796f9178975207099101b87 Reviewed-on: https://gerrit.libreoffice.org/75497 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-14-Werror=deprecatedStephan Bergmann
("implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20"; but the recommended replacement with [=,this] leads to "'this' cannot be explicitly captured when the capture default is '='" failures in older C++ versions) Change-Id: Id759c9e7d15934357425230e6a3585f4b9ee8e6b Reviewed-on: https://gerrit.libreoffice.org/75575 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-11Postpone loading of all external references, including INDIRECT()Eike Rathke
... which can be constructed with an arbitrary URI text string not an svExternal* token type, until link updates are allowed. Change-Id: I2ce4de415ff99ace04c083c36c1383d76a4ef40d Reviewed-on: https://gerrit.libreoffice.org/75422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-07-11Deduplicate URL tooltip creationSamuel Mehrbrodt
Change-Id: I94eb40ff4d727029ad764a381df300beee90481c Reviewed-on: https://gerrit.libreoffice.org/75409 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11tdf#121012 Display "Ctrl-click to follow hyperlink" inside shapes/textfieldsSamuel Mehrbrodt
Change-Id: I8def50f0de20098ebbfd2b0934825a297e1d24d0 Reviewed-on: https://gerrit.libreoffice.org/75408 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-10Postpone filter detection until link update is allowedMike Kaganski
Change-Id: I85b2185e550f2a133ceb485241ef513b40593e34 Reviewed-on: https://gerrit.libreoffice.org/75301 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-10tdf#126255 compare the URL of the exported fileJan-Marek Glogowski
xDocSh contains the original loaded file. Change-Id: Idfe15ebd637b55590ba25c521904fbb7406a6a9a Reviewed-on: https://gerrit.libreoffice.org/75328 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-09tdf#126255 handle _WIN32 with different drive lettersJan-Marek Glogowski
Copying the source comment: if the exported document is not on the same drive then the linked document, there is no way to get a relative URL for the link, because ../X:/ is undefined. Change-Id: Ic83be54d878f968daa027918ce0f588774044a94 Reviewed-on: https://gerrit.libreoffice.org/75306 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-09tdf#42949 Fix IWYU warnings in sc/incGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: I3b33b0dee7d7c9afc136510898039cab53990ddf Reviewed-on: https://gerrit.libreoffice.org/74980 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-09Fix typoAndrea Gelmini
Change-Id: I5fee961beeb7cc18f767a61a3b7d65bb4e07f47c Reviewed-on: https://gerrit.libreoffice.org/75257 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-07-09Fix Windows x64 build after commit f43f9b99603736a4d54f550052509eb5f4d04b45Mike Kaganski
... and Windows x32, if it's built with sse2 baseline (will be the default when we drop support for Windows 7). Change-Id: I2e125b49906d7e81b3e8d825b11e28e9b096e1d5 Reviewed-on: https://gerrit.libreoffice.org/75282 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-09CPU intrinsics detection (SSE, AVX)Tomaž Vajngerl
Adds CPU intrinsics detection in configure pass for compile time detection and "cpuid" runtime detection of which CPU instruction sets are available on the user device. Change-Id: I0ee4d0b22a7c51f72796d43e7383a31d03b437ad Reviewed-on: https://gerrit.libreoffice.org/75175 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-08Revert "tdf#126255 disable broken relative link unit test"Eike Rathke
This reverts commit dfdd2b0126a677960946c5ff2b905e95b978b2d5. Wrong assumptions about xlink:href, see https://bugs.documentfoundation.org/show_bug.cgi?id=126255#c5 Change-Id: Ib9522f702205befe71a1992d4811c1064ac6746f Reviewed-on: https://gerrit.libreoffice.org/75220 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-07-08Resolves: tdf#126255 correct xlink:href to escape package, tdf#79305 relatedEike Rathke
The test document wasn't adapted to contain the extra ../ to escape the ODF package. So instead of xlink:href="../xlsx/databar.xlsx" it must be xlink:href="../../xlsx/databar.xlsx" Change-Id: I545d55adf37aaa434e29f5c06c50be2380efcf4e Reviewed-on: https://gerrit.libreoffice.org/75219 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-07-08tdf#126192 (Related) Translate automatic chart axis labels in xlsGabor Kelemen
Automatic axis labels in xls format are created on a different code path than the ones in OOXML, translate these too Change-Id: Id1e8a10accf765d40d71c4fcdfec2c1acee832a2 Reviewed-on: https://gerrit.libreoffice.org/75202 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-07-08tdf#124840 Text for confirming updating external links should beRoman Kuznetsov
"Allow updating" instead "Enable Content" Change-Id: Ife53dafc1b72ebe8665a5c74a75e422a54f56136 Reviewed-on: https://gerrit.libreoffice.org/75081 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-07-08sc: the type is not Data, but DateTakeshi Abe
Change-Id: I32105e1f40ddb0c206d62f30f66054b7dbe803d0 Reviewed-on: https://gerrit.libreoffice.org/74594 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-07-07tdf#126255 disable broken relative link unit testJan-Marek Glogowski
Relative links are currently broken and this was hidden by this unit test. Funnily asserting for aURL.startsWith("..") happens to work for most tested build targets, but the link is generally wrong, even if it starts with "..". I don't know either how to retrieve the relative link from the XML nor how to generate the correct link in Calc, so this unit test can test, if the linked document exists and work correctly. So - hopefully as a temporarly measure - this disables the comparing assertion, until the bug and test are fixed. Change-Id: I165ac3ce763133fcef6cea5a8dd221b0076f1ee4 Reviewed-on: https://gerrit.libreoffice.org/75172 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-06change Calc's shortcut for dumping cell properties to Ctrl+Shift+F6Luboš Luňák
Ctrl+Shift+F9 is the recalc-all shortcut, and so my dbgutil build litters dump.xml files all over the place (especially annoying in sc/qa/unit/data dirs, as test simply try to test all files in a dir and fail because of the dump.xml). Change-Id: I4d55e0aa69104626fcaa4264dc74f37203c46021 Reviewed-on: https://gerrit.libreoffice.org/74950 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-07-06WIN fix some unit tests more generallyJan-Marek Glogowski
Fixes regressed unit test failures from commit 3f7e8ddea89f ("Enable many more unit tests on all archs"). Change-Id: I76a8f7560675b9be3765237f8368d05cff22591d Reviewed-on: https://gerrit.libreoffice.org/75155 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05cid#1448260 Argument cannot be negativeNoel Grandin
Change-Id: I147f68c04c8905aac9e790766c260a30cc061d92 Reviewed-on: https://gerrit.libreoffice.org/75141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-05Enable many more unit tests on all archsJan-Marek Glogowski
This depends on commit "Make font-based unit test depend on instdir fonts, not that it's sure that this really fixes the problem, as its origin is really unknown. It especially enables all the font-based tests I could find on all archs. Same for many more test where I couldn't see any reason they don't work generally. To get rid of even more ifdefs, it moves these from the class to the functions, so there is actually just one needed for any test. As a result some few tests run but do nothing. There is still some problem with embedded fonts on MacOS and with delayed graphics loading on Windows, so these ifdefs are kept. Change-Id: I63f8424e9debda6cbf3e5777c93245e09f8eb0f2 Reviewed-on: https://gerrit.libreoffice.org/74719 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
generated by cgit (git 2.34.1) at 2024-12-27 16:47:00 +0000