summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-02-17Improve code for Protect in viewfunc.cxxAnshu
Change-Id: If197f74945b54675c304d23cac802e3769599554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110205 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-16tdf#140252 unit test Controls in Calc are always on layer 'controls'Regina Henschel
This is the missing unit test for the case of drag-created controls in the fix in commit 1d53f3709de2956f14db31677b6c461f33843bd9. Change-Id: I3afce044588e6b5d850d948dd0cbc4df9185029d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110959 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-02-16uitest: sc: test charts are pasted in a new document...Xisco Fauli
... when the source sheet has a dot in the name I found this problem while working on another UItest. This started to work after b9652803096b68a33702601aac52e78c8a4250c6 Before this commit, the chart wasn't even pasted, due to a2e6f31c6f90e446d1462e7c80f6b1317f7825bc. Before this commit, the ranges in the pasted chart were incorrect. Not sure when this issue got fixed though. Anyway, let's add a test for it Change-Id: I152d569bfa04a0e3e6056e39b9ee59955bf9e1d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110993 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16tdf#66409: sc_ucalc: Add unittestXisco Fauli
Change-Id: I911368d5e5c90f4b0225cfe47b6b912cac9fbbdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110978 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16uitest: sc: move these tests to 'sort' folderXisco Fauli
Change-Id: Ib91417c3edd5f449074f55b2a1628e4ee2df4a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110980 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16Resolves: tdf#66409 CELL() 2nd argument range take top-left cellEike Rathke
... instead of the otherwise usual intersecting position. Change-Id: I0edbf32b39e45e1c8fe8fcd7af2c84380aa4cd6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110951 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-02-16tdf#140387 grab focus to first panel widget on panel gaining focusCaolán McNamara
otherwise focus is getting lost in these currently mixed vcl+gtk widget panels. Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16tdf#140098 sc ooxml: fix export of blank filter in non empty filtersBalazs Varga
Export blank filter value in non empty filters, as the OOXML standard required. Change-Id: I4e1e3d8e1e2e784d1b4adc5e385f200af86d18ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110762 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-15tdf#123202 calc: fix sorting of autofiltered rowsTünde Tóth
by keeping the query, when the data range contains hidden rows. Change-Id: Ib3de0c36d53b6fd4541a9cb5e53e018c29bd38c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110715 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-15tdf#139928 XLSX import: fix conditional formatting in same cell rangeTibor Nagy
Multiple conditional formatting rules of the same cell range were imported incorrectly because of missing handling of their (different) priorities and operators. Note: older unit tests were modified according to the fixed priorities. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I4b542b310642e1a85ef6281d0025b3ef2b2ba8c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110544 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-15loplugin:referencecasting in scNoel
Change-Id: I908c0d5a2a3360bb9c9c9edf925a485411515ea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-14Handle system paths and URLs properlyMike Kaganski
Avoids errors like this: make UITest_conditional_format ... Execution time for tdf117899.Tdf117899.test_tdf117899: 9.992 tearDown: calling terminate()... ...done ERROR ====================================================================== ERROR: test_tdf117899 (tdf117899.Tdf117899) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:/lo/src/core/sc/qa/uitest/conditional_format/tdf117899.py", line 64, in test_tdf117899 self.ui_test.load_file('file://' + xFilePath) File "C:\lo\src\core\uitest\uitest\test.py", line 76, in load_file component = desktop.loadComponentFromURL(url, target, 0, tuple()) uitest.test.com.sun.star.lang.IllegalArgumentException: Unsupported URL <file://C:\cygwin64\tmp\tmpfs3x8j2r/tdf117899-temp.ods>: "type detection failed" ---------------------------------------------------------------------- Change-Id: Ifbf62c0aaa72412dc0efca921f59441d09c54d90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110882 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-14Move unit conversion code to o3tl, and unify on that in more placesMike Kaganski
This also allows to easily add more units, both of length and for other unit categories. The conversion for "Line" unit (312 twip) is questionable. Corresponding entries in aImplFactor in vcl/source/control/field.cxx were inconsistent (45/11 in; 10/13 pc; 156/10 pt). They were added without explanation in commit c85db626029fd8a5e0dfcb312937279df32339a0. I haven't found a spec of the unit (https://en.wikipedia.org/wiki/Line_(unit) is not specific). I used the definition based on "by pt", "by mm/100", "by char" (they all were consistent); "by pc" seems inverted; "by twip" was half as much. This accepted conversion makes unit test for tdf#79236 pass. Change-Id: Iae5a21d915fa8e934a1f47f8ba9f6df03b79a9fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110839 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-14nullptr dereferenceMike Kaganski
Change-Id: I6a2ffddfd67784ddc2194dafba7d3eaeb6e4e12e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110854 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-14Fix typoAndrea Gelmini
Change-Id: If3697d65e9809eb8dd1f2e72a657b8be70c45e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110848 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-13tdf#134355 custom shapes are never on layer 'controls' in CalcRegina Henschel
Custom shapes were erroneously put on layer 'controls' when drag- create them. But layer 'controls' is special to force form controls to front in edit mode. Layer 'controls' is exclusively used for form controls. Change-Id: I2dd8a3b5ee6ac9bcc72f0446b17a49c037aa6731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110763 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-02-13tdf#101894: sc: Add UItestXisco Fauli
Change-Id: I3ab90dbc1963ef0589ef264c6b734cfa4357bb8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110829 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-12tdf#105301 - increase the size of the sorting keysAndreas Heinisch
During the import of a document, increase the number of shown sorting keys to match the actual size accordingly. Change-Id: I24ab596f47fadf33d0358f162d26b12c24615fa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108987 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-02-12tdf#62057: sc: Add UItestXisco Fauli
Change-Id: Ia2e7e6843a42ce00cee94dde7abf980a7bc25638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110819 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-12tdf#107097: sc: Add UItestXisco Fauli
Change-Id: Ia517095e230fd4b8395ffacac6e10347aade78aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110814 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-12cid#1472119 Uninitialized scalar fieldCaolán McNamara
experiment to see what coverity does with this syntax Change-Id: I028a111ceee5b327a04979b5497a4bc2e1e61819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110808 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-12tdf#136011: sc: Add UItestXisco Fauli
Change-Id: I2fb168a2f7147f97602ddabee6100e53fd7249cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110795 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-11Fix typoAndrea Gelmini
Change-Id: Ic49c364a0133873e00863c2b4ea03e2e18cadc20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110667 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-11devtools: move devtools from svx to sfx2Tomaž Vajngerl
It's a better suited location for devtools as we can access the classes when we handle the .uno:DevelopmentToolsDockingWindow event. Change-Id: I753ca56808804c9cf6713920f92cd7d313f1f156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110733 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-11tdf#104026: sc: Add UItestXisco Fauli
Change-Id: Id423fd75de75a70a7bd48e6104d870b63d2c744e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110753 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-11loplugin:refcounting generalise type checkingNoel
Change-Id: Ia013878ac9c2918d8eaf9aab16b291d8211e708f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110700 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-11tdf#117899: sc: Add UItestXisco Fauli
Change-Id: Iddb34ccd3455efc9ea37a7b8c12bc374a0a488d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110730 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-10uitest: sc: remove duplicated testXisco Fauli
Change-Id: Ib24bfb42cd178c51256c01965e395242323d3daa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110724 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-10tdf#140006 don't limit dropdown width to 300pixelsCaolán McNamara
let it use the full width of the cell. Keep that 300 pixel limit if we are expanding the widget width beyond its size request. Change-Id: Ifeaa9ee60e0d5649de71c960ae83270fb1afb2e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10Don't shrink row height when deleting cell contents interactively eitherTor Lillqvist
Follow-up to e763e13873adfe3c6abfa4c2dfd3ac3847e2d494. Such shrinking of row height, typically by a few silly pixels, just causes unnecessary invalidation thrash in a collaborative editing context. Change-Id: I5651ce994ba4bf82c83d7d4ef1bb8ed5bab0a66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110696 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-02-10tdf#140252 Controls in Calc are always on layer 'controls'Regina Henschel
The ctor of SdDrawLayer had set the name of the control layer to 'Controls' (uppercase), whereas the ctor of SdrLayerAdmin sets it to 'controls' (lowercase). In result, for a control object in Calc the layer was not found and therefore set to default layer ID 0. I have not investigated in detail why it was not found, but simple change the name in Calc to use 'controls' too. Second error was, that a control, which was inserted as default object via ctrl+click, had not get 'controls' als layer. Change-Id: Iaac349cda0b0dcf3f098ca3484308ac52a83aa38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110636 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-02-10cid#1472857 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib2901a8751f45a33bc125ac3f9a5fdeee94b7448 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110694 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10pass FastAttributeList around by rtl::ReferenceNoel
Change-Id: I958a22f60975c74dfaeb8469b4c0cd3759d40130 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-09tdf#123052: sc: Move UItest to CppUnitTestXisco Fauli
Change-Id: If7a30aef44a722b4c0d91ecd7626a2a39fe1290a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110652 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-09loplugin:cppunitassertequals (clang-cl)Stephan Bergmann
Change-Id: I9ab5d2047f9a13fb919c31ca66a0020feac08701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110644 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09tdf#104502 sc: skip hidden columns at printing pagesAttila Szűcs
Page calculation counted the hidden columns, resulted printing blank pages by accident. Extend GetPrintArea() and GetTableArea() to count pages without the hidden columns, too. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I4817965a675e059cdc8f81ca3bb6e128af874f2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110028 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-09tdf#140151: sc_uicalc: Add unittestXisco Fauli
For some reason, this test fails on Mac and Windows. I tried different approaches but all of them failed. See https://gerrit.libreoffice.org/c/core/+/110551 Since I don't know any other way of testing this bug, let test it at least on Linux Change-Id: I40e0afe6c850533e4a1db0fec30838a66f206512 Change-Id: Ide728ad41cf3952d1acf8fd98a64b72ee7c5cda6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110624 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-09lok: Take indent and margins into accountDennis Francis
... when painting tiles with edit-text content. Conflicts: sc/source/core/tool/editutil.cxx Change-Id: I31199c18ed5aab005d56241046a9f7109691db99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109755 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit bc025dac6ce3301f5798e8ada4fee07b415de76a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110619 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-02-09return by unique_ptr from NewGeoDataNoel Grandin
Change-Id: Iab806959d79ce828069cb16b6a7883981d85dfaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-08Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: I90d15fa6992a566e89c76dfab5fc863b33e0078a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110523 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-08Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: I1c5bfcddeb0f5619dc848bbf02408cf166bebc8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110521 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-08tdf#134059: sc: Add UItestXisco Fauli
Change-Id: I81d0afa56eee32f87f64b8d0461c95552e34525f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110582 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-08uitest: sc: blind fix for failing test (take 2)Xisco Fauli
Change-Id: Id7bc0bb4552513cdd8a287f6f239ef899c18d143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110587 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-08jsdialog autofilter: show submenu on demadSzymon Kłos
- add posibility to trigger full update - send information if docking window is visible - send close message on builder destruction Change-Id: I0b3abc5ebcacf7f9a48910edf1bf0d73e8120d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110578 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-08tdf#129940 handle text:ruby element inside text:pMark Hung
Implement ScXMLCellTextRubyContext for text:ruby. It creates two types of child elements: ScXMLCellRubyBaseContext for text:ruby-base, and ScXMLCellRubyTextContext, for text:ruby-text. Ruby text isn't used now, but can serve for future application. Change-Id: I33b778838032458ffbefc6a2835d2ae59dff30cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110088 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-02-08update pchesCaolán McNamara
Change-Id: Icf55ddda055d11b649e7607c2cdd8b6d6ddfefbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-08ofz#27846 restrict number-rows-repeated when fuzzingCaolán McNamara
to avoid uninteresting timeouts Change-Id: I20876b10589558a4431433ffd04668b17aea16cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-08Improve loplugin:cppunitassertequal for CPPUNIT_ASSERT(a && b)Stephan Bergmann
...by re-enabling the code temporarily #if'ed-out in a528392e71bc70136021be4e3d83732fccbb885e "Fixed/improved loplugin:cppunitassertequals" (and which then triggers lots of other lopglugin:cppunitassertequal CPPUNIT_ASSERT -> CPPUNIT_ASSERT_EQUAL warnings). For two css::uno::Reference equality comparisons in cppu/qa/test_any.cxx, it was more straightforward to rewrite them with an explicit call to operator == (which silences loplugin:cppunitassertequal) than to adapt them to CPPUNIT_ASSERT_EQUAL's requirement for arguments of identical types. In sc/qa/unit/ucalc_pivottable.cxx, ScDPItemData needs toString, which has been implemented trivially for now, but might want to combine that with the DEBUG_PIVOT_TABLE-only ScDPItemData::Dump. Change-Id: Iae6d09cf69bd4e52fe4411bba9e50c48e696291c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110546 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-08tdf#94235 Add support for series name in data series labelsSamuel Mehrbrodt
including ODF/OOXML import/export (and test) Change-Id: Id5a5194630a67476f7c5390294400a00ea3ad42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110338 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-02-07prevent reference range resetting on panning in mobilePranam Lashkari
Change-Id: Ic6cabe1d4e5a1e7c4d42294550d654e38e27db22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110458 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-24 02:04:15 +0000