summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-12-20loplugin:duplicate-definesNoel Grandin
move these into their own file, the way we do elsewhere Change-Id: Ib97e09c80537e31d795a8c66a6dfb06b350ff0e2 Reviewed-on: https://gerrit.libreoffice.org/85560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20loplugin:duplicate-definesNoel Grandin
just include the header file which has a shared definition Change-Id: I7412cc2c87ab1c757a82ac3f307a3a07c3289980 Reviewed-on: https://gerrit.libreoffice.org/85561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20loplugin:duplicate-definesNoel Grandin
duplicates in same file Change-Id: I3f700bf3d7641f544f007a2a662a414a579156e4 Reviewed-on: https://gerrit.libreoffice.org/85559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20tdf#129228 speedup load xls file with lots of commentsNoel Grandin
by locking the underlying SdrModel while the comments are added, so we avoid the reformatting that happends when the model is unlocked Takes the time from 3m30 to 1m for me. Change-Id: Ibc3d2b1ded548d5eee7715d9a655a0af61b0eb2b Reviewed-on: https://gerrit.libreoffice.org/85523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-19Remove commaAndrea Gelmini
Change-Id: Ie8b573d2b319c046013e7189fa3cc19c9409f499 Reviewed-on: https://gerrit.libreoffice.org/85517 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-19lok: send "EMPTY" if the rect is empty for cell selection or fillTomaž Vajngerl
It can happen that the selection or auto-fill rectangles are empty and if that's the case then we need to send "EMPTY" string and not the content of an empty rectangle (0, 0, -32768, -32768). This can happen for CELL_SELECTION_AREA or CELL_AUTO_FILL_AREA in calc. Change-Id: I9a60e3907a2ab8b0e0fd1a2ff81137fba6c8e9a3 Reviewed-on: https://gerrit.libreoffice.org/85441 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-18Unit test insert with shared formula group shift, tdf#129396Eike Rathke
Change-Id: I99ab71f6fba4eb9f83fe8c262a6549a236ccf1ec Reviewed-on: https://gerrit.libreoffice.org/85422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-12-18Resolves: tdf#129396 Refresh shared formula group area listeners upon shiftingEike Rathke
Regression from commit 47230a036fe35b9a7a7c0609232849fcbb51efcc CommitDate: Thu Feb 5 11:52:51 2015 +0100 Resolves: tdf#88792 do not hold a ScFormulaCell** in group area listener where previously the listener position's column was taken from the group's remembered top formula cell (then updated) position, which holding the cell was wrong in other cases. Change-Id: Ida1503daa7cbda2b41459ff5d63652a6febd91e0 Reviewed-on: https://gerrit.libreoffice.org/85347 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-12-17Fix typo in codeAndrea Gelmini
Change-Id: I32f99d6dbdaa52f53bd630b611d13decf110fd75 Reviewed-on: https://gerrit.libreoffice.org/85318 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-12-17Removed duplicated includeAndrea Gelmini
Change-Id: Iaa0b6006b53b2f20f9eb6e86f081211bf60d19bf Reviewed-on: https://gerrit.libreoffice.org/85311 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17tdf#129435: Fix menu referenceXisco Fauli
Regression from 81f01259dfe29b7ee73c42d3b44934d6fc973cd8 Change-Id: Ibeb094d7dfd998322acf88bdc38fe1f15d524e78 Reviewed-on: https://gerrit.libreoffice.org/85306 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-17ScSheetLimits must be a complete type here (Windows --disable-pch)Stephan Bergmann
...after 113444f59dc7690850919155b9b164b1a686bbe7 "sc: rowcol: tdf#50916 create ScSheetLimits to hold by rtl::Reference", due to the MSVC rules of emitting definitions of implicit member functions of dllexport classes: > In file included from sc/source/ui/condformat/condformathelper.cxx:14: > In file included from sc/inc\conditio.hxx:30: > In file included from sc/inc/tokenarray.hxx:24: > include\rtl/ref.hxx(74,20): error: member access into incomplete type 'ScSheetLimits' > m_pBody->acquire(); > ^ > sc/inc/tokenarray.hxx(69,5): note: in instantiation of member function 'rtl::Reference<ScSheetLimits>::Reference' requested here > ScTokenArray( const ScTokenArray& ) = default; > ^ > sc/inc/tokenarray.hxx(47,8): note: forward declaration of 'ScSheetLimits' > struct ScSheetLimits; > ^ Change-Id: I4e79340f52e92b88c43fa5b78aa69ed49b367705 Reviewed-on: https://gerrit.libreoffice.org/85260 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17Add missing DoClose of test documentsStephan Bergmann
I had added these while tracking down some issue which ultimately turned out to be unrelated to this. But looks like it can't hurt to explicitly close these documents, as is already done in all the other tests in this file. Change-Id: I32f8b3cb38264aac4b7c5982430006b374142be0 Reviewed-on: https://gerrit.libreoffice.org/85264 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17Resolves tdf#129127: do a safe swap of patternsDennis Francis
Following swap of patterns is not safe : """ const ScPatternAttr* pPat1 = GetPattern(nRow); const ScPatternAttr* pPat2 = rOther.GetPattern(nRow); SetPattern(nRow, *pPat2); rOther.SetPattern(nRow, *pPat1); """ as the first SetPattern can cause deallocation of the pattern object pointed to by pPat1 if it had a reference count of 1 to begin with. In such cases, increase the reference count of first pattern by putting it into document pool, thereby evading deallocation. The stacktrace of the crash without the fix looks like : Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault. 602 SfxPoolItem *pPoolItem = rItem.Clone(pImpl->mpMaster); 0 0x00007ffff4ad2905 in SfxItemPool::PutImpl(SfxPoolItem const&, unsigned short, bool) (this=0x16c6830, rItem=..., nWhich=39321, bPassingOwnership=false) at /ssd1/work/dennis/core/svl/source/items/itempool.cxx:602 1 0x00007fffd179e5a5 in ScDocumentPool::PutImpl(SfxPoolItem const&, unsigned short, bool) (this=0x16c6830, rItem=..., nWhich=0, bPassingOwnership=false) at /ssd1/work/dennis/core/sc/source/core/data/docpool.cxx:333 2 0x00007fffd14e88fb in SfxItemPool::Put<ScPatternAttr>(ScPatternAttr const&, unsigned short) (this=0x16c6830, rItem=..., nWhich=0) at /ssd1/work/dennis/core/include/svl/itempool.hxx:154 3 0x00007fffd14dd228 in ScAttrArray::SetPatternAreaImpl(int, int, ScPatternAttr const*, bool, ScEditDataArray*, bool) (this=0x2cbc020, nStartRow=9, nEndRow=9, pPattern=0x2da5d80, bPutToPool=true, pDataArray=0x0, bPassingOwnership=false) at /ssd1/work/dennis/core/sc/source/core/data/attarray.cxx:464 4 0x00007fffd1653fcd in ScAttrArray::SetPattern(int, ScPatternAttr const*, bool) (this=0x2cbc020, nRow=9, pPattern=0x2da5d80, bPutToPool=true) at /ssd1/work/dennis/core/sc/inc/attarray.hxx:142 5 0x00007fffd163cd41 in ScColumn::SetPattern(int, ScPatternAttr const&) (this=0x2cb4610, nRow=9, rPatAttr=...) at /ssd1/work/dennis/core/sc/source/core/data/column.cxx:694 6 0x00007fffd170e65b in ScColumn::Swap(ScColumn&, int, int, bool) (this=0x2339270, rOther=..., nRow1=0, nRow2=9, bPattern=true) at /ssd1/work/dennis/core/sc/source/core/data/column4.cxx:1112 7 0x00007fffd1ada654 in ScTable::SortReorderByColumn(ScSortInfoArray const*, int, int, bool, ScProgress*) (this=0x2cb9ea0, pArray=0x5ef71a0, nRow1=0, nRow2=9, bPattern=true, pProgress=0x7fffffff09a0) at /ssd1/work/dennis/core/sc/source/core/data/table3.cxx:922 8 0x00007fffd1adf991 in ScTable::Sort(ScSortParam const&, bool, bool, ScProgress*, sc::ReorderParam*) (this=0x2cb9ea0, rSortParam=..., bKeepQuery=false, bUpdateRefs=false, pProgress=0x7fffffff09a0, pUndo=0x7fffffff0950) at /ssd1/work/dennis/core/sc/source/core/data/table3.cxx:1750 9 0x00007fffd17cc70a in ScDocument::Sort(short, ScSortParam const&, bool, bool, ScProgress*, sc::ReorderParam*) ( this=0x2cc4db0, nTab=0, rSortParam=..., bKeepQuery=false, bUpdateRefs=false, pProgress=0x7fffffff09a0, pUndo=0x7fffffff0950) at /ssd1/work/dennis/core/sc/source/core/data/documen3.cxx:1411 10 0x00007fffd22a2f76 in ScDBDocFunc::Sort(short, ScSortParam const&, bool, bool, bool) (this=0x7fffffff0b50, nTab=0, rSortParam=..., bRecord=true, bPaint=true, bApi=false) at /ssd1/work/dennis/core/sc/source/ui/docshell/dbdocfun.cxx:578 11 0x00007fffd2744e29 in ScDBFunc::Sort(ScSortParam const&, bool, bool) (this=0x2e3b560, rSortParam=..., bRecord=true, bPaint=true) at /ssd1/work/dennis/core/sc/source/ui/view/dbfunc.cxx:217 12 0x00007fffd2744d7b in ScDBFunc::UISort(ScSortParam const&) (this=0x2e3b560, rSortParam=...) at /ssd1/work/dennis/core/sc/source/ui/view/dbfunc.cxx:208 13 0x00007fffd2735e3d in ScCellShell::ExecuteDB(SfxRequest&) (this=0x1e42330, rReq=...) at /ssd1/work/dennis/core/sc/source/ui/view/cellsh2.cxx:528 Change-Id: I70f8b95a6ff59f372b909fd173117a114906deff Reviewed-on: https://gerrit.libreoffice.org/85072 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-12-16LOK: emit modified status on entering cell dataAshod Nakashian
Entering data into a cell without committing will normally not set the modified flag. However clients might want to know whether there is in-flight changes when they need to save the document. A possible scenario is that the user enters some cell data and then closes the window. Both WSD and the client app would here rely on the modified notification to decide whether to save the document or not. We do not change the document modified state, since that may be incorrect (in case the user actually cancel the cell entry), so we preserve that so future updates to the modified status would reflect the correct state of the file. Instead, we emit a client notification that the document has been modified, to signal them that saving is sensible. Note that ideally we would undo this when the user cancels the cell edit, but that would be complicated due to multi-editor scenarios. For example, another user might actually edit the document while we cancel our cell edit, and in this case we should not reset the modify flag. Since this is unreliable, we leave the flag set, unless the Core emits an update, which will surely be accurate. Reviewed-on: https://gerrit.libreoffice.org/75513 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 38b899312245758381fa72ad17c2d4c281edb1ba) Reviewed-on: https://gerrit.libreoffice.org/78451 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Change-Id: Id26aa6f8ce2c0a08f8bee6812fcf99275dc24551 Reviewed-on: https://gerrit.libreoffice.org/82093 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-16lok: calc - update our version of the other view's selections on zoom.Michael Meeks
Change-Id: I4d23bb77045b41d04109e7dd70a1f47bca8aaa56 Reviewed-on: https://gerrit.libreoffice.org/84767 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84768 Tested-by: Jenkins
2019-12-16crashtesting: null deref on load of tdf113898-2.odsCaolán McNamara
Change-Id: Ie6e00af220d1ee65c363224abcf63ece2e7bff6f Reviewed-on: https://gerrit.libreoffice.org/85206 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-16crashtesting: null deref on export to odsCaolán McNamara
of EDRM_Data-Set_File-Formats_1-0/data-set/dbs/PICTURES.DBF Change-Id: Id501c1fe24aa42d25974cee7d35693f8d221d067 Reviewed-on: https://gerrit.libreoffice.org/85208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-16lok: calc - send other views our selection in their co-ordinates.Michael Meeks
Change-Id: If48b5adb9b8b03310d2d2c4e4fefab84ad8bb149 Reviewed-on: https://gerrit.libreoffice.org/84370 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/85085 Tested-by: Jenkins
2019-12-15NB tabbed compact Menu File Buttonandreas kainz
Change-Id: I50b03f34e878f6bed97e1f3752485d2e9ecd5e55 Reviewed-on: https://gerrit.libreoffice.org/85179 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-15NB groupedbar compact extension supportandreas kainz
Change-Id: Iae7d2be29a393bacf40996aa9fb021b84c7284cd Reviewed-on: https://gerrit.libreoffice.org/85155 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-15Use SvxBkgTabPage::GetRanges for new background tab pagesJim Raykowski
Commit 03facb4bb75e4283c91de6f081ee96137ca4346c introduced GetRanges function for SvxBkgTabPage. This patch replaces all uses of SvxBackgroundTabPage::GetRanges for new background tab pages with SvxBkgTabPage::GetRanges. Change-Id: I5dd16617d25b09bcf2e02656abd84db25f7b614e Reviewed-on: https://gerrit.libreoffice.org/85137 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-12-14sc: rowcol: convert mark dataNoel Grandin
with this patch I can finally load a 3201 column document Change-Id: I880d485b3f628836e7aed92c276e660466a3b19c Reviewed-on: https://gerrit.libreoffice.org/85139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-14sc: rowcol: tdf#50916 convert Valid* methodsNoel Grandin
which means we end up passing around ScDocument* __everywhere__ Change-Id: I44d235ca5e9d57519f068b6880ee7d66f3ceb529 Reviewed-on: https://gerrit.libreoffice.org/83548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-13sc: rowcol: tdf#50916 create ScSheetLimits to hold by rtl::ReferenceNoel Grandin
ScTokenArray sometimes outlives the ScDocument that created it, which means it accesses dead data when it tries to validate columns and rows. So create the ScSheetLimits class, which ScTokenArray can hold by reference counted pointer. Change-Id: Ic5771734fe4962d12f024fc1b29232124c14208a Reviewed-on: https://gerrit.libreoffice.org/85117 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-13tdf#120948: row deltas should be stored as SCROW...Deena Francis
instead of SCCOL, else it may cause overflows. Also included a unit test for protecting the fix. Change-Id: I8f735b23b7f95ecf34ccae86f00c76b82b0d668f Reviewed-on: https://gerrit.libreoffice.org/85118 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-13Resolves: tdf#128077 cancel goalseek subdialogs on forced removalCaolán McNamara
Change-Id: Ifd0d81d8b5e1b6bea68e74be1cebf082e24d6dde Reviewed-on: https://gerrit.libreoffice.org/85114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13cancel solver subdialogs on forced removalCaolán McNamara
Change-Id: Idd99af070c1ed20ecc458fb17f194a56b9d37cc3 Reviewed-on: https://gerrit.libreoffice.org/85113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13use runAsync for dialog inside another runAsync dialogCaolán McNamara
Change-Id: Ia0196db2e74ca938ac54f45de5a6d5367ea19690 Reviewed-on: https://gerrit.libreoffice.org/85112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13sc: rowcol: tdf#50916 pass ScDocument* around in filter/Noel Grandin
Change-Id: Id328ee85b852eddf755876d2cde9ef75b40cfca1 Reviewed-on: https://gerrit.libreoffice.org/85090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-13sc: rowcol: tdf#50916 pass ScDocument* around in data/Noel Grandin
Change-Id: Ifa99d1c8d593e2a5dd81a3aaf4cd702d3ba96b89 Reviewed-on: https://gerrit.libreoffice.org/85060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12use covariant return type for SfxPoolItem::CloneCaolán McNamara
and can then remove some casting Change-Id: Id821c32ca2cbcdb7f57ef7a5fa1960042e630ffc Reviewed-on: https://gerrit.libreoffice.org/85022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12ScShapeChild has broken copy functionsStephan Bergmann
...as its dtor calls mpAccShape->dispose() on the copied pointer member, thus potentially calling dispose too early (and multiple times, but which in itself should be harmless). The copy functions are used when vectors of ScShapeChild (as used in ScShapeRange) get sorted with std::stort (which requires ScShapeChild to be moveable, but as the move functions are implicitly deleted because of the user-declared dtor, the implicitly defined copy functions are used instead). So turn ScShapeChild into a move-only class, clearing mpAccShape in moved-from instances. (The issue appears to exist ever since the code got introduced with e916b33bde0e863d33fdbb09dfd08c847ab76f20 "#95584#; add notes and shape support". It was found with Clang 10 trunk -Wdeprecated-copy-dtor.) Change-Id: Ib71262048c5af3f02716d03c3acd7d977bc66e07 Reviewed-on: https://gerrit.libreoffice.org/85066 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12Prevent BroadcastRecalcOnRefMoveHandler copiesStephan Bergmann
...which would contain copies of AutoCalcSwitch and ScBulkBroadcast that both do things in their dtors. std::sort (into which BroadcastRecalcOnRefMoveHandler is passed as function object argument) returns its function object argument, which caused the BroadcastRecalcOnRefMoveHandler copies. Better split the RAII part that holds AutoCalcSwitch and ScBulkBroadcast and does things in their dtors into a BroadcastRecalcOnRefMoveGuard class of its own. (And while at it, explicitly delete the copy/move functions of AutoCalcSwitch and ScBulkBroadcast to avoid such issues in the future.) (The RAII part of BroadcastRecalcOnRefMoveHandler had been added with 60d0b992ea3a910be79ae4a8e8b0bb32a358b18a "sc-perf: tdf#87101 add bulk scope for BroadcastRecalcOnRefMove() calls". The issue was found with Clang 10 trunk -Wdeprecated-copy-dtor.) Change-Id: I45d6b81e7c8b34aed57b6f66c5e1e966a43a565d Reviewed-on: https://gerrit.libreoffice.org/85063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12sc: rowcol: tdf#50916 pass ScDocument to the token classesNoel Grandin
needed to create a fake ScDocument for the external ref manager, since it has no ScDocument at all Change-Id: Ia786ac291133e3c438694e81ecfb2590729a853d Reviewed-on: https://gerrit.libreoffice.org/85050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12This shall presumably be ScVerticalStackCellStephan Bergmann
(changed from SfxBoolItem(ATTR_STACKED,...) in 2579895f2c18fd7d606715f91b1463900f6d6937 "Related: tdf#129300 add ScVerticalStackCell to provide a description") Change-Id: I665f5c0a7f5059721e38330e06ce52bd18eae362 Reviewed-on: https://gerrit.libreoffice.org/85062 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12Remove some redundant user-provided dtorsStephan Bergmann
...which silences various -Wdeprecated-copy-dtor warnings from Clang 10 trunk about copy functions being implicitly defined as non-deleted even though the class has a user-declared dtor Change-Id: I3409d403c3c709de4ad94eccbc2d7869e41847cc Reviewed-on: https://gerrit.libreoffice.org/85032 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12Silence some Clang 10 trunk -Wdeprecated-copy-dtorStephan Bergmann
...by explicitly defaulting the copy/move functions in cases where the user- provided dtor is trivial (so could theoretically be replaced with an implicit one, cf. <https://gerrit.libreoffice.org/#/c/85032/> "Remove some redundant user-provided dtors") but is probably defined out-of-class because the class is DLLPUBLIC Change-Id: Iff5e86654b10c7a03333c06312dc5dfce925d947 Reviewed-on: https://gerrit.libreoffice.org/85041 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12loplugin:finalclassesNoel Grandin
Change-Id: Ia9865271cf0a75ebf4b885ff376f7d0a152b2555 Reviewed-on: https://gerrit.libreoffice.org/84925 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12ATTR_SHRINKTOFIT is ScShrinkToFitCellCaolán McNamara
Change-Id: Ia5d50e8be174869439400e0cd7d02d54429c7433 Reviewed-on: https://gerrit.libreoffice.org/85021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12Fix UBSan dynamic-type-mismatchStephan Bergmann
...as seen after 331cafb1484597544bd94fa3f0e0a45b3328a4d8 "Related: tdf#129300 add ScLineBreakCell to provide a description" during CppunitTest_sc_ucalc: > sc/inc/patattr.hxx:76:14: runtime error: downcast of address 0x60200056aaf0 which does not point to an object of type 'const ScShrinkToFitCell' > 0x60200056aaf0: note: object is of type 'ScVerticalStackCell' > 6f 00 00 60 70 7b f7 16 b0 7f 00 00 ff ff ff ff 86 00 02 00 02 00 00 00 ff ff ff 04 10 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'ScVerticalStackCell' > #0 in ScShrinkToFitCell const& ScPatternAttr::GetItem<ScShrinkToFitCell>(TypedWhichId<ScShrinkToFitCell>, SfxItemSet const&, SfxItemSet const*) at sc/inc/patattr.hxx:76:14 > #1 in ScPatternAttr::GetCellOrientation(SfxItemSet const&, SfxItemSet const*) at sc/source/core/data/patattr.cxx:152:9 > #2 in ScPatternAttr::GetCellOrientation(SfxItemSet const*) const at sc/source/core/data/patattr.cxx:170:12 > #3 in ScColumn::GetOptimalHeight(sc::RowHeightContext&, int, int, unsigned short, int) at sc/source/core/data/column2.cxx:809:43 > #4 in (anonymous namespace)::GetOptimalHeightsInColumn(sc::RowHeightContext&, ScColContainer&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:92:17 > #5 in ScTable::SetOptimalHeight(sc::RowHeightContext&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:466:5 > #6 in ScDocument::SetOptimalHeight(sc::RowHeightContext&, int, int, short) at sc/source/core/data/document.cxx:4274:18 > #7 in ScDocFunc::AdjustRowHeight(ScRange const&, bool) at sc/source/ui/docshell/docfunc.cxx:156:26 > #8 in ScDocFunc::InsertCells(ScRange const&, ScMarkData const*, InsCellCmd, bool, bool, bool) at sc/source/ui/docshell/docfunc.cxx:2146:25 > #9 in Test::testFormulaRefUpdateInsertRows() at sc/qa/unit/ucalc_formula.cxx:2247:11 Change-Id: I12b95a8229bac8d67d85f2a5a90a5e2e286a6981 Reviewed-on: https://gerrit.libreoffice.org/84996 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-11tdf#119191 Implement SdrObjCustomShape::AdjustToMaxRectRegina Henschel
and use in ScDrawLayer::RecalcPos and in ScDrawView::FitToCellSize(). Error was, that it was assumed, that SdObjCustomShape::SetSnapRect() changes the shape so, that it fits into the passed rectangle. That is true for other type of shapes, but not for custom shapes. Change-Id: Ib00d52087509f459165000abf43c7f244980a01b Reviewed-on: https://gerrit.libreoffice.org/84216 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-12-11jsdialog: send items on status changeSzymon Kłos
Use existing mechanism, delete sending in getter code which caused unnecessary work. Change-Id: Ibc191c16b95fd58e7065e019f48f3837cfed5bbd Reviewed-on: https://gerrit.libreoffice.org/84914 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-12-11Related: tdf#129300 add ScIndentItem to provide a descriptionCaolán McNamara
Change-Id: Ieb1a12f35cf8974c557c6e52eac0cd9fb7f80914 Reviewed-on: https://gerrit.libreoffice.org/84945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScHyphenateCell to provide a descriptionCaolán McNamara
Change-Id: If00a50a36cf2bb5c9b775a4ca1000af5c5be7bf4 Reviewed-on: https://gerrit.libreoffice.org/84892 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScLineBreakCell to provide a descriptionCaolán McNamara
Change-Id: Ief739616163c68e0e30d6287fdac90c1bcc9d13f Reviewed-on: https://gerrit.libreoffice.org/84879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11sc: rowcol: tdf#50916 initial conversion of Valid* methodsNoel Grandin
just default the params for now Change-Id: I13ee78aeaa1133a167d57520b334d5e644e28ece Reviewed-on: https://gerrit.libreoffice.org/84926 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11Related: tdf#129300 add ScVerticalStackCell to provide a descriptionCaolán McNamara
Change-Id: I8ed99f19ff6f4751c0867147fc1a60ac917f083b Reviewed-on: https://gerrit.libreoffice.org/84876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Fix typoAndrea Gelmini
Change-Id: Idbcf73ea3034b62e283537e052c17a9fb3988a8b Reviewed-on: https://gerrit.libreoffice.org/84918 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-10Calc add Extension support to Tabbed NBandreas kainz
Change-Id: I2a6e17d8c9a126155ec599fe50d6d84d074c8ddc Reviewed-on: https://gerrit.libreoffice.org/84878 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-21 09:34:49 +0000