Age | Commit message (Collapse) | Author |
|
...since
<https://github.com/llvm/llvm-project/commit/abf3ca61e3235681f26d0f527b8e2763dd4c0c62>
"[Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment
operator is defined as deleted (PR45634)"
Change-Id: I43ae8a620915ad211a1f21ecf89b6955b7d2faaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114674
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ib2df6c1cbe3bc36df085f310db24810b33ec85e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114612
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
visible cells report wrong number because of the wrong grid size is
retrieved that in turn is due to the fact that the size of the visible
area in Online is used to set up only the active pane,
So when we have windows splitting, even though there is no real split,
the height can be computed using a non active pane whose size is not
be synchronized with Online.
Until we lack that synchronization, we use the implemented workaround
for fixing the problem.
Change-Id: I9df9e4b0ef77a2a8a5847ce77fe90d83ec75019d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114429
Tested-by: Jenkins
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
|
|
Change-Id: I4021d07a2c011c2d5b2e79ecd878019d29cabd21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114567
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Until now the form controls were nto rendered to a tile when
drawing tiles for LOKit usage (online). This change adds
LokControlHandler that is responsible for rendering of the
form controls on the tiles (currently implemented only for Calc)
and handles mouse input events that come through LOKit.
Change-Id: Ifcecc9a320a7836b76b0a10771b06c15339baed2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114635
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I930445e9047478b26142d049598fbe656d25d666
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114628
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Without that, it doesn't make sense to compare values smaller than
10^-20, where ROUND(val;20) returns 0; ROUND does not accept count
greater than 20.
ROUNDSIG was implemented in tdf#105931 with unit testing in mind.
Change-Id: I20cbe4d116373d1b783b781a1dfdb6c94fe13833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114625
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I6f2ec861571ed947ecbd267bc721fb9a3f5ceea9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114594
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I52af3509afde02dae494747527ab800590682fa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114591
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibd1b3d54ff94eb5a3e7ce92d9c790721bbe23c85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114378
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
bIsMultiRangeRowFilteredTranspose can only be true if bIncludeFiltered is false
so nRowCountInRange is always set from nRowCountNonFiltered, and nRowCountAll
is then unused
Change-Id: I6b15a9d84b5db475a2ba2e230acc5d09d588dfce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114588
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ied615268001b580a3f51726cd0e57189a00e3c60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114570
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
so return early instead of looping to do nothing
though that was introduced by
commit b41332475783c31136673fb44cf4c411bb0148f8
Author: Steve Yin <steve_y@apache.org>
Date: Mon Dec 2 15:54:29 2013 +0000
Integrate branch of IAccessible2
so maybe its existance is dubious
Change-Id: Ibb8fe1409a8e66d37d51d9a1b99ce135f36b9522
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114565
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ifaff6a048b9d174a9aa3fc9dabf62c1f8c509eb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114572
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: Ic52623ac8ca6e0758578b7ae57332f0e9c184b5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114573
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: I0a8279429c9e0d884a5e8fbb8f22617832385a53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114574
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
if the number of items exceeds 1000, just stop, the UI
becomes unresponsive.
This takes the load time from 24s to 17s on my machine, and also
makes clicking around much better (because it rebuilds the tree on
every single cursor click)
Change-Id: Ib32578306d1098fe9953d8c96b6926110c64d1c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114553
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id4e7778ffcbeadf53684e5b6814d139e82bcf7e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114555
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
gen uses the absolute screen position so that's what's expected
Change-Id: I4f51c272a49a640e0a387bc123b2cc17ea430d6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114551
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Filtered rows do not belong to a selection and are not pasted.
Change-Id: I03e1c03c42b508e24194b769a466611503ce44d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113991
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
I did not write any tests, as the multi range copying to system clipboard
has another issue, see tdf#141847
Change-Id: I3af58d68370038274a07d753809fb4ceca9016f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114534
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
revert...
commit f97dbac73fe149e8fed0932890d0c1d6be4869a3
Author: Caolán McNamara <caolanm@redhat.com>
Date: Wed Jun 26 21:00:02 2019 +0100
infinite focus changing in toc biblio page
which blocked calling focus-changed callbacks when grab_focus is called
explicitly analogous to how we block value-changed callbacks setting
values through code but don't block them when the value is changed by
user interaction.
In retrospect that was a poor choice, so revert that and subsequent
workarounds in favour of just not calling gtk_grab_focus if the widget
already has focus.
checked:
a) tdf#138427 focus set to wrong input box
b) tdf#138078 only call GetFocus if we gained focus from an unfocused state
c) tdf#137993 ensure the toplevel vcl::Window is activated
d) tdf#136941 call focus in handler explicitly
Change-Id: I411480e2d627aa9995fb41b0aa17e9fb6d34d73f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114524
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
so its in the expected state when the child contents are created
Change-Id: Id5baaca8479334c8fa2ec60ce8b598b7a61a3d7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114481
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Bug 101217 - Setting the column width and height should not round
the values causing compounding errors
This patch fixes the problem caused by rounding errors by
increasing the number of decimal places for row height,
optimal row height, column width, and optimal column width to 4.
Change-Id: Iefb5ef09af3bd81d429cf17386c8b1a54e111957
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113824
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: Ieef4cc320067dae96b11610e544f9eb7260f8f5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114471
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Row filtering, Special Paste transposing and multi range selections had
various issues. Since the same methods are used in different code paths,
I made a unified fix for these issues.
Moreover, Special Paste dialog allows the combination of options.
There are about 50 test cases for these various combinations of filtering,
selection, transposing and pasting options.
The following cases are supported and checked in test combinations:
* Transposing
* Filtering
* Multi range column and row selection
* All cell types: number, string, formula, rich text, empty
* Notes
* Formatting patterns (e.g. cell backgrounds and borders)
* Empty cell skipping
* Special Paste as link
* Merged cells
* Formula references:
* Relative and absolute references
* References to rows before and after filtered row
* References to filtered row
* Double references (e.g. A1:A3)
Notably the following cases are fixed and tested:
* Transposing of filtered data (tdf#107348)
* Copy/Paste of filtered multi range selections (tdf#45958)
* Transposing of filtered multi range selections (tdf#107348, tdf#45958)
* Notes at different position (tdf#141215 ^)
* Transposed multi range selection pasted as link (tdf#141683 ^)
^ = discovered during tests
Due to the unit tests, I refactored some code. Mainly, I extracted
methods to improve the readability and to avoid code duplication.
Change-Id: Iccccd17d3b4deee29ac5fc7c11e17244da0d4054
Change-Id: I43cf630890e0081e55fd04cf2f8e5afdb6d9bebe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114450
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
it just creates an unnecessary temporary
Change-Id: Ide3cd99b2ac4f2a621e5d55ce4bdc95d05430709
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114467
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ideb436dbbef1c6fb36cae93e5dd55ef2d00698c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114454
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: Ie676a88546bd7ee1a077aba4c3322307b14319a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114457
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The RSQ/PEARSON functions return values greater than one, if the divisors are below the numerical limits.
Change-Id: Ice224315072afafc6206c367f219771adebe23ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114301
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ic5fec6f1dd76aab6b11e822d127f0eb4c705ffae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114388
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Text and empty cells in the value range are ignored.
Change-Id: I0790a83c79d3861afa855bf89a1c4eb39eb6d638
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113971
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: If55f04a71516e80637c9c26d2ccfcddeac06e90f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114389
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie7190aa94fc62e8e53c06b5edc8b6ecaf43a5531
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114384
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: I656f06a74d9f0180ae460264563d6a935c7d2c60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114377
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Fix:
Reset position cache for all sheets on zoom change.
Change-Id: I58264d4674d2cb736c702096ffd52faffb603ec6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114227
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit fe52c79323f9ac4b5ea61e7d7e5f038552e9a247)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114363
Tested-by: Jenkins
|
|
See bt:
6 0x00007f276e146773 in ScChartsObj::getByName(rtl::OUString const&) (this=0x7738e00, aName="Object 1") at sc/source/ui/unoobj/chartuno.cxx:345
7 0x00007f276e146865 in non-virtual thunk to ScChartsObj::getByName(rtl::OUString const&) () at sc/source/ui/unoobj/chartuno.cxx:348
8 0x00007f27a1d87b7f in (anonymous namespace)::NameAccessTreeEntry::fill(std::unique_ptr<weld::TreeView, std::default_delete<weld::TreeView> >&, weld::TreeIter const&)
(this=0x6d463e0, pDocumentModelTree=std::unique_ptr<class weld::TreeView> = {...}, rParent=...) at sfx2/source/devtools/DocumentModelTreeHandler.cxx:139
9 0x00007f27a1d87905 in (anonymous namespace)::ChartsEntry::fill(std::unique_ptr<weld::TreeView, std::default_delete<weld::TreeView> >&, weld::TreeIter const&)
(this=0x6d463e0, pDocumentModelTree=std::unique_ptr<class weld::TreeView> = {...}, rParent=...) at sfx2/source/devtools/DocumentModelTreeHandler.cxx:596
10 0x00007f27a1d842e5 in DocumentModelTreeHandler::ExpandingHandler(weld::TreeIter const&) (this=0x76e3850, rParent=...) at sfx2/source/devtools/DocumentModelTreeHandl
chart isn't retrieved from there:
0 sc::tools::findChartsByName(ScDocShell*, short, std::basic_string_view<char16_t, std::char_traits<char16_t> >, sc::tools::ChartSourceType)
(pDocShell=0x351baa0, nTab=0, rName=u"Object 1", eChartSourceType=sc::tools::ChartSourceType::CELL_RANGE) at sc/source/ui/unoobj/ChartTools.cxx:106
1 0x00007f6297305323 in ScChartsObj::GetObjectByName_Impl(rtl::OUString const&) const (this=0x77ce370, aName="Object 1") at sc/source/ui/unoobj/chartuno.cxx:126
2 0x00007f62973076b4 in ScChartsObj::getByName(rtl::OUString const&) (this=0x77ce370, aName="Object 1") at sc/source/ui/unoobj/chartuno.cxx:343
Indeed, if graph hasn't type ChartSourceType::CELL_RANGE, it could be ChartSourceType::PIVOT_TABLE
Change-Id: Id5a248535b214ad5f114671c52e4592d87c9f54a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113777
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I692e7a2dab068f0fc19d9612dbc36f5ad2abfe5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114343
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
When multiple objects' glue points collide the ordnum
will be used to decide which glue point to connect to
for the connectors. Without that the default logic chooses
the lowest ordered object which is searched and found in the object list
Change-Id: I64579d28bbe6cbd92bab745838fe2995585b6a3f
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113517
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114032
Tested-by: Jenkins
|
|
We add them directly for LOK case and have no functionality
for interactive drawing.
Noticed that in Writer we didnt even add them directly
I also implemented that as well.
Change-Id: If90bfc8d2cdf84f200bc7963ae4126ef789524ff
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112703
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114025
Tested-by: Jenkins
|
|
Change-Id: I5d27824694e38de540e5f1fcd8704f8777f65140
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114261
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Notebookbar load takes some time. We don't use most of
the items in online so minify .ui file to contain
only needed widgets.
Change-Id: I4796caae14bb63e3e04d318093209adfb87a77df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113623
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114154
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: I869c1cf23d8055b0327ca486bbfbc68dd98af842
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114250
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I6d3e10fa945da303b1af69b1d631bd2dc8cdab43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114228
Tested-by: Jenkins
Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
|
|
Click on the filter button of cells merged horizontally
showed the "Empty" entry instead of the filter list.
Pressing Alt-Down (.uno:DataSelect) worked correctly here,
so only mouse handling was broken. This was a regression
from commit aaab3a79dfd762a64fa4c1d19dd29ae46c0b9dd0
"Resolves: #i120017, filter button is not shown in merged cell"
(which fixed filtering clicking on cells merged vertically).
Partial revert of that commit sets the correct
first column in the merged range again instead of the last one.
Change-Id: I83724f18580134868867bc829cad0739f0932733
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114050
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Changes done in 'Data field' subdialog were not
applied in the result pivot table.
Change-Id: Ia221380a9ab3d292033512b9b642646f4b53a39d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112096
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114212
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: I63011526d60f332ee56edebf5bf48b30ad6b2a94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108807
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114211
Tested-by: Jenkins
|
|
Change-Id: Ieda601ce25d822394d6ddd12da861128b9270aa2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107843
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114207
Tested-by: Jenkins
|
|
Change-Id: I37aff5e53e300c29a4c6920461530b63e1519cf4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114219
Tested-by: Jenkins
Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
|