summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-10-14tdf#102212: correct constraints for Calc functions CRITBINOM, BINOM.INV.Winfried Donkers
Argument alpha can be 0<=alpha<=1. Change-Id: Ic1e6dec52bcfe227de49f6b9af38a618f4602c95 Reviewed-on: https://gerrit.libreoffice.org/28934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-14loplugin:mergeclasse merge ScCbWarningBox with ScReplaceWarnBoNoel Grandin
Change-Id: I7b55b036c1992b88b01b51053a3560e9f97986c9
2016-10-13Annotate the code a bit around EditGrowX/Y.Kohei Yoshida
Change-Id: Ib7ee2e4aa393b7d842aeaf0569f104eee17ea4ad
2016-10-13tdf#102742 fix wrong results for MOD functionWinfried Donkers
ScInterpreter::ScMod has been largely rewritten and a constraint check has been added (numerator != 0). It appears that integer values of arguments cannot accurately determined nor converterd accurately to int values, so no simpler (faster) treatment for integer values. Updated test document. Change-Id: I3af60d93019b212ce7c03eea48b509bfbc713cf7 Reviewed-on: https://gerrit.libreoffice.org/29365 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-13tdf#94635 follow up; handle linear data properly when samples in periodWinfried Donkers
are to be calculated by function. Applies to all FORECAST.ETS functions with argument period_length having value 1. Change-Id: Icb5a0288670321caf0dd5b70bee4b8811b9ba4a9 Reviewed-on: https://gerrit.libreoffice.org/28923 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-13tdf#94635 follow up; correct handling of double x-values in case ofWinfried Donkers
month intervals. Change-Id: I310d8d127d6b9ca571200ba8974a980430d69eb7 Reviewed-on: https://gerrit.libreoffice.org/29076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-13tdf#102328 Add constraint for argument X in Calc function GAMMA.DIST.Winfried Donkers
Change-Id: I5702cabac8f1e331072acfe25581569f3b7f64cc Reviewed-on: https://gerrit.libreoffice.org/29148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-13LOK: Calc: in the numeric content case, the used alignment can be wrongMarco Cecchetti
-description: in the numeric content case, the used horizontal alignment can be wrong when input content goes further than the cell border; - reason: (very odd) bMoveArea and nEditAdjust are global variables in viewdata.cxx instead of being data members of ScViewdata; - solution: now bMoveArea and nEditAdjust are data members of ScViewdata. Change-Id: I58a4ec26ca290fd328ef28a92c3c590462c7231a Reviewed-on: https://gerrit.libreoffice.org/29628 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29661 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-13tdf#101390 Add "Diagonal Line" command to the calc arrowsbar.Gulsah Kose
Change-Id: I1e29cd9a63424771576d1a5a47558d30faf53dda Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29769 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-13tdf#101390 Add "Dimesion Line" command to the calc arrowsbox.Gulsah Kose
Change-Id: I00a324dd0a27dbcf598e83d2a6cc857ab7b7d6aa Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29716 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-13unused src fileCaolán McNamara
Change-Id: I89c57286f09fdbec25d1ee5eeabe9b4ee9ef83e0
2016-10-13add DECIMAL test caseZdeněk Crhonek
Change-Id: Ia39837e0bf92008a7aceb97afd2f657c46287514 Reviewed-on: https://gerrit.libreoffice.org/29700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-13convert SvxPageUsage to scoped enumNoel Grandin
and expand out the bit-tricks some of the code was playing to make it more obvious what is going on Change-Id: I9c98334393b939b1d900425f6133556ce88247ae Reviewed-on: https://gerrit.libreoffice.org/29734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12propagate original named expression error, if anyEike Rathke
... instead of substituting with NoName error. Change-Id: Id80f46f0f4c17a0fd06abdf821d1cf5ca5d7a3ec
2016-10-12use isFinite() instead of !isNan()Eike Rathke
... to cover (theoretical?) +/-inf values as well. Change-Id: I23ab17f905bbd32345b88bea87ad6f010a5406ad
2016-10-12create NoName error token instead of setting error at the token arrayEike Rathke
... when handling name token. This can happen when importing BIFF .xls and the original range is not present in the document. The document is broken, but such formula can continue to work if the range expression was not actually executed, for example IF(TRUE(),then_good,else_bad_range) where else_bad_range is #NAME? error. Change-Id: I823ac89115418cf5069b2baf5c5de2c814319ae7
2016-10-12Revert "silence gcc4.8 warning"Michael Stahl
This reverts commit a77ff8446e7ed2255b11406b4ccce7ec742d7c67. GCC does not like the pragma: error: ‘-Werror’ is not an option that controls warnings [-Werror=pragmas] Change-Id: I8b97f39056091df644bcfe570332738560cd5dc3
2016-10-12Revert "convert MULTILINE constants to scoped enum"Noel Grandin
This reverts commit b5e352e5117fffaca8cfddde426079708a208258. GCC4.8 doesn't like the combination of a scoped enum and storing such a type in a bitfield. And it has a bug (still present in its current master) which prevents us from suppressing the warning nicely. Change-Id: I8c73e4c5175cfc43a1b8251ad85d262ad89c4f4d
2016-10-12silence gcc4.8 warningNoel Grandin
Change-Id: I1e433d6011de22e018b5324754f00065f2bfa6eb
2016-10-12gcc4.8 does not seem to like explicit-width-scoped-enum and bitfield memberNoel Grandin
there is a field a little lower down declared as Multiline meMultiline :2; which gcc gets unhappy about Change-Id: I3681d566181b6739a222898fe32af13accdf0d43
2016-10-12convert SC_NESTEDBUTTON constants to scoped enumNoel Grandin
Change-Id: Ic0bc7036972d0577c4c910ee63f92690d9c0a14d
2016-10-12convert CSV_DIFF constants to typed_flags_setNoel Grandin
Change-Id: Ib4aea2d8288ee25cb14514c38bc8809e08e61985
2016-10-12convert EXC_TABBUF constants to typed_flags_setNoel Grandin
Change-Id: I40b5d94fc559350f7dd4e0efde8f71be9518b87c
2016-10-12convert EXC_COLROW constants to typed_flags_setNoel Grandin
Change-Id: I08f06aa24228c0967ba1af139ac5b710537a2de5
2016-10-12convert constants to scoped enumNoel Grandin
Change-Id: I189027a05a49b362fb24047ff9a84521ab39ece3
2016-10-12convert SC_MATVAL constants to typed_flags_setNoel Grandin
Change-Id: I973c5253b385a5495bec38201655e3dbcb9a6f81
2016-10-12convert MULTILINE constants to scoped enumNoel Grandin
Change-Id: I1928fa3ca6e9d62719b9e4ca4649ec9fad9633a8
2016-10-12convert SC_CLIPMARK constants to typed_flags_setNoel Grandin
Change-Id: Ibdfe3c46da35b96b040f02a167d35651502a65ef
2016-10-12convert SC_ROTDIR constants to scoped enumNoel Grandin
Change-Id: Ia726ce9e9fcfe9a8b5bc4057f0176edf10b6ab3f
2016-10-11convert writer navigator to .ui formatCaolán McNamara
Change-Id: I83f834ea050372362b50de61753c2b3e33c67778
2016-10-11Resolves: tdf#101691 re-intern strings of external formula resultsEike Rathke
If the external cell referenced is a formula result of type string that string needs to be re-interned for the reference cache as well. Change-Id: Iea3c3d777dede2ad6ba0b084533af964da991ca6
2016-10-11loplugin:constantfunctionNoel Grandin
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10try enabling password tests on mac and windowsCaolán McNamara
Change-Id: I4054a3c285828f8c5a7d2c4b6e2716fd79c5fdf7 Reviewed-on: https://gerrit.libreoffice.org/29666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-10safemode: Add uno command and menu entrySamuel Mehrbrodt
Change-Id: I1843767160b79041c42e506eff0cf39399c74f26 Reviewed-on: https://gerrit.libreoffice.org/29668 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-09DDExtraWidth doesn't existCaolán McNamara
Change-Id: Ic231be1487f21dbcae9290b75be34f85318ad99a
2016-10-09No need for ScAddInDocs to be a class of its ownStephan Bergmann
Change-Id: Idfc06295dc3dc1a1dcabe9df1df76c47c874f090
2016-10-09Add better comment for this function.Tamás Zolnai
Change-Id: I9fb0b3cbb92c8f48b1ee2e2a53faeaf9a72b34f9
2016-10-09Reduce code duplicationTamás Zolnai
Change-Id: If45bd7d2d5c5ebda9fa8020138353c1224b2e1c8
2016-10-09tdf#102694, bnc#957991: Improve pivot cache reading performanceTamás Zolnai
When two or more tables have the same source data, then the grouping of source fields are shared between these tables, so don't need to import these grouping for each tables. The added code checkes whether we already imported the group fields and don't create them again using API functions, but apply the exisiting groups of an other table sharing the source. Change-Id: Iad6be9a9e30944ab9a241c8498eff95c6c356689
2016-10-09Pivot table tests: Check also grouped fields' name.Tamás Zolnai
Change-Id: I6b38e8e97613f63accf341115bbc1397ade07415
2016-10-09Pivot table XLSX import: PivotCache is not handled as a const object.Tamás Zolnai
Change-Id: I226902205e977deb1a4a73db33e3bf7671067bc8
2016-10-08skip hidden rows/columns for spellchecking, tdf#99607Markus Mohrhard
Change-Id: Ic84368f4bb70973c3c5f5293d852fc573c5f73f7 Reviewed-on: https://gerrit.libreoffice.org/29601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-08Silence false MSVC C4701 warningStephan Bergmann
...about use of potentially uninitialized aRowHeightRange.mnValue in nSum += aRowHeightRange.mnValue; Assuming it is indeed a false warning, as if (aRowHeightRange.mnRow2 < nRow) will be entered on the first round through the for-loop, and the call to if (!mpRowHeights->getRangeData(nRow, aRowHeightRange)) will then probably initialize aRowHeightRange.mnValue Change-Id: I6f942884386e2a9ed5d215bbd183ed584d254658
2016-10-08loplugin:vclwidgetsStephan Bergmann
Change-Id: I4f11af544daa2d973ccae27c49dc0143944b9c40
2016-10-07Reduce the number of calls to underlying flat_segment_tree structure.Kohei Yoshida
By replacing the getValue() call to getRangeData(). Change-Id: Ia563b08dd356d9653e6a6ce16256196b28f56b65
2016-10-07Write test case for it.Kohei Yoshida
Change-Id: I63f8b5d490686f838c0618d670bb21a957690866
2016-10-07Properly skip the hidden row(s) at the end.Kohei Yoshida
This method is supposed to return the first visible row that occurs below the specified hight. The old code would sometimes return a hidden row. Change-Id: Idf32c625c4f51355cd5d8a9f12ae9bbdddd4e5aa
2016-10-07convert calc navigator to .ui formatCaolán McNamara
Change-Id: I74d718b128ea1d795ab01da1234f58cfe1852aff
2016-10-07sc: Allow paste to overwrite existing data in tiled editin mode.Michael Meeks
Change-Id: Ibb7a4697a509d011dd8a6a1793f41d4c73d1f253 Reviewed-on: https://gerrit.libreoffice.org/29598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>