summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-03-15Resolves: tdf#130371 Undo of sheet-local named expressionsEike Rathke
... created during paste (and maybe other operations). Change-Id: I75d668f717b7336a1a65a9e02c75bf2aefe860b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90497 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-15tdf#131273: fix crash when pasting quotes with fixed widthJulien Nabet
See bt https://bugs.documentfoundation.org/show_bug.cgi?id=131273#c2 Change-Id: I78f592bb2ee59b50e7301fe4e6f282e53c4eeb7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90438 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-14tdf#130974 replace `rtl::math::isSignBitSet` with `std::signbit`.Yukio Siraichi
Change-Id: I91235eee8c6a9d4a59c1933527b49141f64cd91b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-13uitest: select child instead of moving downXisco Fauli
Change-Id: I2df86546eb617c67b889382e2e968c2476375ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90471 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: chartDataLabels.py: assert changes in chartXisco Fauli
Also removed commented code. The new asserts also check the changes done are not overwritten after reopening the dialog Change-Id: Icc7d1950ace395b88647658b3eab1b5ec35e467c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90429 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: import missing LocaleXisco Fauli
Change-Id: I5021b9b207e2cbbe402abbae69a714c813078a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13replace tabs with spaces, and unclog clang buildbotNoel Grandin
since commit 02c9e05551d69980e0757b1b0a624692ea21a96b Date: Thu Mar 12 17:34:12 2020 +0100 tdf#131291: Add UItest Seems that only some buildbots are being strict about this and generating an error like: IndentationError: unindent does not match any outer indentation level Change-Id: Ifc8d01eefca0028cf134c8e71237fc0b59bc27d5
2020-03-12tdf#130976 replace `rtl::math::isInf` with `std::inf`.Yukio Siraichi
Change-Id: Id0f0e07b324230d2d69cbf4ab07b0fff5b24474d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90377 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12tdf#131291: Add UItestXisco Fauli
Change-Id: I65aede1899d2c509fd52f8db0657ec3a5791f681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90430 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12tdf#130977 replace `rtl::math::isFinite` with `std::isfinite`.Yukio Siraichi
- make all calls look like `std::isfinite`. - change the comments referring `rtl::math::isFinite`. Change-Id: I0cde9ceb9f20150467b454cddde5e62003cfde1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90234 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12tdf#83901: move UItest to CppunitTestXisco Fauli
Change-Id: I0d074da097912f8abba6bae6171596076d71e998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90345 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12tdf#95854 Same shortcut for insert and edit commentMaxim Monastirsky
But at the same time keep them as two separate commands for tdf#84153. The idea is to define a global shortcut for the insert command (it's the same shortcut in all modules anyway), and then override it as a Calc-specific shortcut for the edit command. As a result, both menu (or context menu) items will show the same shortcut, but what will be actually executed by the shortcut is the edit command (as module specific commands have higher priority). This would work, as both commands share the same execution code. The only problem is that the edit command is disabled when the cell doesn't have a comment, and so can't be executed. Solve that by setting the FastCall sdi property on it (and reuse this general solution for the lok case too). Change-Id: I8a7280edb2aad7016ca31c63ca778b98fef85365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90354 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-03-12Revert "loplugin:constfields in sc"Noel Grandin
This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11tdf#125440 Allow raising text import dialog for pasteSamuel Mehrbrodt
This adds an entry to the "Paste special" dialog to raise the Text Import Dialog. This way, users can correctly import CSV/TSV, even when pasting just one line of formatted input. Change-Id: Ic09d7d60a05b14906f166668b38ec0eb8ead2d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11tdf#125440 When inserting TSV, consider quotes as field markersSamuel Mehrbrodt
The problem is that this is "plain text" from the clipboard format, but actually contains TSV (tab separated values). So treat them accordingly, so that each value gets its own cell. Change-Id: I0029e6ace90fc542c3269dd82bb7531654157a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87194 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11tdf#126742 Don't change visible area while retrieving itSamuel Mehrbrodt
This leads to funny size changes in embedded calc docs Change-Id: I2c4a0fbebb782faae7508e7d61c8da9d440a5916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90247 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11Fix typoAndrea Gelmini
Change-Id: I0eaddcdcd41327a40559ec943d5c744b7e4c5387 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90310 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-10Enable CppunitTest_sc_uicalc also for MACOSXStephan Bergmann
there appears to be no reason not to Change-Id: Ic7c0e34e28bc67bd7b342b50f893990057b2e261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90305 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-10tdf#125520 create a persist correctly for OLEArmin Le Grand
If the D&D-Start described as in the task is an OLE object we need to create a Persist-object to copy the included EmbeddedObjectContainer Change-Id: Ib8b9677bbc3e6c5b3895abc55e6da5b0a96e33d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90263 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-10tdf#124815: move UItest to CppunitTestXisco Fauli
Change-Id: If6482bf6666f00c3c613315cd18d188239ea61f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90265 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#124816: move UItest to CppunitTestXisco Fauli
Change-Id: I2ad49fc599bf2c0d4be79967e935abed13e75970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90264 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#126904: Add unittestXisco Fauli
Change-Id: Ie5ec86642bcd4a8822d885d18516ee3ad6fecbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90250 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#122232: move UItest to CppunitTestXisco Fauli
Change-Id: I6cb9019fea4b1be5af94dcc8811a4f96fc1b6d37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90238 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#93831 xlsx file full of pictures of numbers slow to openNoel Grandin
Change-Id: I6c984c84c409519a986eacb265c943307a7b57af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09improve loplugin:unusedfieldsNoel Grandin
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-07ofz#20463 TimeoutCaolán McNamara
Change-Id: I7707451573a57e99e9f417617b733a00ea991c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-07ReplaceNullTransformation::Transform fix nEndRowDarkByt31
Change-Id: Ib041694e8de2113f11b3ef1b8553334e0d9e1c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89969 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2020-03-06loplugin:unusedmethodsNoel Grandin
Change-Id: I698981490eb1391930cdd06821a80a5f770e000e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06formula manager: wrong category returned by ScFuncDesc::getCategoryMarco Cecchetti
In the function manager the index associated to each category starts from 0 while in ScFuncDesc starts from 1 (data member ScFuncDesc::nCategory) Change-Id: I92d0cd2a1a2871785e45faafd797dcf3a500bec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89198 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90072 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: calc: unwanted cell range selection occurs when clicking on a cellMarco Cecchetti
When user clicks on a cell after the browser has lost focus user gets the cell range from A1 to the current clicked cell selected Change-Id: I1dd495f42ca7e5ee8cad1d2354dcebc0cb05d65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88549 Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90071 Tested-by: Jenkins
2020-03-06lok: calc: send text selection rectangles for the input barMarco Cecchetti
Change-Id: I3caeaddd7a5ddc6e496650539b88e2fd81b37e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86790 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90069 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: calc: zoom: object selection - is unreliableMarco Cecchetti
Change-Id: Ic8e61c56bdf38bbb74f179fa36075bdd3a601249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90068 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: calc formula bar tunneling: resize the main windowMarco Cecchetti
When a resize msg is forwarded from the client to the core for the formula bar, for instance because of a browser window resizing, we need to resize the whole main app window not the formula bar only. On the contrary we have 2 issues: 1) each time the formula bar get focus the layout manager tries to set the size of the formula bar back so that it fits inside the app window 2) the part of the formula bar outside the app window doesn't respond to mouse events on the client side. Change-Id: I13ddc40a2a8e543808a4bf36a04022deb3700163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89858 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: calc formula bar tunnelingMarco Cecchetti
Change-Id: I92026098222e04a163796225a048c6d7dc1b37c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89857 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: on calc spelling context menu didn't pop upMarco Cecchetti
The problem has been fixed by making visible cell range syncronized with client visible area Change-Id: I632f8ef4d5e8fa227b55fcb0459ed89d10798134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89856 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06Related: tdf#131157 inherit ScDrawTransferObj from TransferDataContainerCaolán McNamara
Change-Id: I5119b959a6bff958582c404c03af59bd52c9497a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90051 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-06tdf#131157 problems dragging and dropping from calc navigatorCaolán McNamara
Change-Id: I40f05704248c43c30d479d42932adfd594391a60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-06use more FastParser in ScXMLTableContextNoel Grandin
Change-Id: I16018b07bb4c71b60c547dad2d53420a14686e18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06use more FastParser in ScXMLContentValidationContextNoel Grandin
Change-Id: I958d2ad1a8dc6c2a3da1c1a4fc6bd4f0011367fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05restore calc navigator custom tooltipCaolán McNamara
Change-Id: Ic378364e0d6c5eb704872ec9a3c73f63c222855a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90049 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-05lok: remove complex rotation / alignment settingsHenry Castro
It is very confusing for mobile user the text orientation properties, let's remove the property for mobile view. Change-Id: I4150f9ed7343d38fd00ee66fa5afffe40426b984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89840 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-03-05tdf#75330 add a new overlay/no-overlay feature for the legendTünde Tóth
Implement "Show the legend without overlapping the chart" option for chart legend. Change-Id: Ifbba4c81136e13995d276434dc17a97b0675428c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89810 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-05use FastParser in ScXMLMasterStylesContextNoel Grandin
Change-Id: I432a3b5a1087a50b2cdc959b42bc58209a6cedfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89993 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05use FastParser in XMLTableStylesContextNoel Grandin
Change-Id: If06d8cfc856aa5180199bce2bc747fa9bd667bb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89994 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05Rename method setReplacementElement()Jens Carl
... to setElement() to have a uniform interface with similar classes like XNameContainer. Change-Id: I2058e3ea9f14a5792a07f23f4bd13c4708dccdfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89784 Tested-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-03-04fix ToC links give unhelpful url popupsMert Tumer
core expects ctrl+click for internal links too and it should not expect it if it is tiled rendering Change-Id: Id841f0e9729e46f00988ea0b4eb29bd65098a740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89559 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3fe9dfca2d44d9e41ee329883f199359c673f382) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89919 Tested-by: Jenkins
2020-03-03Revert "Make Chart Creation Wizard async"Stephan Bergmann
This reverts commit ed86b6250cd00ed6b7bdb81307bc66adba129cae. Reason for revert: Most Jenkins builds for that change were aborted after timing out, and many other Gerrit Jenkins and tinderbox builds now time out, too. It very much smells like that commit was the culprit. Change-Id: I5473c58957f92d63113e32f862ad9c114f9c844c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89803 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02uitest: check copy in .uno:MoveXisco Fauli
Change-Id: I916d3853500705b1037aa669374511c184402313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89822 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-02cid#1459023 Dereference null return valueCaolán McNamara
Change-Id: Id99adac0a544b59b6ac8f6ac225df1f218ed8405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-09 10:33:59 +0000