summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2022-01-22tdf#118246 add support for Application.GetOpenFilename func.Tomaž Vajngerl
Opens the file dialog and returns the selected filename. Change-Id: I4eccd34a7fbb892c0950b2f7c34977cf2aad6f89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128721 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-21sc: move vba tests to the new vba-macro-test fileXisco Fauli
Change-Id: Iaec40b8a1d5bce5d9a96447fee5102dc18a16f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128736 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-21gtk4: set homogeneous to true to get two equal width buttonsCaolán McNamara
Change-Id: Iff8c9579bbb4758c2bb13b946fafcaf3b9433a84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128735 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-21tdf#141591 Add DevTools to the Tabbed interfacerafaelhlima
This patch adds the DevTools command to the Tabbed interface. It is located in the cotnext menu in the Tools tab. Change-Id: I5f323b1b5ffc6707fc4f8b3c6eca2db7b8b97adc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127973 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-21sc: fix VBA Copy-Paste using same and separate documentTomaž Vajngerl
This fixes 2 issues with VBA copy-paste: - VBA command Range(..).Copy issue where the range wasn't selected when copying and the copied cells were from the previous selection. The Copy command now does the same selection as the Cut command. - VBA PasteSpecial issue where the wrong view was used to get the clip document. - VBA Workbooks.Add issue where the new workbook wasn't activated after it was created, which causes an issue when running tests, but not when running in LO application. The Add command does now the same as the Workbooks.Open command. All the issues are supported by new test cases. Change-Id: I36ec45c01f18f7f76e4f95a25a28402a6ee0e2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128720 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-20tdf#139974: sc: Add UItestXisco Fauli
Change-Id: I2fe60ece55cd5f8298ed656fa043287eeaef1a53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128651 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-20sc: ubsan - initialize D&D pointers properly.Michael Meeks
Change-Id: I95c6a9b55ed25cc6d51f9f4544cb9fc016bbec64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128672 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-01-20uitest: sc: make sure text is copied from the input windowXisco Fauli
Change-Id: I17f163486f253bc80f40f13c01fb61187d8276e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128649 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-18Resolve gtk3 crash of If1ffb50743292f3cc0c3271646d0538337977762Heiko Tietze
Change-Id: Id1080b71d1252bdcef804a4f8398a3c42073ee0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128522 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-17tdf#136362 Remove unnecessary blank area and option in some image toolbarJeff Huang
Only in Calc, Draw and Impress. Change-Id: I944aad875fedd1dd19657c49b059e33fd6e9d3f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127984 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-17Resolves tdf#143733 - Make selection border widerHeiko Tietze
Border width and handle size follow the zoom factor now Border is drawn evenly inside and outside the rectangle Change-Id: I83cfb8a8156e2f0346ded3e2abed4386d4006d00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128222 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-16tdf#146421 Calc Sidebar Alignment Section follow arrangement guidelineandreas kainz
Change-Id: If1ffb50743292f3cc0c3271646d0538337977762 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126688 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2022-01-15A unit test for tdf#146367Eike Rathke
Change-Id: Ie47f1525f387d019c7c1131a76faf3784ee99d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128466 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-15tdf#146367 reintroduce approxAdd() similar handling with last summandEike Rathke
... to tie result to 0 eliminating opposite sign small equalish fractions. This does not "fix" all interim values of the bug's sample document, which repeatedly adds single values in sequence using SUM() and should use the + operator instead to benefit from approxAdd() for each, but maintains the better accuracy of Kahan summation in the not near equal zero cases. And the dreaded SUM(0.1;0.2;-0.3) also works again resulting in 0 with all permutations. Change-Id: I67188a6abbdb98212f070166ad02319c3d477e28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128451 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-15Change cursor -> pointer in spreadsheet option tipOlivier Hallot
Change-Id: I4fe40f321849846daaddd1c9374a0271689b5823 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128425 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-15Fix extended tip on printer options for speradsheetsOlivier Hallot
Change-Id: Iad153527e4ee4b74cb9d7bf6a57821a9f13f1f16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128426 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-15Resolves tdf#139395 - Redesign of font name and effects pagesHeiko Tietze
* Western/CJK/CTL selection placed into a GtkNotebook * Font color and transparency in one line * Alignment adjusted at font effects page * Char-, para- & style dialogs made non-resizable according the guideline Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-14make comphelper::OInterfaceContainerHelper4 more threadsafeNoel Grandin
(*) make all the methods that require an external mutex take a std::unique_lock as a parameter, so that call sites cannot forget (*) make the forEach method drop the lock when firing listener methods, to reduce the odds of deadlock Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-14tdf#136481 show the focus rect for the case nothing is yet selectedCaolán McNamara
but the cursor is at pos 0 Change-Id: I7c94480bffdced23fe89d4e3ba0e729742247130 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-13small optimisationNoel Grandin
Change-Id: I51fc0292a3907613391bc8a2a16bac486cdadee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-12tdf#146454 - Check for multiline string in setDataArrayAndreas Heinisch
Check for a multiline string in the setDataArray function. If that is the case, set a string or edit cell. Otherwise, just set a plain string in order to prevent performance issues due to the adjustments of the row height. Regression from b9e2c5d2a36fbd189c20448cadf4212edf02914d Change-Id: I9216b198b878fda5da29596d25504db853acd756 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127660 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-01-12used cache value in ViewObjectContact::getPrimitive2DSequence (2nd attempt)Noel Grandin
Rely on the cached primitives in VOC. But only enable it for calc and draw right now, by adding a flag at the SdrModel level. This way we can leave it disabled for writer, where it definitely doesn't work. Change-Id: I11ca4836eb773c0f078cdb82056c6e0309d15a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-12cid#1497092 Result is not floating-pointCaolán McNamara
Change-Id: I3ee4a3fa13db8958970206059dbd99d841d3c706 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-12sc: fix cond. format icon size, when we work with pixelsTomaž Vajngerl
This is the case when the device is bWorksInPixels is true, which is the case when running LOKit. Change-Id: Ibfced11bf614604521240908f4821fb9abfbf362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128200 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-10use less SvStream::Flush()Noel Grandin
Flush() turns into a sync() on the device, which is pretty slow. Most of the time all we actually want to do is to flush the internal buffers from the SvStream. So expose the FlushBuffer method and use that where possible. And also means we don't need the mbDontFlushOnClose flag on SvStream any more. Change-Id: Ibe089b88b325f0fdc565200a97ce72cd26b7fcfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-10sc: fix typoTomaž Vajngerl
Change-Id: If9a8f7265c17dafa99b51fe6266d935afedfa394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128207 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-10sc: make icon size of cond. formatting same as font sizeTomaž Vajngerl
This makes the behavior of the Calc te same as other spreadsheet programs, where the icon size of the conditional formatting is the same as the font size and not the actual cell height (as it is the behaviour now). Change-Id: I00c96ad83458cd31f67c0b6f566e3d01dd8cd47b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128185 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-10Move HAVE_MORE_FONTS into an extra config headerJan-Marek Glogowski
No need to recompile most of LibreOffice, because the --with-fonts configure flag changed. This preprocessor define is just used by unit tests anyway. Change-Id: Ia2eae7d0c74e59e034fdd8513504a34e51ab428e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128197 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06tdf#145059: sc: always write dxf node for color filter for XLSXVasily Melenchuk
If there is no dxf reference to color filter (for example if selected color is not in range of available colors for current range) Excel is not able to show color filter correctly: it is not marked as used filter, no ability to reset, etc. Change-Id: I65378ddd6f8f8233cda147ff9dcd28f455a58225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127745 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-06tdf#146617: iterators may be invalidated during handler callMike Kaganski
... when the handler decides to remove itself from listeners. Change-Id: I1d5fe802f50d284bf70d747edaff0a19852c5a7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-06Resolves: tdf#146592 "Reset" to the current document propertiesCaolán McNamara
not those seen at the initial load of the TabPage Change-Id: Ieba4c278a0a9b7fef3030d8462cb845c27dba9b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-05sc: fix crash with document properties dialogTomaž Vajngerl
"ImagePreferredDPI" property was added for impress and writer, but it was not handled in calc, so it document properties dialog crashed (exception because of a non existent property). Change-Id: I9eb3f6aa7cf6d8ab48930b3071b993e073117688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127942 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-04sc export chart as graphic: handle PDFMiklos Vajna
The context menu for Calc charts would call into GraphicFilter::ExportGraphic(), which has explicit code for e.g. SVG, but not for PDF. The graphic exporter to PDF is only meant to work with images backed with PDF data, not with all shapes. Fix the problem by explicitly handling PDF in GraphicHelper::SaveShapeAsGraphic() in svx/, and invoking the normal PDF export in that case. Continue to fall back to XGraphicExportFilter for other formats. This requires passing down the current document from sc/. Change-Id: Ia5f78bffa1d26989bb0ad3ed265b922e609f076f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127969 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-04Removed break; never reachedAndrea Gelmini
Change-Id: I027c967020821e93fecab8df0f23c5e7b5664734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127008 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-04Drop also commented-out obfuscated SAL_DEBUG callsTor Lillqvist
Change-Id: I7bc8ee2e5e989e41fcc0b6f96c5b2b8f151cdd3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127937 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-01-04osl::Mutex->std::mutex in ScDocumentNoel Grandin
Change-Id: I163b7e6b7403f9f489b4965861241280cfc37e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127917 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-03tdf#129115 Calc functions OPT_* have no Help id'sOlivier Hallot
Change-Id: If275d804fc81b535c422a29ba594eb88ce5e70c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127896 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-01-03CppunitTest_sc_subsequent_filters_test2: check format instead of stringXisco Fauli
Otherwise, this might fail. See 660e538ee77109bc3e7dff4491164d696e503abc < Disable broken part of ScFiltersTest2::testTdf126116 > Change-Id: I40534b70fc19ee163d9e6cb0c081fae40b81fdb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127887 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-03Disable broken part of ScFiltersTest2::testTdf126116Thorsten Behrens
Fails since New Year with: Test name: ScFiltersTest2::testTdf126116 equality assertion failed - Expected: 03/03/21 - Actual : 03/03/22 Change-Id: Ic5c259e6bf1f184ceb7cf15e1ba7a83dac729c2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127879 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-02Introduce OUString::unacquired(const OUStringBuffer&)Mike Kaganski
... and avoid OUStringBuffer::toString when the temporary is used for checking current buffer content Change-Id: I114178f3e74ca3e4a3e517763f9eaab4797b7deb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-01tdf#140286 fix INFO("OSVERSION") for Linux: return kernel versionscito
If LibreOffice Calc is running on Linux, the Linux version as shown in about dialog is returned, e.g. "Linux 5.3". MacOS and Windows parts are prepared, but not implemented. (I develop only on Linux.) Change-Id: I2b266a257e5c01c0fde7d076385ded4a6413d3c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127756 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-31tdf#114995: sc: Add UItestXisco Fauli
Change-Id: I351f080f56b5e6183d932463ea2faf13bb666ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127765 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30tdf#127484: sc: Add UItestXisco Fauli
Change-Id: I7c15750ae42d78bfb714638e44c7b761f5c22b47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127759 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30uitest: sc: reintroduce code incorrectly removedXisco Fauli
Change-Id: I18ad03632950530d7ae2c24608936dba325b0a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127758 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30tdf#95217: sc: simplify testXisco Fauli
Rechecking again, I found out that the encoding problem described in tdf#95217 was actually fixed by the same commit that fixed tdf#146048 ( 3392f567be8d52804b187b0bced47204ef38fa3c < tdf#146048: detect UTF-16 without BOM > ) This commit partially reverts d7fb6b22cf7e66eb2594001cc42c6bff8b5a49e2 < tdf#95217, tdf#142600: sc: Add UItest > since we don't have to create any http server to reproduce the issue Change-Id: I2f0177f8450f77de5df756354d48505193a6ba3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127742 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30tdf#95217, tdf#142600: sc: Add UItestXisco Fauli
for that, launch an http server in a separate thread Change-Id: I9d78c9a4349620a9de31b3963f2a31ff1d354f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-29lok: fix formula mode after reference dialog was usedSzymon Kłos
m_nCurRefDlgId is a global variable which can be used by many views. It should be deglobalized in LOK case in the furture. For now let's fallback when we didn't get child window for remembered value of m_nCurRefDlgId. It fixes following case: 1. opened pivot table dialog and in destination section selected "selection", selected a range, closed dialog 2. tried to type formula in the cell and point any cell to add reference before this patch formula mode was closed, after it adds correctly the selected range to the formula Change-Id: I4d6756f08207f78a6033865203905bc2fed59fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123803 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127667 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-12-28tdf#139602 Added all subtotal functions to autosumDhiraj Holden
For every function that is an option for SUBTOTAL that was not already an option in autosum (that is COUNTA, PRODUCT, STDEV, STDEVP, VAR, VARP), the option was added in the autosum menu. Change-Id: Ic560cd45df206dafaa2d960550aaf185a1806806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127600 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-27remove unused DECL_ABSTDLG_BASE and IMPL_ABSTDLG_BASETomoyuki Kubota
Change-Id: I8ba8f940cb4931974d10c8d6cf1d4fd205c18e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127469 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-13 08:39:12 +0000