summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-04-22place an intermediate class as parent for SfxTabPagesCaolán McNamara
so a SfxTabPage can be parented by a vcl::Window or a welded native notebook tabpage. That ways the same SfxTabPage can be used at the same time in both a native dialog or a vcl dialog. The impl can be changed to the weld api, and when hosted in a native dialog the vcl impl of that will be instantiated, while native otherwise. e.g. print options appearing in print options dialog and general options. This allows incremental changeover. Change-Id: I6f1fed1e8d0898b01853bb878757bad41cbf9bba Reviewed-on: https://gerrit.libreoffice.org/53193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-22NB Implementation: calc data tab use now correct orderandreas kainz
Change-Id: I62d6c88a8a10d9455279c38e885cf3a5b91428a5 Reviewed-on: https://gerrit.libreoffice.org/53274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-21Translate German variable namesJohnny_M
Puffer -> Buffer in Lotus filter Change-Id: If6d5190c7bc2f884083a2a47b6bd665b3f95b3b0 Reviewed-on: https://gerrit.libreoffice.org/53250 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-04-21loplugin:unusedmethodsNoel Grandin
Change-Id: I9dc6e81149eae3ba2284fa7fe608dd9252503dce Reviewed-on: https://gerrit.libreoffice.org/53197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-20fix for "drop IS_SET macro"Noel Grandin
regression from commit 8c9c1b852ce0ebc6bd19437e9e583ef4226cf685 Date: Wed Apr 18 14:12:06 2018 +0200 drop IS_SET macro Jochen Nitschke: InsertDeleteFlags::ATTRIB sets 2 bits, before it checked both bits and now it's true if only one of them is set. Change-Id: I169ffae10d219063ce378257e95fbb4f863ca525 Reviewed-on: https://gerrit.libreoffice.org/53211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-20tdf#115582 Correct coordinate usage for sc's ::ArrayArmin Le Grand
In ScOutputData::SetCellRotations() eventually existing CellRotations are added to the svx::frame::Array data that gets created for repaint. This used the wrong coordinate calculation, thus in some cases the repaint of rotated Cells failed. Change-Id: Ib5df8576e8c9404d717d5dcc5662aa04b82cf959 Reviewed-on: https://gerrit.libreoffice.org/53171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-20Fix typosAndrea Gelmini
Change-Id: I8674d279fe1e2d386a12de97fb3d2e3cfa7c5258 Reviewed-on: https://gerrit.libreoffice.org/53003 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-20Function to load graphic swapped out (loaded on demand)Tomaž Vajngerl
When a document is loaded it takes a lot of time and memory to load the graphic that are in the documet, so avoid that and just store the compressed graphic into a temporary file (handeled by GfxLink) and load when we really need to show the graphic. GraphicObject cached some attributes from Graphic, but this attributes now aren't available immediately so this attributes are removed form GraphicObject and now delegate to the Graphic itself. GetSizeBytes attribute however was removed as it is only used in some tests. GfxLink initial values were moved to the constructor and are not set in the header file anymore (as it is the recommended way to do it). The SdImportTest::testDocumentLayout failed as it looks like the dump sometimes didn't include the width and height of the null bitmap (which is set to 32x32) of the FillBitmap in some situations, but then in other situations it did include this attributes. With this change the width and height are always included for the FillBitmap which looks like it is more correct. Change-Id: Ia1218f93b1735402b7828404f65660e2d4acf32f Reviewed-on: https://gerrit.libreoffice.org/53016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-19cppcheck - fix variableScope in some filesGökhan Gurbetoğlu
Reduced the scope of some variables in source. Change-Id: I705e7f2587fd81015f06fb301eb8d4a270668d73 Reviewed-on: https://gerrit.libreoffice.org/53042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Gökhan Gurbetoğlu <gokhan.gurbetoglu@pardus.org.tr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19gla11y: fix a grandfathered warningCaolán McNamara
Change-Id: I1741f5822c5132e4176c6a46248feee2ac8a72a8 Reviewed-on: https://gerrit.libreoffice.org/53126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19weld CompressGraphicsDialogCaolán McNamara
Change-Id: I593e6f0fe2e002c75ecd367a38dda96e7e6552f9 Reviewed-on: https://gerrit.libreoffice.org/53125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19drop IS_SET macroNoel Grandin
Change-Id: I876462e3f436b1540bb1a7ef92f184fa1c0be0e8 Reviewed-on: https://gerrit.libreoffice.org/53102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19convert SFXSTYLEBIT to scoped enumNoel Grandin
drop SFXSTYLEBIT_HIERARCHY because it has no overlap with these values, it's used an extra bit in SfxCommonTemplateDialog_Impl::LoadFactoryStyleFilter Change-Id: I8ee5ecb9b5f8d2087d8eedd1f5526260ec1e4018 Reviewed-on: https://gerrit.libreoffice.org/53089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19NB Implementation: update calc data tab .ui fileandreas kainz
Change-Id: If317a6183dffc2d5411c7da49bb26ed25973964a Reviewed-on: https://gerrit.libreoffice.org/53135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-19NB Implementation: add print / presentation action to shortcuts listandreas kainz
Change-Id: Id49672a9a363e78844d08d18e34944dbd7a4711e Reviewed-on: https://gerrit.libreoffice.org/53131 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-04-18tdf#42949 Remove unnecessary helpids.h from sc.hrcGabor Kelemen
There is only a few files now where HIDs are set from code so no need to include helpids.h into the widely used sc.hrc Change-Id: Id7c9ef7fdf299c580f597e4c27ba8bece3d99f5d Reviewed-on: https://gerrit.libreoffice.org/53076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18tdf#45904 Move _XScenario Java tests to C++Jens Carl
Change-Id: Ic12eebe62de5132dce26ec46c62501f90200b909 Reviewed-on: https://gerrit.libreoffice.org/52180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-18convert DelCellCmd to scoped enumNoel Grandin
Change-Id: I4766fc874026f218b33e66944b98562d1ec614d3 Reviewed-on: https://gerrit.libreoffice.org/53088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18tdf#42949 Remove unnecessary localization headers of editengGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<editeng/eerdll.hxx\> -e \<editeng/editrids.hrc\> | xargs grep -c EditResId | grep :0$ | grep -v /pch Change-Id: Ic542ceee09352cb52dcdc9780d4cb1890e02f383 Reviewed-on: https://gerrit.libreoffice.org/53062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17tdf#45904 Move _SheetSortDescriptor Java tests to C++Jens Carl
The C++ tests are now located in sheetsortdescriptor2.(hxx|cxx), because this is the latest implementation of the UNO API interface (SheetSortDescriptor2.idl). Change-Id: I5b11a38f6cd0473714c4d57ee92889bfd7605e83 Reviewed-on: https://gerrit.libreoffice.org/52930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-17Fix typosAndrea Gelmini
Change-Id: If89ec640901253121529c09aef4537c6b13cee1d Reviewed-on: https://gerrit.libreoffice.org/52280 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-17coverity#1434889 Uncaught exceptionCaolán McNamara
and coverity#1401334 Uncaught exception Change-Id: Ib2fadd83068cc94c972f6312719081d5ac75d8ce
2018-04-17Only relevant whether mpTestEqualCondition is non-nullStephan Bergmann
...so change it from 'const bool*' to just 'bool' Change-Id: Ibc36058f2faab565162cd05f6e798ecaae094dc1 Reviewed-on: https://gerrit.libreoffice.org/52990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-04-17tdf#117017 Make modifier keys not trigger the InputChanged handlerMaxim Monastirsky
Change-Id: Ib05883688ef4143c0b53871c4336920dde6f91cc Reviewed-on: https://gerrit.libreoffice.org/52924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-04-17tdf#116821 Keep row/column buttons enabled even when insert impossibleMaxim Monastirsky
So other commands included in these buttons (like delete or set height/ width), could still be used. Change-Id: If9e96116aebf73b2d20fb8d63ee67da3d17e3d9f Reviewed-on: https://gerrit.libreoffice.org/52909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-04-17Simplify calls to Menu::CheckItemMuhammet Kara
in cui, dbaccess, vcl, sc, sd Change-Id: I328d81cf6cd5a7e31fb21a758e4b2670e7df1b91 Reviewed-on: https://gerrit.libreoffice.org/52797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu
Change-Id: I3ba75dbe6754b8138f61e223387832a6fb53c1c5 Reviewed-on: https://gerrit.libreoffice.org/52752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17cppcheck: identicalInnerCondition in scJochen Nitschke
and remove a related known condition dpcache.cxx Change-Id: I6069849c33ea03eff61a55eb790ce6a8aad3d915 Reviewed-on: https://gerrit.libreoffice.org/53005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17loplugin:constparamsNoel Grandin
Change-Id: I3d1b88dbd0ff73fddc08d52f50e0efb42daab89b Reviewed-on: https://gerrit.libreoffice.org/52756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16Take care of E3DObjListArmin Le Grand
E3DObjList is not needed, remove. Remove memeber from E3DObject, derive E3DScene directly from SdrObjList, some cleanups in SdrObject, too Change-Id: Ifa4620a800c14faf21f8b80fd4dc1d39f71be804 Reviewed-on: https://gerrit.libreoffice.org/52740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-16Nitpick: a pointer is p...Eike Rathke
Change-Id: I14a9fd8eb794fb23271174b83910deca58f6607a
2018-04-16Resolves: tdf#116003 check presence of subtotal in group, tdf#107267 follow-upEike Rathke
Change-Id: Ifed6e28926c689dd17914b8b1cbf47b58e2ffcdc
2018-04-16weld SvxPostItDialogCaolán McNamara
Change-Id: I0aa88270aa604180223f2b35829b45e5828f792a Reviewed-on: https://gerrit.libreoffice.org/52896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16NB Calc: update tabbed notebookbarandreas kainz
Change-Id: I44cf1195a6e202c993a39e53249120b44b866f3d Reviewed-on: https://gerrit.libreoffice.org/52943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-16NB Implementation: show menubar in NBShortcutsandreas kainz
Change-Id: I44acbdd96a7ede1fc89bbafbd1eb7c5bf25fc193 Reviewed-on: https://gerrit.libreoffice.org/52936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-16tdf#42949 Remove unnecessary localization headers from scGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<scresid.hxx\> -e \<strings.hrc\> sc | xargs grep -c ScResId | grep :0$ | grep -v /pch and git grep -l -e \<globstr.hrc\> sc | xargs grep -c GetRscString | grep :0$ | grep -v /pch since global.hxx contains so much more, it's omitted from this round. This also gives some false positives used in ErrorMessage() calls or just untranslated strings. Also translate some stray German comments Change-Id: Icfea2b2942d12c3c134d419cb7c9a84534c04a86 Reviewed-on: https://gerrit.libreoffice.org/52932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-15remove some unused comphelper includesJochen Nitschke
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-15tdf#45904 Move _FunctionDescription Java tests to C++Jens Carl
Change-Id: Ib4baf75dddb3b63bab25ab13967a20c65d692ce2 Reviewed-on: https://gerrit.libreoffice.org/52613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-14look for check buttons without underlinesCaolán McNamara
Change-Id: Ia9963190cf3dccbfa82951a3f2c0e29e00171429 Reviewed-on: https://gerrit.libreoffice.org/52847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-14look for radio buttons without underlinesCaolán McNamara
Change-Id: I0ed97515a03a5633628a492ec7797fc3ade8a3d8 Reviewed-on: https://gerrit.libreoffice.org/52846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13Revert "calc: unit tests for data validation"Eike Rathke
This reverts commit 78d774381b09fc244de162211e9c3fbfe891cbea. Makes unit tests fail, see comment in https://gerrit.libreoffice.org/50381 Change-Id: I16d00540e12482c47e9a300958746730f12c008a Reviewed-on: https://gerrit.libreoffice.org/52849 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-04-13weld ScDeleteContentsDlgCaolán McNamara
Change-Id: Ibd3723fc615d97a4747a41e881dbad6829929c0c Reviewed-on: https://gerrit.libreoffice.org/52833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13calc: unit tests for data validationMarco Cecchetti
Change-Id: I51e1d992236de8ecc3e7dcf0085d629c5b863776 Reviewed-on: https://gerrit.libreoffice.org/50381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-04-13weld ScNameCreateDlgCaolán McNamara
Change-Id: I8b75647a419020504adc2cdff7c6d046ef043491 Reviewed-on: https://gerrit.libreoffice.org/52830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13weld ScDeleteCellDlgCaolán McNamara
Change-Id: Ie85c51c019f892f647c2a13f67f47080ffa414b1 Reviewed-on: https://gerrit.libreoffice.org/52829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13weld ScInsertCellDlgCaolán McNamara
Change-Id: I91118d4c0c5e2fa17fed02377547caa65e11bfdc Reviewed-on: https://gerrit.libreoffice.org/52824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13Related: tdf#100925 background not getting set under X sometimesCaolán McNamara
not sure why this is the case, but it is reminiscent of rhbz#1283420 which results in missing glyphs in some circumstances X11CairoTextRender::getCairoContext has a hack in it for that problem, whic forces a read from the underlying X Drawable before writing to it which seems to have the effect of syncing it up. So, just before drawing the bg, draw a glyph on it to get it synced, and then overwrite it. Change-Id: I2ffff7e8e989b91821869d8b75a59728ac513d1b Reviewed-on: https://gerrit.libreoffice.org/52810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13make SdrObjUserData::Clone return std::unique_ptrNoel Grandin
Change-Id: Iffe047b081fde0bb582d8730a8e96d2597c7567a Reviewed-on: https://gerrit.libreoffice.org/52780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-13loplugin:useuniqueptr in ScImportExportNoel Grandin
Change-Id: I2b064dfcc3ab8ad7eba360fc90cd56ac9bd1cf22 Reviewed-on: https://gerrit.libreoffice.org/52759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-12Fix typosAndrea Gelmini
Change-Id: I0c9d917b8673680dbd0729f7f9a4cf5a6e686908 Reviewed-on: https://gerrit.libreoffice.org/52543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-01-14 10:18:55 +0000