summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-03-26tdf#131593 ScOutputData::GetMergeOrigin: Handle cells outside own areaMichael Weghorn
Rendering the bugdoc had regressed at commit 9113f17e65b1dafbc178fd269e2967c1e2632f0e ("LOK: fast tile rendering (text only)", 2016-06-04), which had changed the area covered by the ScTableInfo in use from the document's whole rendering area to that covered by the bounding rows and columns for the tile being rendered. For the bug doc, it was e.g. no longer detected that cell A10 (nX=0, nY=9) is merged to A1 when processing the "second tile in the second row of tiles" in ScOutputData::DrawEdit. Change-Id: I60c3ad43ad816d2186547486116f63e27ed3a166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91094 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-26Extend loplugin:cstylecast to certain function-style castsStephan Bergmann
...that are equivalent to const_cast or reinterpret_cast, and should arguably better be written that way for clarity. Drawing inspiration from <https://reviews.llvm.org/D76572> "Replace `T(x)` with `reinterpret_cast<T>(x)` everywhere it means reinterpret_cast. No functional change". Change-Id: I27b8f70d324d32ecba658db4d1c2db03e10d5d3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91086 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-25tdf#127113: Allow to fill any two numeric fields in Fill Series dialogSarper Akdemir
Added m_nSelectHeight and m_nSelectWidth to ScFillSeriesDlg class for deriving missing box if other two boxes are full. CheckValues() mimics behaviour of previous check functions with added functionality of calculating missing start or increment values (end value was already handled in previous check functions) in linear fill mode if it is possible to calculate them from other two values. Change-Id: If30d96f1b5f7e1bb88f473d7c0c5c2802ba6f225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87841 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-25tdf#101181: add sidebar panel for Glow effectMike Kaganski
... in Writer, Calc, Draw and Impress for CustomShapes. The artifacts that become apparent using the controls, e.g. remnants of the effect when decreasing radius (in Impress), or glow not drawn until reload after enabled or radius set to 0, should be fixed in a separate commit. Change-Id: I6107597161bc67ae8c3e62c260ef6ad241c7dedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-25lokit: Mark document as modified on chart insert/edit...Dennis Francis
immediately at least in the case when LOKit is active. This is to allow prompt emission of .uno:ModifiedStatus=true statechange message from lokit to the client. Without this, in online the chart insert/modify related changes may not get saved on client exit. Change-Id: I8c38a37cc455f74a70d43b6aaa3e5035b283d47f (cherry picked from commit 75adb624dfff4659e6f3099a1720fbd697560f9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91036 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-24weld writer navigatorCaolán McNamara
GtkToggleToolButton are much wider than vcl equivalents. Split the bottom toolbar into two toolbars. Rearrange their contents so the layout of each level visually match. Notes: Master documents have two modes, master content tree and the normal content tree. You can drag entries from the content tree into the document, drag mode drop down controls whether its a link or a copy etc that's dropped in. Documents can be dropped into the content and global trees. If outline tracking isn't active, then when content changes the tree is cleared and refilled, typically an effort is made to reselect the same entry that was previously selected. Additionally, if the amount of content didn't change an effort is made to scroll back to the location the scrollbar was at before the clear. Change-Id: I00c015145eac5b1acc3398d3c40861d830e4264a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-24tdf#131296: get numeric value with its data type in StepLOADNCAndreas Heinisch
In order to load numeric values, generate SbiOpcode::NUMBER_ opcodes including the numeric value and its data type instead of SbiOpcode::CONST_. The numeric value and its data type will be restored in SbiRuntime::StepLOADNC. When the new compiled code is stored in documents, e.g. password-protected libraries, leagcy LO versions will just read up to non-numeric characters, thus correctly obtaining number value and ignoring the type, so the change is backward-compatible. To interpret legacy compiled code, old treatment of SbiRuntime::StepLOADI is restored, reverting commit 0b4f8bf571baf2ccd5a8aafdc4deb41867420be3. This change reimplements the fix for tdf#129596. Change-Id: I46ebfc77f9bea69479968950c0fb7264e4a7ab27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90858 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-20The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-ltoStephan Bergmann
dbfc495a9ace0865d764dad7404633a12cda2873 "Add config option used when we try to link one huge object file" had added it for the --enable-lto case, but without documenting exactly what it should help with. And at least my local Linux --enable-lto --enable-dbgutil etc. build successfully does `make check && make screenshot` without it. This removes the only use of STATIC_LINKING, so remove it completely. (And basctl/source/basicide/basidesh.cxx still needs to include config_options.h for ENABLE_MERGELIBS.) Change-Id: I3820e1cacccc92f5ac0c9c7fcc539c29a6864694 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-20Rename isMobile to isMobilePhone and introduce a separate isTabletTor Lillqvist
The intended semantics of isMobile() has been to say whether the device is a mobile phone ot not. Not whether it is a mobile device in general. So make that explicit. Adjust call sites as necessary. Also, in a couple of places where it is likely that what is relevant is whether it is a mobile device in general, not just whether it is a mobile phone, check both isMobile() and isTablet(). For stable interoperability with current Online, keep accepting also the .uno:LOKSetMobile "command" (and .uno:LOKUnSetMobile, except that Online never sends that). Online will eventually be changed to use .uno:LOKSetMobilePhone or .uno:LOGSetTablet only (and never the UnSet variants). Also drop the default value for the bool parameter to setMobilePhone(). Default bool parameters can be quite confusing, and it was especially silly in this case as there is one (1) call site. This is a work in progress and will be improved. Currently there are undefined corner cases. Change-Id: I2a71c37323ee151cbc671bd8e714e1dee10f8b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90560 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90778 Tested-by: Jenkins
2020-03-19loplugin:redundantpointerops add some more smart pointer typesNoel Grandin
Change-Id: Ia7f3441404d8d2e5de501e70da496b6fdc6c9a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-17sc lok: Implement execution of SID_SPELLCHECK_APPLY_SUGGESTIONTamás Zolnai
Used by online spellchecking context menu. Change-Id: Id065d366d5ef2ddb3ecf78d202a7264b6962ec8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90601 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17sc lok: Implement execution of SID_LANGUAGE_STATUS...Tamás Zolnai
Also for selection and paragraph which is used by the spellchecking context menu. Change-Id: I583caf48b9176ef4d6971cfe3b445080d01dc531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90599 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17sc lok: Implement execution of SID_SPELLCHECK_IGNORE_ALLTamás Zolnai
Used by online spellchecking context menu. Change-Id: I31779a38f467838d3719a0d32cbf37e335432d38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90600 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-16uitest: chartWall.py: assert changes in chartXisco Fauli
Change-Id: I8c9f4614a76015b0032347290f6b92b2892ddd10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90588 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16remove unnecessary Window::Update() calls, which immediately follow InvalidateNoel Grandin
Update() is effectively "paint immediately". Rather just let the invalidate do it's thing and have the widget paint on the next paint loop, along with the rest of the stuff. This is probably mostly cargo-cult, from the days when our invalidate/paint timer could take a long time to kick in. Change-Id: Idff06526e9a2892244cfd8ce6947916032b0d1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90567 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2020-03-16tdf#129985: Add unittestXisco Fauli
Change-Id: I9a8b923da6ca20fef9a61b9e478267d8c91ace58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90573 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16tdf#130371: Add UItestXisco Fauli
Change-Id: Ia1bd884d3aa4210e777ea59aece50940d3aa6f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90571 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16-Werror,-Wunused-private-fieldStephan Bergmann
Appears to be a mis-merge of 9d4c36d7914e2746a751a56de01063c9159f0f99 "Revert 'loplugin:constfields in sc'". Change-Id: I69a51cdc95fe0a2741b469d2400af51713c6afe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90553 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-03-15Fix typoAndrea Gelmini
Change-Id: I9715f320bbf35ceafc2d0f2eb9a69c02821779d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90528 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-15cid#1460665 Division or modulo by float zeroCaolán McNamara
Change-Id: Iea166a3d152b5b38665691bfa16f3022d684771c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-15Resolves: tdf#129985 OOXML import: do not force a fixed-locale number formatEike Rathke
... instead of system locale. Change-Id: Ie7b4c6a560468f142df6916f50bfda9daaf7c379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90538 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-15cid#1460666 Unchecked return valueCaolán McNamara
Change-Id: I47298fdb780ac546ad1c795ba5aea54b6a71758c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-15Resolves: tdf#130371 Undo of sheet-local named expressionsEike Rathke
... created during paste (and maybe other operations). Change-Id: I75d668f717b7336a1a65a9e02c75bf2aefe860b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90497 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-15tdf#131273: fix crash when pasting quotes with fixed widthJulien Nabet
See bt https://bugs.documentfoundation.org/show_bug.cgi?id=131273#c2 Change-Id: I78f592bb2ee59b50e7301fe4e6f282e53c4eeb7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90438 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-14tdf#130974 replace `rtl::math::isSignBitSet` with `std::signbit`.Yukio Siraichi
Change-Id: I91235eee8c6a9d4a59c1933527b49141f64cd91b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-13uitest: select child instead of moving downXisco Fauli
Change-Id: I2df86546eb617c67b889382e2e968c2476375ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90471 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: chartDataLabels.py: assert changes in chartXisco Fauli
Also removed commented code. The new asserts also check the changes done are not overwritten after reopening the dialog Change-Id: Icc7d1950ace395b88647658b3eab1b5ec35e467c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90429 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: import missing LocaleXisco Fauli
Change-Id: I5021b9b207e2cbbe402abbae69a714c813078a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13replace tabs with spaces, and unclog clang buildbotNoel Grandin
since commit 02c9e05551d69980e0757b1b0a624692ea21a96b Date: Thu Mar 12 17:34:12 2020 +0100 tdf#131291: Add UItest Seems that only some buildbots are being strict about this and generating an error like: IndentationError: unindent does not match any outer indentation level Change-Id: Ifc8d01eefca0028cf134c8e71237fc0b59bc27d5
2020-03-12tdf#130976 replace `rtl::math::isInf` with `std::inf`.Yukio Siraichi
Change-Id: Id0f0e07b324230d2d69cbf4ab07b0fff5b24474d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90377 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12tdf#131291: Add UItestXisco Fauli
Change-Id: I65aede1899d2c509fd52f8db0657ec3a5791f681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90430 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12tdf#130977 replace `rtl::math::isFinite` with `std::isfinite`.Yukio Siraichi
- make all calls look like `std::isfinite`. - change the comments referring `rtl::math::isFinite`. Change-Id: I0cde9ceb9f20150467b454cddde5e62003cfde1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90234 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12tdf#83901: move UItest to CppunitTestXisco Fauli
Change-Id: I0d074da097912f8abba6bae6171596076d71e998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90345 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12tdf#95854 Same shortcut for insert and edit commentMaxim Monastirsky
But at the same time keep them as two separate commands for tdf#84153. The idea is to define a global shortcut for the insert command (it's the same shortcut in all modules anyway), and then override it as a Calc-specific shortcut for the edit command. As a result, both menu (or context menu) items will show the same shortcut, but what will be actually executed by the shortcut is the edit command (as module specific commands have higher priority). This would work, as both commands share the same execution code. The only problem is that the edit command is disabled when the cell doesn't have a comment, and so can't be executed. Solve that by setting the FastCall sdi property on it (and reuse this general solution for the lok case too). Change-Id: I8a7280edb2aad7016ca31c63ca778b98fef85365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90354 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-03-12Revert "loplugin:constfields in sc"Noel Grandin
This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11tdf#125440 Allow raising text import dialog for pasteSamuel Mehrbrodt
This adds an entry to the "Paste special" dialog to raise the Text Import Dialog. This way, users can correctly import CSV/TSV, even when pasting just one line of formatted input. Change-Id: Ic09d7d60a05b14906f166668b38ec0eb8ead2d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11tdf#125440 When inserting TSV, consider quotes as field markersSamuel Mehrbrodt
The problem is that this is "plain text" from the clipboard format, but actually contains TSV (tab separated values). So treat them accordingly, so that each value gets its own cell. Change-Id: I0029e6ace90fc542c3269dd82bb7531654157a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87194 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11tdf#126742 Don't change visible area while retrieving itSamuel Mehrbrodt
This leads to funny size changes in embedded calc docs Change-Id: I2c4a0fbebb782faae7508e7d61c8da9d440a5916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90247 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11Fix typoAndrea Gelmini
Change-Id: I0eaddcdcd41327a40559ec943d5c744b7e4c5387 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90310 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-10Enable CppunitTest_sc_uicalc also for MACOSXStephan Bergmann
there appears to be no reason not to Change-Id: Ic7c0e34e28bc67bd7b342b50f893990057b2e261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90305 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-10tdf#125520 create a persist correctly for OLEArmin Le Grand
If the D&D-Start described as in the task is an OLE object we need to create a Persist-object to copy the included EmbeddedObjectContainer Change-Id: Ib8b9677bbc3e6c5b3895abc55e6da5b0a96e33d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90263 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-10tdf#124815: move UItest to CppunitTestXisco Fauli
Change-Id: If6482bf6666f00c3c613315cd18d188239ea61f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90265 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#124816: move UItest to CppunitTestXisco Fauli
Change-Id: I2ad49fc599bf2c0d4be79967e935abed13e75970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90264 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#126904: Add unittestXisco Fauli
Change-Id: Ie5ec86642bcd4a8822d885d18516ee3ad6fecbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90250 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#122232: move UItest to CppunitTestXisco Fauli
Change-Id: I6cb9019fea4b1be5af94dcc8811a4f96fc1b6d37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90238 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#93831 xlsx file full of pictures of numbers slow to openNoel Grandin
Change-Id: I6c984c84c409519a986eacb265c943307a7b57af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09improve loplugin:unusedfieldsNoel Grandin
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-07ofz#20463 TimeoutCaolán McNamara
Change-Id: I7707451573a57e99e9f417617b733a00ea991c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-24 06:07:43 +0000