summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-05-24member can be a ref instead of a pointerCaolán McNamara
Change-Id: Idb0c27933b42f3aef65f0bce098f9bd7a81dc034
2018-05-24ScTabViewShell is never optionalCaolán McNamara
Change-Id: I9f42fd6179c0a64cc14a051ca7c9e2ed9300f5c8
2018-05-24coverity#704702 Dereference after null checkCaolán McNamara
Change-Id: I876ffc1511b2115562039b97961c28d7b30e2c06 Reviewed-on: https://gerrit.libreoffice.org/54730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-24reduce some unnecessary ScRangeList copyingNoel Grandin
and reduce unnecessary work in ScRangeList Change-Id: I0ee767fe28571f75f8a2ff980cea27c97c9797dc Reviewed-on: https://gerrit.libreoffice.org/54705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-24Calc threading : Check for "self" references...Dennis Francis
...on indirect dependencies too. Here a self reference to any formula-group means if there are any references in a formula (of the formula-group itself or any of its dependencies) that points to any element inside the formula-group. If there are any self-references, then that formula-group can't be computed in parallel. For example, with this patch we can detect the following case:- Suppose the formula-group that we want to check is: "=(F2+G2-10)*10.0" spanning A2:A100. Let the formula-group starting at F2 be "=A1*0.1-10". The indirect dependency formula-group starting at F2, references back the elements of our original formula-group at A2. This makes the F.G at A2 unsafe for parallel computation. Concretly, this patch fixes a recalc crash on tdf#63638/1 Change-Id: I7b999a34571b191d2f70da6a3831f78b24a6b0a7 Reviewed-on: https://gerrit.libreoffice.org/54433 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-23Fix typoAndrea Gelmini
Change-Id: Ie9501a1cb9f8c2a747b92eb74c120816b49148d8 Reviewed-on: https://gerrit.libreoffice.org/54709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-23toolbar:id is not valid attribute of toolbar:toolbarChristian Lohmaier
according to framework/dtd/toolbar.dtd – and having the same ID everywhere also is kinda pointless.. Change-Id: Ia7768be2f951886e39e24d78fc6d69b4f3c84235 Reviewed-on: https://gerrit.libreoffice.org/54665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-23tdf#117228: crash in SfxItemSet::GetItemState...Henry Castro
(unsigned short, bool, SfxPoolItem const**) when pasting comment of closed document Re-work commit 1b7a8277aa3e9f73ccdf15e933a1ee3b42849a44. In the tiled rendering case, each view has its own clipboard, but not in desktop version which it has a shared clipboard each view. Change-Id: I57b1ab81e4c141829dbad899330e5c22204c384a Reviewed-on: https://gerrit.libreoffice.org/53922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-23extend mutex protection to the whole of ScEditUtil::GetString()Luboš Luňák
Otherwise with Calc's threading enabled and novell#306440-1.xlsx this function gets called multiple times at the same time and the SetText() calls operate on the same object. Change-Id: Ic044132ac98bed46440aadbdad6ad36f3a2e9beb Reviewed-on: https://gerrit.libreoffice.org/54520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-05-23Fix typoAndrea Gelmini
Change-Id: Ic7a5cceb30c3301c05d1ec241ec7afb86af035d7 Reviewed-on: https://gerrit.libreoffice.org/54667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-22Fix typosAndrea Gelmini
Change-Id: I5ad14286712e27e8d15174c9ed420bf93367d041 Reviewed-on: https://gerrit.libreoffice.org/54579 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-22Conditional jump or move depends on uninitialised valueStephan Bergmann
Regression introduced with f7a011c45b0b88cb3c3ea9206cb851375266523d "loplugin:unusedfields in sc" e.g. during `VALGRIND=memcheck make CppunitTest_sc_subsequent_export_test CPPUNIT_TEST_NAME=ScExportTest::testTrackChangesSimpleXLSX`: > ==16928== Conditional jump or move depends on uninitialised value(s) > ==16928== at 0x3C72975F: lcl_GenerateGUID(unsigned char*, bool&) (/sc/source/filter/xcl97/XclExpChangeTrack.cxx:87) > ==16928== by 0x3C731303: XclExpChangeTrack::XclExpChangeTrack(XclExpRoot const&) (/sc/source/filter/xcl97/XclExpChangeTrack.cxx:1470) > ==16928== by 0x3C18B6B1: ExcDocument::ReadDoc() (/sc/source/filter/excel/excdoc.cxx:788) > ==16928== by 0x3C1FC902: ExportBiff5::Write() (/sc/source/filter/excel/expop2.cxx:112) > ==16928== by 0x3C1A1506: lcl_ExportExcelBiff(SfxMedium&, ScDocument*, SvStream*, bool, unsigned short) (/sc/source/filter/excel/excel.cxx:181) > ==16928== by 0x3C1A1044: ScFormatFilterPluginImpl::ScExportExcel5(SfxMedium&, ScDocument*, ExportFormatExcel, unsigned short) (/sc/source/filter/excel/excel.cxx:219) > ==16928== by 0x2D947526: ScDocShell::ConvertTo(SfxMedium&) (/sc/source/ui/docshell/docsh.cxx:2325) > ==16928== by 0x2FA06539: SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) (/sfx2/source/doc/objstor.cxx:1510) > ==16928== by 0x2FA0A91D: SfxObjectShell::DoSaveAs(SfxMedium&) (/sfx2/source/doc/objstor.cxx:1897) > ==16928== by 0x2EFD30D7: ScBootstrapFixture::saveAndReload(ScDocShell*, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags) (/sc/qa/unit/helper/qahelper.cxx:664) > ==16928== by 0x2EFD381D: ScBootstrapFixture::saveAndReload(ScDocShell*, int) (/sc/qa/unit/helper/qahelper.cxx:686) > ==16928== by 0x29A6ADEA: ScExportTest::testTrackChangesSimpleXLSX() (/sc/qa/unit/subsequent_export-test.cxx:2615) Change-Id: I08f6a8e4a3827440f8b908791555e4b2226be12d
2018-05-22uitest for bug tdf89958Zdeněk Crhonek
Change-Id: I174c4c641d992e78056003fc8f4b9a24ea1c1b93 Reviewed-on: https://gerrit.libreoffice.org/54639 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-22Missing test dependencyStephan Bergmann
[...] > CppunitTest_sc_subsequent_export_test > warn:oox:31852:31852:oox/source/export/vmlexport.cxx:1099: failed to open vml-shape-types > /usr/lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/debug/vector:417: > Error: attempt to subscript container with out-of-bounds index 202, but > container only holds 0 elements. > > Objects involved in the operation: > sequence "this" @ 0x0x7f6f0c456340 { > type = std::__debug::vector<rtl::OString, std::allocator<rtl::OString> >; > } [...] Change-Id: I1a93d97e18eb4341ea9059ea7ad52f20c298c97f
2018-05-22tdf#42949 Fix IWYU warnings in sc/inc/formularesult.hxxGabor Kelemen
Found with bin/find-unneeded-includes This one caused lots of fallout, manage it separately Change-Id: Idf153caa07b1edd85352609806f5b8b74fc6ead8 Reviewed-on: https://gerrit.libreoffice.org/54410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-22Fix the incomplete self reference checks for doublerefsDennis Francis
This fixes the case when the start and end points of the doubleref are themselves outside the formula-group range, but the doubleref engulfs the entire formula-group. Change-Id: Ie43ef5560a867769a1f08c893d9497c40401cc5b Reviewed-on: https://gerrit.libreoffice.org/54642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-05-22Revert "lokdialog: Give non-programmatic name to autofilter"Jan Holesovsky
In the meantime, we are able to treat the title-less pop-ups just fine. This reverts commit a895f6356159f4267c0ac24781814ae0cbcba0b9. Change-Id: I1e2913190e9a1141eddf9aba0732e57bd5407987 Reviewed-on: https://gerrit.libreoffice.org/54629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-05-21uitest - Calc standard filterZdeněk Crhonek
Change-Id: I578e0fa94326677ce277cd24e043c699d152a5dd Reviewed-on: https://gerrit.libreoffice.org/54636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-21weld ScSortDlg, ScTabPageSortOptions and ScTabPageSortFieldsCaolán McNamara
Change-Id: I103e5e3670f8c95c1f480ce0c36e08c3de74e900 Reviewed-on: https://gerrit.libreoffice.org/54541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21sc: Avoid looking up system clock twice to get current datetimeTakeshi Abe
Change-Id: I904067260c15263f8169f095809e642d0738f6bb Reviewed-on: https://gerrit.libreoffice.org/53957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-21loplugin:unusedfields in scNoel Grandin
Change-Id: I04aee9574b97d6120fe20be97b2c0fb8187fb260 Reviewed-on: https://gerrit.libreoffice.org/54453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-20weld ScDataPilotDatabaseDlgCaolán McNamara
Change-Id: Ie8e9914bb8042e33a2ab2a1e07bb0203a54d5422 Reviewed-on: https://gerrit.libreoffice.org/54584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-20weld ScCalcOptionsDialogCaolán McNamara
Change-Id: I391e26bd95cb3dc6cfa983502aa960a5c54cc800 Reviewed-on: https://gerrit.libreoffice.org/54580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-20weld ScDPShowDetailDlgCaolán McNamara
Change-Id: Ifbb93a71ac891f4a5621edcd1c3f004a278a088d Reviewed-on: https://gerrit.libreoffice.org/54577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-20NB calc: update IDsandreas kainz
Change-Id: I0209fe6992d603cac47f1a8f0dd58fd52b9b3a2c Reviewed-on: https://gerrit.libreoffice.org/54592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-19weld ScSortWarningDlgCaolán McNamara
Change-Id: I9462906fbe77a8463d7b283942c5280fdd71239e Reviewed-on: https://gerrit.libreoffice.org/54565 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-19weld ScColRowLabelDlgCaolán McNamara
Change-Id: If706a86b4aa55f2678b3ad9a96e81679eca0faea Reviewed-on: https://gerrit.libreoffice.org/54566 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-19Fix typosAndrea Gelmini
Change-Id: Ie0c9f168759a625d78668cd57838b208fbc9dc56 Reviewed-on: https://gerrit.libreoffice.org/54458 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-19tdf#42949 Fix IWYU warnings in sc/inc/l*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib19d239ac3f48192461aeeb1b1456bda986c11e3 Reviewed-on: https://gerrit.libreoffice.org/54462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-19NB Calc update IDsandreas kainz
Change-Id: Ia117cf44d0a7be5798be1fb51c63003b8c64bc86 Reviewed-on: https://gerrit.libreoffice.org/54561 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-19NB: update IDsandreas kainz
Change-Id: I41e16c68709a85c4d06a6a0de737b5eb59d2a5d9 Reviewed-on: https://gerrit.libreoffice.org/54558 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-18weld ScSelEntryDlgCaolán McNamara
Change-Id: I1bc78b61a50f909ceb4c79e9dc9425306d41e617 Reviewed-on: https://gerrit.libreoffice.org/54534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-18weld ScDataPilotSourceTypeDlg and ScDataPilotServiceDlgCaolán McNamara
Change-Id: I03ef6f1994e8e1a801e4515586a6a73d3748f13b Reviewed-on: https://gerrit.libreoffice.org/54528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-18weld DataStreamDlgCaolán McNamara
Change-Id: I8da7228de5a1a9b7637c8c43ffd79f5f044bc788 Reviewed-on: https://gerrit.libreoffice.org/54521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-18weld ScInsertTableDlgCaolán McNamara
Change-Id: Ia3e00ccdc89aaf7b5546a0b346d174814fcea97d Reviewed-on: https://gerrit.libreoffice.org/54518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-18tdf#42949 Fix IWYU warnings in sc/inc/f*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here with minimal fallout management Change-Id: I5574c9ccac02977c9cde01e24534f82dd9ec82be Reviewed-on: https://gerrit.libreoffice.org/54409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-18Fix typosAndrea Gelmini
Change-Id: I4f96c813ed4dd5ebc396b397e3c9c578f96f5619 Reviewed-on: https://gerrit.libreoffice.org/54515 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-18Related: tdf#117093 place assert on SanitizeWhichActive() resultsEike Rathke
Trying to chase the culprit. Change-Id: Iec5e6b3b38b4c0e7cd224cc861d4303a1eb04c4c Reviewed-on: https://gerrit.libreoffice.org/54491 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-18Resolves: tdf#117093 sanitize the active grid window valueEike Rathke
Don't know yet how that could had happened, but the sample document has a bad ActiveSplitRange value that doesn't match HorizontalSplitMode and VerticalSplitMode. * sanitize the value when reading view settings * prevent writing such value to help versions that don't sanitize Change-Id: I1b450c7b8102148a24d545ff7568f725d7492a6a
2018-05-17disable also ocStyle for Calc's threadingLuboš Luňák
The ocStyle token is only in the RPN tokens, the raw tokens array contains only ocName, so it's necessary to check also RPN tokens. Prevents a crash with tdf#91220/1 because of ScInterpreter::ScStyle() causing a SfxBroadcaster::Broadcast() call. Change-Id: I7fa04114b698918569014322c721751ab3d8c62f Reviewed-on: https://gerrit.libreoffice.org/54326 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-17New o3tl::temporary to simplify calls of std::modfStephan Bergmann
...that ignore the out-parameter integral part Change-Id: I05f07c1a8909023232f8aecf75ea5541d4eb81ca Reviewed-on: https://gerrit.libreoffice.org/54474 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-17tdf#42949 Fix IWYU warnings in sc/inc/[pq]*Gabor Kelemen
Found with bin/find-unneeded-includes Removal proposals are dealt with here, and a bit of fallout management. Change-Id: If2d73998c3d3d9fea50420688818cd7fe0f0a27c Reviewed-on: https://gerrit.libreoffice.org/54463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-17uitest - Calc sheet renameZdeněk Crhonek
Change-Id: If7ea2fd921c2e673f76ecb79188dc5dcb4cba442 Reviewed-on: https://gerrit.libreoffice.org/54447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-17weld ScInsertContentsDlgCaolán McNamara
Change-Id: I432048f086e4aa49ebac6a6cdafd1e11c3832ab0 Reviewed-on: https://gerrit.libreoffice.org/54445 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-16ofz#6352 set limits for useful fuzzingCaolán McNamara
Change-Id: Id4a2dab7da84adf6c6268340dff34e8776abe924 Reviewed-on: https://gerrit.libreoffice.org/54383 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-16tdf#117630 wrong accelerator character for update commandandreas kainz
Change-Id: I36888ddda9ca5cfd9f5e9d344d0656917637f348 Reviewed-on: https://gerrit.libreoffice.org/54404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-16loplugin:constantparamNoel Grandin
Change-Id: I0110e0c662004456e4bc8f8082e2e2fea59e0148 Reviewed-on: https://gerrit.libreoffice.org/54385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-15NB Implementation: update Menu drop down menuandreas kainz
Change-Id: If4b5ba6579e06a3f179de032919bdf7335b39a7b Reviewed-on: https://gerrit.libreoffice.org/54389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-15uitest Calc - format CellsZdeněk Crhonek
Change-Id: I2a2f0515d872e1affd7c1c27eb901ea2a183114b Reviewed-on: https://gerrit.libreoffice.org/54387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-15NB Implementations: update for better maintenance and syncandreas kainz
Change-Id: I024d597f218824d8618d113a5aaae2fd314ec807 Reviewed-on: https://gerrit.libreoffice.org/54367 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2024-12-27 14:43:41 +0000