summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-11-29lok: sc: subdivide headers data in rangeMarco Cecchetti
Change-Id: I984b5da5774f97172de7659ecab84675060f8301 Reviewed-on: https://gerrit.libreoffice.org/44676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-11-29lokdialog: Move the LOKWindowId <-> VclPtr<Window> mapping to Window.Jan Holesovsky
This allows registering & de-registering of non-sfx windows too, and makes the Calc autofilter popup to appear. Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93
2017-11-29lokdialog: Move the painting down to Window, and enable Calc and Impress.Jan Holesovsky
Tested with .uno:FormatCellDialog in Calc, Impress not tested. Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8
2017-11-29lokdialog: Make the Autofilter popup notify about its creation.Jan Holesovsky
Change-Id: Ib4062fa887b44eb1368205a414f4ac162f648c5c
2017-11-29ofz#4406: don't increment ScCompressedArray::Iterator past endCaolán McNamara
Change-Id: I4975e0655b5ed3083244c63c86f29f3fcad48079 Reviewed-on: https://gerrit.libreoffice.org/45368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29loplugin:unusedmethodsNoel Grandin
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1 Reviewed-on: https://gerrit.libreoffice.org/45386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28Do as the FIXME suggestedTor Lillqvist
Not exactly, though. The FIXME said "Make this a comparison operator at the TokenArray?" but I think that would be misleading as the code in question specifically does not check the TokenArrays for being completely identical; it intentionally ignores the RPN part. So make it a member function 'EqualTokens' instead. Change-Id: I15d840c422844fa144415a76c1f8fcbd6cae3c83 Reviewed-on: https://gerrit.libreoffice.org/45404 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-11-28ofz#4412 bail on failure in Formulacell tooCaolán McNamara
Change-Id: Ie7f9e4309ae8468947dce12355201d038e7e63fa Reviewed-on: https://gerrit.libreoffice.org/45428 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28tdf#113271 Fix order of color's attributes import.Bartosz Kosiorek
The order of import color is very important in case of more than one color attributes was provided. This order (theme -> rgb -> indexed -> auto) is not documented and was gathered experimentally based on MS Excel 2013. Information about <fonts>: https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.fonts(v=office.14).aspx Information about font: https://msdn.microsoft.com/en-us/library/ff531892(v=office.12).aspx https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.font(v=office.14).aspx More information about color class: https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.color(v=office.14).aspx https://msdn.microsoft.com/en-us/library/ff532831(v=office.12).aspx Example: With indexed auto, colour, rgb and them, <color auto="1" theme="1" rgb="FFFFFF" indexed="62" /> The priority is as follows: 1. theme 2. rgb 3. indexed 4. auto Change-Id: I7bb5ab7d7b7a52091f0130fd6f21bac44eca7408 Reviewed-on: https://gerrit.libreoffice.org/45266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-28add xlsx support to fftesterCaolán McNamara
Change-Id: I07198f24a3e096fab67333cf6a98185d5b40fffc Reviewed-on: https://gerrit.libreoffice.org/45399 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28Fix typosEike Rathke
Change-Id: I01f0ca82f1350b74ea2d3205948c032918049c02
2017-11-28tdf#113455 follow-up: clear spin buttons when disabled in ResetMike Kaganski
otherwise they show "1" in disabled state, unlike after being enabled and then disabled again manually (see ToggleHdl) Change-Id: I4ff4d0ef006b7530bb20d9b830dc5e2f5732530d Reviewed-on: https://gerrit.libreoffice.org/45383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-28Factor out a code snippet copy-pasted four timesTor Lillqvist
Change-Id: I29fb16ea51873b396c4f884f6acf454ce2b229e6 Reviewed-on: https://gerrit.libreoffice.org/45363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-28The aStrNmsp[12] fields can be constTor Lillqvist
Change-Id: I257b2be52b13c8ce76dbcc06e080e348af9e1b68 Reviewed-on: https://gerrit.libreoffice.org/45359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-28Set correct file permissionsJens Carl
Change-Id: I3667d1feda74aad160bbfd79e6baafc42e3cf83d Reviewed-on: https://gerrit.libreoffice.org/45302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-27tdf#113455 follow-up: use spin button labels as checkboxesMike Kaganski
This streamlines the UI (avoids extra controls on page). Labels' ids kept intact to preserve localization context. Change-Id: Idbeb47d7f4e783107d49cb045125434291331140 Reviewed-on: https://gerrit.libreoffice.org/45333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27ofz#4412 do not read past end of fileEike Rathke
Change-Id: Id1d9e83a931fda3921948206cf927b2c20d88173
2017-11-27Address some nitpicks, tdf#39593 follow-upEike Rathke
* clarify the comment in ClearableClipRegion dtor * invest some spaces for readability * indicate that "auto ClipRegion" is actually a (unique) pointer, so name it pClipRegion * also const auto Change-Id: Ia4d822df37a1a783c1b362e9c602567fde4bafa9
2017-11-27tdf#39593 deduplicate code in ScOutputDatatagezi
Change-Id: Ic709739c75b7305757b2e1985765497985a0b8b6 Reviewed-on: https://gerrit.libreoffice.org/45106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-27The eTempGrammar[12] fields can be constTor Lillqvist
Change-Id: Ibf3f0f9fed7c2158c4ad366f0c865b075943f2a8 Reviewed-on: https://gerrit.libreoffice.org/45321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-27loplugin:unnecessaryparen: Warn about parentheses around literalsStephan Bergmann
...that are not composed of multiple tokens, like ("foo" "bar"). Also don't yet warn about Boolean literals, which are sometimes wrapped in parentheses to silence unreachable-code warnings. To avoid multiple warnings about code like f((0)) switch to generally using a set of ParenExpr to keep track of which occurrences have already been handled. Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc Reviewed-on: https://gerrit.libreoffice.org/45317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27tdf#113831 Show number of search resultsheiko tietze
Skipped label used to show the number via resource strings Change-Id: I6f57799565126c202041d0bf6a9f361d4e64cdfd Reviewed-on: https://gerrit.libreoffice.org/45269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-27Bin confusing comment, there is no lcl_ScDocFunc_CreateTokenArrayXMLTor Lillqvist
It went away in bffe1113a31bb1f58aafbdba9b50b4232816f2f5 earlier this year. Change-Id: I6b7646cfa4b86a4dc0eadf887d72b144625f4216
2017-11-27tdf#45904 Move _XHeaderFooterContent Java tests to C++Jens Carl
Change-Id: I5e6ee9f44223c4b0b92ec32bb508d5b6c988689f Reviewed-on: https://gerrit.libreoffice.org/45265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-26Add debug output operator<< for ScFormatEntry::TypeTor Lillqvist
Change-Id: I4e23f17a59e995d76258420f07818079c7a9b94b Reviewed-on: https://gerrit.libreoffice.org/45288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-26Add debug output operator<< for ScConditionModeTor Lillqvist
Change-Id: I031d080dc8cbfcc5619bf7d5ee6112dde0a2ef04 Reviewed-on: https://gerrit.libreoffice.org/45277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-26Convert ScFormatEntryType to scoped enumTor Lillqvist
Change-Id: I9a6b3fb05255630852a96ebf74d901b869a581f4 Reviewed-on: https://gerrit.libreoffice.org/45276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-25Avoid a trivial typedefTor Lillqvist
Change-Id: Iea8700f168c5d13ebf1b98f435eeabea425b8259 Reviewed-on: https://gerrit.libreoffice.org/45275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-25Revert "ofz#4406: don't increment ScCompressedArray::Iterator past end"Caolán McNamara
that doesn't help of course This reverts commit ab58e2e68f969e49b97b28b81225ed1e87df0855.
2017-11-25coverity#1422232 Improper use of negative valueCaolán McNamara
Change-Id: I79b24e175906ca5552f45b6af472c436ffde5fe3 Reviewed-on: https://gerrit.libreoffice.org/45247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-25Convert ScConditionMode to scoped enumTor Lillqvist
Change-Id: I9b6aaa64e7f649581b27f0238e2908026ab6e0bd Reviewed-on: https://gerrit.libreoffice.org/45157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-24tdf#97198 Make Calc function LEFT work with Unicode non-BMP charactersWinfried Donkers
Change-Id: I66d24dd962f824079fd0aea2827bd5b975ffe698 Reviewed-on: https://gerrit.libreoffice.org/44684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-24tdf#97198 Make Calc function SEARCH work with UniCode non-BMP characters.Winfried Donkers
Change-Id: I99b44dc88fe9c8d4d5d7a319bd6bc84dd2bff4f3 Reviewed-on: https://gerrit.libreoffice.org/45170 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-24tdf#97198 Make Calc function LEN work with Unicode non-BMP characters.Winfried Donkers
Change-Id: Ibfdaaf1ed313257fc5f9036a7dd1ef51033fa8cd Reviewed-on: https://gerrit.libreoffice.org/44681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-24tdf#97198 Make Calc function FIND work with UniCode non-BMP characters.Winfried Donkers
Change-Id: I512199a5d29aa955b278f0666c7ce904e67d9767 Reviewed-on: https://gerrit.libreoffice.org/45171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-24tdf#97198 Make Calc function RIGHT work with Unicode non-BMP characters.Winfried Donkers
Change-Id: I775bc50d8e5948a2af9efb77dcea9d7cae7293d5 Reviewed-on: https://gerrit.libreoffice.org/44834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-24tdf#97198 Make calc function MID work with Unicode non-BMP characters.Winfried Donkers
Change-Id: Ic86344495490d6ca942f9fd2752874da22ef531f Reviewed-on: https://gerrit.libreoffice.org/45040 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-24tdf#45904 Move _XSheetAnnotationAnchor Java test to C++Jens Carl
Fixes #i109517 for sc.ScCellObj by adding a note/comment during the set up of the test in sccellobj.cxx and allows to re-enabled the test. Change-Id: Ic7aa6bcb2606f555a76612a6f50c200d738674db Reviewed-on: https://gerrit.libreoffice.org/44617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-24ofz#4406: don't increment ScCompressedArray::Iterator past endCaolán McNamara
Change-Id: I2adc204722a6143384bab8aecd16bed42cb5016a Reviewed-on: https://gerrit.libreoffice.org/45192 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24drop unused ATTR itemsNoel Grandin
the table autoformat stuff does not use these values at all, it just writes the internal details of PoolItems in a pre-determined order Change-Id: Id6d8ae7508a8d19f5fd1e70f9a428d324082d3bf Reviewed-on: https://gerrit.libreoffice.org/45199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24consistently use sal_uInt32 for number formats in scNoel Grandin
instead of a mix of short/sal_uLong/sal_uInt32 Change-Id: Ie5bd26e1a6f716c0c4e174a6d560827084b3f421 Reviewed-on: https://gerrit.libreoffice.org/45159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23Document, and simplify the two uses of ScMutationGuard.Michael Meeks
Creates ScMutationDisable - used to ensure that no core data structure is mutated below this guard in any thread. This can also be used to disable access in the same thread now. Change-Id: I7e4e98d8ff986490ccd5064b3b9af56acd877b49 Reviewed-on: https://gerrit.libreoffice.org/45119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-23related tdf#108757 small enhancements for speed upSerge Krot
- no strings reallocation - faster for-loops Change-Id: I98a355eb3bcb48219afd6334615c9c092ed1a352 Reviewed-on: https://gerrit.libreoffice.org/45142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-23Add debug output operator<< for ScRangeListTor Lillqvist
Change-Id: I55f16428bbadd45d302ac31df9c1a691730c4a49 Reviewed-on: https://gerrit.libreoffice.org/45158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-23crashtesting: crash loading fdo41403-1.xlsmCaolán McNamara
regression since... commit 3af8a4faf5e20ccae2386052697713da160afb16 Date: Wed Nov 15 13:10:40 2017 +0300 tdf#113861: Less aggressive expansion of chart headers. pre-change code had... FormulaToken* pToken = it2->second; if (pToken && nRow>=nHeaderRowCount) check, so restore that check for presence of FormulaToken Change-Id: Ia1b301e4f7fdf447b08de7fb22bd7fde8735bd52 Reviewed-on: https://gerrit.libreoffice.org/45155 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Resolves: tdf#113962 save detected filter outside file dialogCaolán McNamara
different file dialog impls work differently so store the detected filter outside the file dialog Change-Id: I144d8df06e5265fed8f11b284a2f40c17c3e09ef Reviewed-on: https://gerrit.libreoffice.org/45166 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Move the need for several ugly const_casts deeper down to just one placeTor Lillqvist
Change-Id: I2cdd66b9819f070548c2a0af7388d9bfbd3689c1 Reviewed-on: https://gerrit.libreoffice.org/45144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-23TypedWhichId create custom get methods in ScPatternAttrNoel Grandin
Change-Id: Iaa326332f5806477dd81463e6b6004a962bac934 Reviewed-on: https://gerrit.libreoffice.org/45128 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23tdf#50746 add paste unformatted to menu and context menuYousuf Philips
also unified menus and context menus in writer and calc Change-Id: I929df7a0fe2be7b8bf58cf048e53536ea89d5c9c Reviewed-on: https://gerrit.libreoffice.org/45095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-25 05:49:31 +0000