summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-11-02tdf#115317 Fix empty url representationPaul Trojahn
ScTabEditEngine doesn't override CalcFieldValue, so the function in EditEngine returns a single space as representation. By inheriting from ScFieldEditEngine the representation is calculated correctly. Change-Id: I6f3be8bd2c3936acf9f3d082c25c080bd3cbee76 Reviewed-on: https://gerrit.libreoffice.org/62428 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-01Add REGEX() 4th parameter also to Excel import/export, tdf#113977Eike Rathke
Change-Id: I5c849c8646711d3de74b91d804e39cdcc20e30fe Reviewed-on: https://gerrit.libreoffice.org/62743 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-11-01gbuild: rename value OS=IOS to OS=iOSMichael Stahl
This gets rid of the horrible hack in gbuild.mk to accomodate the case-incorrect iOS platform makefiles that cannot be renamed without upsetting git on file systems that sadly lack the case sensitivity feature. Keep the macro defined to IOS though. Change-Id: I1022bfef4900da00e75fc1ccce786b20f8673234 Reviewed-on: https://gerrit.libreoffice.org/62705 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-01clang-tidy: (WIP) bugprone-too-small-loop-variable findingsTamás Zolnai
Change-Id: Iaa255b39928ac45dec1ed37e368c149d6027f561 Reviewed-on: https://gerrit.libreoffice.org/62701 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-31Translate German commentsJohnny_M
Change-Id: I94cdb753d01dfd0d5b8f78ede1819b281b840ab2 Reviewed-on: https://gerrit.libreoffice.org/62669 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-31tdf#42949 Fix IWYU warnings in sc/inc; sc/source/filter/inc/Gabor Kelemen
Found with bin/find-unneeded-includes after recent improvements - remove UNO headers from blacklist - remove newly found unneeded fw declarations - fix up some not self contained headers Change-Id: I605656bc98a64640a78d2ff4de9c7c37326033cf Reviewed-on: https://gerrit.libreoffice.org/62264 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-31cppCheck RedundantAssignment variable bRefFoundZdibák Zoltán
Change-Id: I1b8e9d434a682717e09ae1d23470baef55935fe6 Reviewed-on: https://gerrit.libreoffice.org/62664 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable pMergeAttrZdibák Zoltán
Change-Id: I5dc87ec04a7c79359c947ba2786bbe067770904c Reviewed-on: https://gerrit.libreoffice.org/62665 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable pPatternZdibák Zoltán
Change-Id: Iba6eb684366bd60c19e4f28ec76c4d85bd1c4b64 Reviewed-on: https://gerrit.libreoffice.org/62666 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable bRecordingZdibák Zoltán
Change-Id: I2fb7c2ce3581bf6347a5b6ee85d7e603e2b58800 Reviewed-on: https://gerrit.libreoffice.org/62643 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31RedundantAssignment variable aResult1Zdibák Zoltán
Change-Id: I9c8a40389cc9cc18a017f5ab98aa022856ef301d Reviewed-on: https://gerrit.libreoffice.org/62642 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2018-10-30tdf#42949 Fix IWYU warnings in include/sax/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8061ef6a7a8c04baf350844fae1f97836ac03554 Reviewed-on: https://gerrit.libreoffice.org/62399 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-304th parameter Flags for REGEX(), tdf#113977Eike Rathke
REGEX( Text ; Expression [ ; [ Replacement ] [ ; Flags ] ] ) REGEX(Text;Expression) extracts the first match of Expression in Text. If there is no match, #N/A is returned. REGEX(Text;Expression;Replacement) replaces the first match of Expression in Text, not extracted. If there is no match, Text is returned unmodified. REGEX(Text;Expression;Replacement;"g") replaces all matches of Expression in Text, not extracted. If there is no match, Text is returned unmodified. Change-Id: I9d26a48f40c64a2704d9d07576c8b1b98b2c7b84 Reviewed-on: https://gerrit.libreoffice.org/62545 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-30loplugin:returnconstantNoel Grandin
Change-Id: I5b859de6ccd908eee4356acbe1f12b441ab36df3 Reviewed-on: https://gerrit.libreoffice.org/62539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-30sc: Fix a wrong reference in a SMALL()'s test caseTakeshi Abe
Change-Id: I6eb5491cb437745a787304bde9f5673e63892773 Reviewed-on: https://gerrit.libreoffice.org/62380 Tested-by: Jenkins Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-10-30Rewrite REGEX() to directly use icu::RegexMatcher, tdf#113977Eike Rathke
This not only avoids all the overhead of i18npool's TextSearch and Transliteration efforts (which are useful in the Find&Replace dialog bu we don't use here) that could possibly even get in the way how they are implemented, but also gives us direct control over all possible flags; plus ICU's replace features are more convenient to use and have better error checking to report back and there is the advantage that ICU's regex description can be taken verbatim. Change-Id: Iaa06c26a3ff6882a0057d1ca92b1605073429bca Reviewed-on: https://gerrit.libreoffice.org/62531 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-10-30context menu: finish draw and calc context menuesandreas kainz
and update NameGroup arrangement Change-Id: I373229793fa1605e731c04824112118c15e05c29 Reviewed-on: https://gerrit.libreoffice.org/62528 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-29uitest for bug tdf#67346Zdeněk Crhonek
Change-Id: I637a9811ac656db46e0e993343e962dc296e360b Reviewed-on: https://gerrit.libreoffice.org/62527 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-29uitest for bug tdf#54197Zdeněk Crhonek
Change-Id: Iaa6039f9ebabdd4b17e044a82b4e047506addf79 Reviewed-on: https://gerrit.libreoffice.org/62522 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-29calc: sync calc popupmenu and toolbare files with writerandreas kainz
Change-Id: I0cd058974f879166d2205dd7f26e0fd867db4c47 Reviewed-on: https://gerrit.libreoffice.org/62487 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-29sc: fix: range/step calculation for progress barSerge Krot
Change-Id: I733e4003b65b410d44d9a1132be4e9e10ac24c3e Reviewed-on: https://gerrit.libreoffice.org/62305 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-29loplugin:oncevarNoel Grandin
Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd Reviewed-on: https://gerrit.libreoffice.org/62498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-29tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[f-p]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie40401e8706dda219b8578d180983811114cabed Reviewed-on: https://gerrit.libreoffice.org/62208 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-29Notebookbar: add context-Printpreview to calc tabbed NBandreas kainz
Change-Id: I9b63a515c407692f5632cb5e1f391593cfd68736 Reviewed-on: https://gerrit.libreoffice.org/62433 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-29tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I0516dc68cf7d451eafc044be8e50a66d2bddf15f Reviewed-on: https://gerrit.libreoffice.org/62484 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28drop unnecessary requires lib="LibreOffice"Caolán McNamara
Change-Id: I5444e5076ca69e8f6f8d28e36f4e744721cf43ef Reviewed-on: https://gerrit.libreoffice.org/62445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28update old 'interface-requires' comments to <requires> tagCaolán McNamara
Change-Id: If7533650ae543f9d43a3a50fdfc137141fa64586 Reviewed-on: https://gerrit.libreoffice.org/62444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: Iaa1a1811b638aadfe6b06b3465a182cb675031b5 Reviewed-on: https://gerrit.libreoffice.org/62476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I2b2ea62ff4ed3e16cd4fa2a5e588d001d21121cb Reviewed-on: https://gerrit.libreoffice.org/62465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I1e5098e11f1e5e2f7c5518ea05c57512f58b585b Reviewed-on: https://gerrit.libreoffice.org/62464 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: Ic92cc594979cac2edac04a085957398672a5dfcc Reviewed-on: https://gerrit.libreoffice.org/62450 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27uitest Calc signature lineZdeněk Crhonek
Change-Id: I249c843f89ed5fe1d413f17fa57671d4ef9c69b2 Reviewed-on: https://gerrit.libreoffice.org/62404 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-27uitest: integrate the calc input bar into the ui testingMarkus Mohrhard
Change-Id: Ib73d09b648c0663de57e4b205e7154d6af1366f8 Reviewed-on: https://gerrit.libreoffice.org/62412 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-27tdf#120856 sync shape, graphic, frame and ole contect toolbarandreas kainz
in writer and calc Change-Id: I36458c27027748c790a5e6ef768fcd19986b656d Reviewed-on: https://gerrit.libreoffice.org/62336 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-27tdf#120703 (PVS): V519 The variable is assigned values twice successivelyMike Kaganski
Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27 Reviewed-on: https://gerrit.libreoffice.org/62406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-26tdf#120861 move paste special to a submenu in menubarandreas kainz
Change-Id: I4b6a2eb32ff155855bb9e5d1638f7239252278f3 Reviewed-on: https://gerrit.libreoffice.org/62301 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-26Use CheckStringResultLen() also for CONCATENATE(), CONCAT() and TEXTJOIN()Eike Rathke
Change-Id: Ifbc2b127998e037be3f014bebf8721bef15ef53b Reviewed-on: https://gerrit.libreoffice.org/62385 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-26missing includeStephan Bergmann
Change-Id: I57dfc006d849918179a2398ef22be7585cb0993f
2018-10-26Let REGEX() return #N/A instead of #VALUE! if no match, tdf#113977 follow-upEike Rathke
So match can be checked with IFNA(REGEX(...);...) and IF(ISNA(REGEX(...);FALSE();TRUE()) Change-Id: I2b75dce78ad8a955aa6f94ea5d225a79ae0e2dc5 Reviewed-on: https://gerrit.libreoffice.org/62386 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26tdf#42949 Fix IWYU warnings in include/unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e Reviewed-on: https://gerrit.libreoffice.org/62041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-26use unique_ptr when Clone()'ing PoolItemsNoel Grandin
and fix a handful of small leaks in the process Change-Id: I876e12ff5305f9dda84532d4182fb91657d6fa0c Reviewed-on: https://gerrit.libreoffice.org/62389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26loplugin:singlevalfields improvementNoel Grandin
look for any kind of types, not just POD types, helps to find smart pointer fields that are only assigned nullptr Change-Id: I2d887e98db012f03b646e1023985bcc196285abc Reviewed-on: https://gerrit.libreoffice.org/62382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26Change kScInterpreterMaxStrLen now result string length limit to 256MBEike Rathke
This is arbitrary. Change-Id: I88875e674464984c174e27fa6038080cc7366ecf Reviewed-on: https://gerrit.libreoffice.org/62375 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26Use SAL_MAX_INT32 in CheckStringPositionArgument()Eike Rathke
... as that does not affect the result string length. Change-Id: Ia4426b4444845b3966da6a8c46089d8a98a38cb0 Reviewed-on: https://gerrit.libreoffice.org/62374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26Introduce kScInterpreterMaxStrLenEike Rathke
... and use that instead of SAL_MAX_UINT16 where string operations are involved. Change-Id: I41248bc1a876c19cd917269e44a6e91f51e569f5 Reviewed-on: https://gerrit.libreoffice.org/62373 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26Rework GetStringPositionArgument() to return sal_Int32Eike Rathke
... and set FormulaError::IllegalArgument for illegal values. Change-Id: Iaf4c5123a3290ee1860d16fcf270e8c2a2e0845f Reviewed-on: https://gerrit.libreoffice.org/62372 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-25return std::unique_ptr from CloneSetWhichNoel Grandin
Change-Id: I709122cb8cd7c257e7eb2bd564c529689e6d555a Reviewed-on: https://gerrit.libreoffice.org/62350 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-25Resolves: tdf#113977 implement REGEX() spreadsheet functionEike Rathke
REGEX( Text ; Expression [ ; Replacement ] ) Using ICU regular expressions http://userguide.icu-project.org/strings/regexp Change-Id: I4cb9b8ba77cfb5b8faab93037aa0d947609383d7 Reviewed-on: https://gerrit.libreoffice.org/62332 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-25tdf#118747 sc: use manual height for previous rows in TransferObjVasily Melenchuk
This can ensure, that visible area will not shift if autoheight will change height of previous rows. Change-Id: I66e013e9f3f27396f13b26fde37353cb63e47258 Reviewed-on: https://gerrit.libreoffice.org/62279 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>