Age | Commit message (Collapse) | Author |
|
Change-Id: I9b781aaf98c16c83e12406ee38167814fb32cfc9
|
|
Change-Id: I832ab43e2fccf9b2c24e98ae443a9611012ea5a1
|
|
overwrote crash-1.xls by accident in
commit d2281e20d96c640998530f3fb577b87ee85426f1
Author: Caolán McNamara <caolanm@redhat.com>
Date: Fri Oct 2 10:41:25 2015 +0100
fix crash on loading certain xls
Change-Id: I2dd58060c1f3c9f12356c4ab18a0c838e7cdd718
so restore that, add another test case for...
commit c4d1a99ec667bdd661669afd72a708bd9a963db2
Author: Caolán McNamara <caolanm@redhat.com>
Date: Sat Oct 3 11:53:48 2015 +0100
fix crash on loading certain xls
Change-Id: I4f4563b07109df7e2288458cf8adda37582262cf
as crash-4.xls
and add d2281e20d96c640998530f3fb577b87ee85426f1 test-case in
as crash-5.xls
Change-Id: I2de3986290bdf5e227e4471e411bb6a9a83b3085
|
|
Change-Id: I4f4563b07109df7e2288458cf8adda37582262cf
|
|
Change-Id: I22be90d7c54b1118f81337bd9e1d97ba3a1fd86e
|
|
In preparation of matrix calculations to use string conversion
configuration and UI markers for cells containing strings that could be
numeric values.
Change-Id: Ifa9e45853dded249fa741c050ae1f106365f99ea
|
|
Change-Id: I36f9439e417b380bd3f999c02c55c29337796002
|
|
Change-Id: I2dd58060c1f3c9f12356c4ab18a0c838e7cdd718
|
|
Was not liked.
This reverts commit e4ddba2b5f8ff32dd35e8c8f66f145597407be42.
This reverts commit ab092bdc0f8c45e174cad403de9d2342adc01fb6.
Change-Id: If2e9e032a135530da92b5bd166f5b559b10b0b91
|
|
Change-Id: I648ad2fe4b4cd425b2f7f1014c063169beae54db
|
|
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c
Reviewed-on: https://gerrit.libreoffice.org/19072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I5e9d5b63bf18caa89565270c1630e1c8431c8630
|
|
Change-Id: Ib397b70f5c33fcf0f8ab26c82bffe7713e1042fd
Reviewed-on: https://gerrit.libreoffice.org/17595
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I09b9b1bc62b084824dc0eaffd6ee500de11781fd
Reviewed-on: https://gerrit.libreoffice.org/17594
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
WalkElementBlocksMultipleValues class is able to collect a few values at
once. scmatrix.cxx were moved to matrixoperators.cxx
Change-Id: Id069f89a58cce046fb3d4ddf6f49db0452bdfb36
Reviewed-on: https://gerrit.libreoffice.org/17593
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ib42d0d51945f634a3052c387a0317d7a919a4d4b
Reviewed-on: https://gerrit.libreoffice.org/17482
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I5f7f52b6f2fb92c46e2b24e0edf95b4ccd17671d
|
|
- preserve backward compatibility
- nDebugFlag is stored but not used when loaded
- Flag nDebugFlag set the top bit to 1
- stores the multiplier of sal_Int16 limit to reach nStart
- in load, test this flag bit
- rebuild correct nStart
- new B_CURVERSION file format for binary storage macro
- unit test for big modules
Reviewed-on: https://gerrit.libreoffice.org/18926
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit db17079fcff6f9a068c499b17f2501cc4c82d10b)
Change-Id: Iaa037982d828fef7195615e6eda546b7199a4fe8
|
|
It's more valuable to have the raw text data of the html instead of
having it locked up in images. If the comments are exported as
images, then it makes it almost impossible to discern what comment
belongs to what cell when viewing the html file itself.
This is done by rendering the comments in their own comment tag
(to make it still easy to extract from scripts that modify html)
that is shown to the user. This element is initially not displayed
until the user hovers over the comment indicator
The comment indicator is denoted by a 0.5em by 0.5em red square with
a black border. The notes will always appear on a pale yellow
background with black text when the indicator is hovered over.
Change-Id: I01a3dfd77ec54566e64b196b8df3309ea941ad4c
Reviewed-on: https://gerrit.libreoffice.org/18837
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
...where the most plausible explanation for the bug's crash from within
ScGridWindow::CreateAccessible appears to be that the call to
xAcc = new ScAccessibleEditObject(this, ...)
which stores "this" as a css::uno::Reference in the ScAccessibleEditObject, can
cause xAcc to be deleted synchronously from within the ScAccessibleDocument
ctor, causing the ScAccessibleDocument instance itself to also be deleted.
So re-use the existing ScAccessibleDocument::Init (already properly called at
the only place that instantiates ScAccessibleDocument, in
ScGridWindow::CreateAccessible) to defer any initialization that uses "this",
and hope that the resulting slight re-ordering of when certain initialization
code is executed does not cause problems.
Change-Id: I524a1659394e8900b7d33de358fdd4baf647c083
Reviewed-on: https://gerrit.libreoffice.org/18750
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I83e028428933e2153b639ca6b34fd69db88fb53f
|
|
Change-Id: Ief198f88530d72cde0a253508cdf6de2975b31ab
Reviewed-on: https://gerrit.libreoffice.org/19066
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
those whose string ref syntax is unknown or can't be guessed i.e.
don't use it for new documents (prefer user settings in that case)
Change-Id: I1355031cdd63e2a5c50064531011be71ae7f7b8f
Reviewed-on: https://gerrit.libreoffice.org/18923
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
the $WORKDIR
Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Sun bug numbers without any accompanying text are completely useless.
Fixed with
git grep -lP '//\s*#\d+#\s*$'
| xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.
Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Id9864f199e270d13d801348b12f1e94dd80558c7
|
|
Change-Id: I23e219cec1a8d98e02c3584041f67ff42dd29bd8
|
|
Change-Id: I05624acbdf4695ef652e619662996ac41afed410
|
|
Change-Id: I8450ed77094094b19d77a0ffa37fe9fbaa889fa3
Reviewed-on: https://gerrit.libreoffice.org/18969
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Auformat list (maData) is defined as "MapType" which itself is defined like this:
boost::ptr_map<OUString, ScAutoFormatData>
so default sorting is ascii
2 consequences:
1) Default didn't appear first
2) When adding a new autoformat entry when it was new first one of the list
wasn't saved because of iterator was incremented first before looping
See https://bugs.documentfoundation.org/show_bug.cgi?id=94173#c5
There were some other weird behaviors too according to comments of the bugtracker
Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=72c1b6141d590fb4479925ed8bc88b79357c2bfc
Solution:
Add a Compare so Default entry is always first one so the first time incremented iterator is ok and
new entry (even if new first one in list) is saved
Thank you Markus for the idea! (I was lost in Compare syntax)
Change-Id: I9ba0cdc63c66b747db102bb661cd09fbfe5996ae
Reviewed-on: https://gerrit.libreoffice.org/18598
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
We will return false if any of the tests here match, so good to test
the trivial things first before ones involving a potentially complex
function call.
Change-Id: I531282041c888799d37d95ae773daa349e60a37d
|
|
Change-Id: Ifb52f4a5a547a5a52462c0f9166aad13cbf21cd9
Reviewed-on: https://gerrit.libreoffice.org/18971
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
This was crashing in CppunitTest_sc_macros_test on Windows with
--enable-mergelibs (release build), because the first invocation of
processWindowResizeEvent() deleted the vcl::Window, and the
maControllers.count(pWindow) test creates a VclPtr for it, so ends up
with a double-free.
TODO: is processWindowResizeEvent() supposed to be idempotent?
It would be possible to detect that there is already an event posted by
checking m_PostedWindows in postWindowResizeEvent().
Change-Id: I7b72f2baf21bb8223e9fe4bd929d826217b920e5
|
|
Change-Id: Ia41f4f0ca30ae3346d0720271478ec5bcdab797b
Reviewed-on: https://gerrit.libreoffice.org/18967
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Idd4b0f7b6c422abd6790185b5d48082b294bae64
Reviewed-on: https://gerrit.libreoffice.org/18968
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I3ea8a90f0ec917b4e26335fcd31a5f7e0888589e
Reviewed-on: https://gerrit.libreoffice.org/18972
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I532c635d2dd2ba58bb6dba6422cb50dfac32fcc5
Reviewed-on: https://gerrit.libreoffice.org/18970
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I5c331380b872429cf1fa3908c6add8de879c9ed2
|
|
... that cured only a symptom.
This reverts commit 04aceed37a42245392ed4671d276dd2de6118a89.
|
|
Change-Id: I490841fd2c526e4ca6d6c94cc7b9dba318c932a1
|
|
"sc/source/filter/oox/pivotcachebuffer.cxx:401:45: error: assuming signed
overflow does not occur when assuming that (X + c) < X is always false" at least
with "g++ (GCC) 5.1.1 20150618 (Red Hat 5.1.1-4)" and --disable-debug
Change-Id: I1d267b2947f04b84f73da2b1458d316397e2374e
|
|
Change-Id: I6290ab4a5951ada1588b9b7641b7e047cc82a9ee
|
|
Change-Id: Ib2df51589726c0163b8cbb5434c9017d358abc78
|
|
Regression introduced with ecfcc545433d30e3b70fd0c909cce782edbdee39 "Replace
Stack with std::stack< std::pair< XclObj*, XclEscherHostAppData* > >"
Change-Id: Ib4776a2df3c2f9648f2e1af70c7d20485a7ff888
|
|
Change-Id: I88b655d3591483625d45c8a39890773d081b406f
|
|
Test case scenario:
* in A1 enter =1E222
* move cell cursor back onto A1
* status bar displays Sum=1000000... repeated until filled (or 222 '0'
characters)
Change-Id: Icc1a11a2b007649fc7074e7538917e56dc943444
|
|
Change-Id: I8f649229ffce60de16e6b4611b1c081811cef225
|
|
Change-Id: I00dc8c2550053235ea9ddb5fa3078b11a0be395c
|
|
Change-Id: I353d6ceb74347f09dad77116b52771dd5aa21dab
|