summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-05-26coverity#1409897 Dereference before null checkCaolán McNamara
Change-Id: I9ce73a4836df502267ec9b247432dd86b6ac1b62
2017-05-26coverity#1409898 Dereference before null checkCaolán McNamara
Change-Id: I44b5ab0c66b4050c2ee47684af7526e2543945ca
2017-05-26coverity#1409901 Unused valueCaolán McNamara
Change-Id: I1a363ed385ba251ece29f7bd1eaa151c0657f14e
2017-05-26tdf#108049 VBA exception avoided in ScVbaRange::setStyleJustin Luth
Change-Id: I5fc928373d70829b6e68d9000140a30f04179536 Reviewed-on: https://gerrit.libreoffice.org/37981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-26xlsx export: limit dataValidation list to 255 chars, not 254Justin Luth
related to tdf#99856 commit b139bf96574010f317c543bc45d23dd6a5810621 which had a logic failure, caused by investigating too many alternative ways of fixing. Change-Id: I6ffce8c0bc10c992804cb5d8c75441da1a4c3d37 Reviewed-on: https://gerrit.libreoffice.org/38051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-05-25tdf#99856 xlsx export: limit dataValidation list to 255 charsJustin Luth
Excel consider the file corrupt if it has an overly long validation list. Change-Id: I4145859d4f76e0a70521c7bee33c96927b437ace Reviewed-on: https://gerrit.libreoffice.org/38038 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-25tdf#108017 xlsb import: protection settings were reversedJustin Luth
Back in LO4.3, commit 5728a56b20e01d6c9e86a23f20af64a1b68ad604 fdo#70499 selectn of lock/unlocked cells with worksheet protection reversed ...reversed finalizeImport's understanding of maSheetProt.* to match xml import, but then it no longer matched the binary stream import. So, .xlsb imported the opposite of what .xlsx/.xlsm imported. Change-Id: I2da3967ef52187e4ef36ce7d01b17a4672f61e1c Reviewed-on: https://gerrit.libreoffice.org/37952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-24Clean up a commentTor Lillqvist
Change-Id: I9ee47a3de42087fb63e5d3e931ecee538017f3cc
2017-05-24tdf#107945: properly iterate over mtv during pivot cache loading.Kohei Yoshida
This reduces the total time required for populating the pivot cache by ~60%. Change-Id: I6a8511959c20231a8a5dbd0b0a9a3d0930a1fa0c Reviewed-on: https://gerrit.libreoffice.org/37971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-23Extend the loop over svRefList to cover also the query evaluationEike Rathke
... otherwise all but the last reflist entry are thrown away.. Change-Id: Ic8e66cfb6179a86140e566d25cbffc901527f269
2017-05-23svRefList always needs to be in a loop to be eventually popped from stackEike Rathke
If it has more than one entries, rRefInList and rParam are incremented (effectively annulating a nParam--) and only the last entry pops the token from stack. This could had led to wrong references for other (previous) parameters. Change-Id: I4204d1be4da2e538cece20d92cb7cd96b7c8fa84
2017-05-23sc: work around MSVC 2017 ICE in AccessibleDocument.cxxMichael Stahl
MSVC 2017 dies with INTERNAL COMPILER ERROR on the ConvertLayerId function, which uses fancy C++14 constexpr SdrLayerId/strong_int stuff; it happens to compile without complaint if it is expressed as an if-elseif chain instead of the switch statement. Change-Id: Ib1324bbabeb7a971ba090b9647dde55c1cd0d587
2017-05-23Move pushing the result token into IterateParametersIfs, tdf#58874Eike Rathke
Change-Id: I7c44afad1610fd04b0b2acc51c654a583ed991e6
2017-05-23PushError() instead of SetError() so there's a result tokenEike Rathke
Change-Id: I8c2a7e01b04c26e008c8cbea9332f71d47293c75
2017-05-23Unit test for COUNTBLANK with array of references, tdf#58874Eike Rathke
Change-Id: I44c4db675b822c0456197bf019783076cb7a4b78
2017-05-23Handle COUNTBLANK with array of references, tdf#58874Eike Rathke
Change-Id: Icf8d2ac32a75ebb45c8c6b3b5ae46d01757eb07a
2017-05-23MustHaveParamCount() already pushes error, tdf#58874Eike Rathke
Change-Id: I5d4ec4f36d7c047a377528495e04cbd9a7bdc38b
2017-05-23drop the SCsROW/SCsCOL/SCsTAB typedefsNoel Grandin
which are exactly the same as the regular SCROW/etc typedefs, and have been this way since commit 43a21999a92c99867bc3417291719996776b0647 Author: Oliver Bolte <obo@openoffice.org> Date: Fri Jun 4 09:00:39 2004 +0000 INTEGRATION: CWS rowlimit (1.1.2); FILE ADDED Change-Id: Ia7f75d71227ca3167b5fd56019bb9bdf0697d1b0 Reviewed-on: https://gerrit.libreoffice.org/37911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-23Handle SUMIF and AVERAGEIF with array of references, tdf#58874Eike Rathke
Change-Id: I37bad7b85ee61631399f1b49d0bc9be3b8d00423
2017-05-23Move pushing result token into IterateParametersIf(), tdf#58874Eike Rathke
Change-Id: I98c52784992f5734480736ce4f8290490ca752f1
2017-05-23Handle COUNTIF with array of references, tdf#58874Eike Rathke
Change-Id: Id0325fba37cbf2cfea4a33e3e8110c5d85cf16a6
2017-05-23enhance useuniqueptr lopluginNoel Grandin
teach it to look for the following sequence in a destructor: delete m_pfoo; m_pfoo = nullptr; Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380 Reviewed-on: https://gerrit.libreoffice.org/37900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-22Revert "Handle SUMPRODUCT with svRefList arguments, tdf#58874" (Excel can't)Eike Rathke
This reverts commit 6b417ec3daaec72c736fcfe0d980ce205e589633.
2017-05-22svRefList argument can be handled now in ForceArray context, tdf#58874Eike Rathke
... but it's up to the comsuming function if and how, so don't set a hard error here anymore. Change-Id: I316b6fb22c4b0569d209880c34704bb04f757045
2017-05-22Handle SUMPRODUCT with svRefList arguments, tdf#58874Eike Rathke
Change-Id: I03c2ed1f957db5ad8a67aaab45076373a020e9c1
2017-05-22Introduce GetMatrix() from svRefList, tdf#58874Eike Rathke
Change-Id: Id3a2500c475835c54fbf02505f852bb33e1403cc
2017-05-22sc lok: prevent wrong assignment aEnd.Y()Henry Castro
In tiled rendering case, the window size is small, and the assignment aEnd.Y() will cause wrong invalidation area. However, at this time will never happen because MAXTILEDROW < MAXROW, so better to avoid in case the last row meets the condition. Conflicts: sc/source/ui/view/tabview3.cxx Change-Id: I9c6af57c0342f173195bb2f3d8ac5ef0f3964911 Reviewed-on: https://gerrit.libreoffice.org/37908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-05-22Unit tests for ...,ref1,arrayofrefs,ref2) to result array, tdf#58874Eike Rathke
Change-Id: I21e98ccd6c13c7e4aa98d5bbdd0dab6d9917a3dc
2017-05-22Unit test for SUBTOTAL STDEV with array of references, tdf#58874Eike Rathke
Change-Id: I27d8a0a3c03012a4575785feb32df11a76d6fcdb
2017-05-22Handle STDEV, STDEVP, VAR and VARP with arrays of references, tdf#58874Eike Rathke
Change-Id: Ifdd5336124df9a085902417590d081646d05a588
2017-05-22Unit test for SUBTOTAL AVERAGE with array of references, tdf#58874Eike Rathke
To test the count vector as well. Change-Id: Idc6bcdc779ea0e6e8a6118934fd8e7856eba1518
2017-05-22Get vector count right, tdf#58874Eike Rathke
Change-Id: I1d4224c6a87af4ed9f879e144958f95418fabbf7
2017-05-22Move result token push into GetStVarParams(), tdf#58874Eike Rathke
Change-Id: If38637f2dcaf0457e95444a9d46636d91def4f9c
2017-05-22Make GetStVarParams() parameter bTextAsZero non-optional, tdf#58874 prepEike Rathke
Change-Id: Ia38c5617be71a739f0a3a8fcf28060518e9334d1
2017-05-22Generalize to lambda MatOpFunc(), tdf#58874Eike Rathke
Change-Id: Ibd5b1e83ad718d0d5ab832ecf884be69eeb0d22e
2017-05-22Factor out ScInterpreter::SwitchToArrayRefList(), tdf#58874Eike Rathke
Change-Id: I7a672b8d0bd6dae9baa1289a3b00b0789a0d4d6d
2017-05-22Unit test for SUBTOTAL MIN,MAX with array of references, tdf#58874Eike Rathke
Change-Id: I116b236066f28e3442f644544e789e1dbc2ff88a
2017-05-22Handle MIN and MAX with arrays of references, tdf#58874Eike Rathke
Change-Id: I24c9f3078f60e14e64f1e1e3910963dfe0a38d77
2017-05-22const nMatRows, tdf#58874Eike Rathke
Change-Id: Ic9e11ed6b8890fe9d3db4b3a9b4d1d8d50838b2e
2017-05-22Factor out to ScInterpreter::GetRefListArrayMaxSize(), tdf#58874Eike Rathke
Change-Id: Ie08c37ff66faaaba8f8945503e3d212943d324d7
2017-05-22Add unit test for SUBTOTAL over reference list in array context, tdf#58874Eike Rathke
Change-Id: I82752c035f6551d3136dc06331ff8745ba959463
2017-05-22Use SetValue() instead of SetString()Eike Rathke
Change-Id: I9d1f9be14d69006126a2c72b7c4cfbfb24b3cfe8
2017-05-22Handle reference list as array in IterateParameters(), tdf#58874Eike Rathke
This in array context now returns the expexted array for an expression like =SUBTOTAL(9,OFFSET(A1,ROW(1:3),0,2)) where OFFSET returns an array (svRefList) of references, here A2:A3 A3:A4 A4:A5 and SUBTOTAL(9,...) sums each of the references independently to return an array of three sums. Currently works with SUM, COUNT, COUNT2, AVERAGE, PRODUCT and SUMSQ. MAX and MIN are not handle in IterateParameters() and need an extra implementation, or rather move them into IterateParameters() as well? Change-Id: I03b7d1cccf78c1a831348106432126aec8d1f519
2017-05-22Change IterateParameters to push token instead of returning double, tdf#58874Eike Rathke
Change-Id: Ib256d99126116379b27fc246dedf0fac2efb8c02
2017-05-22Get rid of some unneccessary formula:: namespaceEike Rathke
Change-Id: Icd30167589b507c3f83a31dbb5c0eb473ab6580e
2017-05-22Do not force return value to double in SUBTOTAL and AGGREGATE, tdf#58874Eike Rathke
Change-Id: I305adfb97022f353dde6aab4e234faff0fdfb904
2017-05-22Create RefList at JumpMatrix if current function returns Reference, tdf#58874Eike Rathke
Change-Id: I8fcdbc743c614857ee298b3d9c730ab64477dd8c
2017-05-22Introduce ScRefListToken::mbArrayResult for reference results, tdf#58874Eike Rathke
Change-Id: Icd077a82ab0c951667a6566d5c5d47084c46d20d
2017-05-22Introduce ScJumpMatrix::mvRefList for array of reference results, tdf#58874Eike Rathke
Change-Id: I478ddbcd951b386b8d4cbb38059b904af7c79703
2017-05-21tdf#91820 Add cell style and spreadsheet theme commandYousuf Philips
Change-Id: Ia9a3a4704b5c07e5ae26a290855cf77bd33bcbd1 Reviewed-on: https://gerrit.libreoffice.org/37844 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
generated by cgit (git 2.34.1) at 2025-03-19 11:15:36 +0000