summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-12-12use unique_ptr in SfxChildWinCtorNoel Grandin
Change-Id: I155036f6a47c765595938ff325ede6bbe6dd5c48 Reviewed-on: https://gerrit.libreoffice.org/65000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12use unique_ptr for SfxChildWinFactoryNoel Grandin
Change-Id: I4305310ea296a5326838759742b14e687158d426 Reviewed-on: https://gerrit.libreoffice.org/64954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12Use Welford one-pass variance algorithm for DataPilot / pivot tableEike Rathke
... instead of the naïve algorithm. Short test case with 4 values: 10000000007 10000000011 10000000013 10000000017 Naïve Var: -21845.3333333333 Welford Var: 17.3333314259847 VAR() two-pass: 17.3333333333333 Change-Id: I2f27ab91166551e96c0e467f41bd6e6d49b50295 Reviewed-on: https://gerrit.libreoffice.org/64993 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-11uitest for bug tdf#31805Zdeněk Crhonek
Change-Id: I21790869be9c87e923cb4d87b58b2dc4b143fb25 Reviewed-on: https://gerrit.libreoffice.org/64971 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-11Correct typed_flags<PivotFunc> mask is 0x1fffEike Rathke
This was wrong since commit 298ee50676b849020a8a5042e8612f71379ecf3b CommitDate: Sun Nov 20 00:14:28 2016 +0100 PivotMedian: Implement median as a new pivot table function and in fact in a debug build failed an assertion soffice.bin: include/o3tl/typed_flags_set.hxx:85: constexpr o3tl::is_typed_flags<E, M>::Wrap::Wrap(type name std::underlying_type<_Tp>::type) [with E = PivotFunc; typename std::underlying_type<_Tp>::type M = 4607; typename std::underlying_type<_Tp>::type = int]: Assertion `static_cast<typename std::underlying_type<E>::type>(~0) == M || (value & ~M) == 0' failed. when one of the functions (e.g. StdVar) not included in the mask was chosen as pivot table data function. Change-Id: I5b9efc7d2cbcf6fece3ef228db8f6e0ffa17b510 Reviewed-on: https://gerrit.libreoffice.org/64974 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-11Resolves: tdf#46119 implement GeneralFunction_VAR, VARP, STDEV and STDEVPEike Rathke
These were never implemented. Likely because they aren't used internally by Calc, which for formula expressions in the interpreter and for DataPilot / pivot table uses a different approach, but they are needed for css::sheet::XSheetOperation::computeFunction() Change-Id: I1af038bf9db8d0c04d69598b992b827b083e2248 Reviewed-on: https://gerrit.libreoffice.org/64957 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-11OSX implement bitmap-only rendering modeJan-Marek Glogowski
Eventually OSX should also depend on SVP and SVP should just export the platform agnostic code, so we can get rid of all the IOS and ANDROID ifdefs. Since the SVP mode now also uses a default DPI value of 96, we can get rid of those "broken" adjustments to the tests in commit a4ab0c08e747 ("Row height tolerance level increase for unittest") and commit 1e55a47e89a9 ("tdf#62268: allow row height recalculation on document load"). The DPI handling on OSX seems really broken. Additionally DPI should probably a float value, as rounding results in various of-by-one errors in tests. Change-Id: I47881683a9c3d3e1b4f8e7aba1d03842da4d6652 Reviewed-on: https://gerrit.libreoffice.org/64736 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-11crashtesting: ooo55266-3.ods some members are nullptrKatarina Behrens
Crashes since commit 6481bda69ade61cb5420156272fcf17edd43d620 tdf#121612: update pivot caches during saving to XLSX without refresh, pivot cache export was skipped entirely Change-Id: Ic68d4974d5cb9278d61938a59aa8f1a01b920f1f Reviewed-on: https://gerrit.libreoffice.org/64903 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-11find-unneeded-includes: Avoid proposing o3tl fw declarationGabor Kelemen
This does not really work: even when it seems to, it compiles only because of transitive includes - Filter o3tl/typed_flags_set.hxx in f-u-u - Remove already added fw declarations from hxx files and include full header just in case - Remove now unnecessary blacklist entries Change-Id: Ie0de6667af697095a623b435806449e7e28a6004 Reviewed-on: https://gerrit.libreoffice.org/64659 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-11tdf#121677 missing item name check for updatesandreas kainz
Change-Id: I35f2beffb564f1e20731ca1e972b69130276cdea Reviewed-on: https://gerrit.libreoffice.org/64905 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-10uitest for bug tdf#91425Zdeněk Crhonek
Change-Id: I95057eb6a8db1bd141bfa53ff955cd72c2b20cd4 Reviewed-on: https://gerrit.libreoffice.org/64883 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-10uitest for bug tdf#80583Zdeněk Crhonek
Change-Id: Ifcbab8c5745b86eaf2406e1fdb3ad368acbb6fe0 Reviewed-on: https://gerrit.libreoffice.org/64849 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-10loplugin:unusedfieldsNoel Grandin
Change-Id: I03e8814407fd8e345cb07ac433db4230b4d96e10 Reviewed-on: https://gerrit.libreoffice.org/64822 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-09Tabbedbar: add EditDoc command to Review Tabandreas kainz
Change-Id: I37b1397dc8406759ac138921aa9fa6c528f95bc7 Reviewed-on: https://gerrit.libreoffice.org/64827 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-09loplugin:unusedmethodsNoel Grandin
Change-Id: I4f2635d468c9ad83b3ac93733529e01a4d03f38e Reviewed-on: https://gerrit.libreoffice.org/64805 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-08Resolves: tdf#80583 create range list string with proper delimiterEike Rathke
... which is the to be used function parameter separator here. The current document's grammar (from which the separator is obtained in ScRangeList::Format() if not specified) may differ from the forced English grammar later when compiling the formula, and all formula expressions to be inserted use the language independent ';' semicolon function parameter separator. Change-Id: I7a3deb6d50fc57ed434ede1f00bbe8c5c1361e0f Reviewed-on: https://gerrit.libreoffice.org/64819 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08Clean up LIBO_INTERNAL_ONLY uses of SAL_WARN_UNUSED_RESULTStephan Bergmann
Change-Id: I98b2d90c8345f07010f6defd82557188d5cd35c7 Reviewed-on: https://gerrit.libreoffice.org/64808 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-08tdf#39674 Translate German variable namesJohnny_M
Change-Id: I6ace9eb6d13c13da0aaf2919c8846fa3cf5fe4c1 Reviewed-on: https://gerrit.libreoffice.org/62837 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-08tdf#112236 Enhance error message when renaming a sheet to blankRoman Kuznetsov
Change-Id: Icd7ac2d10e9d28d563f964cb144bbe94027617c1 Reviewed-on: https://gerrit.libreoffice.org/64788 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-12-08Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-08tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScCellFieldsObj. Change-Id: I09e7c6be401bb54e1314da95d6797790aedefbe1 Reviewed-on: https://gerrit.libreoffice.org/64795 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScCellFieldsObj. Change-Id: I140cb1f1d5f9cbccfd4dbb43d37c9cd48b7346e8 Reviewed-on: https://gerrit.libreoffice.org/64794 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScCellFieldsObj. Change-Id: Ic5679c32669b1368a702c9b132e6789fb828330f Reviewed-on: https://gerrit.libreoffice.org/64793 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08Adds additional test-case for AVERAGEIFS...Dennis Francis
to ensure that the commit Find actual data area inside the main-range... 24b1827309e7fe4d77108da5732f7f4eddad3ae6 does not change results by its optimizations. Change-Id: I07113359cac9c653f692e84a7b79b06621142aaf Reviewed-on: https://gerrit.libreoffice.org/64658 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-07HAVE_CXX_CWG1579_FIX is always true nowStephan Bergmann
...(according to <http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1579> it is fixed in C++14), but for safety, leave the configure.ac check in for some longer. Change-Id: Ibd2f0cac228117e35ac299e2fe74207394c900cd Reviewed-on: https://gerrit.libreoffice.org/64773 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07HAVE_CPP_INLINE_VARIABLES is always true nowStephan Bergmann
...but for safety, leave the configure.ac check in for some longer. Also remove now-redundant SAL_INLINE_VARIABLE again (which was LIBO_INTERNAL_ONLY). Change-Id: Id049e0cb84b4f97f5859f1b16b867b39b448dec0 Reviewed-on: https://gerrit.libreoffice.org/64772 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07uitest for bug tdf#107869Zdeněk Crhonek
Change-Id: I797b13c3ba76869e67c12832402798ab2b65596a Reviewed-on: https://gerrit.libreoffice.org/64776 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-07Find actual data area inside the main-range...Dennis Francis
and trim all ranges to match this actual data area. Don't do this optimization for COUNTIFS where there is no main-range. This optimization is also turned off if any of the parameter ranges are not double-refs. Benefits in cases like - =SUMIFS(A:A, B:B, ">=20", C:C, "<=10") and the is data only in say A1:A10000 and rest are empty. Range trimming in this case saves lot of execution time and memory (for vConditions and vRefArrayConditions). Change-Id: I6b4ad91e23f89dc48603b98000bcef4dbdb03112 Reviewed-on: https://gerrit.libreoffice.org/64657 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-07sc: Peel off a pimplTakeshi Abe
Change-Id: I8797ccc165fb0a6060c6232babc299114411130a Reviewed-on: https://gerrit.libreoffice.org/64707 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07lok: Insert shapes directly into the document.Mike Kaganski
Change-Id: I182aa395ce0f4e4185c9c85a866dec89499842f9
2018-12-07sc: Drop ineffective SetError()Takeshi Abe
as GetNewMat() already sets error FormulaError::MatrixSize when returning null. In fact IllegalArgument is irrelevant here. Change-Id: Ib7354c2e861b666deef1353b2c26d876668d77e3 Reviewed-on: https://gerrit.libreoffice.org/64420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07tdf#121759 Revert "tdf#99296 - Disable headers/footers by default"Heiko Tietze
This reverts commit 08b5048198d59441cb8033ed14cd17e68c943004. Disabled h/f lead to an inactive menu entry (tdf#121759). Also, the change was not accepted by the OP (tdf#99296). See discussion on the mailing list, Gerrit, and BZ. Change-Id: Ie3dcf14c173a1813da05d8f2a9c8f2eda14cee46 Reviewed-on: https://gerrit.libreoffice.org/64727 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-07tdf#105225 Add palette choice to calc tab background color dialogJim Raykowski
Change-Id: I9891a20d3bc3de51fec84fb54c7aae42f7142662 Reviewed-on: https://gerrit.libreoffice.org/64329 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07remove unused XMLShapeExportFlags::NO_CHART_DATANoel Grandin
dead since commit ec712408961a4a2efc667a7af83a21209907f9eb Date: Fri Nov 20 11:58:22 2009 +0100 chartpositioning: #i100778# chart positioning excluding labels Change-Id: Ibc7f23d51a0ba4ac1e63cd89a28298d95a405110 Reviewed-on: https://gerrit.libreoffice.org/64718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07loplugin:singlevalfields extend to all static varsNoel Grandin
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528 Reviewed-on: https://gerrit.libreoffice.org/64710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScUniqueCellFormatsObj. Change-Id: I2aabc835d37c5f12afacfcbafc2d7d6346619a3c Reviewed-on: https://gerrit.libreoffice.org/64666 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-06remove uno:InsertObjectChartFromFile command from UIandreas kainz
cause command isn't available any more Change-Id: Ie73491e02979fe24f59e8c627b69f902a12b512a Reviewed-on: https://gerrit.libreoffice.org/64711 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-06tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScUniqueCellFormatsObj. Change-Id: Ia49fce123577a62e1ad60ef0dab4ac61148a1551 Reviewed-on: https://gerrit.libreoffice.org/64665 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-06tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScUniqueCellFormatsObj. Change-Id: I9cec7605afa2cbfec48e5ecee22c12983c68afee Reviewed-on: https://gerrit.libreoffice.org/64664 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-06print also contents of OpenCL buffers in debug outputLuboš Luňák
Specifically, the input arguments of the run programs and the results buffer. This should make it much simpler to check if an OpenCL program works correctly. Change-Id: I0667082bf9a88757c8bda0c7ed54e2fc918534d7 Reviewed-on: https://gerrit.libreoffice.org/64547 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-12-05tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScCellFormatsObj. Change-Id: I5ef1e789a535af55705c3a39f07a9396666adbed Reviewed-on: https://gerrit.libreoffice.org/64648 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScCellFormatsObj. Change-Id: I68b9e0308b1959b848e8a53b143c6a6a49589bb7 Reviewed-on: https://gerrit.libreoffice.org/64647 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScCellFormatsObj. Change-Id: I8c72c7eb352720f4ff40727df4823855ec8014e5 Reviewed-on: https://gerrit.libreoffice.org/64646 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05tdf#45904 Move XControlAccess Java test to C++Jens Carl
Move XControlAccess Java test to C++ for ScViewPaneObj. Change-Id: If18596b41fccc140186820c9e370f502fb2b6458 Reviewed-on: https://gerrit.libreoffice.org/64606 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05Resolves: tdf#121887 RowModel::mnRow is 1-based, alwaysEike Rathke
Basically this was always wrong. Original code didn't treat the r attribute as optional and resulted in an invalid -1 row for such cases, hence the RowModel wasn't applied later. Then commit af8e6f4f544ecd01d3eda5f38bbd4779d5e8b2c6 CommitDate: Wed May 29 22:05:02 2013 +0200 r is an optional attribute in c and r, fdo#65059 introduced a 0-based SheetDataContext::mnRow but assigned that to a 1-based RowModel::mnRow as well if r attribute was missing, and did not update SheetDataContext::mnRow if r attribute was given. commit ff56553e34dfed01b9226ce7a516dbeb6da32124 CommitDate: Thu Mar 13 18:39:22 2014 -0400 fdo#76032: This row index is 1-based whereas our own mnRow is 0-based. then correctly assigned the decremented r attribute to SheetDataContext::mnRow but did not touch the assignment to RowModel::mnRow if r was not given. Probably confused by the ++mnRow already there which is correct but not sufficient for the assignment. Which we now finally fix herewith.. Change-Id: Iae1563ed01b95e7852ddad4fd59374c07186b493 Reviewed-on: https://gerrit.libreoffice.org/64580 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-05tdf#51671, implement feature to disable legend entry for seriesMarkus Mohrhard
No UI and no ODF or OOXML support yet. Change-Id: I839c195e9c42f074838ff6592331f7cdd13b6cd2 Reviewed-on: https://gerrit.libreoffice.org/64583 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-12-05loplugin:singlevalfields in scNoel Grandin
Change-Id: Ia18d05b80f90a2333faf41029e7ae66fbd52dc78 Reviewed-on: https://gerrit.libreoffice.org/64599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05OpenCL FVSCHEDULE() error checkingLuboš Luňák
Change-Id: If93a9ea6e0265ba616b4a1fbe138d310ea3e8693 Reviewed-on: https://gerrit.libreoffice.org/64546 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-21 16:04:24 +0000