summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-12-20sc: Simplify RemoveSubTotalsHandler using std::setTakeshi Abe
instead of std::vector. Change-Id: I5927e061b5d2944cad68b96e313934738c63c321 Reviewed-on: https://gerrit.libreoffice.org/65400 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-19Add XServiceInfo tests to ScTableRowsObjJens Carl
Change-Id: I9ebf0c3664c56f99a4e423c409c5d1621b8ea082 Reviewed-on: https://gerrit.libreoffice.org/65402 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19Fix typo in QA pathAndrea Gelmini
Change-Id: I866611929f75dd322ce81ec54a63ec08002f55cc Reviewed-on: https://gerrit.libreoffice.org/65401 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XTableRows Java tests to C++Jens Carl
Move XTableRows Java tests to C++ for ScTableRowsObj. Change-Id: I765d213e0a3e95a3925f1fc179a8a3f6c6611739 Reviewed-on: https://gerrit.libreoffice.org/65398 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#120859 bad column span in .ui leads to overlapping checkbuttonsCaolán McNamara
possibly(?) since... commit d999b55e28d0445df870f69b3a269964e3635def Date: Sun Dec 10 10:56:38 2017 +0530 tdf#114200 : added 'Trim space' feature in 'Text Import' made a checkbox to Trim extra white spaces from both ends while using seperators in 'Text Imort' Change-Id: I280c5daacdc823ea26d02890ddbc4685a5382e6c Reviewed-on: https://gerrit.libreoffice.org/65427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19tdf#42949 Fix IWYU warnings in sc/source/filter/oox/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ibf5b7a813910f2ab37d8705b99bd8a9a19706c43 Reviewed-on: https://gerrit.libreoffice.org/65061 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-19tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScTableRowsObj. Change-Id: Ic2d37c7b918faff3af7a682f72a1f2b04857c5d7 Reviewed-on: https://gerrit.libreoffice.org/65373 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableRowsObj. Change-Id: Iefe5024cbde5f1583a560d8569e9aa460b68e42e Reviewed-on: https://gerrit.libreoffice.org/65372 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19Turn OSL_ENSURE(IsCalculated()) into assert()Eike Rathke
That is a programming error if precondition is not fulfilled. Change-Id: I9eb04cc99d10c27f193321ecaee74cc1b41ce531 Reviewed-on: https://gerrit.libreoffice.org/65359 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-19tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScTableRowsObj. Change-Id: I90dc592ba7901dab9c402b56e9e992fe7593c71c Reviewed-on: https://gerrit.libreoffice.org/65371 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18Add XServiceInfo tests to ScScenariosObjJens Carl
Change-Id: I4d8fb95af78330d488e4b782eb8cdff5b83f1cc2 Reviewed-on: https://gerrit.libreoffice.org/65369 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScScenariosObj. Change-Id: I73dd65e672e1e98a6839cea03c30cfafb7da4ff4 Reviewed-on: https://gerrit.libreoffice.org/65313 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScScenariosObj. Change-Id: Ic1592746f99f685375e5b96c5b51c221d48ab07f Reviewed-on: https://gerrit.libreoffice.org/65308 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScScenariosObj. Change-Id: Idfe41c83adcec7a9cb6b29da9aafcb8c7c25c711 Reviewed-on: https://gerrit.libreoffice.org/65306 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18tdf#120513 Change error message for Excel files about recalculateRoman Kuznetsov
Change-Id: If69941920060bb34894ea399aa7f15052502b078 Reviewed-on: https://gerrit.libreoffice.org/65288 Tested-by: Jenkins Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-18no need to allocate sc::op::Op on the heap hereNoel Grandin
Change-Id: I6a048a51eacaa7063318cdc27d5bc25cc96d557b Reviewed-on: https://gerrit.libreoffice.org/65304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18tdf#121592 add context-Form toolbar to NBandreas kainz
tabbed and groupedbar_compact add context-form support Change-Id: I4a59d4b71bbbc253ee4188c4c15a7353e623e2f1 Reviewed-on: https://gerrit.libreoffice.org/65295 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-17tdf#99438: sc: support for .xltx exportVasily Melenchuk
Added support for content types for template and template with macros (.xltm, but no user interface for this yet). Fixed preferred extension for template: by default it is .xltx and not .xltm (macro-enabled), because MS Excel is very strict about matching of content-type and extension here. Fixed wrong namespace in FilterService for ExcelFilter. Change-Id: Ie717d31d72203601324860f069918d75082add4a Reviewed-on: https://gerrit.libreoffice.org/65111 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-17tdf#42949 Fix IWYU warnings in sc/source/filter/excel/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia155032426e02eb9ee64db3fb10946f5c9d445b7 Reviewed-on: https://gerrit.libreoffice.org/64832 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-17tdf#121581 update Tools tabb in NBandreas kainz
Change-Id: I788e97ce1f6422ba95a478fb1618773c850764f5 Reviewed-on: https://gerrit.libreoffice.org/65262 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-17tdf#122154 add DataSort action to data groupandreas kainz
and update some alignments Change-Id: I8d21e2764805e6b86fce776b7587d7bc0f76ae33 Reviewed-on: https://gerrit.libreoffice.org/65259 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-17Resolve deprecated implicit capture of *this by reference in C++20Stephan Bergmann
...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-16uitest for bug tdf#119954Zdeněk Crhonek
Change-Id: Id9dbd53f2902f484f9d1209953ff2ad58d77936c Reviewed-on: https://gerrit.libreoffice.org/65199 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-15Fix typoAndrea Gelmini
Change-Id: I846df107b450c966725bc1e516cec5989b8f4b08 Reviewed-on: https://gerrit.libreoffice.org/65193 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-15tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScHeaderFieldsObj. Change-Id: Ibead91f6c4369bb75e218eadb99776b0d1fb7cf4 Reviewed-on: https://gerrit.libreoffice.org/64799 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-15tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScHeaderFieldsObj. Change-Id: Ia922b11e93f38bfc56795cc34c150b3429fd5447 Reviewed-on: https://gerrit.libreoffice.org/64798 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-14lok: Insert shape at the positon of the selected cellTamás Zolnai
Calculation of the visible area is not working correctly in online case which leads to positioning of the shape outisde of the view. Instead of that calculation use the selected cell's position to insert the shape at, similar how image insertion works. Change-Id: I5c887261556c491962ed19f416ce480a63c24a9a Reviewed-on: https://gerrit.libreoffice.org/65177 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-14avoid possible expensive repetitive formula group changes (tdf#102364)Luboš Luňák
The testcase from tdf#102364 is actually a rather pathological case, the document having a full 1M cells column with the same formula, and doing undo in this case essentially pastes the column over itself (I think a column is first deleted, which moves this column, and then ScUndoInsertCells will trigger ScMoveUndo::UndoRef(), which will paste the column in that place again. And since this is done cell by cell, removing old cell first splits the large formula group and then adding a new cell with the same formula rejoins the formula group, and setting these formula group changes for all the cells over and over actually takes a long time. Avoid that by delaying the formula grouping operation and do it just once at the end. I'm not sure if this is that good way of handling this, given the testcase is very specific, but I can imagine something similar happening in other possible cases (manual copy&paste of a large column over itself or moving it slightly up or down). Change-Id: Ie4241197103a039c232150333250f78175b1c2c7 Reviewed-on: https://gerrit.libreoffice.org/64782 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-14optimize expensive EndListener() calls (tdf#102364)Luboš Luňák
The document has a large (1M cells) column, and when replacing old cells with new cells during undo as described in the bugreport the repeated calls to EndListener() from ScColumn::DetachFormulaCell() get quite costly. Optimize this by doing a single EndListeningFormulaCells() call. Change-Id: If51dacdfbe876134de956dbc6bbd73e97d9686ff Reviewed-on: https://gerrit.libreoffice.org/64781 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-14Use ScFunctionData and thus Welford in ConsolidationEike Rathke
Change-Id: I83972b07dafadf87f7322897332bbdf0cf58afd3 Reviewed-on: https://gerrit.libreoffice.org/65162 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-14coverity#1441522 FontWorkGalleryDialog mpSdrView member is never nullCaolán McNamara
Change-Id: If17d2984831b0881d39101648206accdadde12aa Reviewed-on: https://gerrit.libreoffice.org/65163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-14Encapsulate ScFunctionData members and abuse WelfordRunner membersEike Rathke
... to squeeze some memory and later use this as a mass object during consolidation. Change-Id: I3f0aa03ec0bbbb4c64a4854b55a451dd3cacfa90 Reviewed-on: https://gerrit.libreoffice.org/65124 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-14tdf#119734 add icon AutoFilter to groupedbar in calcandreas kainz
Change-Id: I9ddb8f70b53600c02addeaf44a8cd1978e1ba5d0 Reviewed-on: https://gerrit.libreoffice.org/65128 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-13Remove moot commentEike Rathke
ScMarkData is passed since long. Change-Id: I7bf66d1f66d66287206ba4ef69c89f9b020103c6 Reviewed-on: https://gerrit.libreoffice.org/65123 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-13Use ScFunctionData::update() and getResult() instead of direct member accessEike Rathke
So we can start to bundle everything in one place. Change-Id: I5df76bfae0e1bd5e8923b0012c1337e3a7f14db8 Reviewed-on: https://gerrit.libreoffice.org/65122 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-13Add SUBTOTAL_FUNC_SELECTION_COUNT to ScFunctionData::update() and getResult()Eike Rathke
Change-Id: Ie72854a812c9ea73ded6a3e8ed8992dcc73f40ad Reviewed-on: https://gerrit.libreoffice.org/65112 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-13Allow better packing of ScFunctionDataEike Rathke
Change-Id: I10fde27502903c5fdbd474995237502d2636a403 Reviewed-on: https://gerrit.libreoffice.org/65106 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-13Should had been sal_uInt64 nCountEike Rathke
Change-Id: I45b725ee740ea84f6af297338889dc447f279acd Reviewed-on: https://gerrit.libreoffice.org/65104 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-13Fix sc_ddelinkobj testsMike Kaganski
Regression from commit 63ff8602c16b0c26927dc3413b12a5368fe367b0. See thread started at https://lists.freedesktop.org/archives/libreoffice/2018-December/081542.html The Application::SetName is mandatory for DDE to work; otherwise InitializeDde() in SfxApplication::SfxApplication() fails. DDE spreadsheet formula expects full name of the target spreadsheet, including path. Fixed sheet name (it's "Sheet1", not "Sheet"). Removed redundant tests (former "testRemoveRefreshListener" tests all). Change-Id: I6299a9ec03c3657a21ad42d0ff87db25cf2be905 Reviewed-on: https://gerrit.libreoffice.org/65079 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-13update groupedbar_compact for calcandreas kainz
Change-Id: Iebbf1eb2db64efa340287b0e0846fa8a121ddf19 Reviewed-on: https://gerrit.libreoffice.org/65081 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-13Introduce ScFunctionData::update() and getResult()Eike Rathke
... to further replace code where that is explicitly done. Change-Id: I2d4065ee2c111a073b65bfc0e42e3479fbd9cf6e Reviewed-on: https://gerrit.libreoffice.org/65039 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-13sc: Use std::find() to simplify codeTakeshi Abe
Change-Id: I903a59591cd204556e873429280aac9cf8d5325a Reviewed-on: https://gerrit.libreoffice.org/65067 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:unusedfields in scNoel Grandin
Change-Id: I5c9e92f5aff6d8fcae7e6affe2977f5804133ea9 Reviewed-on: https://gerrit.libreoffice.org/65053 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13uitest for bug tdf#39650Zdeněk Crhonek
Change-Id: I1eb757939c31aafd9730715bd43a60513842e560 Reviewed-on: https://gerrit.libreoffice.org/65056 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-13uitest for bug tdf#44398Zdeněk Crhonek
Change-Id: I998784e9382866e1afdce4618a2f4acb25d3efa6 Reviewed-on: https://gerrit.libreoffice.org/65060 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-13uitest for bug tdf#39917Zdeněk Crhonek
Change-Id: I6b3c8a72cc36db802aace7aa54efc167d19c1bc9 Reviewed-on: https://gerrit.libreoffice.org/65062 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-13loplugin:constantparamNoel Grandin
Change-Id: I389f98d06058ba65a8c2d4df2bf7d4e5102659ad Reviewed-on: https://gerrit.libreoffice.org/65017 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12Reset WelfordRunner in ScDPAggData::Reset()Eike Rathke
Change-Id: I170b6bc5557f6d0d982751ace3dccc94c6778808 Reviewed-on: https://gerrit.libreoffice.org/65048 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-12tdf#69569 implement proposed change to ODF1.2 part 2 §4.11.7.7Winfried Donkers
Calculating the number of days in a year in AddIn function GetDaysInYear() for basis 1 (actual/actual) gave wrong results. Now the results are correct and the same as in Excel. Extended the unit test document for function YEARFRAC and corrected the unit test document for function AMORDEGRC (verified the results with Excel). Change-Id: Ic68f108496f41dec71b3616095dff80512a64c31 Reviewed-on: https://gerrit.libreoffice.org/64837 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-20 06:11:42 +0000