summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-02-02Fix for tdf#97084 : Scroll view to the ref boundary...Dennis Francis
...but maintain the fix for tdf#96524 Change-Id: I35128843d13904e9e0cf9ded559c352acb3c7c46 Reviewed-on: https://gerrit.libreoffice.org/21559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-02-02tdf#84843 Stop using PseudoSlots for drawing slotsMaxim Monastirsky
Instead of fighting with this obsolete thing, let's just kill it. This fixes disabling in read-only doc, as well as pressed/unpressed states. Change-Id: I4d06ba3395024ffd09d77c6d22653a2c5e227115 Reviewed-on: https://gerrit.libreoffice.org/22010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-02-02boost::hash->std::hashNoel Grandin
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-01Avoid vague and misleading terminologyTor Lillqvist
Sorry, could not resist. "debug mode" can mean a lot. We say here that we mean dbgutil, so use just that term then. And it is no special "mode", it is a dbgutil build, as we already said. Change-Id: I62f1b580298db8a479ff0852834aa7115297e838
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31This can be a Window and not a DockingWindow nowCaolán McNamara
Change-Id: I5b7e42c008328e30d6475283a635e4fdfa1148cb
2016-01-31implement missing FID_FUNCTION_BOX GetStateCaolán McNamara
since it was turned into a sidebar thing Change-Id: Ic7e53b9da3255bb8dfde048e0a12f1d9c89102d0
2016-01-31SfxChildWindow is always nullCaolán McNamara
Change-Id: I0a17066b8571cb40f53921000b7eeb4cdf0c9527
2016-01-31so ScFunctionChildWindow doesn't appear to be needed anymoreCaolán McNamara
Change-Id: I24f9bda13befc05de7376683a5b70d2b98ea8ecf
2016-01-31RecentFunctionsChanged doesn't do anything since...Caolán McNamara
function list was moved to sidebar Change-Id: Icf97e0ec93b2080941f6dcd4d99d30437eac28d8 Reviewed-on: https://gerrit.libreoffice.org/21954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31function list is always in the sidebar nowCaolán McNamara
so its always just left/right aligned Change-Id: I17ecfbb45891b79f20621cf195b3080496a8180b Reviewed-on: https://gerrit.libreoffice.org/21940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31sequence->vector in PrinterOptionsHelperNoel Grandin
Change-Id: I643519397a4e714e3407ec0c3a10d329654b9f7d Reviewed-on: https://gerrit.libreoffice.org/21887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-29oox: replace boost::bind with std::bindMichael Stahl
Change-Id: Ic402cfd6900cdf1741264b409f6fbe8f2db7e17a
2016-01-29vcl: add text alignment functions to ImplFont and FontAttributesChris Sherlock
ImplFont and FontAttributes now have GetAlignment and SetAlignment, and I have renamed Font::GetAlign to Font::GetAlignment, and Font::SetAlign to Font::SetAlignment. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit test added to vcl/qa/cppunit/font.cxx to test text alignment. Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba Reviewed-on: https://gerrit.libreoffice.org/21876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-27add test for tdf#96912Markus Mohrhard
Change-Id: I6d3f7f86cffef8e91cf108c3aecdf5278e4b8658
2016-01-27we need the space="preserve" also for formatted strings, tdf#96912Markus Mohrhard
Change-Id: I6e245de697c1c42acd916beb75d4d157b2962a9a
2016-01-27tdf#96222: Better to avoid anything except MM_NONE, says EikeTor Lillqvist
I.e., avoid MM_REFERENCE, too. Change-Id: I8a12dfbd921861f977427bf8b284e85f367c128d
2016-01-27tdf#96222: Don't attempt to handle matrix formulas as formula groupsTor Lillqvist
(Also known as array formulas.) Change-Id: Ief61c75efb05ea7c880d05e118d9fe10177774db
2016-01-27tdf#89308: Delete old copy of pivot table on moving destinationKatarina Behrens
except for the case when origin of the new range lies within the old range (Calc doesn't update the table then, this needs to be fixed separately) Change-Id: I554a347a94df830ac1fd651c30cf8e83279cdef8 Reviewed-on: https://gerrit.libreoffice.org/21804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-01-27add test for tdf#97308Markus Mohrhard
Change-Id: If35a3d6ef7af619f9544ba15e994f663581de374 Reviewed-on: https://gerrit.libreoffice.org/21819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-27extract all cond format tests in ucalc to own fileMarkus Mohrhard
Change-Id: Ia4773e81e7d3c23404090f5cf5d9d35038c24cd7 Reviewed-on: https://gerrit.libreoffice.org/21817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-27add test for tdf#94626Markus Mohrhard
Change-Id: I868e318bc2f8b0f4a7b0abdd93bda27f36f95d26 Reviewed-on: https://gerrit.libreoffice.org/21828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-26handle entries with num type and formula during OOXML import, tdf#94626Markus Mohrhard
Change-Id: I0d48120f2b128fb898c7cc55cc41ce52378851dc Reviewed-on: https://gerrit.libreoffice.org/21820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-26Resolves: tdf#93151 handle ExpandRefs and mnColDelta the same as mnRowDeltaEike Rathke
Change-Id: I8cd00494fc63124443fc01582296ef17f4cd5e27
2016-01-25tdf#96910 : Calc crashes while using "Insert Column Left" for large DocumentsYogesh
Change-Id: I6e813b7525a3d9b1db131db9f08fc20f7320345f Reviewed-on: https://gerrit.libreoffice.org/21661 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-25tdf#86567 Dropdown for conditional formattingMaxim Monastirsky
Change-Id: I1ba12a8b7501065e3cd52e17b7c0c83a0f58f9cf
2016-01-25Drop unused definesMaxim Monastirsky
Change-Id: I99b505fe59adc095bb55fc983dade23150fc5d75
2016-01-24tdf#74667 interchange slope and intercept for power regressionTomaž Vajngerl
Change-Id: I9da7edeabcc9f963ac19d26114fa101d4b5ce98f
2016-01-23tdf#97308: fix logic with conditional "ends with"Julien Nabet
Change-Id: Ib9f9ed627dc37b11d8c3911aa4fe62141ff471c2 Reviewed-on: https://gerrit.libreoffice.org/21723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-01-23sc lokit: update zoom values to graphic and text selectionHenry Castro
Change-Id: I750f31c5698d9dc5ed589a1812a6993991915dc5 Reviewed-on: https://gerrit.libreoffice.org/21724 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>
2016-01-22editeng: ImpEditView::mbTiledRendering is never readMiklos Vajna
Change-Id: Ie8e33d075f0cedbb9f7148717c4318f4494ed419
2016-01-22Move sc/source/ui/dbgui/validate.cxx from scui to scStephan Bergmann
8d1a24dae03690b576310e3539369916f31ac475 "Make virtual ~ScValidationDlg non-inline" caused the RTTI for ScValidationDlg to only be emitted in library scui instead of (weakly) wherever needed. That causes UBSan to fail when it uses the RTTI in ScValidityRefChildWin::ScValidityRefChildWin (sc/source/ui/view/reffact.cxx, in library sc, to check that operations on VclPtr<ScValidationDlg> pDlg indeed operate on an ScValidationDlg object). The cleanest fix appears to be to move ScValidationDlg from scui to sc. As Moggi put it on IRC, "that dialog should be in sc as it is a modeless dialog; no idea why it works for that dialog but all other modeless calc dialogs have to be in sc to avoid linker problems." One remaining question is whether it is save nowadays in ScCellShell::ExecuteDB (sc/source/ui/view/cellsh2.cxx) to clean up the ScValidationDlg pointed to by pDlg when that VclPtr<ScValidationDlg> variable goes out of scope, instead of doing the PostUserEvent(... DelayDeleteAbstractDialog) dance that was there before because "after end execute from !IsModalInputMode, it is safer to delay deleting." Lets see. Change-Id: I3ecfd4fafc7b37b2f30e75974ece9b0a23311ef4
2016-01-21tdf#34873 : Show autofilter row count in status barDennis Francis
Change-Id: I91aa637d654c1f4d828832f2e43ad21f03036ad0 Reviewed-on: https://gerrit.libreoffice.org/20134 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-21IMHO " : " doesn't need to be localizable, tdf#95878 follow-upEike Rathke
Removing STR_FUNCTIONS_NAMEDESCS from resident strings, what should poor localizers translate it to anyway? Change-Id: I333f3e48332a0796112c28c230be20529e2241c4
2016-01-21sc lok: Implement unit test for .uno:{Insert,Name,Remove} for sheets.Jan Holesovsky
And fix indexing when at that - the inserting is 1-based, so let's be consistent in the .uno:Name and .uno:Remove too. Change-Id: Ib854e81551ae0a39d3ba7c68512e81ea227e9eb1
2016-01-21sc lok: Fix .uno:Remove (removing sheets) to accept a parameter.Jan Holesovsky
.sdi annouces that, but it was never implemented... Change-Id: I7abfbdc88f055eeb993617a5a51371af0f825d34
2016-01-21sc lok: Fix .uno:Name (renaming sheets) to really accept parameters.Jan Holesovsky
The code handles them, but they were unusable, because .sdi did not announce them. Change-Id: I35bd3009d092eb48a36aee2ffed3964dc61946e2
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-21vcl: rename Font::GetFamily to Font::GetFamilyTypeChris Sherlock
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254 Reviewed-on: https://gerrit.libreoffice.org/21633 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-20there's no reason to be sparing with new linesEike Rathke
Change-Id: Id8334694aec17ec61490460b0917514beebd94a3
2016-01-20tdf#97247 Keep focus on merged cell at top-left cornerTakeshi Abe
... when typing either UP or LEFT key. Change-Id: I7bc0e7eb0cba322bcc26c35d0474ea558d3bdd6e Reviewed-on: https://gerrit.libreoffice.org/21599 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-20nitpicks, tdf#96822 follow-upEike Rathke
Change-Id: Ic745433a870c70c09afa953a4ebef86f4363f9f4
2016-01-20tdf#96822 : Make cell contents left align when number formatting is textYogesh Desai
Change-Id: I9754db93f4cf71a6001d5b3f39ee2bc2b01889cc Reviewed-on: https://gerrit.libreoffice.org/21134 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-19sc lokit: the visible row/column must be 0, when loading a documentHenry Castro
Change-Id: Ie980e0bb0726dd8bc4215d5b23ac6e1d2c9e2719 Reviewed-on: https://gerrit.libreoffice.org/21611 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>
2016-01-19follow-up of tdf#89031Winfried Donkers
No function name hints or autocompletion when character right of caret is '$' Change-Id: I4fcfa6e29e5671e97743c7fc520953721d0bda24 Reviewed-on: https://gerrit.libreoffice.org/21577 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-19loplugin:unusedmethods in sc/Noel Grandin
Change-Id: I2c24d06d9fad26c65fa13cdcaa2c3f908971106c
2016-01-19Make virtual ~ScValidationDlg non-inlineStephan Bergmann
...otherwise, GCC 6 would aggressively inline ScValidationDlg destruction of the VclPtr<ScValidationDlg> in ScValidityRefChildWin::ScValidityRefChildWin (sc/source/ui/view/reffact.cxx, in sc library), checking whether the vtable points at ~ScValidationDlg (instead of a derived class dtor) to directly inline the ~ScValidationDlg code, which requires the ScValidateionDlg vtable (to store it in the object's vtable during destruction), which requires the code of inline virtual ScValidationDlg::dispose and ScValidationDlg::Close, which in turn need the addresses of (non-inline) ScValidationDlg::RemoveRefDlg and ScTPValidationValue::RemoveRefDlg, both defined in the scui library and not exported from there. Change-Id: I7eb96f42deb5edd844d91e999aa5511679302c01