summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-08-24loplugin:constparam in sc part4Noel Grandin
Change-Id: I745f50257948a53ca07766955c4f4e86dd2a366e Reviewed-on: https://gerrit.libreoffice.org/41497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24loplugin:constparam in sc part3Noel Grandin
Change-Id: I8abc44b9f0bcd5e39fd8a94abafaf80aadcd26ca Reviewed-on: https://gerrit.libreoffice.org/41496 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24Consistently use OUString in test::DirectoriesStephan Bergmann
Change-Id: Ia5fd8af34ee9d2f37e4450ab241f6bb9a06445b2 Reviewed-on: https://gerrit.libreoffice.org/41466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-23Fix typoAndrea Gelmini
Change-Id: I04ca767a317af6afa8f3ef82fee137c86211e34a Reviewed-on: https://gerrit.libreoffice.org/41479 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-08-23tdf#45904 Move Java _XUniqueCellFormatRangesSupplier test to C++Jens Carl
Change-Id: I66c62f1676515437197d1875600407408040ca74 Reviewed-on: https://gerrit.libreoffice.org/41445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23tdf#45904 Move Java _XAreaLink tests to C++Jens Carl
Change-Id: I95112555de3a5dd5a75c478edb5856cf79919db9 Reviewed-on: https://gerrit.libreoffice.org/40859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23Clean up string constructionStephan Bergmann
Change-Id: I41ca0c7c9ac1892cc87eb4dbba858527aa340c75
2017-08-23ScFiltersTest::testUnicodeFileNameGnumeric only works with UTF-8Stephan Bergmann
Change-Id: If31062abf50125c65a90566f1276f37d6725f73c
2017-08-23Make ScBootstrapFixture::createFileURL generate properly encoded URLsStephan Bergmann
Requires the rsBaseString arg to the ScBootstrapFixture ctor to consitently be passed as a relative path without a leading slash. Change-Id: Ieff38d465b0053fdae42acc4babfb34d1a4827bd
2017-08-23loplugin:constparam in sc part2Noel Grandin
Change-Id: I4fd18096d7d22d8c146a2437906187d5df1cb268 Reviewed-on: https://gerrit.libreoffice.org/41447 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23fix bug in ScTable::LastHiddenColRowNoel Grandin
found by inspection, noticed that the for loop is not actually using it's index variable introduced in commit b3579d71c6536ab1d03cc47249d582a574fd054a koheirowlimitperf: #i109369# #i109373# #i109384# #i109385# #i109386# million, and integrated lots of speed optimization and bug fixes to ensure Calc remains usable after the row limit increase. Change-Id: Icfee19ddb051e8d4333ed4c91d384379bf494444 Reviewed-on: https://gerrit.libreoffice.org/41439 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23convert message box style bits to scoped enumNoel Grandin
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22loplugin:constparam in sc part1Noel Grandin
Change-Id: I82fba7ebb3b4f018721642c96bbfa615c6a382c3 Reviewed-on: https://gerrit.libreoffice.org/41419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22Assert that caller columns are within boundsEike Rathke
Change-Id: Icf93bb5d57c9a4b6988a2ea34fc3ca23130d7eeb
2017-08-22Convert ErrCode area to scoped enumNoel Grandin
Change-Id: Ifa365bbac3c7eb21da9381ec8bb3be6b6785016b Reviewed-on: https://gerrit.libreoffice.org/41402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22convert WB_QUICK_SEARCH/WB_FORCE_MAKEVISIBLE to bool fieldsNoel Grandin
Change-Id: Ic297d97911a6c0356d24ffe4b58442dfe866139f Reviewed-on: https://gerrit.libreoffice.org/41407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22tdf#108706 Unify loading document progress bar labelTakeshi Abe
This also reduces the number of strings to be translated. Change-Id: I032ba12c1e762ee3851658d439dfe2c81c6bd34f Reviewed-on: https://gerrit.libreoffice.org/41329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-08-21WalkAndMatchElements: really really limit the match, tdf#108292 follow-upEike Rathke
getRemainingCount() could deliver a wrapped around overflow value if mnIndex was already greater than the end index, which could happen if when/for non-matching larger block sizes were added, and if then a match was found behind those blocks a non-requested/unexpected index was returned, which in turn led to the assert() being hit in ScInterpreter::CalculateLookup(). In non-debug could result in an invalid block position access. This happened with the bug case document of tdf#111943 which in master can be loaded. Also, the start and end index are not dynamic and don't have to be recalculated each time, so make them const; column argument values are unused after. Change-Id: Ic294cade4e8e7828bee394e5ade61d7127be6bbb
2017-08-20Typo about "document"Julien Nabet
Change-Id: Id12718b5b80b08f18fa9a0370c1991d94b2892ec Reviewed-on: https://gerrit.libreoffice.org/41353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-20tdf#83562: Make the EditTextObject export of automatic colors...Dennis Francis
... use the xml token "use-window-font-color" instead of "color" to encode a boolean value of whether an auto color is used or not. This is because the "auto" color is 0xffffffff and cannot be written into "color" xml field which can store only 3 byte-hexcode. This commit also adds a unit test in subsequent_export-test.cxx to ensure the correct export of automatic color. Change-Id: I42aab926f31669c1423bc09b96b45c410c9732de Reviewed-on: https://gerrit.libreoffice.org/41252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2017-08-20Fix 'make translations' runGabor Kelemen
Recent commits introduced strings in .ui files without context which makes 'make translations' fail with: [build POT] pot.done Traceback (most recent call last): File "/home/gabor/src/core/solenv/bin/uiex", line 30, in <module> keyid = entry.msgctxt + '|' + entry.msgid TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' Affected commits are: e74be9ad773c7769c5d8765bb2ac234967e420ec 213a83ce46edf1b81f2285fd59f1d04935760caa Change-Id: If7afc4bb157a6406cabba141d375e9b0dab5f3de Reviewed-on: https://gerrit.libreoffice.org/41322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-20external data: add a way to get the available data sourcesfor a providerMarkus Mohrhard
Change-Id: I1620537ee004c5acbc85db05dce2b8e3b84bb565 Reviewed-on: https://gerrit.libreoffice.org/41345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-20external data: improve the external data dialogMarkus Mohrhard
Change-Id: I417bc57e2b4be56c4e3f51aa47b447ad48f5684d Reviewed-on: https://gerrit.libreoffice.org/41340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-20external data: add a menu entry to refresh the dataMarkus Mohrhard
Change-Id: I1942488d518be91c3ad03f91d98834e22bfdfb16 Reviewed-on: https://gerrit.libreoffice.org/41339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-20external data: forgot to add the new html provider to the listMarkus Mohrhard
Change-Id: I4982cd9213827493ce41c99ddf4048ddbfd08618 Reviewed-on: https://gerrit.libreoffice.org/41337 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-20get the ScDocument directly from the ScViewDataMarkus Mohrhard
Change-Id: Id4b836bb334a208f83aeffed8ae932f4ce7437ec Reviewed-on: https://gerrit.libreoffice.org/41338 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-18tdf#45904 Move Java _XViewFreezable tests to C++Jens Carl
Change-Id: I75a0363304dbaaeb5988f2ec027d8211f4e01a4f Reviewed-on: https://gerrit.libreoffice.org/40872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-18tdf#109104: respect RFC3986 for newlines in ScEncodeURLJulien Nabet
Quotation of RFC3986: A percent-encoded octet is encoded as a character triplet, consisting of the percent character "%" followed by the two hexadecimal digits representing that octet's numeric value So test the length of the return of OString::number and add "0" if needed ScEncodeURL was added with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=25434372bf56e0ebdb7e7d47ab3c14c68211509f Thank you to Bele (the bugtracker reporter) for code pointer! Change-Id: I8df102eb38b31933c6ebb15bb25c125b423f722b Reviewed-on: https://gerrit.libreoffice.org/41086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-08-18Rename flag to less generic name to prepare adding more flagsUlrich Gemkow
Change-Id: I27663a42890bbae3279847a7da971cd367335cb3 Reviewed-on: https://gerrit.libreoffice.org/40736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-08-18loplugin:unnecessaryparenNoel Grandin
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Fix typosAndrea Gelmini
Change-Id: I795059109e23800987cda6f04c58ab18c488ad07 Reviewed-on: https://gerrit.libreoffice.org/41242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17drop unused SdrCustomShapeAdjustmentItemJochen Nitschke
unused since commit 935baf97a926baa50d985808736e0adb8837c716 Date: Tue May 19 09:32:45 2009 +0000 CWS-TOOLING: integrate CWS impress169 Change-Id: I1e8b0285ae1f6e8d92efd3f5a2463ff3126f1a0d Reviewed-on: https://gerrit.libreoffice.org/41248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Removing unused serialisation codeVarun Dhall
Change-Id: I86911c77f0831d448ff803afae2a74ec55ad4dd8 Reviewed-on: https://gerrit.libreoffice.org/41233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17tdf#86019: Use ChartDataRowSource_COLUMNS as the chart...Dennis Francis
...data row source if there is atleast a sequence along a column. Change-Id: I24838a704d31f83fa51efa2eb44b489affe86f35 Reviewed-on: https://gerrit.libreoffice.org/41202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2017-08-16sc: drop dead codeJochen Nitschke
dead after a series of removals, last one commit 4d89865ef2026f40a9a4d66f3e047b77454e6fee new loplugin:deadclass Change-Id: I43caada8d846b29f08ffe9501f3dfba52b7b4e88 Reviewed-on: https://gerrit.libreoffice.org/41228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16add a test for storing formula cells in the cacheMarkus Mohrhard
Change-Id: I094491c7a9be5384f88c30ed6a3271aa73674ad8 Reviewed-on: https://gerrit.libreoffice.org/41222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16also import formula cells again from the cacheMarkus Mohrhard
Change-Id: I116337f32151db4d897d88879acb0380fcedc161 Reviewed-on: https://gerrit.libreoffice.org/41221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16handle formula cells also in the python scriptMarkus Mohrhard
Change-Id: I8a68cbd68db89c3e30827fa449e18f6c13f4d6e0 Reviewed-on: https://gerrit.libreoffice.org/41220 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-16add formula cells/groups to the cacheMarkus Mohrhard
Change-Id: I04a8055f4df27a080291362ef31ccf559fa709cf Reviewed-on: https://gerrit.libreoffice.org/41219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16external data: apply the transformation still in the fetch threadMarkus Mohrhard
Change-Id: I0509a569f47fcf838ea5c102e6fd0c6e765a0152 Reviewed-on: https://gerrit.libreoffice.org/41208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16add a way to restore from our new cache formatMarkus Mohrhard
Change-Id: I6eeaaf9ca05bed2a908143ae5f4daab6e098799c Reviewed-on: https://gerrit.libreoffice.org/41199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16tdf#39468 Translate German comments/termsJens Carl
Change-Id: I3c8d8ba10de007429b1cdf26f5e8b207f7cc5eea Reviewed-on: https://gerrit.libreoffice.org/41201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16Add note about order or row, column, and tab as fields vs. parametersTor Lillqvist
Change-Id: I45e0f9a95da20c1a3b6bdf2ac1387b3c14e3dad4
2017-08-16remove unused param from CreateScNamePasteDlgNoel Grandin
unused since commit b3dfb1e807eba91eed35a02d74fe8a917c41ee6f "loplugin:checkunusedparams in sc" Change-Id: I53ac9e281a93651259eb39a145acbb89613d3e04 Reviewed-on: https://gerrit.libreoffice.org/41205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16add python script to interpret the calc cache formatMarkus Mohrhard
Change-Id: I5d66024024b8150fad67397a0debc40aab1ae5fc Reviewed-on: https://gerrit.libreoffice.org/41200 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>