summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-11-20tdf#95880 Add a lock mark on protected sheet tab.Gulsah Kose
Change-Id: Ic9ec598d9bfdf98336cc4a11af21502ca7a1e4fb Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/44558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-20ofz#4321 Direct-leakCaolán McNamara
Change-Id: I0ce2da99f34082e4e090753e3a4aa8fcc4420a5d Reviewed-on: https://gerrit.libreoffice.org/44955 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-20tdf#89216 forward empty cells as empty to BASIC instead of 0.0Matti Lehtonen
This change causes that either empty or unknown cells are forwarded to macros as empty, not as zero (double). Change-Id: Ia73bcb2ab48e08f97b46cdb45ae4dc3d21bbffd5 Reviewed-on: https://gerrit.libreoffice.org/43226 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-20ofz#4306 Null-dereference READCaolán McNamara
Change-Id: Iccbaed9ab6252ac8c61104ac0e6a9b8972913f6c Reviewed-on: https://gerrit.libreoffice.org/44954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20ofz#4328 AbrtCaolán McNamara
Change-Id: Ia122ca02b96682e436315b89c1510230c2ec5150 Reviewed-on: https://gerrit.libreoffice.org/44950 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20cosmetics: Drop duplicate semicolonTakeshi Abe
Change-Id: I96d2ffb903f9ed15070572552c9564b5089df12f Reviewed-on: https://gerrit.libreoffice.org/44914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-20ofz#4334 Null-dereference READCaolán McNamara
Change-Id: I64cf71566248d81713f251d95d435d51701d3188 Reviewed-on: https://gerrit.libreoffice.org/44949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for SDRATTR* constants (1)Noel Grandin
Change-Id: I29bd18fea4dea531ae84ebc024d2aa87a5c7004d Reviewed-on: https://gerrit.libreoffice.org/44943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20Fix typosAndrea Gelmini
Change-Id: Ib138f971c4efcc67c68c901c9f08b4d1d95cdde2 Reviewed-on: https://gerrit.libreoffice.org/44933 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-20TypedWhichId for XATTR* constantsNoel Grandin
Change-Id: Ie9d637d701b77a549de3b00956f9c74ee8bd08c1 Reviewed-on: https://gerrit.libreoffice.org/44830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-19Fix typosAndrea Gelmini
Change-Id: I964528cf4f3b81230c683011e1878b28378b0014 Reviewed-on: https://gerrit.libreoffice.org/44915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-19Typos about "bottom"Julien Nabet
Change-Id: I8fec1f12d5f8330cd54da3e219268bf4e0b4c213 Reviewed-on: https://gerrit.libreoffice.org/44932 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-19tdf#113536 Better wording for CSV separatorheiko tietze
Change-Id: I4bdd275f2343341e64a4a5dba4e5271888ca1799 Reviewed-on: https://gerrit.libreoffice.org/44901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-11-19Replace list by vector in accessible part of scJulien Nabet
+ remove useless typedef following https://cgit.freedesktop.org/libreoffice/core/commit/?id=65e578640f0258768a9253389356dbc63c845b7e + use for range loops Change-Id: I9b69acf4c0b783ee8db34791b1044cbebb68da9f Reviewed-on: https://gerrit.libreoffice.org/44919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-19tdf#50746 Make "paste unformatted text" work for CalcSerge Krot
The same command with the same Ctrl+Shift+Alt+V hot-key was already added inside Writer. So now Calc has it too. Change-Id: I2b2d1b02e33288bc058c773431f029fb1d33d3be Reviewed-on: https://gerrit.libreoffice.org/44886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-18ofz#4306 init draw layerCaolán McNamara
Change-Id: I2a8bfa72e7e83ec86301cbfb952235e6b984b363 Reviewed-on: https://gerrit.libreoffice.org/44906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-18Updated liborcus to 0.13.1.Kohei Yoshida
Change-Id: Id5aa07f87603879fe7a21dc96cad207f1b168286 Reviewed-on: https://gerrit.libreoffice.org/44850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-11-18tdf#113861: Less aggressive expansion of chart headers.Vasily Melenchuk
For sheets with low data density (many empty cells) created charts with checked "First row as label" or "First column as label" can get too much extra rows/columns from data range (if they contain no data). New approach is to treat empty cells as belonging to data, not to headers. Change-Id: Ib5fd47636b80e0b8807f75d9eb582eed0ef68627 Reviewed-on: https://gerrit.libreoffice.org/44755 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-18tdf#45904 Move _XSpreadsheetView Java tests to C++Jens Carl
Change-Id: I1e5346e2f014b412a2f8be08553c8eeff37920f9 Reviewed-on: https://gerrit.libreoffice.org/44840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-17ScVbaRange::Find - allow empty string as What to search forJustin Luth
Excel's find macro is able to search for an empty string and find an empty cell, without giving a script error. LibreOffice was raising a "missing params" error if it was passed an empty string to search for, causing execution failure, a misleading error code, and failing to find an empty cell. Also fixed the other copy/paste error codes to indicate that this is the find function, not the replace function. Also added a sanity control line to the VBA test. First select cell A1 - instead of assuming that no one has touched the file. Change-Id: Iabbac7333c37886a667ab5670af819b1cd53c086 Reviewed-on: https://gerrit.libreoffice.org/44618 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-17tdf#113894 release ctrl of ctrl+v in input line should strip formattingCaolán McNamara
Change-Id: I1cd1501d6f20765d7e5a90a9ccb07745758682d4 Reviewed-on: https://gerrit.libreoffice.org/44880 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-17coverity#1422192 include param field in string fieldEike Rathke
Change-Id: Ia2ef910fd9b4b74c8cf227717fde93c562bbb1b6
2017-11-17TypedWhichId for EE_CHAR* constantsNoel Grandin
Change-Id: I261f8a949ddd858dee196118bb42993a101a2a28 Reviewed-on: https://gerrit.libreoffice.org/44829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17TypedWhichId for EE_PARA* constantsNoel Grandin
Change-Id: I64d1765336f39c3e3ded4d58ebdee80e97624276 Reviewed-on: https://gerrit.libreoffice.org/44799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16ofz#4243 TimeoutCaolán McNamara
Change-Id: Ib1d06c966d10cef2016522a63272bf5c1670977f Reviewed-on: https://gerrit.libreoffice.org/44808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16ofz#4243 TimeoutCaolán McNamara
Change-Id: I00767cfd99634f0ccd22e63cf0d635a2f75bc224 Reviewed-on: https://gerrit.libreoffice.org/44806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16Straighten use of MAXSTRLEN to be maximum string lengthEike Rathke
... plus limiting 0-character, and not buffer length in (only) some cases where max len then was MAXSTRLEN-1, accompanied by a mix of >= and > comparisons. Change-Id: I5b8452db52b1d464eb1410e31990043f7997af20
2017-11-16related ofz#4243 TimeoutCaolán McNamara
Change-Id: I6734c1df06ce1b2cd0fcca488bc5d2fe333ad55b
2017-11-16coverity#1421095 Useless callCaolán McNamara
and coverity#1421110 Useless call coverity#1421127 Useless call coverity#1421082 Useless call just returns aDocument member, so this isn't testing anything Change-Id: I556d84c89128bbc652b0cc417e60a1a77ad0dfc9 Reviewed-on: https://gerrit.libreoffice.org/44775 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16use implict conversion operator in TypedWhichIdNoel Grandin
instead of spreading calls to Which() everywhere. Change-Id: Ie32d106e44f5cb583908eeebe254ab8b8168ae61 Reviewed-on: https://gerrit.libreoffice.org/44760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16ofz: special case max index for cSymbolCaolán McNamara
Change-Id: Ia5fb036196b0cff0739789e691a36d294660540b Reviewed-on: https://gerrit.libreoffice.org/44759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-15tdf#45904 Move _XScenariosSupplier Java test to C++Jens Carl
Change-Id: I152f6358e505d7a480e157bd49613e0bb496e163 Reviewed-on: https://gerrit.libreoffice.org/44748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-15tdf#108144: tabbed notebookbar add margins to seperatorsandreas kainz
Change-Id: I374873eed5e89c0788869150187219078d22f986 Reviewed-on: https://gerrit.libreoffice.org/44757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-11-15tdf#45904 Move _XSheetAnnotationsSupplier Java test to C++Jens Carl
Change-Id: I18143d96f49ea4f4b80ae89df33d2963bb20e125 Reviewed-on: https://gerrit.libreoffice.org/44747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-15TypedWhichIdNoel Grandin
use a strong-typedef template to give which IDs a type, which we can carry around to do a (a) little bit more convenience when Get()'ing them and (b) a little bit of enforcement of which PoolItem subclass each ID uses Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass in AccessibleEditableTextPara::_correctValues Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b Reviewed-on: https://gerrit.libreoffice.org/44587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15Fix typosAndrea Gelmini
Change-Id: I8bdced3fa572074aedabdcfce841adf525ae8b81 Reviewed-on: https://gerrit.libreoffice.org/44710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-14Translate German comments and debug stringsJohnny_M
Change-Id: I12c92ecc270e65cb99e38e9179cf354a8c0708aa Reviewed-on: https://gerrit.libreoffice.org/44633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-14Distinguish single/multiple cell copy for plain text, tdf#113571 follow-upEike Rathke
A single cell may contain embedded line breaks and tabs, copy/pasting multiple cells may not. Change-Id: Iae58f5c6b5330b327acfb50a37e9d210e72de7c7
2017-11-14Changed encoding from cp1252 to UTF-8Andrea Gelmini
In [54]: open("sc/qa/unit/pivottable_filters_test.cxx",'r').readlines() --------------------------------------------------------------------------- UnicodeDecodeError Traceback (most recent call last) <ipython-input-54-39091a82db4d> in <module>() ----> 1 open("sc/qa/unit/pivottable_filters_test.cxx",'r').readlines() /usr/lib/python3.6/codecs.py in decode(self, input, final) 319 # decode input (taking the buffer into account) 320 data = self.buffer + input --> 321 (result, consumed) = self._buffer_decode(data, self.errors, final) 322 # keep undecoded input until the next call 323 self.buffer = data[consumed:] UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 1648: invalid continuation byte In [55]: open("sc/qa/unit/pivottable_filters_test.cxx",'r',encoding="cp1252").readlines() Out[55]: ['/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */\n', '/*\n', ... Change-Id: Iad48bdf3502fcb6340e358249781a39d50f80c85 Reviewed-on: https://gerrit.libreoffice.org/44708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-13ofz#4202 Null-dereference READCaolán McNamara
Change-Id: Ib9beadaea1bc6521faf7d8080d301e4b5451fb1d Reviewed-on: https://gerrit.libreoffice.org/44685 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-13tdf#45904 Move _XLabelRange Java tests to C++Jens Carl
Change-Id: I707631718c30d4503ae675f3679038705371f969 Reviewed-on: https://gerrit.libreoffice.org/44672 Reviewed-by: Jens Carl <j.carl43@gmx.de> Tested-by: Jens Carl <j.carl43@gmx.de>
2017-11-13Resolves: tdf#113571 paste-special "Unformatted text [TSV-Calc]", tdf#32213Eike Rathke
For intra-Calc on-cell pastes using the paste special toolbar button the SotClipboardFormatId::STRING_TSVC format can be used, which preserves embedded line breaks and tabs by enclosing such content in double quotes and escaping quotes by doubling them, similar to CSV. This differs from the IANA text/tab-separated-values MIME type (see https://www.iana.org/assignments/media-types/text/tab-separated-values) that does not allow quoted fields or embedded line breaks or tabs. The text/plain "Unformatted text" format now again (after the change with commit cdcd262ea4aa3c3e407b14ed533e514f75de2d3a for tdf#32213) results in unquoted/unescaped content as expected for external pastes. A follow-up commit probably should distinguish whether the source is one single cell or multiple cells and for multiple cells use a strict TSV (with embedded line breaks and tabs changed to spaces) if a simple "Unformatted text" is requested, which always uses tabs as field separators anyway. Further enhancement could be to offer strict text/tab-separated-values and also text/csv at the clipboard if there are applications that actually handle these MIME types. Change-Id: Ica60f256e26867d854639823c62eedbf13eb4d4b Reviewed-on: https://gerrit.libreoffice.org/44686 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-13Translate German variable and function names in Calc (financial)Johnny_M
This follows up on https://gerrit.libreoffice.org/44295 Change-Id: Iac8351161a5e0d79a61fbb06d96985f92db68e3c Reviewed-on: https://gerrit.libreoffice.org/44626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-13tdf#113768 Fix opposite argument description for Calc function VDB.Winfried Donkers
Also, use self-explaining variable name for argument NoSwitch. Added use of argument NoSwitch to unit test document. Change-Id: I801d4dbd489898b28543e0eb46f74717671ea03a Reviewed-on: https://gerrit.libreoffice.org/44647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-13ofz+valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara
if, before lcl_UnicodeStrNCpy is called, aSymbol contains embedded nulls then the aSymbol.getLength() and the mnRangeOpPosInSymbol value derived from an earlier aSymbol.getLength() include the range after the embedded null, while lcl_UnicodeStrNCpy stops at the first embedded null leaving cSymbol with uninitialized value that are later read from it. Conditional jump or move depends on uninitialised value(s) at 0x23BFBCA0: ScCompiler::IsReference(rtl::OUString const&, rtl::OUString const*) (compiler.cxx:3275) by 0x23BFFF4C: ScCompiler::NextNewToken(bool) (compiler.cxx:4248) by 0x23C00D20: ScCompiler::CompileString(rtl::OUString const&) (compiler.cxx:4419) by 0x23A29FAF: ScFormulaCell::Compile(rtl::OUString const&, bool, formula::FormulaGrammar::Grammar) (formulacell.cxx:1118) by 0x23A278B7: ScFormulaCell::ScFormulaCell(ScDocument*, ScAddress const&, rtl::OUString const&, formula::FormulaGrammar::Grammar, ScMatrixMode) (formulacell.cxx:656) by 0x23772EC3: ScColumn::ParseString(ScCellValue&, int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam const*) (column3.cxx:1729) by 0x2377354B: ScColumn::SetString(int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam*) (column3.cxx:1851) by 0x23AE2B97: ScTable::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (table2.cxx:1369) by 0x23897045: ScDocument::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (document.cxx:3377) by 0x1F35F41C: ScEEImport::WriteToDocument(bool, double, SvNumberFormatter*, bool) (eeimpars.cxx:400) by 0x1F366F3B: ScFormatFilterPluginImpl::ScImportRTF(SvStream&, rtl::OUString const&, ScDocument*, ScRange&) (rtfimp.cxx:34) Change-Id: Iefc6be6c3a383bd9b3cdeaa896c07e24e5100dc7 Reviewed-on: https://gerrit.libreoffice.org/44658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-13Move pivot table tests to a separate test suitTamás Zolnai
Change-Id: Ic0797a988b7135927a53ca9f16c8bc30d24feef5 Reviewed-on: https://gerrit.libreoffice.org/44673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-13tdf#45904 Move _XLabelRanges Java test to C++Jens Carl
Change-Id: I32d07ba85f4a37a10eaf03d251d41b9e71d34c93 Reviewed-on: https://gerrit.libreoffice.org/44660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-13Fix typosAndrea Gelmini
Change-Id: I2a10e087a776ac96b3193226610577227d2492a8 Reviewed-on: https://gerrit.libreoffice.org/44655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-13Fix typosAndrea Gelmini
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
generated by cgit (git 2.34.1) at 2025-01-01 07:52:08 +0000