summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2022-09-18Simplify by using replaceAll instead of insert in some loops (sc)Julien Nabet
Change-Id: I1defbbcd391230b928d57ebd049c514781bf720a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140107 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-18crashtesting: "unknown cell text: element" assert for text:bookmarkJustin Luth
since... commit 690a35680adad07c4ab79d82cd1531bb82fe4bc1 Date: Sat Sep 10 16:32:46 2022 -0400 tdf#103829 ods import: parse <text:tab/> Change-Id: Ia157c3503b119f2fa8daf31870894344e0313204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-18use more string_view in utl::TempFileNoel Grandin
Change-Id: I151c66479053b9b5b7699a4938a622b4320aeaa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-18crashtesting: "unknown cell text: element" assertCaolán McNamara
on e.g. import of fdo74225-2.ods since... commit 690a35680adad07c4ab79d82cd1531bb82fe4bc1 Date: Sat Sep 10 16:32:46 2022 -0400 tdf#103829 ods import: parse <text:tab/> Change-Id: I3eaffda8d9815564d314edf613832173313e46a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140110 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-17speed up large sheet with lots of conditionsNoel Grandin
shaves 10% off view load time Change-Id: Iecb1274e35da2294f796376ebdc62eab509e5480 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140071 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-17speed up large sheet with lots of conditionsNoel Grandin
shaves 10% off view load time Change-Id: I51078ef81613faa2f8c37530fb7dc77b73192525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-16cid#1513720 silence Improper use of negative valueCaolán McNamara
negative col doesn't seem to arise in this branch, seems it can only negative for the other direction and/or for styles which isn't handled in this method. Change-Id: I3a50ebef57a84e808a03fc677030acfd7605230d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-16Simplify by using replaceAll instead of replaceAt in a loop (sc/global2)Julien Nabet
Change-Id: I26a51eb3b4d5e6a0d8903c348bd0e6084521f117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140039 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-16vcl: AnimationBitmap -> AnimationFrameChris Sherlock
The emphasis is not quite right. An animation is made up a sequence of *frames*, not bitmaps. A frame includes such things as position, size, timeout till the next frame *as well as* a bitmap. Note: had to regenerate a bunch of precompiled headers Change-Id: Ib1959452653857555f41e01ac0151d08c41a3b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76460 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-16tdf#103829 ods export: don't output invalid office:string-valueJustin Luth
If the formatted (i.e. \t) string was different from the raw string (i.e. \x001 EE_FEATURE_TAB marker), then export was outputing office:string-value with IsInvalidChar \x001. The impact on import is that the cell wants to display this string-value, which is missing all of the "invalid char" stuff. So, just don't export a wrong string at all. Change-Id: Ib98e58d0c6e1186d199a4dcf294b56403b710f48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139816 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-15Resolves: tdf#132519 Use string reference syntax for CELL("ADDRESS";...)Eike Rathke
... so the result can be used with INDIRECT(). Change-Id: I76e4d7739e22c53a3cfa3e004a9b24dc3dfcd233 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140021 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-15cid#1500581 silence Explicit null dereferencedCaolán McNamara
presumably this must hold Change-Id: I2c218c6a63d5213f5abc1b671fa9f035bc69ed7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139996 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-15tdf#103829 ods export: output <text:tab/> when CELLTYPE_EDITJustin Luth
regression since LO 4.2 Change-Id: Ic9b6c00af9f1cccdb58ac3eede59268d1c83c767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139761 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-15CppunitTest_sc_vba_macro_test: unify the way tests are setup and teardownXisco Fauli
Some tests were using mxComponent and some other tests where using their own xComponent Hopefully this will fix the CppunitTest_sc_vba_macro_test failures on windows Change-Id: I75fa51edf273582057201f50847b2c1a3ed1fcc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139948 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-15CppunitTest_sc_macros_test: simplify code a bitXisco Fauli
Change-Id: Ie0b685dbcbc3504de10372b9c0127781171f8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139946 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-14Related: tdf#149665 Unify input of a leading ' apostrophe in non-Text cellEike Rathke
If a cell is not formatted as Text and ScSetStringParam::mbHandleApostrophe is true, all input (except one single apostrophe that otherwise would lead to an empty cell string) now is treated the same and the leading apostrophe is removed and the remainder is set as text content. The Input Line and editing a cell get an apostrophe prepended for the cases needed to generate such escaped string again. This made it necessary to adapt a unit test that exactly checked the old behaviour. Change-Id: I07b35d33f3704970784dc6de1322bda28903bb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139934 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-14libxml2: upgrade to release 2.10.2Michael Stahl
Fixes CVE-2022-2309 Change-Id: I180218be275d3b6d38f8f74aa51c57e50d2734ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139911 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-09-14try wait_until_property_is_updated in test_tdf134390Caolán McNamara
====================================================================== FAIL: test_tdf134390 (navigator.navigator) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/qa/uitest/calc_tests8/navigator.py", line 143, in test_tdf134390 self.assertEqual(get_state_as_dict(xColumn)['Value'], '2') AssertionError: '1' != '2' - 1 + 2 Change-Id: I7c781191facd10abbb25f895cb0d2bacb72d92ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-14fix off-by-one in Calc shadow handling (tdf#150931)Luboš Luňák
A mistake from d48e68407931fc33044aa7f3fc9e971897fac610, the number is off as can be seen when compared to the bRightDiff part above. Change-Id: Id87d69c45cd3336ab8a122a2cae505a16848cdf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139902 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-14Resolves: tdf#150926 Add-In result svl::SharedString needs to be internedEike Rathke
Change-Id: If582e7e1bf818dcf9eaddd5313aa21f5768a578f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139886 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-14move ErrCode to comphelper and improve debug output stringNoel Grandin
need to move it, because modules "below" vcl want to use the debug output method Change-Id: Ibcaf4089a1e0b3fcc0b5189c7ebf1aae90f50b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-14tdf#149551 use 'WritingMode' instead of TextPreRotateAngleRegina Henschel
Commit 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0 changed the code so, that TextPreRotateAngle is used to track ooxml vert attribute. This patch changes it so, that the style attribute WritingMode is used. Now text direction can be written in 'writing-mode' attribute in the graphic properties in ODF, same for shapes as for frames. The needed conversion from WritingMode BT-LR and TB_LR90 to TextPreRotateAngle for rendering of text in custom shapes is now in one place in class SdrObjectCustomshape. The shape edit engine cannot yet render it itself. Some unit tests are adapted to use WritingMode property instead of TextPreRotateAngle. The value text::WritingMode2::TB_RL90 is introduced, corresponding to vert='vert' and textDirection='tbRl' or ='rl' in OOXML. It is used for frames too, so that the original text direction is preserved and vert='eaVert' can be distinguished from vert='vert'. TextPreRotateAngle is currently still used in SmartArt import for 'upr' and 'grav' and in emulating 'upright' but no longer to emulate text direction. Change-Id: Idc4339bbfc3592fe90b154d75e2c404a1fa30856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138813 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-13tdf#150766: sc_uicalc: Add unittestXisco Fauli
Change-Id: I4acff046167f05a576eb7320edc3c85d759f6776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139790 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-13clean up opencl helper functionsLuboš Luňák
It seems a bit wasteful to use std::string for const strings. Change-Id: I31bb38f5cdcd0210f6f91144b3c37abae9301333 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139487 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-13reduce opencl copy&paste in op_math.cxxLuboš Luňák
Change-Id: Ibe2afa6ca3720a6cec8b74af5c582cb946cf5396 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139486 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-13reduce opencl copy&paste in op_addin.cxx and op_logical.cxxLuboš Luňák
The svDoubleVectorRef stuff in OpAnd etc. didn't make sense, those operators are required to do implicit intersection (which can be done in sc core in ScCompiler::HandleIIOpCodeInternal()). Change-Id: Ic970c8e649a651f6a804b5ed265fe2e08ff29681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139485 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-13reduce opencl copy&paste when generating function declarationLuboš Luňák
Change-Id: Ibe3677ed56423aeb0d19b510664bc402fc53366d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139484 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-13tdf#103829 ods import: parse <text:tab/>Justin Luth
regression since LO 4.1 Change-Id: I65e847a45b8b233c558bf7bc90b554ba8b4b7763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139757 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-12tdf#150288: sc: Add UItestXisco Fauli
Change-Id: I3a71d37b4d0eed72f6f5fa291c9d460caadf373a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139595 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-12tdf#131073 - Don't show hidden rows/cols after setting optimal row/col heightAndreas Heinisch
Change-Id: I1dbe92cfc577e3425787b942415182889cda6a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139327 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-09-11Simplify by using replaceAll instead of insert in a loop (sc)Julien Nabet
Change-Id: Ibf41f78521a390cc73e10adaf1b85cd499abc2ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139769 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-11ScValueIterator ScDocument& parameter is now superfluousEike Rathke
Since commit 3be1cdce9d92cbadca1b276b3193c727032ea717 ScInterpreterContext is passed that has it. Just a minor change for a const ScDocument&. Change-Id: I388ff55393056c52f85d7543fcfb6c549fc2a346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139759 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-11Simplify by using replaceAll instead of replaceAt (sc)Julien Nabet
It also shows more clearly the intention. Since replaceAt with "0" as second arg isn't a replace per se since it doesn't remove the first arg string. + get rid of lcl_DoubleEscapeChar which was used only once Change-Id: I08c38c6cfd016a6265725134cb87e518b51ab361 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139755 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-10Resolves: tdf#150766 Listen to entire shared formula group instead of a sliceEike Rathke
Change-Id: I677602bd3401dbd401e35f7db64cd34d164d9d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139744 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-10unique_ptr->optional for GraphicNoel Grandin
Graphic is just a wrapper around shared_ptr, so no need to allocate this separately Change-Id: Ie657dea1c021e66a6876e814090a44cb6f995b91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-10Use stable_sort to sort hidden rows in sortAndRemoveDuplicatesStephan Bergmann
With a randomizing debug-mode libc++, UITest_autofilter2 failed for me with > FAIL: test_tdf117276_autofilter (tdf117276.tdf117276) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "sc/qa/uitest/autofilter2/tdf117276.py", line 78, in test_tdf117276_autofilter > self.assertFalse(is_row_hidden(calc_doc, 21)) > AssertionError: True is not false when _LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY_SEED is e.g. 0. Change-Id: I3e77731e2f3a2283fcf70293fab39369f316d301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139742 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-09GetCurNumFmtInfo is always called with the same context as given in ctorCaolán McNamara
Change-Id: Ic3aefaa5ddd26b5cb44bfc299f7ae7188f205d17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09always pass ScInterpreterContext to ScValueIteratorCaolán McNamara
its available at every call site Change-Id: I764962d1d2330c414e02ed215b4a0c5be2979145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139637 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09crashtesting: threaded assert on loading forum-de3-3100.odsCaolán McNamara
use SetInterpreterContext like I see in similar places to avoid the need to call ScDocument::GetFormatTable #9 0x00007fd35b1af283 in ScDocument::GetFormatTable() const (this=this@entry=0x5573153bf1d0) at sc/source/core/data/documen2.cxx:463 __PRETTY_FUNCTION__ = "SvNumberFormatter* ScDocument::GetFormatTable() const" #10 0x00007fd35b196f57 in ScAttrArray_IterGetNumberFormat(sal_uInt32&, ScAttrArray const*&, SCROW&, ScAttrArray const*, SCROW, ScDocument const&, ScInterpreterContext const*) (nFormat=@0x7fd354458b38: 0, rpArr=@0x7fd354458b30: 0x0, nAttrEndRow=@0x7fd354458b54: 0, pNewArr=0x557315063910, nRow=nRow@entry=30, rDoc=..., pContext=0x0) at sc/source/core/data/dociter.cxx:80 nRowStart = 30 nRowEnd = 30 pPattern = 0x557316c093f0 #11 0x00007fd35b19e5b7 in ScValueIterator::GetThis(double&, FormulaError&) (this=this@entry=0x7fd354458b20, rValue=@0x7fd354458b00: 0, rErr=@0x7fd354458af8: FormulaError::NONE) at sc/source/core/data/dociter.cxx:196 bNextColumn = <optimized out> pCol = 0x557316aca050 nCurRow = 30 nLastRow = 32723 #12 0x00007fd35b19e8c4 in ScValueIterator::GetNext(double&, FormulaError&) (this=<optimized out>, this@entry=0x7fd354458b20, rValue=@0x7fd354458b00: 0, rErr=@0x7fd354458af8: FormulaError::NONE) at sc/source/core/data/dociter.cxx:297 #13 0x00007fd35b6a5307 in ScInterpreter::GetNumberSequenceArray(unsigned char, std::__debug::vector<double, std::allocator<double> >&, bool) (this=this@entry=0x5573169d9900, nParamCount=nParamCount@entry=1 '\001', rArray=std::__debug::vector of length 2, capacity 200 = {...}, bConvertTextInArray=bConvertTextInArray@entry=false) at sc/source/core/tool/interpr3.cxx:3986 nCellCount = <optimized out> nErr = FormulaError::NONE fCellVal = 0 aValIter = {mrDoc = @0x5573153bf1d0, pContext = 0x0, pAttrArray = 0x0, nNumFormat = 0, nNumFmtIndex = 0, maStartPos = {nRow = 0, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}, maEndPos = {nRow = 199, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}, mnCol = 0, mnTab = 4, nAttrEndRow = 0, mnSubTotalFlags = SubtotalFlags::NONE, nNumFmtType = SvNumFormatType::UNDEFINED, bNumValid = false, bCalcAsShown = true, bTextAsZero = false, mpCells = 0x557316aca280, maCurPos = {first = {<mdds::mtv::soa::detail::iterator_updater<mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreTrait>::const_iterator_trait>> = {m_cur_node = {type = 10, position = 30, size = 1, data = 0x557316d734d0, __private_data = {parent = 0x557316aca280, block_index = 1}}, m_pos = {position_iterator = 30, size_iterator = 1, element_block_iterator = 0x557316d734d0}, m_end = {position_iterator = 7378697629483820646, size_iterator = 7378697629483820646, element_block_iterator = 0x6666666666666666}}, <No data fields>}, second = 0}} eStackType = <optimized out> aAdr = {nRow = 0, nCol = 0, nTab = 0, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}} aRange = {aStart = {nRow = 0, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}, aEnd = {nRow = 199, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}} bIgnoreErrVal = false nParam = 0 nRefInList = 0 #14 0x00007fd35b6aa9ed in ScInterpreter::CalculateSmallLarge(bool) (this=this@entry=0x5573169d9900, bSmall=bSmall@entry=true) at sc/source/core/tool/interpr3.cxx:3657 nCol = 1 nRow = 1 aArray = std::__debug::vector of length 1, capacity 1 = {1} nRankArraySize = 1 __PRETTY_FUNCTION__ = "void ScInterpreter::CalculateSmallLarge(bool)" aRankArray = std::__debug::vector of length 1, capacity 1 = {1} aSortArray = std::__debug::vector of length 2, capacity 200 = {1, 21} nSize = <optimized out> #15 0x00007fd35b6abac8 in ScInterpreter::ScSmall() (this=this@entry=0x5573169d9900) at sc/source/core/tool/interpr3.cxx:3717 #16 0x00007fd35b6cd929 in ScInterpreter::Interpret() (this=this@entry=0x5573169d9900) at sc/source/core/tool/interpr4.cxx:4373 bGotResult = <optimized out> nRetTypeExpr = SvNumFormatType::NUMBER nRetIndexExpr = 0 nErrorFunction = 0 nErrorFunctionCount = 0 aErrorFunctionStack = std::__debug::vector of length 0, capacity 0 nStackBase = 0 aTokenMatrixMapIter = Python Exception <class 'AttributeError'> 'NoneType' object has no attribute 'pointer': {_M_node = 0x5573169d99c8} eOp = ocSmall __PRETTY_FUNCTION__ = "formula::StackVar ScInterpreter::Interpret()" bForcedResultType = <optimized out> p = <optimized out> eType = <optimized out> #17 0x00007fd35b3c6ed1 in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) (this=0x55731309d8f0, rContext=..., eTailParam=eTailParam@entry=ScFormulaCell::SCITP_NORMAL) at sc/source/core/data/formulacell.cxx:1945 pScopedInterpreter = std::unique_ptr<class ScInterpreter> = {get() = 0x0} pInterpreter = 0x5573169d9900 nOldErrCode = FormulaError::NONE bContentChanged = <optimized out> aNewResult = {static MULTILINE_UNKNOWN = 0 '\000', static MULTILINE_FALSE = 1 '\001', static MULTILINE_TRUE = 2 '\002', {mfValue = 6.9438766800236802e-310, mpToken = 0x7fd3544591e8}, mbToken = false, mbEmpty = false, mbEmptyDisplayedAsString = false, mbValueCached = true, meMultiline = 3 '\003', mnError = 28442} bOldRunning = false bForceNumberFormat = <optimized out> aRecursionCounter = {rRec = @0x557316da2b40, bStackedInIteration = false, cell = 0x55731309d8f0} #18 0x00007fd35b0c84cb in ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned long, unsigned long, unsigned int, unsigned int) (this=<optimized out>, rContext=..., nRow=nRow@entry=0, nLen=nLen@entry=30, nOffset=nOffset@entry=0, nThisThread=nThisThread@entry=0, nThreadsTotal=48) at sc/source/core/data/column2.cxx:3218 Change-Id: Ifeddbfda8afe47c3754ed1fcab836dfd2c8f38ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09Related: tdf#150312 Assert a defined name's non-empty table:base-cell-addressEike Rathke
Change-Id: Iaf377ae51c20e30e0362f5dc6f66172c544483d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139728 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-09Related: tdf#150312 "Repair" broken table:base-cell-address of defined namesEike Rathke
... to not lose them entirely, though this may shift relative addressing, which may be equally bad because there is no indication and can go unnoticed. Most defined ranges use absolute addressing though and formula expressions are rarely affected. Change-Id: If57ff9274e673a4eb43c656698f6ed43e8415458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139706 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-09tdf#150312 unit testEike Rathke
Change-Id: I140d94b4022dafe4f54b45d3d335c881d967ea56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139725 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-09Resolves: tdf#150312 Move base-cell-address to a valid sheet upon deletionEike Rathke
... and adjust references accordingly. For ScTokenArray::AdjustReferenceOnDeletedTab() that now also moves the base of the first deleted sheet not only after, which was a one-off before. Change-Id: I4c19e8b8a7318ba03b6a7d0b2dfaae5d05a51a29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139720 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-08Fix location of ScDocShell in commentJulien Nabet
Change-Id: I316d967427b6b86d3a2dbea46f535405f2966a1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139705 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-08Fix CppunitTest_sc_subsequent_filters_test2 on non-default DPIMike Kaganski
Change-Id: I940c3213dda02a73924a9f8dc6500d7ecc38ba6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139674 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Fix CppunitTest_sc_jumbosheets_test on non-default DPIMike Kaganski
Change-Id: I067622274cfa7518462ad74015dc3942f35b6b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139675 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-07crashtesting: prevent nullptr accessEike Rathke
There's a xlsx export crash on *2nd* export with data pilot data of forum-en-38962.ods. We export without crash this .ods to xlsx *once*, but on saving again to xlsx it crashes. It also crashes with an export to .xls and then an export to .xlsx. Repeated exports to xls are crash free. Already on the first export there are loads of warning messages of ScDPMember::GetItemData: what data? nDim 0, mnDataId # ScNameToIndexAccess getByIndex failed com.sun.star.container.NoSuchElementException message: "at sc/source/core/data/dptabsrc.cxx:2267 The pivot tables are broken on both exports. This smells like some sort of data pilot cache corruption/insufficiency during .xlsx export but the root cause is yet unknown. This only fixes the crash symptom. Change-Id: Ie479f7f0abc4af284e61f6aa5a69943ccdd72eab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139611 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-07cid#1509288 rearrange to make clearer what actually happensCaolán McNamara
similar to commit ce36d36233053cea8b5db7f39f2693726a43940a Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Sep 6 14:25:09 2022 +0100 cid#1500385 rearrange to make clearer what actually happens Change-Id: I559dab7b8570662644f6b4dac392c307bdef9a84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07tdf#150307, tdf#150829: sc: Add UItestXisco Fauli
Change-Id: If4a7e9fc6e4d9057f880f6b8c1dba7598597031e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139583 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-07apply ui-rulesCaolán McNamara
Change-Id: I5acc6cfe5488f8aa92ecaafa0ebdc50f2ad9758e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-03-12 18:16:57 +0000