summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2022-03-30handle xlsx with too large sheets the same way as e.g. odsLuboš Luňák
The generic approach sets an error code on import and then SfxBaseModel::handleLoadError() takes care of it. This also allows checking for the warning in unittests. A drawback is that this generic approach can handle only one error code, so if a sheets has too many rows and column, there will be only one warning, but I consider that to be minor. Change-Id: I1d5f7f9162ef63c3c2e8414823d18a1ff50ad71e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131970 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-30allocate columns for initDataRows()Luboš Luňák
Triggered by TestSort::testSortImages() with INITIALCOLCOUNT set to 1. Change-Id: Ifd3e63de6411e0a4d8776ed6cc8a7b6c7c64eec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132283 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-30use ScTable::ColumnData() in ScDocument::ExtendOverlapped()Luboš Luňák
Otherwise there's invalid array access triggered by VBAMacroTest::testVba() with INITIALCOLCOUNT set to 1. Change-Id: Iaff333788d2d29444139c99b0f6e82b69a5a2d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132282 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-29tdf#125800: sc_macros: Add unittestXisco Fauli
Change-Id: I9286264bbfa1e59e51d2a94417f7e8526357f821 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132277 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-29allocate columns in ScTable::Compare()Luboš Luňák
This gets triggered by ScCellRangeObj::testSortOOB() if INITIALCOLCOUNT is set to 1. Change-Id: I4d9715e89403072b312c0002a43c67ac59960d1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132281 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-29allocate column in ScTable::FillSeries() when neededLuboš Luňák
There's an assert triggered by Test::testAutoFill() if INITIALCOLCOUNT is set to 1. Change-Id: I65ecd7df3bf6b38a8121a252f7f53dd7f5bbb0fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132270 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-29tdf#89449 PPTX import: fix line connectorsTibor Nagy
Line connectors were imported as plain shapes, losing their functionality during editing, i.e. keeping connections of boxes and other shapes. Change-Id: I0f1562be2dbcce0e45eb209c6ca4e035731039e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131303 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-03-29avoid repeated calls to ScMarkData::GetMarkedRanges() (tdf#148147)Luboš Luňák
ScTable::HasSelectionMatrixFragment() gets called several times when opening 'Sheet' in the menubar, and the functions it calls end up a quadratic cost for the number of columns repeatedly calling ScMarkData::GetMarkedRanges() for the same object. Fix the performance problem by getting the value once and reusing it. Change-Id: I8b05475832c3560318c43429c3b9323035a3691f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132267 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-29do not provide non-const iterators for ScMarkData internalsLuboš Luňák
It's a bad idea, and it's actually not needed. Change-Id: Ic1022bc4774a33abbc37158539881a15792bc282 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132266 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-29sc: fix use after free in ScChart2DataSequence::ExternalRefListenerMichael Stahl
UITest_chart: tdf122011.tdf122011.test_tdf122011 ERROR: AddressSanitizer: heap-use-after-free on address 0x61e00007a13e at pc 0x7f9a88217e2b bp 0x7f9a901e7ab0 sp 0x7f9a901e7aa8 READ of size 1 at 0x61e00007a13e thread T53 #0 ScDocument::IsInDtorClear() const sc/inc/document.hxx:2421:56 #1 ScChart2DataSequence::ExternalRefListener::~ExternalRefListener() sc/source/ui/unoobj/chart2uno.cxx:2897:26 #4 ScChart2DataSequence::~ScChart2DataSequence() sc/source/ui/unoobj/chart2uno.cxx:2458:1 #6 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9 #8 com::sun::star::uno::Reference<com::sun::star::chart2::data::XDataSequence>::~Reference() include/com/sun/star/uno/Reference.hxx:114:22 #9 chart::LabeledDataSequence::~LabeledDataSequence() chart2/source/tools/LabeledDataSequence.cxx:89:1 #11 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9 #12 cppu::WeakImplHelper<com::sun::star::chart2::data::XLabeledDataSequence2, com::sun::star::lang::XServiceInfo>::release() include/cppuhelper/implbase.hxx:115:66 #13 com::sun::star::uno::Reference<com::sun::star::chart2::data::XLabeledDataSequence>::~Reference() include/com/sun/star/uno/Reference.hxx:114:22 #20 chart::DataSeries::~DataSeries() chart2/source/model/main/DataSeries.cxx:218:1 #24 chart::DataSeries::release() chart2/source/model/main/DataSeries.cxx:537:1 #25 rtl::Reference<chart::DataSeries>::~Reference() include/rtl/ref.hxx:129:22 #32 std::__debug::vector<rtl::Reference<chart::DataSeries>, std::allocator<rtl::Reference<chart::DataSeries> > >::clear() /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/debug/vector:720:9 #33 chart::ChartType::~ChartType() chart2/source/model/template/ChartType.cxx:65:19 #34 chart::ColumnChartType::~ColumnChartType() chart2/source/model/template/ColumnChartType.cxx:134:2 #36 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9 #38 chart::ChartType::release() chart2/source/model/template/ChartType.cxx:330:1 #39 rtl::Reference<chart::ChartType>::~Reference() include/rtl/ref.hxx:129:22 #46 chart::BaseCoordinateSystem::~BaseCoordinateSystem() chart2/source/model/main/BaseCoordinateSystem.cxx:185:1 #47 chart::CartesianCoordinateSystem::~CartesianCoordinateSystem() chart2/source/model/main/CartesianCoordinateSystem.cxx:53:2 #49 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9 #51 chart::BaseCoordinateSystem::release() chart2/source/model/main/BaseCoordinateSystem.cxx:406:1 #52 rtl::Reference<chart::BaseCoordinateSystem>::~Reference() include/rtl/ref.hxx:129:22 #53 chart::VCoordinateSystem::~VCoordinateSystem() chart2/source/view/axes/VCoordinateSystem.cxx:89:1 #55 chart::VCartesianCoordinateSystem::~VCartesianCoordinateSystem() chart2/source/view/axes/VCartesianCoordinateSystem.cxx:69:1 #65 chart::ChartView::impl_deleteCoordinateSystems() chart2/source/view/main/ChartView.cxx:1091:20 #66 chart::ChartView::~ChartView() chart2/source/view/main/ChartView.cxx:1085:5 #68 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9 #70 rtl::Reference<chart::ChartView>::~Reference() include/rtl/ref.hxx:129:22 #71 chart::ChartModel::~ChartModel() chart2/source/model/main/ChartModel.cxx:183:1 #73 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9 #75 rtl::Reference<chart::ChartModel>::clear() include/rtl/ref.hxx:196:19 #76 chart::CreationWizardUnoDlg::disposing() chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:235:19 #77 cppu::OComponentHelper::dispose() cppuhelper/source/component.cxx:161:17 #78 chart::CreationWizardUnoDlg::notifyTermination(com::sun::star::lang::EventObject const&) chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:140:5 #79 framework::Desktop::impl_sendNotifyTerminationEvent() framework/source/services/desktop.cxx:1649:79 #80 framework::Desktop::terminate() framework/source/services/desktop.cxx:282:13 0x61e00007a13e is located 2238 bytes inside of 2712-byte region [0x61e000079880,0x61e00007a318) freed by thread T53 here: #0 0x4fe267 in operator delete(void*) (instdir/program/soffice.bin+0x4fe267) #1 ScDocShell::~ScDocShell() sc/source/ui/docshell/docsh.cxx:2899:1 #2 SvRefBase::ReleaseRef() include/tools/ref.hxx:163:29 #3 tools::SvRef<SfxObjectShell>::~SvRef() include/tools/ref.hxx:56:36 #4 IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() sfx2/source/doc/sfxbasemodel.cxx:245:5 #12 SfxBaseModel::dispose() sfx2/source/doc/sfxbasemodel.cxx:757:13 #13 SfxBaseModel::close(unsigned char) sfx2/source/doc/sfxbasemodel.cxx:1482:5 #14 SfxBaseModel::dispose() sfx2/source/doc/sfxbasemodel.cxx:718:13 #15 gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 Change-Id: I4ac7a702c50f9519a0f982ece9776c2d449c43ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132242 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-29initialize output parameter of ScFormatRangeStyles::GetStyleNameIndex()Luboš Luňák
ScMyDefaultStyles::FillDefaultStyles() calls this in a loop and compares with previous. Change-Id: Iba3420023e16c3091f4695640251a5525b28f467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132199 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-29sc a11y: Fix + port events for row/col ins/delMichael Weghorn
Previously, incorrect indices were sent when inserting or deleting rows or columns from a Calc spreadsheet, e.g. when deleting rows 4 to 12 (i.e. rows with indices 3 to 11), the pyatspi script from Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89, "a11y: Add new table model change types for row/col insertion/del" would have this output: > object:row-deleted(12, 10, 0) > source: [table | Sheet Sheet1] > host_application: [application | soffice] > sender: [application | soffice] > object:column-deleted(0, 16384, 0) > source: [table | Sheet Sheet1] > host_application: [application | soffice] > sender: [application | soffice] i.e. LO would announce the deletion of all columns and the deletion of 10 rows, starting at index 12, which is obviously wrong. For the case where rows or columns have been deleted, the range in the update hint passed to `ScAccessibleSpreadsheet::Notify` is the spreadhseet range after the removed rows/columns; for the case where rows or columns have been inserted, the range in the update hint is from the first inserted row/column to the last row/column in the spreadsheet. So, calculate the indices of the actually inserted/deleted rows/columns from that. Also, switch to using the table model change event types introduced in the change mentioned above. With this in place, output of the Python script for the above case now is as expected (9 rows, starting at row index 3, have been deleted): > object:row-deleted(3, 9, 0) > source: [table | Sheet Sheet1] > host_application: [application | soffice] > sender: [application | soffice] Deletion of non-contiguous row/column ranges (e.g. deleting columns A to C and F to H) also results in the correct events getting sent, since `ScAccessibleSpreadsheet::Notify` gets called multiple times, once for each contiguous cell range. Change-Id: I6e61eb45f255741661b29efb72394029109d682e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132220 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29sc a11y: OSL_ENSURE -> assertMichael Weghorn
Change-Id: I79f477c950e0aca75e2a6041c5fb6a78be4b07c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132219 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29a11y: Use new table model change types for row/col ins/delMichael Weghorn
This ports most existing uses of the now deprecated `AccessibleTableModelChangeType::INSERT` and `AccessibleTableModelChangeType::DELETE` to emit events of the the four new table model change types added in Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89, "a11y: Add new table model change types for row/col insertion/del" instead, which among others fixes the a11y events that are sent on the platform level for gtk3 and macOS, s. commit message of the mentioned change for more details. From all I can see, `AccessibleGridControlTable::commitEvent` is just meant to handle removal of rows, not columns, so add a corresponding assert there. (See how only row-related a11y events are emitted in `svtools/source/table/tablecontrol_impl.cxx`, and the "columns aren't selectable" comment for `AccessibleGridControlTable::isAccessibleColumnSelected`. Given that the full range of rows would previously have been sent in the `AccessibleTableModelChangeType::DELETE` event for column removal, this should still have worked in practice, since this would have cleared the whole vector, and elements would have been inserted on demand as needed again later. However, if that should ever be needed in the future, it should be handled more explicitly.) The handling of sending events when rows or columns are inserted or deleted in a Calc spreadsheet is more fundamentally broken and will be handled in a separate commit. Change-Id: Icfd5e326143e8e90cc513e430bfabbba39e7bdc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132218 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29sc: fix crash in SdrPageView::GetPageWindow()Aron Budea
From online crashreport: SIG Fatal signal received: SIGSEGV SdrPageView::GetPageWindow(unsigned int) const svx/source/svdraw/svdpagv.cxx:84 (anonymous namespace)::ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact(basegfx::B2DVector&, sdr::contact::ViewObjectContact const&) const sc/source/ui/view/gridwin4.cxx:1397 sdr::contact::ViewObjectContact::getGridOffset() const svx/source/sdr/contact/viewobjectcontact.cxx:463 sdr::contact::ViewObjectContact::getPrimitive2DSequence(sdr::contact::DisplayInfo const&) const include/basegfx/tuple/b2dtuple.hxx:81 sdr::contact::ViewObjectContact::getObjectRange() const svx/source/sdr/contact/viewobjectcontact.cxx:198 ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact() didn't check if PageWindowCount() was non-zero. Change-Id: I4a00b5b13a277d0805af3076150a952306908e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132251 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-03-29sc: set default parameters in SparklineGroupTomaž Vajngerl
The colors are set to COL_TRANSPARENT except for the series color, which is set to COL_BLUE by default. Other parameters are set to their default values according to OOXML specs. Change-Id: I67ceab2ffd723511fbf0616cca661992f0a8cf69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131920 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-03-29sc: refactor sparkline struture to store a list of sparklinesTomaž Vajngerl
We need to access a list of sparklines and sparkline groups for a sheet. To preven going through all the columns of a sheet, we need to store all the created sparklines in a list. For this it is necessary to change the model structrue a bit. A cell now has a container that stores a shared_ptr to the sparkline instead of storing the sparkline directly. With this we can store a list of weak_ptr to the sparklines in a list (vector), which can be accessed at any time and is quite fast. This is needed by the OOXML export. Change-Id: Iaca0a41e20912775f072ea6e8cab9c44367d6f30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131919 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since 777e3930a1e85b9bc97c1852b09802fc389c5e2d "Move the code for "fill simple" to its own method." Change-Id: Iea240530696b89f56fba314b599e7cd43ce6a780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132231 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since bc712935a05dd34142b4c17dd6686761d9b9d5e1 "TableRef: refresh table column names before saving" Change-Id: I7537fa3632ff03f73d36eaf9fc6ba0ab73319cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132232 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since d9dd003f63a781e63bfbe380ea737e080c21881f "tdf#143103 Support Color Filter in 'Standard Filter' dialog" Change-Id: I04441f4d812e3598b5b91e3bf915315a11ab6e67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132233 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since df50b02cd3177570bb26484a03273ba5caa50037 "weld ScFilterListBox" Change-Id: I02e835bb9de373fea7891babbce5eec605455198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132234 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since 24da580f8bd0a348fee64c07f9015b09918f8388 "95584#; add RangeId to have the draw ranges unique" Change-Id: I60e98b9645eb4acb2d3d4e47ada81c976e43a424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since fa44673e154ed4fb0b518b8850e2f6e4b9069531 "bnc#885548: Adjust xlsx export of revisions to get it to work in Excel." Change-Id: I4e9c8d176cc5bd3ff1f374fcbcf16c738ebf2388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132240 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 "tdf#125254 Performance: A spreadsheet opens too slow, part2" Change-Id: Ie04e72155b306f6d5e95abf09623d819ee21cdf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132230 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-03-28tdf#147014 Image missing due to integer overflowAron Budea
32-bit awt::Point/Size/Rectangle cannot fit size of 1M rows with larger (eg. 5x the usual) height, and could overflow. This causes problems in 64-bit Linux builds and, since the following commit, in 64-bit Windows builds: 3d90997fb6f232d8008df4d166d7b97b869c200f For now, clamp possibly overflowing values to 32-bit. Change-Id: Ifda7265703388abdfb47f523da4f0c5822358404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129876 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-03-25tdf#113541: sc_uicalc: Add unittestXisco Fauli
Change-Id: I8c2e2b531ef31b834d7431543c94acfb67ff9ae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132113 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-25fix ScTable::GetLastChangedCol() for unallocated columnsLuboš Luňák
Column flags and widths are stored separately from ScColumn data, and so don't depend on allocated columns count. Also rename the functions from the misleading generic name to what they actually do. Change-Id: If85ae80efda1d8b382fa3b559aa65be0292e25ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132114 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-25tdf#122011: sc: Add UItestXisco Fauli
Change-Id: I67938dc8863e5c36bfe9e4a78059d6c467981945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132099 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-25loplugin:constantparamNoel Grandin
Change-Id: Id89c74fcd6c6332f5da9f57986bfc2fe075d71c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132087 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-25loplugin:constantparamNoel Grandin
Change-Id: Ic2c93bca1b77c29e547473f889f53a2af8755fe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-25loplugin:constantparamNoel Grandin
Change-Id: I3a3f78896a1483aa07d2ca2350a7c01ab860083a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-25loplugin:constantparamNoel Grandin
Change-Id: If19a34e7f358e213d8827a107cc744a968ac6c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-24uitest: sc: remove tests not testing anything in particularXisco Fauli
these tests were added in 2016 as a demo: - 8a9861c47b66afed9f9a22ee7f507ba99cd4162a "uitest: add demo for chart wizard" - fc0c5d6163e99d29498c9b8599d9bdf9a3e4ca6c "uitest: add demo showing how to deselect an UI object" - 559f2e233108ed5e9da305ffbf945d6ed568f7eb "uitest: add demo showing how to activate chart" and others. They just perform pretty basic actions and they have no asserts at all. After all these years, there are already other tests covering the same actions Change-Id: I978e28c090cf71a65db4881da96c865080ab9b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132088 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24tdf#39716: sc: Add UItestXisco Fauli
Change-Id: Ic28f676d14b21edc1f06b726afbcfc19c8015b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132081 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24tdf#70455: sc_subsequent_filters2: Add unittestXisco Fauli
Change-Id: I757bef506eff21071de8b8b40f5e1fc9d82b1ab7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132083 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24tdf#113898: sc_uicalc: Add unittestXisco Fauli
Change-Id: I52fa7ad0cb1f9b3d2f72229d961674f6292be60f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132071 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24CppunitTest_sc_uicalc: combine external reference testsXisco Fauli
Change-Id: Ie3bc4dbf69e1b09ebbbb5ffdc4e7a02bc3a7cb02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132069 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24tdf#116149: sc_uicalc: Add unittestXisco Fauli
Change-Id: I304bbbbd21e818b90b4c4daba26448836e23bc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132067 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24Resolves tdf#140439 - AutoFormat Table preview not using DOCCOLORHeiko Tietze
WYSIWYG preview should use the actual document color instead the dialog/window background Change-Id: Ifff07b2f754ed88cb7e60e0494092e266d3c7cf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132023 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-03-24tdf#114820: sc_uicalc: Add unittestXisco Fauli
Change-Id: I6aa50bdaf6a8d796d1aee817b7a1c0fddce26030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132060 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24tdf#115162: sc_uicalc: Add unittestXisco Fauli
Change-Id: I79874452b1f6909f23629cf0662f8c59faf02558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132059 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24Resolves tdf#147515 - Make header text readable on dark themesHeiko Tietze
COL_LIGHTBLUE works well for bright themes but is too dark in case of dark themes Change-Id: I7fe317da4d67c1d8a5c0330320a10206a003b4ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132028 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-03-24tdf#100847: sc_uicalc: Add unittestXisco Fauli
Change-Id: I0bd79a0b3bc6d92ec83ecd86c4ca631e65528c35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132057 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24tdf#36387: sc_uicalc: Add unittestXisco Fauli
Change-Id: I6da7fbb03d127a093042a5dc6546f314b6af40ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131988 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24loplugin:constantparamNoel Grandin
Change-Id: Ib65abd0546f1219387fe3fd7ad4f6ba0eb029bd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131987 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-23forcepoint#81 fix array sizeLuboš Luňák
A mistake from 694148a9898b47d749588f9a32173a9933262e29, the array is meant to be from column 0, so as if 'nStartCol == 0'. Change-Id: I7f2ecea6c7378d0d5530cb38314807a8f7c896c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131972 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-23Use correct language for spellchecking in calcSzymon Kłos
Fixes the problem of not applied spellchecking language change in calc. 1. Open spreadsheet with German text but with English UI language 2. Change spellchecking language to German result: no difference expected: spellchecking should be performed and mark words correctly Visible in both LOK and desktop. Regression introduced in: commit bdd149b1ff3d43b94cadc0d43365100c287c7639 Author: Dennis Francis <dennis.francis@collabora.com> Date: Sun Oct 4 12:47:46 2020 +0530 Improve spell checking performance and impl. in several ways: Change-Id: I679b1181af118e9894a3f5240523d4945af8ccf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131870 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-03-23loplugin:unusedmethodsNoel Grandin
Change-Id: I59c9e52997e80174a3aa7f81bacdfb29e47be0a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-23loplugin:unusedfieldsNoel Grandin
Change-Id: Ifa2e2b35b725a877ef43526ad243cbfd02148807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-22tdf#103994: sc_uicalc: Add unittestXisco Fauli
Change-Id: I64704b615e148573ba084cf4ecd15dc716b35194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131942 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-25 21:54:01 +0000