summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-12-01weld OfaAutocorrExceptPageCaolán McNamara
Change-Id: I735ca7d70045b278d6b885cc2de35bf76885b487 Reviewed-on: https://gerrit.libreoffice.org/64258 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-01tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScAreaLinksObj. Change-Id: I89beb6a1c05d853e94ebbedb031d87484cb84b38 Reviewed-on: https://gerrit.libreoffice.org/64373 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScCellsObj. Change-Id: If721582a36ef5a82fba20d4ec7e0806d1d0524d9 Reviewed-on: https://gerrit.libreoffice.org/64365 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01Correct class nameJens Carl
Change-Id: I76b440e72a80f20d05af477a38e9695cb17cb979 Reviewed-on: https://gerrit.libreoffice.org/64354 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-30i#32345 Support a matrix of rank argument for LARGE()/SMALL()Takeshi Abe
This is a followup of e22ab5e6f6b0ea49231ca454a567133996306116. Change-Id: I7052e113173204f7cfcd40622f52c5d4e14b3aa9 Reviewed-on: https://gerrit.libreoffice.org/64139 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-30tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java tests to C++ for ScCellsObj. Change-Id: I3ec78142db7cfa924bf5663ca44cca80b6a0e556 Reviewed-on: https://gerrit.libreoffice.org/64315 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-30add uitest fr bug tdf#121263Zdeněk Crhonek
Change-Id: I138e097c65bac9fb37d9b08b444cc5cb9627a4d8 Reviewed-on: https://gerrit.libreoffice.org/64260 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-30Specify label mnemonic widgetsMike Kaganski
Fixes: sc/uiconfig/scalc/ui/conditionalentry.ui: WARNING: 'GtkLabel' 'Label_minimum' does not specify what it labels within 'interface' sc/uiconfig/scalc/ui/conditionalentry.ui: WARNING: 'GtkLabel' 'Label_maximum' does not specify what it labels within 'interface' after commit b907fe59a819aaba75518dc1534eb71d9e378b74 Change-Id: Iff3340cd17fd6c31970fd2d01b49c55e60680978 Reviewed-on: https://gerrit.libreoffice.org/64325 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-30tdf#114113: handle quoted sheet namesMike Kaganski
Change-Id: I569903fc06448fe6ee7f948488319b6b1f1f8fbb Reviewed-on: https://gerrit.libreoffice.org/64334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-30tdf#42949 Fix IWYU warnings in sc/source/ui/*/hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3a945828b4c74be7747850e3e0eab2f4adeb67fd Reviewed-on: https://gerrit.libreoffice.org/64140 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-30remove unused HeaderBarItemBits enum valuesNoel Grandin
Change-Id: I84752cb9d683cb22c96d91cc54d7c4dc474603fc Reviewed-on: https://gerrit.libreoffice.org/64269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30tdf#93005, tdf#100611, remove the incomplete ODC export featureMarkus Mohrhard
Change-Id: I96a3882cd412ea5d993971df7e20b1fd8da73642 Reviewed-on: https://gerrit.libreoffice.org/64283 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-30weld OfaAutocorrReplacePageCaolán McNamara
Change-Id: I143792cfe123942d44b2e39cb1910a5127b2f592 Reviewed-on: https://gerrit.libreoffice.org/64254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-29Adds print even pages/print odd pages options in print dialogDaniel Silva
Change-Id: I17733d83cc652be8c5abaf20cd4b5e23d3a577a1 Reviewed-on: https://gerrit.libreoffice.org/57380 Tested-by: Jenkins Reviewed-by: Daniel Silva <danielfaleirosilva@gmail.com>
2018-11-29Configures page range in print dialogDaniel
Change-Id: I62bd9affc9e065d7afcc60296a72eae4612b0ddd Reviewed-on: https://gerrit.libreoffice.org/55840 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-29Rename Mac OS X to official name macOS in comments and documentationBartosz Kosiorek
Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95 Reviewed-on: https://gerrit.libreoffice.org/64102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-29tdf#42949 Fix IWYU warnings in include/vcl/[i-m]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If1b2e04872eb0dd6725802c1709a9085f4cd8c91 Reviewed-on: https://gerrit.libreoffice.org/64141 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-29make OpenCL bail out if it can't handle multi-column refsLuboš Luňák
The opencl code splits SvDoubleRef into subarguments by each column, but many functions simply treat each subargument as one argument for the function, thus possibly getting things wrong (e.g. SUMPRODUCT would make a product of each column and sum those, rather than making a product of the whole SvDoubleRef). So bail out if multi-column SvDoubleRef is encountered, unless the function is known to handle this case properly (either it takes extra care, such as VLOOKUP, or it doesn't matter, such as SUM, AND, MAX). Change-Id: Ied89a2fc252fb35fe49796140489ff4588038e25 Reviewed-on: https://gerrit.libreoffice.org/64238 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-29calc threads cycle detection should not break computing a valueLuboš Luňák
If ScFormulaCell::Interpret() is called to actually compute the cell's value (bRunning==true), do not bail out on a detected cycle, it needs to be detected as an actual cyclic reference. Happens with testCopyPasteMixedReferenceFormula when during computing dependencies cell C1 actually has a cyclic dependency on itself. Without this change, it would simply use its previously computed value. Change-Id: Ibf90b118b87d3536f5014004ea4a1dbad93ab270 Reviewed-on: https://gerrit.libreoffice.org/63183 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-11-29Support occurrence number as REGEX() 4th argument, tdf#113977 follow-upEike Rathke
REGEX( Text ; Expression [ ; [ Replacement ] [ ; Flags|Occurrence ] ] ) REGEX(Text;Expression) extracts the first match of Expression in Text. If there is no match, #N/A is returned. REGEX(Text;Expression;Replacement) replaces the first match of Expression in Text, not extracted. If there is no match, Text is returned unmodified. REGEX(Text;Expression;Replacement;"g") replaces all matches of Expression in Text with Replacement, not extracted. If there is no match, Text is returned unmodified. REGEX(Text;Expression;;Occurrence) extracts the n-th match of Expression in Text. If there is no n-th match, #N/A is returned. If Occurrence is 0, Text is returned unmodified. REGEX(Text;Expression;Replacement;Occurrence) replaces the n-th match of Expression in Text with Replacement, not extracted. If there is no n-th match, Text is returned unmodified. If Occurrence is 0, Text is returned unmodified. Change-Id: Iadb705e4c76415c57bf510489410ec029344cca7 Reviewed-on: https://gerrit.libreoffice.org/64199 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-11-29loplugin:stringconstant look for unnecessary OString constructor useNoel Grandin
and tweak the methods in check.hxx to make them more flexible when called with dc.Class(xxx ? "foo" : "bar") Change-Id: I881fe628f22121ced4d8849715d6b1c92b092da1 Reviewed-on: https://gerrit.libreoffice.org/64207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29No GridOffset support for PDF or PrintArmin Le Grand
Change-Id: I40c1128ef2fb8860e883016344138bb84f68c2de Reviewed-on: https://gerrit.libreoffice.org/64112 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-11-29remove unnecessary "if (!empty()" checks before loopsNoel Grandin
found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29tdf#105236, only take number format from numeric cellsMarkus Mohrhard
Change-Id: I55deaa1f0579582a45dc1e10bb578b680eb98647 Reviewed-on: https://gerrit.libreoffice.org/64200 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29tdf#121612: update pivot caches during saving to XLSXVasily Melenchuk
Cache was empty so pivot table was not exported completely and pivot table filter were missing. Change-Id: Ib0b9e98a5588159c5c7de1e2e5d2bdcbfe986d8d Reviewed-on: https://gerrit.libreoffice.org/63785 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-28tdf#121581 change organize dialoogs to organize macroandreas kainz
add missing colibre icons improve layout for large icons Change-Id: Id9d003b945654f958ec43d530083e2070d4b580e Reviewed-on: https://gerrit.libreoffice.org/64159 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-28NB tabbed compact: update toolbarandreas kainz
Change-Id: I5c2cd3339634cbb88f2c89226ff46d342eebc3a1 Reviewed-on: https://gerrit.libreoffice.org/64160 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-28Fix SID_EXTRUSION_TOOGLE -> SID_EXTRUSION_TOGGLEAndrea Gelmini
It passed "make check" on Linux. If accepted, I have to update these files: helpcontent2/helpers/help_hid.lst : SID_EXTRUSION_TOOGLE,10960,.uno:ExtrusionToggle helpcontent2/helpers/longnames_commands.csv : SID_EXTRUSION_TOOGLE,.uno:ExtrusionToggle helpcontent2/helpers/uno_hid.lst : SID_EXTRUSION_TOOGLE,10960,.uno:ExtrusionToggle Change-Id: Ie315ef92b6aa8c03c6fc180f4e82d95f28975c2e Reviewed-on: https://gerrit.libreoffice.org/60631 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28drop some unnecessary includesCaolán McNamara
Change-Id: I474b5762e6a07982fddc0315a67181399ea4c30e Reviewed-on: https://gerrit.libreoffice.org/64156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28loplugin:unusedfieldsNoel Grandin
Change-Id: Iffbb4e7107a0b1ae35c879c193a9ec209addf453 Reviewed-on: https://gerrit.libreoffice.org/64144 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3e6424e10eade04951f8ab24bb61af4ce19d1204 Reviewed-on: https://gerrit.libreoffice.org/64113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27Refactor calc non-linear ViewToDevice transformArmin Le Grand
This change solves the non-linear World-To-View trans- formation that calc uses due to it's screen rendering as good as currently possible (AFAIK). Calcv view is layouted on pixel base (due to better homogen distances and full pixel lines between cells), but this leads to having a non-linear transformation between discrete units (pixels, view) and model coordinates (World). In principle, each cell has it's own (so called) ViewTransformation -> the position on screen depends on the mappings of all cells top/left from it. This is obvioulsly non-linear and can sometimes be seen by producing 'offset' errors when many cells (small and thin) are shown in low zoom stages. No better solution for this comes to mind easily. The extremes are - on the one hand AntiAliasing the whole calc edit view and accept 'unsharp/AAed' lines - on the other hand what we have now. Maybe a future solution could find a mapping that gets close to linear mapping for the full view. On the long run this state is hard to keep correct. Even with this extended solution the mapping of SdrObjects spawning mutiple cells is assumed 'linear' in that area - which is in reality currently not the case (!) Note: This is only true for the screen visualization, print and/or PDF export do not do that pixel-based layouting. Note2: This mechanism is general in DrawingLayer (look for '.*GridOffset.*'. If it is deactivated by providing no offsets, the result is the unchanged, linear mapping. First step: Add interfaces to get a possible GridOffset at ViewObjectContact. There it belongs, we have a view- dependent offset per object and view. Add mechanisms to create on-demand and reach back to the view (aka calc's derivation of it). Second step: Implement the on-demand creation, adapt to use it in ViewObjectContact::getPrimitive2DSequence, add stuff to reset on zoom change, disable temporarily old mechanism -> paint already works. Need to adapt the places from old mechanism where the GridOffset was used, but no longer the geometry creations. Third step: Isolated and disabled old mechanism (by already removing SetGridOffset). Marked all places that possibly need change with '//Z' tag. Main work now will be to adapt in the SdrView implementations in svx to know about having a SdrObject-dependent ViewTransformation at all (currently not known, was hard-coded at some places from the old code, ViewTransformation set as MapMode at a target OutputDevice, not member at SdrView at all...). Fourth step: Adapt the Handles and OverlayObjects to use an evtl. existing GridOffset. The mechanism is that the SdrHdl(s) can be seen as 'Model-Objects', these get converted to OverlayObjects in the ::CreateB2dIAObject() implementations, for all SdrMarkView and SdrPageView, so this is the place where the ObjectContact is known (the SdrPageWindow *is* a ObjectContact) and the view- dependent GridOffset can be calculated per SdrObject. I modified OverlayObject to be able to work with a set Offset that embeds the created visualization using this additionally. Handles get now correctly set and have a working HitTest (due to that already using the primitives). Some inter- action stuff already working, some will need more adaption. We simply have no concept for this stuff... Refactored to not get dependencies to SdrObject in ObjectContact. Fifth Step: Make HitTest work by adding the View-And- Object dependent GridOffset in the View when HitTest is triggered. This is in SdrMarkView::CheckSingleSdrObjectHit where pObj->GetCurrentBoundRect() is used that gets the view-independent form. To make HitTest work, add a possible GridOffset. Since this will be necessary more often in SdrView hierarchy, added a tooling method (getPossibleGridOffsetForSdrObject) at that level after checking that at that level will be reachable at all potential spots. Inside that method the correct ObjectContact will be identified and the object-specific offset requested there. Sixth Step: Adaptions and started some cleanups. Still some adaptions needed: - After creation of new object, need to relocate from used GridOffset setting to WorldCoordinates - Interactions, e.g. start with dragging handles or full object/points Seventh Step: React on EndCreateObj. Here, the created SdrObject is in model coordinates and needs to be adapted to evtl. GridOffset. This is 'tricky' due to calculating the possible offset based on new coordinates 'close' to the target position, but may be in the wrong cell. Nonetheless this is the best we can do here. Last (hopefully) missing are now all interaction viszualizations. They already work and are applied correctly, but wrong visualized. Have taken the time to unify adding OverlayObjects for selection visualization to OverlayManager, see handleNewOverlayObject. This does all needed when adding OverlayObjects in one place where the GridOffset can also be handled. It makles things more safe - not possible to forget one of the three steps for others. Eighth Step: Do the same unification for creating the OverlayGeometry, also rename methods to make usage more clear. We now have SdrHdl::insertNewlyCreatedOverlayObjectForSdrHdl SdrDragMethod::insertNewlyCreatedOverlayObjectForSdrDragMethod which can do the needed GridOffset changes centralized. Needed to get a ObjectContact for this at SdrDragMethod, so adapted ::CreateOverlayGeometry implementations accordingly. Missing is now the implementation in insertNewlyCreatedOverlayObjectForSdrDragMethod to add the GridOffset - if used. This has no SdrObject at this time, so we will need a fallback to do the same using a Range (Rectangle). The stuff doing this for SdrObject already has a fallback and is based on using the Rectangle from the SdrObject anyways, so this will be possible. Ninth Step: Cleanup of old stuff (no more //Z), adapted some usages of OverlayObject creations to use getViewIndependentPrimitive2DContainer instead of the view dependent parts so that offset applied to drag-overlays is correct and not already added. Adapted insertNewlyCreatedOverlayObjectForSdrDragMethod to use calculateGridOffsetForB2DRange. Use now that instead of SdrObject-based approach in calc - is more generic. Getting closer, but still not complete - there is an error with dragging the grepped handle somehow - the offset for drag is somehow wrong. Tenth Step: Corrected that offset error. Of course at interaction start and progress (move) the coordinates are in GrifOffset coordinates and need to be corrected to Model coordinates. Done that at ::BegDragObj and ::MovDragObj, works well. Of course there are exceptions for the crop-handles, so needed to add setting the correct parameters at SdrHdl when these got created, then all works as expected. The strategy is to *not* change the model data itself in any way, instead do all changes/adaptions in the view-only code. This has minimal impact and is needed due to having a 1:n relationship between model and views anyways. There are two directions: All visualizations are adapted to take the GridOffset into account (SdrObjects, overlay, handles, InteractionObjects, ...). In the other direction input like MousePosition is in principle in calc EditView in 'GridOffset'-coordinates and needs to be mapped back before usage. Change-Id: I2ecdd409def96a7248a26a65a22e59eb962880a0 Reviewed-on: https://gerrit.libreoffice.org/64057 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-11-27tdf#42949 Fix IWYU warnings in include/vcl/[f-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice2eb8c5994bf2ccb88972332ca4a1d3ed41752a Reviewed-on: https://gerrit.libreoffice.org/63826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-27tdf#45904 Move _XLinkTargetSupplier Java Tests to C++Rahul Gurung
Change-Id: Idd62a6458d7aa0d1d8a479f5ebf78637e0360548 Reviewed-on: https://gerrit.libreoffice.org/63950 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-26tdf#117720 Delete Max from list Min and delete Min from list Max in CF dialogRoman Kuznetsov
This changes how the list items are identified in the code, making use of the support for item ids in comboboxes introduced in commit 83cefb5ceb4428d61a5b9fae80d1e673131e9bfe. Change-Id: I69390c8f9d32b77454e2935cf28b38ea44be8ffd Reviewed-on: https://gerrit.libreoffice.org/63238 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-26NB tabbed calc: add shortcuts and Right2Left supportandreas kainz
Change-Id: I96d760063bf1684cf893e7765f10b0695b2e16ed Reviewed-on: https://gerrit.libreoffice.org/64004 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-26tdf#108027, add external ref string items to the data arrayMarkus Mohrhard
Change-Id: Iaf607fca6d7e88f2c529ab4a374f34164813331a Reviewed-on: https://gerrit.libreoffice.org/64009 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae Reviewed-on: https://gerrit.libreoffice.org/63981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25weld SfxMacroAssignDlgCaolán McNamara
Change-Id: I80045f1d1ca189fc490dc88b3471d68782df6f1c Reviewed-on: https://gerrit.libreoffice.org/63976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: If173f42302553b164267909a0a3156bb25a6d558 Reviewed-on: https://gerrit.libreoffice.org/63957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25drop unused FormulaVectorDisabledNotInSoftwareSubsetNoel Grandin
Change-Id: I6d9b43ce6c72ff876b48bfba4b6de09ed46fd809 Reviewed-on: https://gerrit.libreoffice.org/63946 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25Replace list by vector for ScDDELinkCells typedef (sc)Julien Nabet
Change-Id: I3531ebc46bfc1c4362fafd7f6c93dd97f85676fa Reviewed-on: https://gerrit.libreoffice.org/63963 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-24remove unused sc::ListenerGroupType::SingleNoel Grandin
Change-Id: I98a279731b22f88f57ab667b6f5ef8c71b030832 Reviewed-on: https://gerrit.libreoffice.org/63945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24convert Unit to scoped enumNoel Grandin
and drop unused UNIT_REFDEVX,UNIT_REFDEVY values Change-Id: I4e516f2c51672f6541f3cf7c03a87aebc4a1f1f6 Reviewed-on: https://gerrit.libreoffice.org/63944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24remove unused FuncFlags::BIFFIMPORTONLY,STATE::S_WK1Noel Grandin
Change-Id: I94d88f871bfc78a066f6fd583b7fb7a7305944c8 Reviewed-on: https://gerrit.libreoffice.org/63943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24remove ScMoveUndoMode enumNoel Grandin
we only use one value Change-Id: I7a0f3760615111adcd8b925234f53fafa46a0bd7 Reviewed-on: https://gerrit.libreoffice.org/63942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24remove ScVbaControlObjectBase::ListenerType enumNoel Grandin
we only use one value from it Change-Id: I3d0391e76f07434915940be25025de36a5475bc5 Reviewed-on: https://gerrit.libreoffice.org/63937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23convert FormulaDlgMode to scoped enumNoel Grandin
and drop unused ARGS value Change-Id: I9b9d0c9ea64a2174759dcf6406bdf6cd5be5862a Reviewed-on: https://gerrit.libreoffice.org/63892 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23enum ScMatrix::Op is unnecessaryNoel Grandin
Change-Id: If4ae97b43f012f1770213d99407ffaadac05f9de Reviewed-on: https://gerrit.libreoffice.org/63756 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23Use the correct DPI scaling factor in LibreOfficeKit for iOS, tooTor Lillqvist
Fixes the rendering of spreadsheets in the iOS app. (The cell area was rendered at half the scale of the row and column headers.) Actual code change only in desktop/source/lib/init.cxx, but update related comments elsewhere to mention CoreGraphics, too, and not just cairo. Change-Id: Ife99c6a2d58e592cfea3b4ed1ab09c19fba77e72