summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-05-22Handle STDEV, STDEVP, VAR and VARP with arrays of references, tdf#58874Eike Rathke
Change-Id: Ifdd5336124df9a085902417590d081646d05a588
2017-05-22Unit test for SUBTOTAL AVERAGE with array of references, tdf#58874Eike Rathke
To test the count vector as well. Change-Id: Idc6bcdc779ea0e6e8a6118934fd8e7856eba1518
2017-05-22Get vector count right, tdf#58874Eike Rathke
Change-Id: I1d4224c6a87af4ed9f879e144958f95418fabbf7
2017-05-22Move result token push into GetStVarParams(), tdf#58874Eike Rathke
Change-Id: If38637f2dcaf0457e95444a9d46636d91def4f9c
2017-05-22Make GetStVarParams() parameter bTextAsZero non-optional, tdf#58874 prepEike Rathke
Change-Id: Ia38c5617be71a739f0a3a8fcf28060518e9334d1
2017-05-22Generalize to lambda MatOpFunc(), tdf#58874Eike Rathke
Change-Id: Ibd5b1e83ad718d0d5ab832ecf884be69eeb0d22e
2017-05-22Factor out ScInterpreter::SwitchToArrayRefList(), tdf#58874Eike Rathke
Change-Id: I7a672b8d0bd6dae9baa1289a3b00b0789a0d4d6d
2017-05-22Unit test for SUBTOTAL MIN,MAX with array of references, tdf#58874Eike Rathke
Change-Id: I116b236066f28e3442f644544e789e1dbc2ff88a
2017-05-22Handle MIN and MAX with arrays of references, tdf#58874Eike Rathke
Change-Id: I24c9f3078f60e14e64f1e1e3910963dfe0a38d77
2017-05-22const nMatRows, tdf#58874Eike Rathke
Change-Id: Ic9e11ed6b8890fe9d3db4b3a9b4d1d8d50838b2e
2017-05-22Factor out to ScInterpreter::GetRefListArrayMaxSize(), tdf#58874Eike Rathke
Change-Id: Ie08c37ff66faaaba8f8945503e3d212943d324d7
2017-05-22Add unit test for SUBTOTAL over reference list in array context, tdf#58874Eike Rathke
Change-Id: I82752c035f6551d3136dc06331ff8745ba959463
2017-05-22Use SetValue() instead of SetString()Eike Rathke
Change-Id: I9d1f9be14d69006126a2c72b7c4cfbfb24b3cfe8
2017-05-22Handle reference list as array in IterateParameters(), tdf#58874Eike Rathke
This in array context now returns the expexted array for an expression like =SUBTOTAL(9,OFFSET(A1,ROW(1:3),0,2)) where OFFSET returns an array (svRefList) of references, here A2:A3 A3:A4 A4:A5 and SUBTOTAL(9,...) sums each of the references independently to return an array of three sums. Currently works with SUM, COUNT, COUNT2, AVERAGE, PRODUCT and SUMSQ. MAX and MIN are not handle in IterateParameters() and need an extra implementation, or rather move them into IterateParameters() as well? Change-Id: I03b7d1cccf78c1a831348106432126aec8d1f519
2017-05-22Change IterateParameters to push token instead of returning double, tdf#58874Eike Rathke
Change-Id: Ib256d99126116379b27fc246dedf0fac2efb8c02
2017-05-22Get rid of some unneccessary formula:: namespaceEike Rathke
Change-Id: Icd30167589b507c3f83a31dbb5c0eb473ab6580e
2017-05-22Do not force return value to double in SUBTOTAL and AGGREGATE, tdf#58874Eike Rathke
Change-Id: I305adfb97022f353dde6aab4e234faff0fdfb904
2017-05-22Create RefList at JumpMatrix if current function returns Reference, tdf#58874Eike Rathke
Change-Id: I8fcdbc743c614857ee298b3d9c730ab64477dd8c
2017-05-22Introduce ScRefListToken::mbArrayResult for reference results, tdf#58874Eike Rathke
Change-Id: Icd077a82ab0c951667a6566d5c5d47084c46d20d
2017-05-22Introduce ScJumpMatrix::mvRefList for array of reference results, tdf#58874Eike Rathke
Change-Id: I478ddbcd951b386b8d4cbb38059b904af7c79703
2017-05-21tdf#91820 Add cell style and spreadsheet theme commandYousuf Philips
Change-Id: Ia9a3a4704b5c07e5ae26a290855cf77bd33bcbd1 Reviewed-on: https://gerrit.libreoffice.org/37844 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-05-21tdf#95885 move cell protect command from toolbar to menuYousuf Philips
Change-Id: I5da54901e06346094cbe77e0ac70ecf72d9887ef Reviewed-on: https://gerrit.libreoffice.org/37845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-05-21Fix typosAndrea Gelmini
Change-Id: I438b6719817e0bbb47370ec54561eed2bc402cba Reviewed-on: https://gerrit.libreoffice.org/37783 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-20tdf#107892 add MAXIFS testZdeněk Crhonek
Change-Id: Ibb4d5a4f005390bf7ded06170dd95a8edf5c1c8c Reviewed-on: https://gerrit.libreoffice.org/37858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-05-20cleanup unused css/uri/ includesJochen Nitschke
Change-Id: I08c7981ecce45e343ff9e98277dd3aea4ed68ab9 Reviewed-on: https://gerrit.libreoffice.org/37860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-20cleanup unused css/script/ includesJochen Nitschke
but keep exception includes in headers for now Change-Id: I826828675a2d14b906e57068cbced2e790e12bce Reviewed-on: https://gerrit.libreoffice.org/37846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19loplugin:stringcopy: scStephan Bergmann
Change-Id: Ic6cb5406d20e7e07b8e34514df71adf1c3a4e727
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19Removed unneccessary ASCII-Art and commentsThomas Beck
Change-Id: I455d7aa7c6e6313a0d24137e02b7bf04ede9aae9 Reviewed-on: https://gerrit.libreoffice.org/37752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-18Revert "Fix typos"Stephan Bergmann
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
2017-05-18Fix typosAndrea Gelmini
Only replaced "iff" with "if" Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581 Reviewed-on: https://gerrit.libreoffice.org/37782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18tdf#107862 ignore subtotals in outline mode and empty rowsTomaž Vajngerl
Change-Id: Ifb469193d4f7b3a5f48ab1ef15ae9f5996bfa608 Reviewed-on: https://gerrit.libreoffice.org/37740 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-18Replace macro with functionStephan Bergmann
Change-Id: I005622c607a5a3dcd31b46f6e819546b7ece630b
2017-05-18Pass grammar to ScCompiler ctor instead of subsequent SetGrammar()Eike Rathke
Not only to have more concise code but also to avoid setting grammar twice if the actual grammar differs from the document's default one. Change-Id: I7bfd151c22c48a40aea05f5f983fa0370d9fd9ae
2017-05-18Always set a grammar when constructing ScCompilerEike Rathke
Otherwise mxSymbols is null, which is rather unexpected as the past has shown, see commit 63843a97262ccfa38d838a9cbbc3faadba8290a6 Change-Id: Id4c13a5f50e711513a71a7d6cd6f87b4112b1f1d
2017-05-18assert instead of OSL_ENSURE if grammar is GRAM_UNSPECIFIEDEike Rathke
Change-Id: Ie23a5a98e9bc6dfbd5d685c482fb358ac3822845
2017-05-18tdf#107920: Crash when using ScCompiler in condformatJulien Nabet
Just call SetGrammar from ScCompiler object with grammar of document See bt in https://bugs.documentfoundation.org/attachment.cgi?id=133382 Change-Id: Iedf4b88f2821bbcf728e4b1c023041fd6f10e5f3 Reviewed-on: https://gerrit.libreoffice.org/37739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18Add comment about precedence of Wildcards over RegexEike Rathke
Change-Id: I053c8ebb328aaa3b577283af17b6540b997e3dcc
2017-05-18New HintId and unit test for hidden rows and SUBTOTAL, tdf#93171 follow-upArul Michael
Adding new Hintid for HideRows so that we notify only formulas with subtotal and aggregate function for recalculation. Added unit testing. Change-Id: I44f2e45acaf697f91744bc8202f27b218faa5b43
2017-05-18Respect read-only config items in Options/Calc/Calculate dialogAron Budea
Read-only state is now read except for settings in General Calculations (except Decimal places). Change-Id: Ia947f6657ae5638c414bf4e82fac314b5993f4c5 Reviewed-on: https://gerrit.libreoffice.org/37546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18sc lok: fix wrong assignment aEnd.X()Henry Castro
In tiled rendering case, the window size is small and the end point will be cut, then result wrong invalidation area Conflicts: sc/source/ui/view/tabview3.cxx Change-Id: Ief49c5f47bbc69485354ab396c7508db9548f82a Reviewed-on: https://gerrit.libreoffice.org/37737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-05-18loplugin:unusedmethodsNoel Grandin
Change-Id: I1c50d176e793397a1f9625f797a3750cf191a61c Reviewed-on: https://gerrit.libreoffice.org/37679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-18Clean up a set of RTL-related commentsTor Lillqvist
It is fairly pointless to have a comment like "--- RTL --- (mirror mouse pos)" in front of code that obviously is related to RTL anyway, like "if( AllSettings::GetLayoutRTL() )". Also, the fact that many comment were exactly the same indicates that they has been added as an in-line version control change marker. In other places, comments were informational, but no need for them to include yet another metasyntax, "--- RTL ---". Just "RTL:" works fine. Change-Id: I20feef308ed8ac9d32a8bf440fc20b442753c4ff
2017-05-17sc lok: Don't crash on comment undo.Jan Holesovsky
Change-Id: I3b8686e2d52359de2d99413e63d4a424ba1439d1 Reviewed-on: https://gerrit.libreoffice.org/37710 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-17tdf#107892: fix negative values case with maxifsJulien Nabet
std::numeric_limits<double>::min() returns positive value for float/double so use std::numeric_limits<double>::lowest() (see http://stackoverflow.com/questions/17070351/why-does-numeric-limitsmin-return-a-negative-value-for-int-but-positive-values) Change-Id: I0afce2d38c6936aeff26923182bcafd2f0008d9e Reviewed-on: https://gerrit.libreoffice.org/37693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-17Unit test to ensure that calculating with the intersection works, tdf#96426Eike Rathke
Change-Id: Ia447c91d80b51f183d591a89a103ba68173a9d85
2017-05-17add unit test for Excel whitespace operator intersection, tdf#96426Eike Rathke
Change-Id: I8cc5d9fbb6a92545379288dc1648a6c68ad4ccb1
2017-05-17tdf#43535: add unit test for this.Kohei Yoshida
Change-Id: I4e6b27f82d1344ac77b02867e1e717c510a133b6 Reviewed-on: https://gerrit.libreoffice.org/37696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-17tdf#43535: support additional sheet protection options.Kohei Yoshida
New options are: * insert columns. * insert rows. * delete columns. * delete rows. Change-Id: I076b0d01bee0fff0623e2f1137c09938a6110939 Reviewed-on: https://gerrit.libreoffice.org/37695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-16ExternalZoom and ExternalScroll are unusedCaolán McNamara
which leads to CommandWheelMode::ZOOM_SCALE becoming unused and so touch/touch.h is unnecessary Change-Id: I7cb9a4f6af2719deb0d768e35d514b59010daf79 Reviewed-on: https://gerrit.libreoffice.org/37671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-15 06:44:22 +0000