summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-06-02Improved loplugin:redundantcast static_cast handling: scStephan Bergmann
Change-Id: I11f0deb6913a7a3adc6bc31890451e05bfa00802
2017-06-02convert GRFILTER constants to ERRCODE_GRFILTER_Noel Grandin
since various code mixes these constants in with ErrCode values from other code, let us just make it into real ErrCode values. Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95 Reviewed-on: https://gerrit.libreoffice.org/38313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-01Resolves: tdf#108279 dimension rows are 32-bit and don't wrap at 64kEike Rathke
Change-Id: I7bf7a149fb1db526ef62bea2f52b200cf5053cc2
2017-06-01Perf: do not calculate a null-operation with the result matrix, tdf#58874Eike Rathke
Change-Id: I6fe115ff7ec7960900863ddaf1cd1dc48975fd74
2017-06-01Perf: do not calculate a null-operation with the result matrix, tdf#58874Eike Rathke
i.e. with an empty set within an svRefList when advancing to the next reference. Change-Id: Iae81c3a0cd3c30ab113ad74881a0f28b78b0973d
2017-06-01tdf#107945: store rtl_uString pointers instead of heap OUString objects.Kohei Yoshida
Change-Id: I61079e041a79195f9e9cb77ce80368ef7e909cef Reviewed-on: https://gerrit.libreoffice.org/38288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-06-01Improve suppression of loplugin:redundantcast in CPPUNIT_ASSERTStephan Bergmann
Change-Id: I65f95e7245f08592ea11cc75e1cf34dcbdf16b40
2017-05-31disambiguate dual use of toolbar idsCaolán McNamara
for toolbar title string resource and identifier (for config) Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28 Reviewed-on: https://gerrit.libreoffice.org/38274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-31tdf#108259 Enable autofilter with many different valuesJean-Sebastien Bevilacqua
When you create an autofilter on a column which contains many different values, you will have problems. First of all, if you exceed 65535 values, you will enter in an infinite loop because a uint16 is incremented for each value, and after 65535, you restart to 0. Secondly, the algorithm executes a double loop in O(n2) to determine checked values, it's too long. Instead of that, all checked values can be determined before. This patch is graciously offered by Linagora. Change-Id: Idc4500f6a496ae789aae11eb0e183aee157daa20 Reviewed-on: https://gerrit.libreoffice.org/38269 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31tdf#104219 Don't export color information when color is automaticBartosz Kosiorek
In LibreOffice and MS Office, there are two types of colors: - Automatic (which is taken from settings) and Fixed (which is set by RGB value). OOXML is setting automatic color by default, by not providing any RGB color. To preserve automatic color we need to not export RGB color during OOXML export. Change-Id: I8895230c4fffc9d8741f3eff37e64c4823d71da8 Reviewed-on: https://gerrit.libreoffice.org/37970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-31clang-tidy readability-redundant-string-cstrNoel Grandin
and readability-redundant-string-init Change-Id: I7b25659ace9e1d5be042ec5e179f01191693334e Reviewed-on: https://gerrit.libreoffice.org/38225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31clang-tidy readability-redundant-control-flowNoel Grandin
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04 Reviewed-on: https://gerrit.libreoffice.org/38215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31tdf#107797 select all entries in the dropdownSzymon Kłos
Change-Id: I3ee33040744eab35f841d3622cb8981b49d04333 Reviewed-on: https://gerrit.libreoffice.org/38091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-05-30remove duplicate 'using namespace'Jochen Nitschke
Change-Id: I7f8828f677cfb588135ff75c03ffb75895773440 Reviewed-on: https://gerrit.libreoffice.org/38201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30tdf#86119 Fix toggle behaviour of SID_NUMBER_STANDARD.Gulsah Kose
Change-Id: I718869c92a3a03c05b8db3fe665f5502202f434b Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/38217 Tested-by: Jenkins <ci@libreoffice.org>
2017-05-30teach redundantcast plugin about functional castsNoel Grandin
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-29tdf#97362 CalcRTL unittest partially migarted to python (CalcRTL.py)Kappanneo
java checkSpreadsheetProperties to python testSpreadsheetProperties Change-Id: Ifd342d3f47aef8a64a0421b6bb7f2a643bdc6da8 Reviewed-on: https://gerrit.libreoffice.org/38159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28cleanup unused css/linguistic2/ includesJochen Nitschke
Change-Id: Ifd4b495f965f948d37557d83a03a38df9322039a Reviewed-on: https://gerrit.libreoffice.org/38109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28tdf#107389: Wrong positioning of AutoFilter buttons in tiledrendering modeTamás Zolnai
Must be a regression from this commit: 9113f17e65b1dafbc178fd269e2967c1e2632f0e Where the offset's and origin's meaning were changed, but not all code path was updated accordingly. Change-Id: Ib519303d5ca5ac7f13e74944e8147ea3220d7684 Reviewed-on: https://gerrit.libreoffice.org/38102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-05-27tdf#85594 Add reset default formatting to standard toolbarYousuf Philips
Change-Id: Ie483c3e5454eac45d1fa0f3c48b009cb369a19e3 Reviewed-on: https://gerrit.libreoffice.org/38008 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-05-26coverity#1409897 Dereference before null checkCaolán McNamara
Change-Id: I9ce73a4836df502267ec9b247432dd86b6ac1b62
2017-05-26coverity#1409898 Dereference before null checkCaolán McNamara
Change-Id: I44b5ab0c66b4050c2ee47684af7526e2543945ca
2017-05-26coverity#1409901 Unused valueCaolán McNamara
Change-Id: I1a363ed385ba251ece29f7bd1eaa151c0657f14e
2017-05-26tdf#108049 VBA exception avoided in ScVbaRange::setStyleJustin Luth
Change-Id: I5fc928373d70829b6e68d9000140a30f04179536 Reviewed-on: https://gerrit.libreoffice.org/37981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-26xlsx export: limit dataValidation list to 255 chars, not 254Justin Luth
related to tdf#99856 commit b139bf96574010f317c543bc45d23dd6a5810621 which had a logic failure, caused by investigating too many alternative ways of fixing. Change-Id: I6ffce8c0bc10c992804cb5d8c75441da1a4c3d37 Reviewed-on: https://gerrit.libreoffice.org/38051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-05-25tdf#99856 xlsx export: limit dataValidation list to 255 charsJustin Luth
Excel consider the file corrupt if it has an overly long validation list. Change-Id: I4145859d4f76e0a70521c7bee33c96927b437ace Reviewed-on: https://gerrit.libreoffice.org/38038 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-25tdf#108017 xlsb import: protection settings were reversedJustin Luth
Back in LO4.3, commit 5728a56b20e01d6c9e86a23f20af64a1b68ad604 fdo#70499 selectn of lock/unlocked cells with worksheet protection reversed ...reversed finalizeImport's understanding of maSheetProt.* to match xml import, but then it no longer matched the binary stream import. So, .xlsb imported the opposite of what .xlsx/.xlsm imported. Change-Id: I2da3967ef52187e4ef36ce7d01b17a4672f61e1c Reviewed-on: https://gerrit.libreoffice.org/37952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-24Clean up a commentTor Lillqvist
Change-Id: I9ee47a3de42087fb63e5d3e931ecee538017f3cc
2017-05-24tdf#107945: properly iterate over mtv during pivot cache loading.Kohei Yoshida
This reduces the total time required for populating the pivot cache by ~60%. Change-Id: I6a8511959c20231a8a5dbd0b0a9a3d0930a1fa0c Reviewed-on: https://gerrit.libreoffice.org/37971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-23Extend the loop over svRefList to cover also the query evaluationEike Rathke
... otherwise all but the last reflist entry are thrown away.. Change-Id: Ic8e66cfb6179a86140e566d25cbffc901527f269
2017-05-23svRefList always needs to be in a loop to be eventually popped from stackEike Rathke
If it has more than one entries, rRefInList and rParam are incremented (effectively annulating a nParam--) and only the last entry pops the token from stack. This could had led to wrong references for other (previous) parameters. Change-Id: I4204d1be4da2e538cece20d92cb7cd96b7c8fa84
2017-05-23sc: work around MSVC 2017 ICE in AccessibleDocument.cxxMichael Stahl
MSVC 2017 dies with INTERNAL COMPILER ERROR on the ConvertLayerId function, which uses fancy C++14 constexpr SdrLayerId/strong_int stuff; it happens to compile without complaint if it is expressed as an if-elseif chain instead of the switch statement. Change-Id: Ib1324bbabeb7a971ba090b9647dde55c1cd0d587
2017-05-23Move pushing the result token into IterateParametersIfs, tdf#58874Eike Rathke
Change-Id: I7c44afad1610fd04b0b2acc51c654a583ed991e6
2017-05-23PushError() instead of SetError() so there's a result tokenEike Rathke
Change-Id: I8c2a7e01b04c26e008c8cbea9332f71d47293c75
2017-05-23Unit test for COUNTBLANK with array of references, tdf#58874Eike Rathke
Change-Id: I44c4db675b822c0456197bf019783076cb7a4b78
2017-05-23Handle COUNTBLANK with array of references, tdf#58874Eike Rathke
Change-Id: Icf8d2ac32a75ebb45c8c6b3b5ae46d01757eb07a
2017-05-23MustHaveParamCount() already pushes error, tdf#58874Eike Rathke
Change-Id: I5d4ec4f36d7c047a377528495e04cbd9a7bdc38b
2017-05-23drop the SCsROW/SCsCOL/SCsTAB typedefsNoel Grandin
which are exactly the same as the regular SCROW/etc typedefs, and have been this way since commit 43a21999a92c99867bc3417291719996776b0647 Author: Oliver Bolte <obo@openoffice.org> Date: Fri Jun 4 09:00:39 2004 +0000 INTEGRATION: CWS rowlimit (1.1.2); FILE ADDED Change-Id: Ia7f75d71227ca3167b5fd56019bb9bdf0697d1b0 Reviewed-on: https://gerrit.libreoffice.org/37911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-23Handle SUMIF and AVERAGEIF with array of references, tdf#58874Eike Rathke
Change-Id: I37bad7b85ee61631399f1b49d0bc9be3b8d00423
2017-05-23Move pushing result token into IterateParametersIf(), tdf#58874Eike Rathke
Change-Id: I98c52784992f5734480736ce4f8290490ca752f1
2017-05-23Handle COUNTIF with array of references, tdf#58874Eike Rathke
Change-Id: Id0325fba37cbf2cfea4a33e3e8110c5d85cf16a6
2017-05-23enhance useuniqueptr lopluginNoel Grandin
teach it to look for the following sequence in a destructor: delete m_pfoo; m_pfoo = nullptr; Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380 Reviewed-on: https://gerrit.libreoffice.org/37900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-22Revert "Handle SUMPRODUCT with svRefList arguments, tdf#58874" (Excel can't)Eike Rathke
This reverts commit 6b417ec3daaec72c736fcfe0d980ce205e589633.
2017-05-22svRefList argument can be handled now in ForceArray context, tdf#58874Eike Rathke
... but it's up to the comsuming function if and how, so don't set a hard error here anymore. Change-Id: I316b6fb22c4b0569d209880c34704bb04f757045
2017-05-22Handle SUMPRODUCT with svRefList arguments, tdf#58874Eike Rathke
Change-Id: I03c2ed1f957db5ad8a67aaab45076373a020e9c1
2017-05-22Introduce GetMatrix() from svRefList, tdf#58874Eike Rathke
Change-Id: Id3a2500c475835c54fbf02505f852bb33e1403cc
2017-05-22sc lok: prevent wrong assignment aEnd.Y()Henry Castro
In tiled rendering case, the window size is small, and the assignment aEnd.Y() will cause wrong invalidation area. However, at this time will never happen because MAXTILEDROW < MAXROW, so better to avoid in case the last row meets the condition. Conflicts: sc/source/ui/view/tabview3.cxx Change-Id: I9c6af57c0342f173195bb2f3d8ac5ef0f3964911 Reviewed-on: https://gerrit.libreoffice.org/37908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-05-22Unit tests for ...,ref1,arrayofrefs,ref2) to result array, tdf#58874Eike Rathke
Change-Id: I21e98ccd6c13c7e4aa98d5bbdd0dab6d9917a3dc
2017-05-22Unit test for SUBTOTAL STDEV with array of references, tdf#58874Eike Rathke
Change-Id: I27d8a0a3c03012a4575785feb32df11a76d6fcdb
generated by cgit (git 2.34.1) at 2025-01-15 01:34:41 +0000