summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2023-06-18sc drawstyles: Restore text selection after applying a styleMaxim Monastirsky
Change-Id: I0a9bb39d8a7a9e770b3593eaa0a97867cbe86913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153171 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-17Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)timeEike Rathke
Change-Id: I18567fdac512ee786ce4b0785b01b2ae6da7450e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153203 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-06-17tdf#155402 - sc improving CELL() function return value in case of OOXMLBalazs Varga
In case of Excel/OOXML formula syntax: Before the patch =CELL("FILENAME";D2) returns 'file:///X:/dr/own.ods'#$Sheet1 After the patch =CELL("FILENAME";D2) returns file:///X:/dr/[own.ods]Sheet1 Change-Id: I34c805aef813632c45ac3fe930d690ae3c1d5d96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153098 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-06-17oox, writerfilter, xmloff: use frozen data structures for static dataTomaž Vajngerl
Change-Id: I4a53fa57f52900104d249c84cde36c9d3b9e1300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153175 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-17sc: perf: speedup sheets with lots of repetitive...Dennis Francis
row styles using a small cache of already allocated patterns that are tied to extended format id and number format id. Change-Id: I3136aef9a034635924f7b7b6d2432f9ae5c2bd15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152692 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 92b13ad1f1a87393cf66a35694f3e542db57f150) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-17sc: filter: oox: only insert conditional format if has itemsHenry Castro
Otherwise, the empty conditional format will exists. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I99d83bd50ce4c12ef9be6924cba31b8847c0ad07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149720 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151978 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153200 Tested-by: Jenkins
2023-06-17tdf#118335 notebookbar: set visible false for PrintPreview in MenuFileJustin Luth
The label for "Print Preview" comes from ContextLabel in these menus - and it displays "Close Preview" even if the print preview is not active. The PrintPreview buttons in the notebookbar ribbon itself work fine. So just hide the menu ones for now. Perhaps that is not good for accessibility, but I would imagine accessibility people would stick with the traditional menu anyway, since the notebookbar is also horrendous in many other ways for accessiblity. The user can turn this back on again if they want. Customize - Notebookbar - File Tab | File | Menu File Change-Id: I807941650295132c9e15f04094cece26246318d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153199 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-16sc: filter: oxx: insert more rules same rangeHenry Castro
If there are rules with the same range to preserve priority order. <conditionalFormatting sqref="I4:I5"> <cfRule type="cellIs" dxfId="5587" priority="1500" operator="equal"> <formula>"GO"</formula> </cfRule> </conditionalFormatting> <conditionalFormatting sqref="E11:I12 E15:I16"> <cfRule type="containsText" dxfId="5586" priority="1457" operator="containsText" text="R"> <formula>NOT(ISERROR(SEARCH("R",E11)))</formula> </cfRule> </conditionalFormatting> <conditionalFormatting sqref="I4:I5"> <cfRule type="containsText" dxfId="5585" priority="1501" operator="containsText" text="R"> <formula>NOT(ISERROR(SEARCH("R",E11)))</formula> </cfRule> </conditionalFormatting> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ibb98953f0a50140dbde4d52a79fde968095881d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150436 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153198 Tested-by: Jenkins
2023-06-16sc: filter: oox: fix conditional color scale same rangeHenry Castro
Otherwise, the condition color scale the priority order will be lost. <conditionalFormatting sqref="G1:G5"> <cfRule type="colorScale" priority="5"> <colorScale> <cfvo type="min" val=""""/> <cfvo type="max" val=""""/> <color theme="5" tint="-0.249977111117893"/> <color rgb="FF92D050"/> </colorScale> </cfRule> </conditionalFormatting> <conditionalFormatting sqref="G1:G5"> <cfRule type="colorScale" priority="1"> <colorScale> <cfvo type="min" val=""""/> <cfvo type="max" val=""""/> <color theme="0" tint="0"/> <color theme="0" tint="0"/> </colorScale> </cfRule> </conditionalFormatting> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I33fa73bfe8f0bada1cf79bc07be2e43495a4290c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149721 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151979 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153182 Tested-by: Jenkins
2023-06-16sc: filter: oox: fix conditional color scale empty value \"\"Henry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I115c3731db85267d115efd24739470bffaeace40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149718 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151976 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153178 Tested-by: Jenkins
2023-06-16sc: filter: oox: do not insert rule too earlyHenry Castro
The </cfRule> tag is a good place to do a post check the conditional format sanity. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Id6e99c81011040ec47034e993490fae5c71d7e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149719 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151977 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153159 Tested-by: Jenkins
2023-06-15sc: qa: add databar unit testHenry Castro
<x14:dataBar maxLength="100" minLength="0" border="1" axisPosition="automatic" direction="context" negativeBarBorderColorSameAsPositive="0"> <x14:cfvo type="num"> <xm:f>0</xm:f> </x14:cfvo> <x14:cfvo type="num"> <xm:f>1</xm:f> </x14:cfvo> <x14:fillColor rgb="FF63C384"/> <x14:borderColor rgb="FF63C384"/> <x14:negativeFillColor indexed="2"/> <x14:negativeBorderColor indexed="2"/> <x14:axisColor indexed="64"/> </x14:dataBar> Change-Id: Ib57dac07027e2c3c01ee556a3df791f49637be54 Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149070 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153120 Tested-by: Jenkins
2023-06-15UITest_manual_tests: use oneprocess modeMiklos Vajna
Execution time goes from: real 0m42,203s to real 0m31,854s Also the same for UITest_pasteSpecial: 2m4,180s -> 1m39,375s Also the same for UITest_protect: 0m13,758s -> 0m12,817s Change-Id: I5fb00ca0c854e4078f7cae12dee507aa61da3770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153090 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-15sc: filter: oox: insert a new entry ScDataBarFormat if Id attribute...Henry Castro
does not exist: <x14:cfRule type="dataBar" priority="1" id="{006000A4-0067-40D4-A5EF-00D900B80077}"> <x14:dataBar maxLength="100" minLength="0" border="1" axisPosition="automatic" direction="context" negativeBarBorderColorSameAsPositive="0"> <x14:cfvo type="num"> <xm:f>0</xm:f> </x14:cfvo> <x14:cfvo type="num"> <xm:f>1</xm:f> </x14:cfvo> <x14:fillColor rgb="FF63C384"/> <x14:borderColor rgb="FF63C384"/> <x14:negativeFillColor indexed="2"/> <x14:negativeBorderColor indexed="2"/> <x14:axisColor indexed="64"/> </x14:dataBar> </x14:cfRule> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ie2c1ba2c85d9eead963f4d9b1684d72b64fe815d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149069 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153092 Tested-by: Jenkins
2023-06-14Add editengine view separation in tiled renderingParis Oplopoios
Editengine now gets the background color from the current view instead from a global variable Change-Id: I98a0fccf4d0c83f4dabf8e534a9228b8a5e271d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 7baa475342b67c10537e11da37b8862648679b02) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153073 Tested-by: Jenkins
2023-06-14sc: filter: oox: update databar format before cloneHenry Castro
The ScDataBarFormatData should update from import (finalizeImport) before cloning, otherwise it loose data. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I4af8b79e93eed8091bf01244bacac1d12e591c45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149068 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153068 Tested-by: Jenkins
2023-06-14cid#1532384 Out-of-bounds readCaolán McNamara
sizeof returns num of bytes, not num of elements Change-Id: I9dea109e5f322d93ee10680f120b15554efa92e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-14online: speed up scrolling large excel documentNoel Grandin
the expensive part is the GetTiledRenderingArea(), so lets only do that once, instead of twice Change-Id: I2d18bce1ff116d6d711f0908502963c9743dea8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14sc: filter: oox: add missing formula if it is a text ...Henry Castro
conditional format: <x14:cfRule type="containsText" priority="3" text="Done" id="{00730073-0059-47BC-840A-00E100CE00F2}"> <xm:f>NOT(ISERROR(SEARCH("Done",C1)))</xm:f> <x14:dxf> <font> <color rgb="FF006100"/> </font> <fill> <patternFill patternType="solid"> <fgColor rgb="FFC6EFCE"/> <bgColor rgb="FFC6EFCE"/> </patternFill> </fill> </x14:dxf> </x14:cfRule> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I4da117a1a122b3895788645dcd5de3e36cdcad0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149067 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153008 Tested-by: Jenkins
2023-06-14tdf#151946 cache LocaleDataWrapperNoel Grandin
because it is a little more expensive these days to create it, since I made it an immutable type (which is also why we can safely cache it) Reduces load time from 7s to 1.5s for me Change-Id: I583381f0ee5494b8edf746b2329ac5751a9e5d86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153006 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-13sc: filter: oox: Add a missing tag child of the parent tag "cfvo"Henry Castro
<x14:dataBar maxLength="100" minLength="0" border="1" axisPosition="automatic" direction="context" negativeBarBorderColorSameAsPositive="0"> <x14:cfvo type="num"> <xm:f>0</xm:f> </x14:cfvo> <x14:cfvo type="num"> <xm:f>1</xm:f> </x14:cfvo> <x14:fillColor rgb="FF63C384"/> <x14:borderColor rgb="FF63C384"/> <x14:negativeFillColor indexed="2"/> <x14:negativeBorderColor indexed="2"/> <x14:axisColor indexed="64"/> </x14:dataBar> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ie98507e11a5cdeb0d1adc77a44fd79edb2f26d6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149066 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152998 Tested-by: Jenkins
2023-06-13sc: filter: oox: add missing attribute "indexed"Henry Castro
<x14:dataBar maxLength="100" minLength="0" axisPosition="automatic" direction="context" gradient="0" negativeBarBorderColorSameAsPositive="0"> <x14:cfvo type="autoMin"/> <x14:cfvo type="autoMax"/> <x14:fillColor rgb="FF638EC6"/> <x14:negativeFillColor indexed="2"/> <x14:axisColor indexed="64"/> </x14:dataBar> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If7f6c8c902e4cd0d775f1014acad3dcd19f13f28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149065 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152968 Tested-by: Jenkins
2023-06-13sc: filter: oox: add missing tag "fillcolor"Henry Castro
To fill the positive color of the conditional format data bar: <x14:dataBar maxLength="100" minLength="0" axisPosition="automatic" direction="context" gradient="0" negativeBarBorderColorSameAsPositive="0"> <x14:cfvo type="autoMin"/> <x14:cfvo type="autoMax"/> <x14:fillColor rgb="FF638EC6"/> <x14:negativeFillColor indexed="2"/> <x14:axisColor indexed="64"/> </x14:dataBar> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I17e83a01affff292ff941d92f6ae59954aa246ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149064 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152965 Tested-by: Jenkins
2023-06-13tdf#147021: sc/source/filter SAL_N_ELEMENTS usageDr. David Alan Gilbert
Two blocks that just use SAL_N_ELEMENTS in a form: func(array, array+SAL_N_ELEMENTS(array)) just use std::end for the end of it; I'm not seeing an easier way to pass the whole array in one. Change-Id: I1a229d735385cad6d3d4d7c48a6841906f3a8150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-13tdf#155376 weakly cache ScAccessibleCellNoel Grandin
the macOS accessibility framework repeatedly queries and enumerates all of the visible cells. Every time this happens we create a new set of ScAccessibleCell, which then live until the application shuts down, which then causes a very slow shutdown. So I fix the problem by caching the ScAccessibleCell so we return the same one for a given cell position. Of course, this begs the question of why the ScAccessibleCell objects are not dying when we create new ones, which means we have some kind of leak or lifecycle problem somewhere, but anyhow, this is a fairly simple and comprehensive fix. Change-Id: Id2765236ac4524f490a51b56268fb8038612fd43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152932 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-13lok: sc: disable Value HighlightingHenry Castro
If the document is saved with the option: View - Value Highlighting The online client side does not have implemented yet, otherwise will not paint the cell background. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I05b1a2ef63602a7bf34f717b87c304d00a8c8efc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152019 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152938 Tested-by: Jenkins
2023-06-12sc: fix freeze row/column panesHenry Castro
The UNO command state has changed to Point (row, tab) and Point (col, tab), Otherwise, if the row or column has the same value for all sheets, the state cache will not report any changes to the client side. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I2080f5e664825d81c4fa4dbb2c5d782f188dae64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151344 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151975 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152908 Tested-by: Jenkins
2023-06-12lok: sc: fix RTL auto fill rectangleHenry Castro
In the RTL case, the positive X axis is changed from right to left, otherwise the auto fill rectangle overlay will get negative coordinates. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If4918f02d185fc19e5ab4e8a273c443c69dc7206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150034 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 27dc2814941423d202053cf65bbf755e403c6044) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150172 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152906 Tested-by: Jenkins
2023-06-12sc: uitest: fix sporadic test failuresXisco Fauli
Sometimes theses tests fail with ====================================================================== FAIL: test_tdf153972 (tdf153972.tdf153972) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64_branch/sc/qa/uitest/autofilter2/tdf153972.py", line 37, in test_tdf153972 self.assertEqual('Lime', get_state_as_dict(xSubMenu.getChild('0'))['Text']) AssertionError: 'Lime' != '#81D41A' - Lime + #81D41A ====================================================================== FAIL: test_tdf95520 (tdf95520.tdf95520) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64_branch/sc/qa/uitest/autofilter2/tdf95520.py", line 36, in test_tdf95520 self.assertEqual('Red', get_state_as_dict(xSubMenu.getChild('1'))['Text']) AssertionError: 'Red' != '#FF0000' - Red + #FF0000 See https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil_branch/10807/consoleFull#4610001379567f988-cbcf-4519-af05-6000b834f13f and I believe the reason is the color palette fails to load in sc/source/ui/view/gridwin.cxx:752 and then its not able to translate #81D41A to Lime. Adapt the test and document to use colors without a color name Change-Id: Ie1119fe0ff31147b5395076969e41481706d8dfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152897 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-12tdf#145538 Refactor to use range-based for-loopbuldi
Change-Id: Idc64cae6deccbf62824eadef3a3b4dbb979cfd39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150737 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-06-12cid#1532369 Unchecked dynamic_castCaolán McNamara
Change-Id: I43cd71b608fcddd48d7713e11efdf01d20f963fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-11Related: tdf#155507 don't broadcast UI Theme change unless it did changeCaolán McNamara
a problem since: https://github.com/CollaboraOnline/online/commit/b6d4c88f9011845acae5c8537c0826055c8327a2 Change-Id: Iac1189ba7b892324b5f000f5f6240787b3209892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-11use internal iterator for SfxBroadcasterNoel Grandin
So we can avoid exposing the internal listener vector. (which allows further optimisations) Change-Id: If288141a37314dcc01d203029dc51c71ec2b7f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-10tdf#347349 sc: avoid UpdateEditView when formula buildingJustin Luth
The problem was that with a split window, the editview was being updated when switching to another sheet and then you couldn't select a cell during formula building. GetSelection from ActiveView was returning nothing if the editView was updated during the switch to another tab. This only happened under certain conditions that are detailed in the bug report. While I don't have much knowledge about the calc engine, this change seems reasonable enough to me to submit it. Change-Id: Ibb9a70fdfd57c2e1a1a7ae2ebafc4bf1b850f02a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148567 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2023-06-10Fix typoAndrea Gelmini
Change-Id: I93f8dc6746a9173847e96f1ba16e5fdc4a817ced Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152804 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-06-09tdf#153437 sc: fix broken formatting without performance regressionCzeber László Ádám
Follow-up to commit 7be7e1ff95af485a9cb00748800d3d084f96387c "tdf#153437 sc: fix broken formatting at Undo of row/column insertion" by replacing that with a better version without performance regression. This keeps the original performance fix of commit 2e86718626a07e1656661df3ad69a64848bf4614 "don't allocate unnecessary columns when inserting a row" related to the support of 16k columns. The previous fix used extra memory to fix the broken formatting of the cells. I have now solved the error in tdf#153437 without taking extra memory. It doesn't change the reserved cells, it just deletes a row from the default attribute of the cells when deleting rows, so they don't slip. When deleting a column, the last column in the still reserved area loses its formatting. I copied the default value back here, as the other columns have this value. Change-Id: I35da1cb79ff4e3493e91d29766cc2b81412080eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152742 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-09tdf#155244 filter: XHTML export: Making ODF style IDs unique for ...Svante Schubert
... HTML/CSS by adding a prefix (the @style:family with '-' as glue character) to their style name. Disabled debug output for style:family-name in XSL add text:a to text family ... and add a unit test. Change-Id: Ie846f5ea2a872872f38036aff59d29c8f530ed32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152749 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-08lok: send theme palette after the change in ThemeDialogTomaž Vajngerl
For some reason the SdrPage is constructed in Online after every change (cursor, selection) so can't use that to send theme change callback. Instead of that send it after the theme is changed with the ThemeDialog. in addition this requires that we transport model::ColorSet in a shared_ptr more, to prevent doing constant copies. This requires that the IThemeColorChanger interface is changed and the signature of apply() method. Change-Id: Iac951fce57a8e9dff467bd27b2f9c64ec65ea30c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152635 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 6c40e4d1796bcb6418dcb5ec17f46f576c171796) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152728 Tested-by: Jenkins
2023-06-08ScPatternAttr does not need a special case for *mxHashCode == 0Noel Grandin
I don't why the original commit b26c34267cdf9d0b7ba4e2fda7ae706d5cd76299 replace SfxPoolItem::LookupHashCode() with Lookup() (tdf#135215) did this. After I can tell, the Lookup will function perfectly fine with hashcode == 0, the operator== method already falls back to using full comparison of the underlying SfxItemSets After this change, running 'make sc.check' with ScPatternAttr::CalcHashCode patched to always return 0 reveals no problems. Change-Id: I56c3e6c00796e4cc9c12fd460181d6ca1ec6f066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-08tdf#155726: change the location of the 'Sort by Color' optionJulien Nabet
Change-Id: I3d1abeb654cd2a7d60c9cec947aa583f9f25126d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152734 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-08UITest_function_wizard: use oneprocess modeMiklos Vajna
Execution time goes from: real 0m29,352s to real 0m19,938s Also the same for UITest_goalSeek: 0m30,467s -> 0m26,829s Also the same for UITest_inputLine: 0m21,856s -> 0m15,508s Also the same for UITest_key_f4: 0m10,850s -> 0m9,881s Change-Id: Ie098410d1cef1076f124189f2283770f5a916e11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152718 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-07tdf#155376 partially convert SvCTLOptions to officecfgNoel Grandin
When accessibility is enabled, Calc will add tens of thousands of listeners. We then spend a significant chunk of time creating SvCTLOptions objects (attached to ImpEditEngine) and adding and removing those objects from the related listener lists. But the required information is already globally cached by the officecfg module, so we can avoid that overhead and just fetch it directly from officecfg. Change-Id: I7ff55fd7c4926866eb7086812275ba8bd6e84c75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152645 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-07Remove unused includeStephan Bergmann
...that had been added with e5fe8434110c1299527a0d03bf450e1b6d08ca57 "use a SIMD friendly hashcode for ScPatternAttr", presumably for temporary SAL_DEBUG use Change-Id: I0a77330cf10c0c4e01a88580c2f4eb6a5e1df92c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152699 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-06-07Avoid signed integer overflowStephan Bergmann
For whatever reason e5fe8434110c1299527a0d03bf450e1b6d08ca57 "use a SIMD friendly hashcode for ScPatternAttr" had changed ScPatternAttr::mxHashCode from sizt_t to sal_Int32, better use unsigned sal_uInt32 to avoid > /sc/source/core/data/patattr.cxx:1444:17: runtime error: signed integer overflow: 31 * 887503681 cannot be represented in type 'int' during e.g. CppunitTest_chart2_geometry (<https://ci.libreoffice.org//job/lo_ubsan/2802/>) Change-Id: Ia561b245431d812f43586013477208426aa1cc11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-06-06convert SvtAccessibilityOptions to officecfg where possibleNoel Grandin
Change-Id: Ia530086fe35e64379e55135d392020304b466325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06use a SIMD friendly hashcode for ScPatternAttrNoel Grandin
which shaves 5% off load time of a large sheet with lots of formats. We are calculating a hash over a decent sized array of pointers, so unroll the loop and reduce data-dependencies to give the compiler (and the CPU) a chance to do work in parallel Change-Id: I3d58fcf547c9280437295b9c9ec10aff16419afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152443 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06convert ColorConfig to officecfg where possibleNoel Grandin
Change-Id: I14f0ada21d328b3b6637709e403bfe973a7035b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152670 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-05avoid some UNO queryingNoel Grandin
Change-Id: I5fa793ab979221252f66bdd38e6950c06a66b00a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-05tdf#153972: sc: Add UItestXisco Fauli
Change-Id: I7479be100d2c0abd9484a4095b3b2acf958beffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152616 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-05tdf#132026: sc: move UItest to CppUnittestXisco Fauli
Change-Id: I4a8b40c1618421a0c1775d0585c53d90196f0937 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152608 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-28 08:56:43 +0000