summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-02-24add test for deduplicating cond format against same formatMarkus Mohrhard
Change-Id: I9e21b5b53f7a3c579bdaf5dc0dd6102be805faf9 Reviewed-on: https://gerrit.libreoffice.org/50217 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-24better same document test for conditional format copy&pasteMarkus Mohrhard
Change-Id: Ic896202e072a036108c06768f29ba767d3ea7769 Reviewed-on: https://gerrit.libreoffice.org/50218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23Move OOXML password definitions to struct ScOoxPasswordHash, tdf#104250 prepEike Rathke
Change-Id: I595d5ae8db6f739900afdfdde1e36b0a0b1d2179
2018-02-23deduplicate cond format against source format if possibleMarkus Mohrhard
Change-Id: Ie4bbbb078f2d0456cd5f3ad6e2c5627aca9fbaa9 Reviewed-on: https://gerrit.libreoffice.org/50216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23add test for tdf#115835Markus Mohrhard
Change-Id: Ic07e35fcba503461793abb88b463b6e43ca61972 Reviewed-on: https://gerrit.libreoffice.org/50212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23new loplugin:doubleconvert to with ColorData workNoel Grandin
Change-Id: Ib8f2ef485f548645c4b0e7cf080b72b28c4e278d Reviewed-on: https://gerrit.libreoffice.org/50226 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-23copy multiple single row cond formats correctly, tdf#115835Markus Mohrhard
Change-Id: Ic20cc27f03edf3dbd27975f99c788bf5bffd4c48 Reviewed-on: https://gerrit.libreoffice.org/50211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23tdf#115933 set document read-only on presence of hashValue attributeEike Rathke
Though there's currently no way (password dialog) to edit the document other than saving it to a different file, this seems to be what is expected. Change-Id: Iafa8ac9f6e41c3011ed0ad4b19cc57382c9f2a75
2018-02-23Read algorithmName, hashValue, saltValue, spinCount, tdf#115933 prepEike Rathke
Change-Id: I799d4652099059fcd09088c02537ed5dec087259
2018-02-23Read algorithmName, hashValue, saltValue, spinCount, tdf#104250 prepEike Rathke
Change-Id: Idc68ad62e8420646d5aecd0d4126084390a1ed55
2018-02-23lok: Factor out the code for finding vcl::Window of a documentPranav Kant
This should also help with IME input on charts Change-Id: Ie513790a5d0c87397c39301a328a44b59d394a45 Reviewed-on: https://gerrit.libreoffice.org/50091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-23fix crash while trying to access icon set image fileMarkus Mohrhard
Change-Id: Iaad9b5aeb4163a5262bcaf0a414ee30fd9279a49 Reviewed-on: https://gerrit.libreoffice.org/50219 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-22weld native message dialogsCaolán McNamara
just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22Remove unused forward declarations from vcl/syswin.hxxStephan Bergmann
Change-Id: Ide4990afa32ba4cc7851d0e7d3d8d1247eb27b3b Reviewed-on: https://gerrit.libreoffice.org/50155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22loplugin:redundantcastNoel Grandin
Change-Id: I358e9673edcba81336b3895479e787d981fad7a5
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann
...as it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: https://gerrit.libreoffice.org/50123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22loplugin:redundantcopy extend to ColorNoel Grandin
Change-Id: I224cc955d49ee100d328e0171da710f38068d2d4 Reviewed-on: https://gerrit.libreoffice.org/50114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22ColorData->Color in scNoel Grandin
and fix the sal_Int32() conversion operator in Color, which was always returning 0 Change-Id: I0aefaedc34ee0a8bccd43238ccfe8196d2dd5c5c Reviewed-on: https://gerrit.libreoffice.org/50051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21Limit ScColumnsRange::Iterator to available columns within boundsEike Rathke
Change-Id: Id5481a975dce99a51cc5619e200e5ea46ad3ad1b Reviewed-on: https://gerrit.libreoffice.org/50106 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-21Use iterator pre-increment/decrementEike Rathke
Change-Id: I079850116648dc69b8c92fa23b30233f63d9b6e7
2018-02-21Pass ScColumnsRange::Iterator as const&Eike Rathke
Specifically for each operator==() call two temporaries were copied, for operator!=() even twice as much.. in for(...:GetColumnsRange()) Change-Id: I4b426ae855454544e50efca35aa73303138f7ba7
2018-02-21ColorData->Color in sd..svxNoel Grandin
Change-Id: I70de56b6bfb1ea4655ec03510fad92bf6645f64e Reviewed-on: https://gerrit.libreoffice.org/50046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20Resolves: tdf#115879 treat NOT as the 1-parameter function that it isEike Rathke
... instead of a low precedence unary operator with an odd behaviour. This wasn't documented nor specified but maybe needed for old(est) binary file format compatibility. Generate an error for anything else than a context of a function with one argument. There might be some corner cases of documents where some old usage leads to error now, of which some may have worked by accident, but some not as intended. Related, the internal not exposed (but available) NEG was classified similar as a unary operator but corectly handled as function at all places. Classified as an ordinary 1-parameter function as well. Change-Id: I3d84a6382243c8d64313e37346f81c857e71be95 Reviewed-on: https://gerrit.libreoffice.org/50055 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-02-20Add one more test case for importing border colors.Kohei Yoshida
This one is also for the Excel 2003 XML format. Change-Id: I7c9725f4aa6d11523b647e56af634ca9245c44b6 Reviewed-on: https://gerrit.libreoffice.org/50022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-20Add another test case for Excel 2003 XML import.Kohei Yoshida
This one is for importing border directions. Change-Id: I92666c30b629109a1061b7ae1fad31841850d34b Reviewed-on: https://gerrit.libreoffice.org/50021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-20drop Color::SetColor(ColorData) in favour of operator=Noel Grandin
first stage of getting rid of ColorData Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec Reviewed-on: https://gerrit.libreoffice.org/49997 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20add test for tdf#115530Markus Mohrhard
Change-Id: Ie1eb79d34ca79d1cf085e235e1ead4d886ea7df5 Reviewed-on: https://gerrit.libreoffice.org/49958 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-20for listeners the range needs to be set before the formula, tdf#115530Aron Budea
Change-Id: I001795fd456375c4babab2c2e505bedff03e991f Reviewed-on: https://gerrit.libreoffice.org/49957 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-19Resolves: tdf#115710 let css::sheet::FunctionAccess execute WEBSERVICEEike Rathke
... independent of a LinkManager that is not present in the interim FunctionAccess document. FunctionAccess is executed by extensions, Add-Ons and macros that the user gave permission already. Change-Id: I9349a59ee24089c3657de7786b49e5e81946f175
2018-02-19ofz#5991 limit num of qpro tabs for fuzzingCaolán McNamara
Change-Id: Ifa205912ee0970657debdc17339e3df0c581a18f Reviewed-on: https://gerrit.libreoffice.org/49998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz#5956 TimeoutCaolán McNamara
Change-Id: I72f7601d88213953997c9f6eef30ee85a486a20b Reviewed-on: https://gerrit.libreoffice.org/49996 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-18Fix typosAndrea Gelmini
Change-Id: I3225398aa3d56f76a5e8a60aecb671665d94a717 Reviewed-on: https://gerrit.libreoffice.org/49920 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-17Now we can remove this old checkOutput() for real.Kohei Yoshida
Change-Id: Ieff91dfd8195f1a5b8267753183e34e154a0c29a Reviewed-on: https://gerrit.libreoffice.org/49913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Use the variant of checkOutput that takes nested std::vector.Kohei Yoshida
That one is *the* future. We can't remove the old one just yet... Change-Id: I3c5b1bfee3d2cb8988b68ced5a38d52d641e5881 Reviewed-on: https://gerrit.libreoffice.org/49908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Add a test to make sure we import docs with empty rows correctly.Kohei Yoshida
The previous XSLT-based filter failed to import this correctly. Change-Id: I6218bd2b3e5c5ac1514f84b959be27df23a0c3f8 Reviewed-on: https://gerrit.libreoffice.org/49907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17uitest for bugs #tdf114228 #tdf43078 #tdf105105Zdeněk Crhonek
Change-Id: I4fce7b1f492b6e32d48eb6f7d9c9edb6eba2c56d Reviewed-on: https://gerrit.libreoffice.org/49518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest for tdf#99386Zdeněk Crhonek
Change-Id: I1b9d03da4e5dff6149c98057976adc1cdcdb1770 Reviewed-on: https://gerrit.libreoffice.org/48802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Let's also check for the presence of the range names.Kohei Yoshida
Change-Id: Ic61370e495a8647a17eec484f8f32afe4dcc3b94 Reviewed-on: https://gerrit.libreoffice.org/49888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Revert "loplugin:changetoolsgen in sc" and reapply pluginNoel Grandin
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit 95fab7cbf2f0576d0f728bed8898b7ff769d90e6. Change-Id: Icbdcc0f4227d88812be12e18ba6961088db80c3e Reviewed-on: https://gerrit.libreoffice.org/49840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17Add a test case for global and sheet-local named expressions.Kohei Yoshida
Change-Id: I44247b55f3541214b515378744ee2c1982051e27 Reviewed-on: https://gerrit.libreoffice.org/49882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-16Consolidate the dreaded "Text - txt - csv (StarCalc)" filter nameEike Rathke
... into one define SC_TEXT_CSV_FILTER_NAME. This might prevent typos and doesn't look as ugly. Change-Id: If954852e5e6673331b29c4994f9d97c77b6564a6
2018-02-16Add a test case for importing cell background colors...Kohei Yoshida
... from an Excel 2003 XML file via orcus. Change-Id: I58783acf80de7935e98673b982d8cfb0d4f085ce Reviewed-on: https://gerrit.libreoffice.org/49880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-16Resolves: tdf#114995 support CSV as Link to External DataEike Rathke
... with one CSV_all range for all data. Change-Id: Ibe7a8f5141394eb4592e83a69e620e4b1a6b5221
2018-02-16move CellBorderUpdater bitmap update to VirtualDeviceNoel Grandin
part of the process of making Bitmap an internal detail of vcl/ and remove last outside-of-vcl use of BitmapWriteAccess from header file. Change-Id: I59a4353e11f881d24a7be50cf0f91f4f0dcffcaa Reviewed-on: https://gerrit.libreoffice.org/49850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16ofz#5951 speed up wks fuzzing, skip CalcAfterLoadCaolán McNamara
Change-Id: I942480742da9aec18409b2d31dd68a01275682f9 Reviewed-on: https://gerrit.libreoffice.org/49859 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-16Add a test case for importing merged cells from Excel 2003 XML file.Kohei Yoshida
Since the filter type has changed, we need to also update the filter flags used in the unit tests. And because the new filter no longer relies on XSLT, we can drop the dependency on xslt. Change-Id: I9dd040b3c8c0e95300c4dda1b87bf448a800097d Reviewed-on: https://gerrit.libreoffice.org/49832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-16ofz#6311 still problems with SdrEdgeObj listening to same obj at start as endCaolán McNamara
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30 Reviewed-on: https://gerrit.libreoffice.org/49821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15Resolves: tdf#115046 don't restore a sheet-local DBData from temporaryEike Rathke
And don't clear AutoFilter button flags in the new temporary range. Change-Id: I273de1e04632ac99c267523b2843665d257fd361
2018-02-14lok IME: support dialogs as wellPranav Kant
Change-Id: Ic78da45dadaa5a4e1ca78e20d04974108581121e Reviewed-on: https://gerrit.libreoffice.org/49714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-14No stacked code for jump matrix is worth an assertEike Rathke
Change-Id: I0e65cecd9e016a114a7e9d7b60b24e04d8512f40
generated by cgit (git 2.34.1) at 2025-01-07 23:10:21 +0000