summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2022-01-10sc: fix typoTomaž Vajngerl
Change-Id: If9a8f7265c17dafa99b51fe6266d935afedfa394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128207 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-10sc: make icon size of cond. formatting same as font sizeTomaž Vajngerl
This makes the behavior of the Calc te same as other spreadsheet programs, where the icon size of the conditional formatting is the same as the font size and not the actual cell height (as it is the behaviour now). Change-Id: I00c96ad83458cd31f67c0b6f566e3d01dd8cd47b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128185 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-10Move HAVE_MORE_FONTS into an extra config headerJan-Marek Glogowski
No need to recompile most of LibreOffice, because the --with-fonts configure flag changed. This preprocessor define is just used by unit tests anyway. Change-Id: Ia2eae7d0c74e59e034fdd8513504a34e51ab428e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128197 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06tdf#145059: sc: always write dxf node for color filter for XLSXVasily Melenchuk
If there is no dxf reference to color filter (for example if selected color is not in range of available colors for current range) Excel is not able to show color filter correctly: it is not marked as used filter, no ability to reset, etc. Change-Id: I65378ddd6f8f8233cda147ff9dcd28f455a58225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127745 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-06tdf#146617: iterators may be invalidated during handler callMike Kaganski
... when the handler decides to remove itself from listeners. Change-Id: I1d5fe802f50d284bf70d747edaff0a19852c5a7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-06Resolves: tdf#146592 "Reset" to the current document propertiesCaolán McNamara
not those seen at the initial load of the TabPage Change-Id: Ieba4c278a0a9b7fef3030d8462cb845c27dba9b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-05sc: fix crash with document properties dialogTomaž Vajngerl
"ImagePreferredDPI" property was added for impress and writer, but it was not handled in calc, so it document properties dialog crashed (exception because of a non existent property). Change-Id: I9eb3f6aa7cf6d8ab48930b3071b993e073117688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127942 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-04sc export chart as graphic: handle PDFMiklos Vajna
The context menu for Calc charts would call into GraphicFilter::ExportGraphic(), which has explicit code for e.g. SVG, but not for PDF. The graphic exporter to PDF is only meant to work with images backed with PDF data, not with all shapes. Fix the problem by explicitly handling PDF in GraphicHelper::SaveShapeAsGraphic() in svx/, and invoking the normal PDF export in that case. Continue to fall back to XGraphicExportFilter for other formats. This requires passing down the current document from sc/. Change-Id: Ia5f78bffa1d26989bb0ad3ed265b922e609f076f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127969 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-04Removed break; never reachedAndrea Gelmini
Change-Id: I027c967020821e93fecab8df0f23c5e7b5664734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127008 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-04Drop also commented-out obfuscated SAL_DEBUG callsTor Lillqvist
Change-Id: I7bc8ee2e5e989e41fcc0b6f96c5b2b8f151cdd3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127937 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-01-04osl::Mutex->std::mutex in ScDocumentNoel Grandin
Change-Id: I163b7e6b7403f9f489b4965861241280cfc37e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127917 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-03tdf#129115 Calc functions OPT_* have no Help id'sOlivier Hallot
Change-Id: If275d804fc81b535c422a29ba594eb88ce5e70c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127896 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-01-03CppunitTest_sc_subsequent_filters_test2: check format instead of stringXisco Fauli
Otherwise, this might fail. See 660e538ee77109bc3e7dff4491164d696e503abc < Disable broken part of ScFiltersTest2::testTdf126116 > Change-Id: I40534b70fc19ee163d9e6cb0c081fae40b81fdb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127887 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-03Disable broken part of ScFiltersTest2::testTdf126116Thorsten Behrens
Fails since New Year with: Test name: ScFiltersTest2::testTdf126116 equality assertion failed - Expected: 03/03/21 - Actual : 03/03/22 Change-Id: Ic5c259e6bf1f184ceb7cf15e1ba7a83dac729c2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127879 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-02Introduce OUString::unacquired(const OUStringBuffer&)Mike Kaganski
... and avoid OUStringBuffer::toString when the temporary is used for checking current buffer content Change-Id: I114178f3e74ca3e4a3e517763f9eaab4797b7deb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-01tdf#140286 fix INFO("OSVERSION") for Linux: return kernel versionscito
If LibreOffice Calc is running on Linux, the Linux version as shown in about dialog is returned, e.g. "Linux 5.3". MacOS and Windows parts are prepared, but not implemented. (I develop only on Linux.) Change-Id: I2b266a257e5c01c0fde7d076385ded4a6413d3c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127756 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-31tdf#114995: sc: Add UItestXisco Fauli
Change-Id: I351f080f56b5e6183d932463ea2faf13bb666ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127765 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30tdf#127484: sc: Add UItestXisco Fauli
Change-Id: I7c15750ae42d78bfb714638e44c7b761f5c22b47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127759 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30uitest: sc: reintroduce code incorrectly removedXisco Fauli
Change-Id: I18ad03632950530d7ae2c24608936dba325b0a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127758 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30tdf#95217: sc: simplify testXisco Fauli
Rechecking again, I found out that the encoding problem described in tdf#95217 was actually fixed by the same commit that fixed tdf#146048 ( 3392f567be8d52804b187b0bced47204ef38fa3c < tdf#146048: detect UTF-16 without BOM > ) This commit partially reverts d7fb6b22cf7e66eb2594001cc42c6bff8b5a49e2 < tdf#95217, tdf#142600: sc: Add UItest > since we don't have to create any http server to reproduce the issue Change-Id: I2f0177f8450f77de5df756354d48505193a6ba3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127742 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30tdf#95217, tdf#142600: sc: Add UItestXisco Fauli
for that, launch an http server in a separate thread Change-Id: I9d78c9a4349620a9de31b3963f2a31ff1d354f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-29lok: fix formula mode after reference dialog was usedSzymon Kłos
m_nCurRefDlgId is a global variable which can be used by many views. It should be deglobalized in LOK case in the furture. For now let's fallback when we didn't get child window for remembered value of m_nCurRefDlgId. It fixes following case: 1. opened pivot table dialog and in destination section selected "selection", selected a range, closed dialog 2. tried to type formula in the cell and point any cell to add reference before this patch formula mode was closed, after it adds correctly the selected range to the formula Change-Id: I4d6756f08207f78a6033865203905bc2fed59fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123803 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127667 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-12-28tdf#139602 Added all subtotal functions to autosumDhiraj Holden
For every function that is an option for SUBTOTAL that was not already an option in autosum (that is COUNTA, PRODUCT, STDEV, STDEVP, VAR, VARP), the option was added in the autosum menu. Change-Id: Ic560cd45df206dafaa2d960550aaf185a1806806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127600 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-27remove unused DECL_ABSTDLG_BASE and IMPL_ABSTDLG_BASETomoyuki Kubota
Change-Id: I8ba8f940cb4931974d10c8d6cf1d4fd205c18e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127469 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-27tdf#146377: sc_logical_functions_test: Add unittestXisco Fauli
Change-Id: Ia844ad53ec460abeb1ef7874ad88eeac9c6bf5a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127550 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-27sc: clean up fods files a bitXisco Fauli
Change-Id: Ibb424d1b1d9d310bb5537098d4afd9e2a3d297cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127549 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-27use comphelper::WeakComponentImplHelper in ScPanelFactoryNoel Grandin
Change-Id: Ib772bffd73f6ea1984781701c5827958e7e35488 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127531 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27use comphelper::WeakComponentImplHelper in ScChartRangeSelectionListenerNoel Grandin
Change-Id: I1efac3114b3661ce1d65974d828af7715d5a0d74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27use comphelper::WeakComponentImplHelper in ScEditFieldObjNoel Grandin
Change-Id: I7e839be0685958b12760ef499bc6c71b5003fcd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27use comphelper::WeakComponentImplHelper in TablePivotChartNoel Grandin
and remove some unnecessary use of SolarMutex Change-Id: I3934d89eb75f47a6b7051a8b737dcdbeecfa0c3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-26Avoid OUStringBuffer::toString where possibleMike Kaganski
Change-Id: I99abbe97a48b2077e28d6221fb70036e5e412657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127479 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-26sc-error-codes: STR_LONG_ERR_NO_VALUE should be "Error: No value"Kevin Suo
rather than Error: Wrong data type. STR_LONG_ERR_NO_VALUE was marked as "Error: Wrong data type" in the source code. It was translated in the en_US UI as "Error: No result", which seems to be intentionally. This causes confusion for other languages. This error code is used for case FormulaError::NoValue and this FormulaError enum entry is used in various places, most of them indicates that it is used because of no value is returned. "Wrong data type" should be a reason why there was "no value" returned, thus "Wrong data type" should be a subset of "No value", but anyway STR_LONG_ERR_NO_VALUE != "Wrong data type". Change-Id: Ie0e355ba02e9800fca2263744ed74ada700bfbeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127512 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-26Resolves: tdf#146377 Propagate condition error of IF(condition)Eike Rathke
Previsouly a given ELSE-path was executed as the condition is never TRUE on error, which wasn't significant unless the ELSE was an error evaluating function like IFERROR() or ISERROR() or other IS...() functions. This changes behaviour of an undocumented side effect, so *might* break existing expressions that (unwillingly?) relied on it. Gnumeric, Excel and GoogleSheets all agree on propagating the error value as implemented now. Change-Id: I0905a363be7a3b02925f1c41b4e6c8d36f12df93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127515 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-12-25Related: tdf#146377 Let AND(), OR(), XOR() propagate the current error, if anyEike Rathke
... instead of forcing Err:504 Change-Id: I7e91671ffc61bf82d9095378656b41981040f55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127492 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-12-25oss-fuzz: fix some compiler warningsJan-Marek Glogowski
Some unused functions and variables and many missing HAVE_FEATURE_NSS warnings, because the native-code.py stubs were missing the config_crypto.h header. Change-Id: I88ff7d8f96e7382027a21f205db982fd797bd6af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127392 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-24new comphelper::WeakImplComponentHelperNoel Grandin
to replace the cppu:: equivalent with a lightweight version that uses std::mutex instead of osl::Mutex Change-Id: I1b7873a0c2d9cda21f529e43a4ac2fa7574c91a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24Recheck include/[s-x]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Iaebddd648c52c175da17d2a55a1e8de82c213f4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127330 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-23CppunitTest_sc_subsequent_filters_test2: fix test depending on current yearXisco Fauli
While at it, move the file from ods to fods for better tracking in git Change-Id: I16df221e3a7341dc7c53de6130158c3887c472a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127361 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-22tdf#145057 Fix saving color filter when multiple data ranges in sheetSamuel Mehrbrodt
When mutliple data ranges existed in one sheet, only the first one was considered when exporting color filters. Consider all of them, as any could hold a color filter. Change-Id: I13ae2018057eef7ef24fc8298c814a93df24f74b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127328 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-12-22tdf#143582: Avoid error on clearing leftover return value of a methodMike Kaganski
SbxValue::Clear happens to not error out on clearing string and some other types of objects, but for the rest, it calls SbxValue::Put, and the latter errors out if not CanWrite(). The original test implemented in commit 24d24debef4cda7de702c4b470a3707f1aae3ea3 only checked string return value, so happened to miss this problem. See similar code in SbiRuntime::FindElement. Change-Id: I7c17137cc9e7ee3133ee86a9f701559df66e53b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127248 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-22Separate core drawinglayer func. into drawinglayercore libraryTomaž Vajngerl
This separates the drawinglayer core functionallity into a separate library, to keep a strict separation what is backend dependent and what is not. More strict separation can be done at a later date. This will make it possible to push part of drawinglayer (part of processor2d) directly into VCL. Change-Id: Ibc26580067e50bf20d7cdd37fa0e44eb10200878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127286 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21Fix formatting (wrong indentation)Samuel Mehrbrodt
Apply clang-format to this method Change-Id: I67fbdc4ca8b9c602ed85a57dbbde8ed47bdd45c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127215 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-12-20Recheck include/[e-r]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I44e4e3a88067c1c29ce9d563b22741e984b43576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126964 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-19ofz#42605 Null-dereferenceCaolán McNamara
Change-Id: Ief752f20aa3e7672e4ed7f6cd1809ee56a096c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-19use more cppu::BaseMutexNoel Grandin
Change-Id: Ida8eb69bb90a2ce53a9a783595b1dc0b0c9f334c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-18tdf#103331: Add a test case for inherited font weight attributes.Kohei Yoshida
Change-Id: I8ebca3ab492313a3f7aa9019533bbb7eee2e4a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127019 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2021-12-18Worth an assert (inserting the range name should not fail) not OSL_FAIL()Eike Rathke
Change-Id: I7178d7d9c3e4b86e3fca256031b9ee4de904e5c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127020 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-12-17Fix typosAndrea Gelmini
Change-Id: I7f1636226c4fbe29d9d2ef850318a9d57f1b5450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127009 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-17tdf#146019 Remove confirmation dialog about applying images EXIF rotationGabor Kelemen
Change-Id: I53553f91eeb5bd56bbad19b80421177a84625d96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126616 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-01-10 23:16:50 +0000